Layout Problems
Locked
 
|
Developers,
Please be careful when changing HTML element compounds. The recent changes to certain themes are breaking the layout of the Flat Grey theme - which shouldn't have been affected. I noticed the styling for the tab bar at the top of the content area has been changed. The original styling was a button-bar decorated with the tab-bar style. Now the button-bar style is removed, the tab-bar style has been modified, and the result looks bad. Please try to understand why things are set up the way they are before changing them. In the original design, the button-bar style was intended to be used as a "base" to control whether a button-bar was vertical or horizontal. The decorators were meant to add additional styling to that "base" - colors, borders, etc. The tab-bar style was not intended to be used alone. Whoever broke the Flat Grey layout, please put it back to the way it was designed. -Adrian |
|
|
Adrian,
thank you for sharing the style class logic used. Please find here https://issues.apache.org/jira/browse/OFBIZ-3206?focusedCommentId=12778179&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12778179 an answer to this. -Bruno 2009/11/15 Adrian Crum <[hidden email]>: > Developers, > > Please be careful when changing HTML element compounds. The recent changes to certain themes are breaking the layout of the Flat Grey theme - which shouldn't have been affected. > > I noticed the styling for the tab bar at the top of the content area has been changed. The original styling was a button-bar decorated with the tab-bar style. Now the button-bar style is removed, the tab-bar style has been modified, and the result looks bad. > > Please try to understand why things are set up the way they are before changing them. > > In the original design, the button-bar style was intended to be used as a "base" to control whether a button-bar was vertical or horizontal. The decorators were meant to add additional styling to that "base" - colors, borders, etc. The tab-bar style was not intended to be used alone. > > Whoever broke the Flat Grey layout, please put it back to the way it was designed. > > -Adrian > > > > > |
|
|
In reply to this post by Adrian Crum-2
Adrian Crum wrote:
> Developers, > > Please be careful when changing HTML element compounds. The recent changes to certain themes are breaking the layout of the Flat Grey theme - which shouldn't have been affected. Um, huh? So, because *new* things were done, possibly adding more features, but it broke something else, you want to stop the new feature? Why not just fix the thing that broke? If we all thought your way, then nothing new would ever be done. The changes that were just reversed base on your email, and the jira issue you filed, should be reapplied. Your jira issue should be closed as invalid, and a new one open, listing what has *actually* been broken. > Whoever broke the Flat Grey layout, please put it back to the way it was designed. No, don't put it back. What if the correct fix is to fix flatgrey? |
|
|
Adam Heath wrote:
> Adrian Crum wrote: > >> Developers, >> >> Please be careful when changing HTML element compounds. The recent >> > changes to certain themes are breaking the layout of the Flat Grey > theme - which shouldn't have been affected. > > Um, huh? So, because *new* things were done, possibly adding more > features, but it broke something else, you want to stop the new > feature? Why not just fix the thing that broke? > Responsibilities is written this: *Rule #1 for a committer is the same as for a doctor:* *first do no harm*. Nothing should be committed that breaks existing functionality without replacing it either before or in the same commit. Bilgin |
|
|
Bilgin Ibryam wrote:
> Adam Heath wrote: >> Adrian Crum wrote: >> >>> Developers, >>> >>> Please be careful when changing HTML element compounds. The recent >>> >> changes to certain themes are breaking the layout of the Flat Grey >> theme - which shouldn't have been affected. >> >> Um, huh? So, because *new* things were done, possibly adding more >> features, but it broke something else, you want to stop the new >> feature? Why not just fix the thing that broke? >> > I'm a little confused now, because in OFBiz Committers Roles and > Responsibilities is written this: > > *Rule #1 for a committer is the same as for a doctor:* *first do no > harm*. Nothing should be committed that breaks existing functionality > without replacing it either before or in the same commit. Sure. But we are all human, and we are not perfect. Mistakes happen, in both directions. If someone breaks existing functionality, then either back out their change, or fix the existing code to make it work. In this case, I think that maybe just backing out the changes was the wrong approach to take. Unless they will come back at some point, with whatever problems fixed that they caused. ps: I haven't actually looked at the changes in question. > > Bilgin |
|
|
Adam,
I will definitively put back the "new feature" in a different way that does not hurt. The "new feature" basically is the application tab bar at an higher level in the HTML so that it is rendered in the Dropping crumbs theme (I think I should find a better name for this theme) just below the breadcrumb. It will take some time and probably some discussion because I will ask details. I look forward to the community collabotation. -Bruno 2009/11/16 Adam Heath <[hidden email]>: > Bilgin Ibryam wrote: >> Adam Heath wrote: >>> Adrian Crum wrote: >>> >>>> Developers, >>>> >>>> Please be careful when changing HTML element compounds. The recent >>>> >>> changes to certain themes are breaking the layout of the Flat Grey >>> theme - which shouldn't have been affected. >>> >>> Um, huh? So, because *new* things were done, possibly adding more >>> features, but it broke something else, you want to stop the new >>> feature? Why not just fix the thing that broke? >>> >> I'm a little confused now, because in OFBiz Committers Roles and >> Responsibilities is written this: >> >> *Rule #1 for a committer is the same as for a doctor:* *first do no >> harm*. Nothing should be committed that breaks existing functionality >> without replacing it either before or in the same commit. > > Sure. But we are all human, and we are not perfect. > > Mistakes happen, in both directions. If someone breaks existing > functionality, then either back out their change, or fix the existing > code to make it work. > > In this case, I think that maybe just backing out the changes was the > wrong approach to take. Unless they will come back at some point, > with whatever problems fixed that they caused. > > ps: I haven't actually looked at the changes in question. > >> >> Bilgin > > |
Administrator
|
Bruno,
I like the name, a bit of humor is not bad IMO, and it explains well the concept. Anyway it's as you like... Jacques From: "Bruno Busco" <[hidden email]> > Adam, > I will definitively put back the "new feature" in a different way that > does not hurt. > > The "new feature" basically is the application tab bar at an higher > level in the HTML so that it is rendered in the Dropping crumbs theme > (I think I should find a better name for this theme) just below the > breadcrumb. > > It will take some time and probably some discussion because I will ask details. > I look forward to the community collabotation. > > -Bruno > > 2009/11/16 Adam Heath <[hidden email]>: >> Bilgin Ibryam wrote: >>> Adam Heath wrote: >>>> Adrian Crum wrote: >>>> >>>>> Developers, >>>>> >>>>> Please be careful when changing HTML element compounds. The recent >>>>> >>>> changes to certain themes are breaking the layout of the Flat Grey >>>> theme - which shouldn't have been affected. >>>> >>>> Um, huh? So, because *new* things were done, possibly adding more >>>> features, but it broke something else, you want to stop the new >>>> feature? Why not just fix the thing that broke? >>>> >>> I'm a little confused now, because in OFBiz Committers Roles and >>> Responsibilities is written this: >>> >>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>> harm*. Nothing should be committed that breaks existing functionality >>> without replacing it either before or in the same commit. >> >> Sure. But we are all human, and we are not perfect. >> >> Mistakes happen, in both directions. If someone breaks existing >> functionality, then either back out their change, or fix the existing >> code to make it work. >> >> In this case, I think that maybe just backing out the changes was the >> wrong approach to take. Unless they will come back at some point, >> with whatever problems fixed that they caused. >> >> ps: I haven't actually looked at the changes in question. >> >>> >>> Bilgin >> >> > |
|
|
Jacques,
you convinced me! We will keep like it is now! ;-) 2009/11/16 Jacques Le Roux <[hidden email]>: > Bruno, > > I like the name, a bit of humor is not bad IMO, and it explains well the > concept. Anyway it's as you like... > > Jacques > > From: "Bruno Busco" <[hidden email]> >> >> Adam, >> I will definitively put back the "new feature" in a different way that >> does not hurt. >> >> The "new feature" basically is the application tab bar at an higher >> level in the HTML so that it is rendered in the Dropping crumbs theme >> (I think I should find a better name for this theme) just below the >> breadcrumb. >> >> It will take some time and probably some discussion because I will ask >> details. >> I look forward to the community collabotation. >> >> -Bruno >> >> 2009/11/16 Adam Heath <[hidden email]>: >>> >>> Bilgin Ibryam wrote: >>>> >>>> Adam Heath wrote: >>>>> >>>>> Adrian Crum wrote: >>>>> >>>>>> Developers, >>>>>> >>>>>> Please be careful when changing HTML element compounds. The recent >>>>>> >>>>> changes to certain themes are breaking the layout of the Flat Grey >>>>> theme - which shouldn't have been affected. >>>>> >>>>> Um, huh? So, because *new* things were done, possibly adding more >>>>> features, but it broke something else, you want to stop the new >>>>> feature? Why not just fix the thing that broke? >>>>> >>>> I'm a little confused now, because in OFBiz Committers Roles and >>>> Responsibilities is written this: >>>> >>>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>>> harm*. Nothing should be committed that breaks existing functionality >>>> without replacing it either before or in the same commit. >>> >>> Sure. But we are all human, and we are not perfect. >>> >>> Mistakes happen, in both directions. If someone breaks existing >>> functionality, then either back out their change, or fix the existing >>> code to make it work. >>> >>> In this case, I think that maybe just backing out the changes was the >>> wrong approach to take. Unless they will come back at some point, >>> with whatever problems fixed that they caused. >>> >>> ps: I haven't actually looked at the changes in question. >>> >>>> >>>> Bilgin >>> >>> >> > > |
|
|
In reply to this post by Adam Heath-2
I think you are misunderstanding what happened and what I said.
Developing new themes is fine. Changing markup to suit one particular theme is bad - because it breaks the other themes. If the markup turns out to be a problem for ALL themes, then by all means, let's change the markup. -Adrian Adam Heath wrote: > Adrian Crum wrote: >> Developers, >> >> Please be careful when changing HTML element compounds. The recent > changes to certain themes are breaking the layout of the Flat Grey > theme - which shouldn't have been affected. > > Um, huh? So, because *new* things were done, possibly adding more > features, but it broke something else, you want to stop the new > feature? Why not just fix the thing that broke? > > If we all thought your way, then nothing new would ever be done. > > The changes that were just reversed base on your email, and the jira > issue you filed, should be reapplied. > > Your jira issue should be closed as invalid, and a new one open, > listing what has *actually* been broken. > > > >> Whoever broke the Flat Grey layout, please put it back to the way it was designed. > > No, don't put it back. What if the correct fix is to fix flatgrey? |
|
|
In reply to this post by Bruno Busco
Bruno,
Did you notice that the GlobalDecorator already has a pre-body section? -Adrian Bruno Busco wrote: > Adam, > I will definitively put back the "new feature" in a different way that > does not hurt. > > The "new feature" basically is the application tab bar at an higher > level in the HTML so that it is rendered in the Dropping crumbs theme > (I think I should find a better name for this theme) just below the > breadcrumb. > > It will take some time and probably some discussion because I will ask details. > I look forward to the community collabotation. > > -Bruno > > 2009/11/16 Adam Heath <[hidden email]>: >> Bilgin Ibryam wrote: >>> Adam Heath wrote: >>>> Adrian Crum wrote: >>>> >>>>> Developers, >>>>> >>>>> Please be careful when changing HTML element compounds. The recent >>>>> >>>> changes to certain themes are breaking the layout of the Flat Grey >>>> theme - which shouldn't have been affected. >>>> >>>> Um, huh? So, because *new* things were done, possibly adding more >>>> features, but it broke something else, you want to stop the new >>>> feature? Why not just fix the thing that broke? >>>> >>> I'm a little confused now, because in OFBiz Committers Roles and >>> Responsibilities is written this: >>> >>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>> harm*. Nothing should be committed that breaks existing functionality >>> without replacing it either before or in the same commit. >> Sure. But we are all human, and we are not perfect. >> >> Mistakes happen, in both directions. If someone breaks existing >> functionality, then either back out their change, or fix the existing >> code to make it work. >> >> In this case, I think that maybe just backing out the changes was the >> wrong approach to take. Unless they will come back at some point, >> with whatever problems fixed that they caused. >> >> ps: I haven't actually looked at the changes in question. >> >>> Bilgin >> > |
|
|
Hi Adrian,
yes I did notice this at a later stage but then I changed my mind and used a CSS-only solution committed in rev. 880762. Dropping crumbs theme works quite well with this but I did not manage to have a better rendering when the tab-bar comes to have two lines due to wrapping like this: https://localhost:8443/webtools/control/xmldsdump or when there is a left column like this: https://localhost:8443/catalog/control/ListShipmentMethodTypes Any help to fix this is greatly appreciated! ;-) -Bruno 2009/11/16 Adrian Crum <[hidden email]>: > Bruno, > > Did you notice that the GlobalDecorator already has a pre-body section? > > -Adrian > > Bruno Busco wrote: >> >> Adam, >> I will definitively put back the "new feature" in a different way that >> does not hurt. >> >> The "new feature" basically is the application tab bar at an higher >> level in the HTML so that it is rendered in the Dropping crumbs theme >> (I think I should find a better name for this theme) just below the >> breadcrumb. >> >> It will take some time and probably some discussion because I will ask >> details. >> I look forward to the community collabotation. >> >> -Bruno >> >> 2009/11/16 Adam Heath <[hidden email]>: >>> >>> Bilgin Ibryam wrote: >>>> >>>> Adam Heath wrote: >>>>> >>>>> Adrian Crum wrote: >>>>> >>>>>> Developers, >>>>>> >>>>>> Please be careful when changing HTML element compounds. The recent >>>>>> >>>>> changes to certain themes are breaking the layout of the Flat Grey >>>>> theme - which shouldn't have been affected. >>>>> >>>>> Um, huh? So, because *new* things were done, possibly adding more >>>>> features, but it broke something else, you want to stop the new >>>>> feature? Why not just fix the thing that broke? >>>>> >>>> I'm a little confused now, because in OFBiz Committers Roles and >>>> Responsibilities is written this: >>>> >>>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>>> harm*. Nothing should be committed that breaks existing functionality >>>> without replacing it either before or in the same commit. >>> >>> Sure. But we are all human, and we are not perfect. >>> >>> Mistakes happen, in both directions. If someone breaks existing >>> functionality, then either back out their change, or fix the existing >>> code to make it work. >>> >>> In this case, I think that maybe just backing out the changes was the >>> wrong approach to take. Unless they will come back at some point, >>> with whatever problems fixed that they caused. >>> >>> ps: I haven't actually looked at the changes in question. >>> >>>> Bilgin >>> >> > |
|
|
Fixed, rev 880871.
-Adrian Bruno Busco wrote: > Hi Adrian, > yes I did notice this at a later stage but then I changed my mind and > used a CSS-only solution committed in rev. 880762. > > Dropping crumbs theme works quite well with this but I did not manage > to have a better rendering when the tab-bar comes to have two lines > due to wrapping like this: > https://localhost:8443/webtools/control/xmldsdump > > or when there is a left column like this: > https://localhost:8443/catalog/control/ListShipmentMethodTypes > > Any help to fix this is greatly appreciated! ;-) > > -Bruno > > 2009/11/16 Adrian Crum <[hidden email]>: >> Bruno, >> >> Did you notice that the GlobalDecorator already has a pre-body section? >> >> -Adrian >> >> Bruno Busco wrote: >>> Adam, >>> I will definitively put back the "new feature" in a different way that >>> does not hurt. >>> >>> The "new feature" basically is the application tab bar at an higher >>> level in the HTML so that it is rendered in the Dropping crumbs theme >>> (I think I should find a better name for this theme) just below the >>> breadcrumb. >>> >>> It will take some time and probably some discussion because I will ask >>> details. >>> I look forward to the community collabotation. >>> >>> -Bruno >>> >>> 2009/11/16 Adam Heath <[hidden email]>: >>>> Bilgin Ibryam wrote: >>>>> Adam Heath wrote: >>>>>> Adrian Crum wrote: >>>>>> >>>>>>> Developers, >>>>>>> >>>>>>> Please be careful when changing HTML element compounds. The recent >>>>>>> >>>>>> changes to certain themes are breaking the layout of the Flat Grey >>>>>> theme - which shouldn't have been affected. >>>>>> >>>>>> Um, huh? So, because *new* things were done, possibly adding more >>>>>> features, but it broke something else, you want to stop the new >>>>>> feature? Why not just fix the thing that broke? >>>>>> >>>>> I'm a little confused now, because in OFBiz Committers Roles and >>>>> Responsibilities is written this: >>>>> >>>>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>>>> harm*. Nothing should be committed that breaks existing functionality >>>>> without replacing it either before or in the same commit. >>>> Sure. But we are all human, and we are not perfect. >>>> >>>> Mistakes happen, in both directions. If someone breaks existing >>>> functionality, then either back out their change, or fix the existing >>>> code to make it work. >>>> >>>> In this case, I think that maybe just backing out the changes was the >>>> wrong approach to take. Unless they will come back at some point, >>>> with whatever problems fixed that they caused. >>>> >>>> ps: I haven't actually looked at the changes in question. >>>> >>>>> Bilgin > |
|
|
In reply to this post by Bruno Busco
Bruno Busco wrote:
You have awakened the sleeping giant. I checked this out from trunk today, and took a look at it. We here at Brainfood like where you are going with this. It is way more functional. However, we noticed some minor issues with styling in a few places. So, Erik, the guy who created the design for the current ofbiz website, is currently creating a psd(photoshop) file with some stylistic things he'd like to see implemented into this theme. He'll have something ready in the next few days. If you don't have photoshop, we can produce it in other forms. I can't state how happy we here at Brainfood are about this direction droppingcrumbs is going. It makes us all gushy inside. |
|
|
+1 Bruno! Thanks for diving in and accepting all of those requests
from the various parties - it's definitely making a huge difference in the usability of the theme and now contribution of the community. Glad to have woken the sleeping giant ... Eric's got mad skillz! So anytime we can have him helping out the professionalism of OFBiz, we can all call ourselves lucky. Thanks Eric - can't wait to see it. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Nov 16, 2009, at 4:42 PM, Adam Heath wrote: > Bruno Busco wrote: > > You have awakened the sleeping giant. > > I checked this out from trunk today, and took a look at it. We here > at Brainfood like where you are going with this. It is way more > functional. > > However, we noticed some minor issues with styling in a few places. > So, Erik, the guy who created the design for the current ofbiz > website, is currently creating a psd(photoshop) file with some > stylistic things he'd like to see implemented into this theme. He'll > have something ready in the next few days. > > If you don't have photoshop, we can produce it in other forms. > > I can't state how happy we here at Brainfood are about this direction > droppingcrumbs is going. It makes us all gushy inside. |
smime.p7s (3K) |
|
Hi guys,
happy to see you all react in such a positive way! ;-) We definitely need awake giants to take OFBiz to the next level. Thank you! Photoshop is ok, no problem with it. -Bruno 2009/11/17 Tim Ruppert <[hidden email]>: > +1 Bruno! Thanks for diving in and accepting all of those requests from the > various parties - it's definitely making a huge difference in the usability > of the theme and now contribution of the community. Glad to have woken the > sleeping giant ... Eric's got mad skillz! So anytime we can have him > helping out the professionalism of OFBiz, we can all call ourselves lucky. > > Thanks Eric - can't wait to see it. > > Cheers, > Ruppert > -- > Tim Ruppert > HotWax Media > http://www.hotwaxmedia.com > > o:801.649.6594 > f:801.649.6595 > > On Nov 16, 2009, at 4:42 PM, Adam Heath wrote: > >> Bruno Busco wrote: >> >> You have awakened the sleeping giant. >> >> I checked this out from trunk today, and took a look at it. We here >> at Brainfood like where you are going with this. It is way more >> functional. >> >> However, we noticed some minor issues with styling in a few places. >> So, Erik, the guy who created the design for the current ofbiz >> website, is currently creating a psd(photoshop) file with some >> stylistic things he'd like to see implemented into this theme. He'll >> have something ready in the next few days. >> >> If you don't have photoshop, we can produce it in other forms. >> >> I can't state how happy we here at Brainfood are about this direction >> droppingcrumbs is going. It makes us all gushy inside. > > |
|
|
In reply to this post by Adrian Crum
Hi Adrian,
finally I followed your hint about the pre-body section. I found that several screens had the TabBar in the pre-body section so I think we should change all other to follow the same pattern. In Revision: 883020 I have moved several TabBar menus from the body to the pre-body and now the rendering is much better in both single and mul-colums layouts. If this is OK (may be a little adjustment is necessary on the TabBar margins to have it exactly as it was befor in other themes) I will go further changing al other screens. Is it OK with you? -Bruno 2009/11/16 Adrian Crum <[hidden email]>: > Bruno, > > Did you notice that the GlobalDecorator already has a pre-body section? > > -Adrian > > Bruno Busco wrote: >> >> Adam, >> I will definitively put back the "new feature" in a different way that >> does not hurt. >> >> The "new feature" basically is the application tab bar at an higher >> level in the HTML so that it is rendered in the Dropping crumbs theme >> (I think I should find a better name for this theme) just below the >> breadcrumb. >> >> It will take some time and probably some discussion because I will ask >> details. >> I look forward to the community collabotation. >> >> -Bruno >> >> 2009/11/16 Adam Heath <[hidden email]>: >>> >>> Bilgin Ibryam wrote: >>>> >>>> Adam Heath wrote: >>>>> >>>>> Adrian Crum wrote: >>>>> >>>>>> Developers, >>>>>> >>>>>> Please be careful when changing HTML element compounds. The recent >>>>>> >>>>> changes to certain themes are breaking the layout of the Flat Grey >>>>> theme - which shouldn't have been affected. >>>>> >>>>> Um, huh? So, because *new* things were done, possibly adding more >>>>> features, but it broke something else, you want to stop the new >>>>> feature? Why not just fix the thing that broke? >>>>> >>>> I'm a little confused now, because in OFBiz Committers Roles and >>>> Responsibilities is written this: >>>> >>>> *Rule #1 for a committer is the same as for a doctor:* *first do no >>>> harm*. Nothing should be committed that breaks existing functionality >>>> without replacing it either before or in the same commit. >>> >>> Sure. But we are all human, and we are not perfect. >>> >>> Mistakes happen, in both directions. If someone breaks existing >>> functionality, then either back out their change, or fix the existing >>> code to make it work. >>> >>> In this case, I think that maybe just backing out the changes was the >>> wrong approach to take. Unless they will come back at some point, >>> with whatever problems fixed that they caused. >>> >>> ps: I haven't actually looked at the changes in question. >>> >>>> Bilgin >>> >> > |
|
|
That would be great!
The pre-body section was created for the tab bar when IE 7 came out. The tab bar style had a negative margin to move it over the padding in the main content area. But IE7 would paint the padding over the tab bar. So I created the pre-body section and removed the negative margin from the tab bar style. I changed a few screens as an example, but so far no one else has worked on changing the other screens. -Adrian --- On Sat, 11/21/09, Bruno Busco <[hidden email]> wrote: > From: Bruno Busco <[hidden email]> > Subject: Re: Layout Problems > To: [hidden email] > Date: Saturday, November 21, 2009, 4:49 PM > Hi Adrian, > finally I followed your hint about the pre-body section. > I found that several screens had the TabBar in the pre-body > section so > I think we should change all other to follow the same > pattern. > > In Revision: 883020 I have moved several TabBar menus from > the body to > the pre-body and now the rendering is much better in both > single and > mul-colums layouts. > > If this is OK (may be a little adjustment is necessary on > the TabBar > margins to have it exactly as it was befor in other themes) > I will go > further changing al other screens. > > Is it OK with you? > > -Bruno > > > > 2009/11/16 Adrian Crum <[hidden email]>: > > Bruno, > > > > Did you notice that the GlobalDecorator already has a > pre-body section? > > > > -Adrian > > > > Bruno Busco wrote: > >> > >> Adam, > >> I will definitively put back the "new feature" in > a different way that > >> does not hurt. > >> > >> The "new feature" basically is the application tab > bar at an higher > >> level in the HTML so that it is rendered in the > Dropping crumbs theme > >> (I think I should find a better name for this > theme) just below the > >> breadcrumb. > >> > >> It will take some time and probably some > discussion because I will ask > >> details. > >> I look forward to the community collabotation. > >> > >> -Bruno > >> > >> 2009/11/16 Adam Heath <[hidden email]>: > >>> > >>> Bilgin Ibryam wrote: > >>>> > >>>> Adam Heath wrote: > >>>>> > >>>>> Adrian Crum wrote: > >>>>> > >>>>>> Developers, > >>>>>> > >>>>>> Please be careful when changing > HTML element compounds. The recent > >>>>>> > >>>>> changes to certain themes are breaking > the layout of the Flat Grey > >>>>> theme - which shouldn't have been > affected. > >>>>> > >>>>> Um, huh? So, because *new* things > were done, possibly adding more > >>>>> features, but it broke something else, > you want to stop the new > >>>>> feature? Why not just fix the thing > that broke? > >>>>> > >>>> I'm a little confused now, because in > OFBiz Committers Roles and > >>>> Responsibilities is written this: > >>>> > >>>> *Rule #1 for a committer is the same as > for a doctor:* *first do no > >>>> harm*. Nothing should be committed that > breaks existing functionality > >>>> without replacing it either before or in > the same commit. > >>> > >>> Sure. But we are all human, and we are not > perfect. > >>> > >>> Mistakes happen, in both directions. If > someone breaks existing > >>> functionality, then either back out their > change, or fix the existing > >>> code to make it work. > >>> > >>> In this case, I think that maybe just backing > out the changes was the > >>> wrong approach to take. Unless they will > come back at some point, > >>> with whatever problems fixed that they > caused. > >>> > >>> ps: I haven't actually looked at the changes > in question. > >>> > >>>> Bilgin > >>> > >> > > > |
|
|
By the way, I really appreciate all of the work you're doing on the UI and the visual themes!
Something that might be helpful in your efforts would be to review the dev list emails from January 2007 to around May of 2007. During that time I led an effort to overhaul the markup and styles used in OFBiz, and there was a lot of discussion about it on the mailing list as the community worked out the details. You will see how and why things are set up the way they are. One of the reasons the Flat Grey theme works as well as it does is because the entire community contributed to its development. It is scalable, reversible, it resizes to any window size, and it has good cross-browser support. From my perspective, it is the theme by which all others are measured. If I seem a bit harsh in my response to markup or style changes, it is because I don't want to see all of those efforts reversed or reduced. -Adrian --- On Sat, 11/21/09, Adrian Crum <[hidden email]> wrote: > From: Adrian Crum <[hidden email]> > Subject: Re: Layout Problems > To: [hidden email] > Date: Saturday, November 21, 2009, 5:19 PM > That would be great! > > The pre-body section was created for the tab bar when IE 7 > came out. The tab bar style had a negative margin to move it > over the padding in the main content area. But IE7 would > paint the padding over the tab bar. So I created the > pre-body section and removed the negative margin from the > tab bar style. I changed a few screens as an example, but so > far no one else has worked on changing the other screens. > > -Adrian > > --- On Sat, 11/21/09, Bruno Busco <[hidden email]> > wrote: > > > From: Bruno Busco <[hidden email]> > > Subject: Re: Layout Problems > > To: [hidden email] > > Date: Saturday, November 21, 2009, 4:49 PM > > Hi Adrian, > > finally I followed your hint about the pre-body > section. > > I found that several screens had the TabBar in the > pre-body > > section so > > I think we should change all other to follow the same > > pattern. > > > > In Revision: 883020 I have moved several TabBar menus > from > > the body to > > the pre-body and now the rendering is much better in > both > > single and > > mul-colums layouts. > > > > If this is OK (may be a little adjustment is necessary > on > > the TabBar > > margins to have it exactly as it was befor in other > themes) > > I will go > > further changing al other screens. > > > > Is it OK with you? > > > > -Bruno > > > > > > > > 2009/11/16 Adrian Crum <[hidden email]>: > > > Bruno, > > > > > > Did you notice that the GlobalDecorator already > has a > > pre-body section? > > > > > > -Adrian > > > > > > Bruno Busco wrote: > > >> > > >> Adam, > > >> I will definitively put back the "new > feature" in > > a different way that > > >> does not hurt. > > >> > > >> The "new feature" basically is the > application tab > > bar at an higher > > >> level in the HTML so that it is rendered in > the > > Dropping crumbs theme > > >> (I think I should find a better name for > this > > theme) just below the > > >> breadcrumb. > > >> > > >> It will take some time and probably some > > discussion because I will ask > > >> details. > > >> I look forward to the community > collabotation. > > >> > > >> -Bruno > > >> > > >> 2009/11/16 Adam Heath <[hidden email]>: > > >>> > > >>> Bilgin Ibryam wrote: > > >>>> > > >>>> Adam Heath wrote: > > >>>>> > > >>>>> Adrian Crum wrote: > > >>>>> > > >>>>>> Developers, > > >>>>>> > > >>>>>> Please be careful when > changing > > HTML element compounds. The recent > > >>>>>> > > >>>>> changes to certain themes are > breaking > > the layout of the Flat Grey > > >>>>> theme - which shouldn't have > been > > affected. > > >>>>> > > >>>>> Um, huh? So, because *new* > things > > were done, possibly adding more > > >>>>> features, but it broke something > else, > > you want to stop the new > > >>>>> feature? Why not just fix the > thing > > that broke? > > >>>>> > > >>>> I'm a little confused now, because > in > > OFBiz Committers Roles and > > >>>> Responsibilities is written this: > > >>>> > > >>>> *Rule #1 for a committer is the same > as > > for a doctor:* *first do no > > >>>> harm*. Nothing should be committed > that > > breaks existing functionality > > >>>> without replacing it either before or > in > > the same commit. > > >>> > > >>> Sure. But we are all human, and we are > not > > perfect. > > >>> > > >>> Mistakes happen, in both directions. > If > > someone breaks existing > > >>> functionality, then either back out > their > > change, or fix the existing > > >>> code to make it work. > > >>> > > >>> In this case, I think that maybe just > backing > > out the changes was the > > >>> wrong approach to take. Unless they > will > > come back at some point, > > >>> with whatever problems fixed that they > > caused. > > >>> > > >>> ps: I haven't actually looked at the > changes > > in question. > > >>> > > >>>> Bilgin > > >>> > > >> > > > > > > > > > |
|
|
In reply to this post by Adrian Crum-2
Hi Adrian,
agreed! ;-) I will try to change them all. I think the example was not explicitly saying "hey this is the pattern to follow for future screens!". Having all TabBar menu in the pre-body will be far more visible. -Bruno 2009/11/22 Adrian Crum <[hidden email]>: > That would be great! > > The pre-body section was created for the tab bar when IE 7 came out. The tab bar style had a negative margin to move it over the padding in the main content area. But IE7 would paint the padding over the tab bar. So I created the pre-body section and removed the negative margin from the tab bar style. I changed a few screens as an example, but so far no one else has worked on changing the other screens. > > -Adrian > > --- On Sat, 11/21/09, Bruno Busco <[hidden email]> wrote: > >> From: Bruno Busco <[hidden email]> >> Subject: Re: Layout Problems >> To: [hidden email] >> Date: Saturday, November 21, 2009, 4:49 PM >> Hi Adrian, >> finally I followed your hint about the pre-body section. >> I found that several screens had the TabBar in the pre-body >> section so >> I think we should change all other to follow the same >> pattern. >> >> In Revision: 883020 I have moved several TabBar menus from >> the body to >> the pre-body and now the rendering is much better in both >> single and >> mul-colums layouts. >> >> If this is OK (may be a little adjustment is necessary on >> the TabBar >> margins to have it exactly as it was befor in other themes) >> I will go >> further changing al other screens. >> >> Is it OK with you? >> >> -Bruno >> >> >> >> 2009/11/16 Adrian Crum <[hidden email]>: >> > Bruno, >> > >> > Did you notice that the GlobalDecorator already has a >> pre-body section? >> > >> > -Adrian >> > >> > Bruno Busco wrote: >> >> >> >> Adam, >> >> I will definitively put back the "new feature" in >> a different way that >> >> does not hurt. >> >> >> >> The "new feature" basically is the application tab >> bar at an higher >> >> level in the HTML so that it is rendered in the >> Dropping crumbs theme >> >> (I think I should find a better name for this >> theme) just below the >> >> breadcrumb. >> >> >> >> It will take some time and probably some >> discussion because I will ask >> >> details. >> >> I look forward to the community collabotation. >> >> >> >> -Bruno >> >> >> >> 2009/11/16 Adam Heath <[hidden email]>: >> >>> >> >>> Bilgin Ibryam wrote: >> >>>> >> >>>> Adam Heath wrote: >> >>>>> >> >>>>> Adrian Crum wrote: >> >>>>> >> >>>>>> Developers, >> >>>>>> >> >>>>>> Please be careful when changing >> HTML element compounds. The recent >> >>>>>> >> >>>>> changes to certain themes are breaking >> the layout of the Flat Grey >> >>>>> theme - which shouldn't have been >> affected. >> >>>>> >> >>>>> Um, huh? So, because *new* things >> were done, possibly adding more >> >>>>> features, but it broke something else, >> you want to stop the new >> >>>>> feature? Why not just fix the thing >> that broke? >> >>>>> >> >>>> I'm a little confused now, because in >> OFBiz Committers Roles and >> >>>> Responsibilities is written this: >> >>>> >> >>>> *Rule #1 for a committer is the same as >> for a doctor:* *first do no >> >>>> harm*. Nothing should be committed that >> breaks existing functionality >> >>>> without replacing it either before or in >> the same commit. >> >>> >> >>> Sure. But we are all human, and we are not >> perfect. >> >>> >> >>> Mistakes happen, in both directions. If >> someone breaks existing >> >>> functionality, then either back out their >> change, or fix the existing >> >>> code to make it work. >> >>> >> >>> In this case, I think that maybe just backing >> out the changes was the >> >>> wrong approach to take. Unless they will >> come back at some point, >> >>> with whatever problems fixed that they >> caused. >> >>> >> >>> ps: I haven't actually looked at the changes >> in question. >> >>> >> >>>> Bilgin >> >>> >> >> >> > >> > > > > |
|
|
In reply to this post by Adrian Crum-2
I understand Adrian,
thank you for sharing all this. -Bruno 2009/11/22 Adrian Crum <[hidden email]>: > By the way, I really appreciate all of the work you're doing on the UI and the visual themes! > > Something that might be helpful in your efforts would be to review the dev list emails from January 2007 to around May of 2007. During that time I led an effort to overhaul the markup and styles used in OFBiz, and there was a lot of discussion about it on the mailing list as the community worked out the details. You will see how and why things are set up the way they are. > > One of the reasons the Flat Grey theme works as well as it does is because the entire community contributed to its development. It is scalable, reversible, it resizes to any window size, and it has good cross-browser support. From my perspective, it is the theme by which all others are measured. > > If I seem a bit harsh in my response to markup or style changes, it is because I don't want to see all of those efforts reversed or reduced. > > -Adrian > > --- On Sat, 11/21/09, Adrian Crum <[hidden email]> wrote: > >> From: Adrian Crum <[hidden email]> >> Subject: Re: Layout Problems >> To: [hidden email] >> Date: Saturday, November 21, 2009, 5:19 PM >> That would be great! >> >> The pre-body section was created for the tab bar when IE 7 >> came out. The tab bar style had a negative margin to move it >> over the padding in the main content area. But IE7 would >> paint the padding over the tab bar. So I created the >> pre-body section and removed the negative margin from the >> tab bar style. I changed a few screens as an example, but so >> far no one else has worked on changing the other screens. >> >> -Adrian >> >> --- On Sat, 11/21/09, Bruno Busco <[hidden email]> >> wrote: >> >> > From: Bruno Busco <[hidden email]> >> > Subject: Re: Layout Problems >> > To: [hidden email] >> > Date: Saturday, November 21, 2009, 4:49 PM >> > Hi Adrian, >> > finally I followed your hint about the pre-body >> section. >> > I found that several screens had the TabBar in the >> pre-body >> > section so >> > I think we should change all other to follow the same >> > pattern. >> > >> > In Revision: 883020 I have moved several TabBar menus >> from >> > the body to >> > the pre-body and now the rendering is much better in >> both >> > single and >> > mul-colums layouts. >> > >> > If this is OK (may be a little adjustment is necessary >> on >> > the TabBar >> > margins to have it exactly as it was befor in other >> themes) >> > I will go >> > further changing al other screens. >> > >> > Is it OK with you? >> > >> > -Bruno >> > >> > >> > >> > 2009/11/16 Adrian Crum <[hidden email]>: >> > > Bruno, >> > > >> > > Did you notice that the GlobalDecorator already >> has a >> > pre-body section? >> > > >> > > -Adrian >> > > >> > > Bruno Busco wrote: >> > >> >> > >> Adam, >> > >> I will definitively put back the "new >> feature" in >> > a different way that >> > >> does not hurt. >> > >> >> > >> The "new feature" basically is the >> application tab >> > bar at an higher >> > >> level in the HTML so that it is rendered in >> the >> > Dropping crumbs theme >> > >> (I think I should find a better name for >> this >> > theme) just below the >> > >> breadcrumb. >> > >> >> > >> It will take some time and probably some >> > discussion because I will ask >> > >> details. >> > >> I look forward to the community >> collabotation. >> > >> >> > >> -Bruno >> > >> >> > >> 2009/11/16 Adam Heath <[hidden email]>: >> > >>> >> > >>> Bilgin Ibryam wrote: >> > >>>> >> > >>>> Adam Heath wrote: >> > >>>>> >> > >>>>> Adrian Crum wrote: >> > >>>>> >> > >>>>>> Developers, >> > >>>>>> >> > >>>>>> Please be careful when >> changing >> > HTML element compounds. The recent >> > >>>>>> >> > >>>>> changes to certain themes are >> breaking >> > the layout of the Flat Grey >> > >>>>> theme - which shouldn't have >> been >> > affected. >> > >>>>> >> > >>>>> Um, huh? So, because *new* >> things >> > were done, possibly adding more >> > >>>>> features, but it broke something >> else, >> > you want to stop the new >> > >>>>> feature? Why not just fix the >> thing >> > that broke? >> > >>>>> >> > >>>> I'm a little confused now, because >> in >> > OFBiz Committers Roles and >> > >>>> Responsibilities is written this: >> > >>>> >> > >>>> *Rule #1 for a committer is the same >> as >> > for a doctor:* *first do no >> > >>>> harm*. Nothing should be committed >> that >> > breaks existing functionality >> > >>>> without replacing it either before or >> in >> > the same commit. >> > >>> >> > >>> Sure. But we are all human, and we are >> not >> > perfect. >> > >>> >> > >>> Mistakes happen, in both directions. >> If >> > someone breaks existing >> > >>> functionality, then either back out >> their >> > change, or fix the existing >> > >>> code to make it work. >> > >>> >> > >>> In this case, I think that maybe just >> backing >> > out the changes was the >> > >>> wrong approach to take. Unless they >> will >> > come back at some point, >> > >>> with whatever problems fixed that they >> > caused. >> > >>> >> > >>> ps: I haven't actually looked at the >> changes >> > in question. >> > >>> >> > >>>> Bilgin >> > >>> >> > >> >> > > >> > >> >> >> >> > > > > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |