Mini-language error message handling

[Adrian Crum-3]

While working on the Mini-language overhaul, I noticed that the error
message handling is a little convoluted and it opens up the potential
for things to not work properly.

You can specify the name of the error message list in the
<simple-method> element. You can also specify the name of the error
message list in some of the method operations that generate error
messages. I am not sure what purpose that serves. The event and service
engines will retrieve the error message list specified in the
<simple-method> element - any other error message lists that were
created by method operations are ignored.

In the existing Mini-language code there are only a handful of method
operations that specify the error message list name, and in all of those
cases the default name is used - effectively doing nothing. I would like
to remove the capability to specify the error message list name in all
of the method operations. Instead, method operations that generate
errors will use the error message list name defined in the enclosing
<simple-method> element.

What do you think?

-Adrian

[Scott Gray-2]

I've never understood the use case for it so a general +0 but if no one else knows either then +1

Regards
Scott

On 28/04/2012, at 11:23 PM, Adrian Crum wrote:

> While working on the Mini-language overhaul, I noticed that the error message handling is a little convoluted and it opens up the potential for things to not work properly.
>
> You can specify the name of the error message list in the <simple-method> element. You can also specify the name of the error message list in some of the method operations that generate error messages. I am not sure what purpose that serves. The event and service engines will retrieve the error message list specified in the <simple-method> element - any other error message lists that were created by method operations are ignored.
>
> In the existing Mini-language code there are only a handful of method operations that specify the error message list name, and in all of those cases the default name is used - effectively doing nothing. I would like to remove the capability to specify the error message list name in all of the method operations. Instead, method operations that generate errors will use the error message list name defined in the enclosing <simple-method> element.
>
> What do you think?
>
> -Adrian
>

[Jacopo Cappellato-4]

+1

Jacopo

On Apr 28, 2012, at 1:23 PM, Adrian Crum wrote:

> While working on the Mini-language overhaul, I noticed that the error message handling is a little convoluted and it opens up the potential for things to not work properly.
>
> You can specify the name of the error message list in the <simple-method> element. You can also specify the name of the error message list in some of the method operations that generate error messages. I am not sure what purpose that serves. The event and service engines will retrieve the error message list specified in the <simple-method> element - any other error message lists that were created by method operations are ignored.
>
> In the existing Mini-language code there are only a handful of method operations that specify the error message list name, and in all of those cases the default name is used - effectively doing nothing. I would like to remove the capability to specify the error message list name in all of the method operations. Instead, method operations that generate errors will use the error message list name defined in the enclosing <simple-method> element.
>
> What do you think?
>
> -Adrian
>

[Jacques Le Roux]

+1 to remove if really "it opens up the potential  for things to not work properly."
And of course unless the creator of this option explains the need

Also what attributes will be removed exactly?

Note: I did not find any "error-message" string in *.xml files in trunk

Jacques

From: "Adrian Crum" <[hidden email]>

> While working on the Mini-language overhaul, I noticed that the error
> message handling is a little convoluted and it opens up the potential
> for things to not work properly.
>
> You can specify the name of the error message list in the
> <simple-method> element. You can also specify the name of the error
> message list in some of the method operations that generate error
> messages. I am not sure what purpose that serves. The event and service
> engines will retrieve the error message list specified in the
> <simple-method> element - any other error message lists that were
> created by method operations are ignored.
>
> In the existing Mini-language code there are only a handful of method
> operations that specify the error message list name, and in all of those
> cases the default name is used - effectively doing nothing. I would like
> to remove the capability to specify the error message list name in all
> of the method operations. Instead, method operations that generate
> errors will use the error message list name defined in the enclosing
> <simple-method> element.
>
> What do you think?
>
> -Adrian
>

[Adrian Crum-3]

Search for "error-list-name"

-Adrian

On 4/28/2012 6:55 PM, Jacques Le Roux wrote:

> +1 to remove if really "it opens up the potential  for things to not
> work properly."
> And of course unless the creator of this option explains the need
>
> Also what attributes will be removed exactly?
>
> Note: I did not find any "error-message" string in *.xml files in trunk
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> While working on the Mini-language overhaul, I noticed that the error
>> message handling is a little convoluted and it opens up the potential
>> for things to not work properly.
>>
>> You can specify the name of the error message list in the
>> <simple-method> element. You can also specify the name of the error
>> message list in some of the method operations that generate error
>> messages. I am not sure what purpose that serves. The event and
>> service engines will retrieve the error message list specified in the
>> <simple-method> element - any other error message lists that were
>> created by method operations are ignored.
>>
>> In the existing Mini-language code there are only a handful of method
>> operations that specify the error message list name, and in all of
>> those cases the default name is used - effectively doing nothing. I
>> would like to remove the capability to specify the error message list
>> name in all of the method operations. Instead, method operations that
>> generate errors will use the error message list name defined in the
>> enclosing <simple-method> element.
>>
>> What do you think?
>>
>> -Adrian
>>

[Adrian Crum-3]

The interesting side effect of this change is it causes tests to fail -
because errors were being ignored, so the tests passed.

-Adrian

On 4/28/2012 12:23 PM, Adrian Crum wrote:

> While working on the Mini-language overhaul, I noticed that the error
> message handling is a little convoluted and it opens up the potential
> for things to not work properly.
>
> You can specify the name of the error message list in the
> <simple-method> element. You can also specify the name of the error
> message list in some of the method operations that generate error
> messages. I am not sure what purpose that serves. The event and
> service engines will retrieve the error message list specified in the
> <simple-method> element - any other error message lists that were
> created by method operations are ignored.
>
> In the existing Mini-language code there are only a handful of method
> operations that specify the error message list name, and in all of
> those cases the default name is used - effectively doing nothing. I
> would like to remove the capability to specify the error message list
> name in all of the method operations. Instead, method operations that
> generate errors will use the error message list name defined in the
> enclosing <simple-method> element.
>
> What do you think?
>
> -Adrian
>

[Jacques Le Roux]

Indeed, pretty useless OOTB

Jacques

From: "Adrian Crum" <[hidden email]>

> Search for "error-list-name"
>
> -Adrian
>
> On 4/28/2012 6:55 PM, Jacques Le Roux wrote:
>> +1 to remove if really "it opens up the potential  for things to not
>> work properly."
>> And of course unless the creator of this option explains the need
>>
>> Also what attributes will be removed exactly?
>>
>> Note: I did not find any "error-message" string in *.xml files in trunk
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> While working on the Mini-language overhaul, I noticed that the error
>>> message handling is a little convoluted and it opens up the potential
>>> for things to not work properly.
>>>
>>> You can specify the name of the error message list in the
>>> <simple-method> element. You can also specify the name of the error
>>> message list in some of the method operations that generate error
>>> messages. I am not sure what purpose that serves. The event and
>>> service engines will retrieve the error message list specified in the
>>> <simple-method> element - any other error message lists that were
>>> created by method operations are ignored.
>>>
>>> In the existing Mini-language code there are only a handful of method
>>> operations that specify the error message list name, and in all of
>>> those cases the default name is used - effectively doing nothing. I
>>> would like to remove the capability to specify the error message list
>>> name in all of the method operations. Instead, method operations that
>>> generate errors will use the error message list name defined in the
>>> enclosing <simple-method> element.
>>>
>>> What do you think?
>>>
>>> -Adrian
>>>

[Pierre Smits]

What tests are failing.

Regards,

Pierre

Verstuurd vanaf mijn iPad

Op 28 apr. 2012 om 20:16 heeft Adrian Crum <[hidden email]> het volgende geschreven:

> The interesting side effect of this change is it causes tests to fail - because errors were being ignored, so the tests passed.
>
> -Adrian
>
> On 4/28/2012 12:23 PM, Adrian Crum wrote:
>> While working on the Mini-language overhaul, I noticed that the error message handling is a little convoluted and it opens up the potential for things to not work properly.
>>
>> You can specify the name of the error message list in the <simple-method> element. You can also specify the name of the error message list in some of the method operations that generate error messages. I am not sure what purpose that serves. The event and service engines will retrieve the error message list specified in the <simple-method> element - any other error message lists that were created by method operations are ignored.
>>
>> In the existing Mini-language code there are only a handful of method operations that specify the error message list name, and in all of those cases the default name is used - effectively doing nothing. I would like to remove the capability to specify the error message list name in all of the method operations. Instead, method operations that generate errors will use the error message list name defined in the enclosing <simple-method> element.
>>
>> What do you think?
>>
>> -Adrian
>>

[Adrian Crum-3]

Actually, the tests are fine. I was under the impression that the
<add-error> and <check-errors> elements were related. I thought the
<check-errors> element checked the error list created by <add-error>,
but the two are not related.

-Adrian

On 4/28/2012 8:05 PM, Pierre Smits wrote:

> What tests are failing.
>
> Regards,
>
> Pierre
>
> Verstuurd vanaf mijn iPad
>
> Op 28 apr. 2012 om 20:16 heeft Adrian Crum<[hidden email]>  het volgende geschreven:
>
>> The interesting side effect of this change is it causes tests to fail - because errors were being ignored, so the tests passed.
>>
>> -Adrian
>>
>> On 4/28/2012 12:23 PM, Adrian Crum wrote:
>>> While working on the Mini-language overhaul, I noticed that the error message handling is a little convoluted and it opens up the potential for things to not work properly.
>>>
>>> You can specify the name of the error message list in the<simple-method>  element. You can also specify the name of the error message list in some of the method operations that generate error messages. I am not sure what purpose that serves. The event and service engines will retrieve the error message list specified in the<simple-method>  element - any other error message lists that were created by method operations are ignored.
>>>
>>> In the existing Mini-language code there are only a handful of method operations that specify the error message list name, and in all of those cases the default name is used - effectively doing nothing. I would like to remove the capability to specify the error message list name in all of the method operations. Instead, method operations that generate errors will use the error message list name defined in the enclosing<simple-method>  element.
>>>
>>> What do you think?
>>>
>>> -Adrian
>>>