OFBIZ-5727 - DatePick component returns wrong format in R12 and R11

[Jacques Le Roux]

Hi,

With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours represented as 12 not 24", I wrongly committed changes in R12 and R11 branches.
Though I thought I checked the jquery-ui-timepicker-addon version in R12 and R11, I obviously did it wrong.
The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6 respectively) and don't contain the 24 hours format handling.

So the changes in R12.04 r1616276 and R11.04 r1616281 were Inappropriate. It's an easy fix for the branches to revert this commits (done respectively
at r1621058  and r1621059)

Now I think, due to bad user experience when using 12.04.04 and 11.04.05 where the regression is, we need to release  12.04.05  and 11.04.06, and I'm
ready to act as release manager.

What do you think?

Jacques

[Adrian Crum-3]

Sounds good - crack on!

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 8/28/2014 7:28 AM, Jacques Le Roux wrote:

> Hi,
>
> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours
> represented as 12 not 24", I wrongly committed changes in R12 and R11
> branches.
> Though I thought I checked the jquery-ui-timepicker-addon version in R12
> and R11, I obviously did it wrong.
> The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6
> respectively) and don't contain the 24 hours format handling.
>
> So the changes in R12.04 r1616276 and R11.04 r1616281 were
> Inappropriate. It's an easy fix for the branches to revert this commits
> (done respectively at r1621058  and r1621059)
>
> Now I think, due to bad user experience when using 12.04.04 and 11.04.05
> where the regression is, we need to release  12.04.05  and 11.04.06, and
> I'm ready to act as release manager.
>
> What do you think?
>
> Jacques
>
>

[Pierre Smits]

Jacques,

With the release of the latest versions for r11 and r12, people will start
the upgrade path. So expect more issues regarding the subject.

The sooner we mitigate this the better. Good luck with releasing the
upgrade.

Regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com


On Thu, Aug 28, 2014 at 8:28 AM, Jacques Le Roux <
[hidden email]> wrote:

> Hi,
>
> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours
> represented as 12 not 24", I wrongly committed changes in R12 and R11
> branches.
> Though I thought I checked the jquery-ui-timepicker-addon version in R12
> and R11, I obviously did it wrong.
> The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6
> respectively) and don't contain the 24 hours format handling.
>
> So the changes in R12.04 r1616276 and R11.04 r1616281 were Inappropriate.
> It's an easy fix for the branches to revert this commits (done respectively
> at r1621058  and r1621059)
>
> Now I think, due to bad user experience when using 12.04.04 and 11.04.05
> where the regression is, we need to release  12.04.05  and 11.04.06, and
> I'm ready to act as release manager.
>
> What do you think?
>
> Jacques
>
>
>

[Jacopo Cappellato-4]

On Aug 28, 2014, at 8:28 AM, Jacques Le Roux <[hidden email]> wrote:

> Hi,
>
> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours represented as 12 not 24", I wrongly committed changes in R12 and R11 branches.
> Though I thought I checked the jquery-ui-timepicker-addon version in R12 and R11, I obviously did it wrong.
> The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6 respectively) and don't contain the 24 hours format handling.
>
> So the changes in R12.04 r1616276 and R11.04 r1616281 were Inappropriate. It's an easy fix for the branches to revert this commits (done respectively at r1621058  and r1621059)
>
> Now I think, due to bad user experience when using 12.04.04 and 11.04.05 where the regression is, we need to release  12.04.05  and 11.04.06, and I'm ready to act as release manager.

Jacques, I feel more confident if I take care of the release processing; let me know when we are ready to proceed.

Jacopo

>
> What do you think?
>
> Jacques
>
>

[Malin Nicolas]

In parallel to the 12.04.05 and 11.04.06 maybe to propose a corrective
patch associate to 12.04.04 and 11.04.05 as quick official hot-fix.
I think to production site that update their instance.

Nicolas

Le 28/08/2014 08:28, Jacques Le Roux a écrit :

> Hi,
>
> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours
> represented as 12 not 24", I wrongly committed changes in R12 and R11
> branches.
> Though I thought I checked the jquery-ui-timepicker-addon version in
> R12 and R11, I obviously did it wrong.
> The jquery-ui-timepicker-addon versions are there older (0.9.7 and
> 0.9.6 respectively) and don't contain the 24 hours format handling.
>
> So the changes in R12.04 r1616276 and R11.04 r1616281 were
> Inappropriate. It's an easy fix for the branches to revert this
> commits (done respectively at r1621058  and r1621059)
>
> Now I think, due to bad user experience when using 12.04.04 and
> 11.04.05 where the regression is, we need to release  12.04.05 and
> 11.04.06, and I'm ready to act as release manager.
>
> What do you think?
>
> Jacques
>
>

[Jacques Le Roux]

This is an idea Nicolas, in the meantime we could put a link to the OFBIZ-5727 in the download page.

What others think?

Jacques

Le 28/08/2014 10:05, Nicolas Malin a écrit :

> In parallel to the 12.04.05 and 11.04.06 maybe to propose a corrective patch associate to 12.04.04 and 11.04.05 as quick official hot-fix.
> I think to production site that update their instance.
>
> Nicolas
>
> Le 28/08/2014 08:28, Jacques Le Roux a écrit :
>> Hi,
>>
>> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours
>> represented as 12 not 24", I wrongly committed changes in R12 and R11
>> branches.
>> Though I thought I checked the jquery-ui-timepicker-addon version in
>> R12 and R11, I obviously did it wrong.
>> The jquery-ui-timepicker-addon versions are there older (0.9.7 and
>> 0.9.6 respectively) and don't contain the 24 hours format handling.
>>
>> So the changes in R12.04 r1616276 and R11.04 r1616281 were
>> Inappropriate. It's an easy fix for the branches to revert this
>> commits (done respectively at r1621058  and r1621059)
>>
>> Now I think, due to bad user experience when using 12.04.04 and
>> 11.04.05 where the regression is, we need to release  12.04.05 and
>> 11.04.06, and I'm ready to act as release manager.
>>
>> What do you think?
>>
>> Jacques
>>
>>
>
>

[Jacques Le Roux]

Le 28/08/2014 09:58, Jacopo Cappellato a écrit :

> On Aug 28, 2014, at 8:28 AM, Jacques Le Roux <[hidden email]> wrote:
>
>> Hi,
>>
>> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours represented as 12 not 24", I wrongly committed changes in R12 and R11 branches.
>> Though I thought I checked the jquery-ui-timepicker-addon version in R12 and R11, I obviously did it wrong.
>> The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6 respectively) and don't contain the 24 hours format handling.
>>
>> So the changes in R12.04 r1616276 and R11.04 r1616281 were Inappropriate. It's an easy fix for the branches to revert this commits (done respectively at r1621058  and r1621059)
>>
>> Now I think, due to bad user experience when using 12.04.04 and 11.04.05 where the regression is, we need to release  12.04.05  and 11.04.06, and I'm ready to act as release manager.
> Jacques, I feel more confident if I take care of the release processing; let me know when we are ready to proceed.
>
> Jacopo

That's just great Jacopo, it's ready then. Just need to close OFBIZ-5735 when done. I kept it open (though it's duplicate of OFBIZ-5727) for this
purpose (I saw you entered the fixed versions since)

Jacques
PS: your answer got in Spamcop held-mail, so I read it after Nicolas's proposition, maybe though for few days a link to OFBIZ-5727 in download page
worth the effort?

>> What do you think?
>>
>> Jacques
>>
>>
>
>

[Jacques Le Roux]

Le 28/08/2014 10:39, Jacques Le Roux a écrit :

>
> Le 28/08/2014 09:58, Jacopo Cappellato a écrit :
>> On Aug 28, 2014, at 8:28 AM, Jacques Le Roux <[hidden email]> wrote:
>>
>>> Hi,
>>>
>>> With OFBIZ-5702 - "Wrong timeFormat of datetimepicker causes hours represented as 12 not 24", I wrongly committed changes in R12 and R11 branches.
>>> Though I thought I checked the jquery-ui-timepicker-addon version in R12 and R11, I obviously did it wrong.
>>> The jquery-ui-timepicker-addon versions are there older (0.9.7 and 0.9.6 respectively) and don't contain the 24 hours format handling.
>>>
>>> So the changes in R12.04 r1616276 and R11.04 r1616281 were Inappropriate. It's an easy fix for the branches to revert this commits (done
>>> respectively at r1621058  and r1621059)
>>>
>>> Now I think, due to bad user experience when using 12.04.04 and 11.04.05 where the regression is, we need to release 12.04.05  and 11.04.06, and
>>> I'm ready to act as release manager.
>> Jacques, I feel more confident if I take care of the release processing; let me know when we are ready to proceed.
>>
>> Jacopo
>
> That's just great Jacopo, it's ready then. Just need to close OFBIZ-5735 when done. I kept it open (though it's duplicate of OFBIZ-5727) for this
> purpose (I saw you entered the fixed versions since)
>
> Jacques
> PS: your answer got in Spamcop held-mail, so I read it after Nicolas's proposition, maybe though for few days a link to OFBIZ-5727 in download page
> worth the effort?

I think we must definitely do that, because the releases can't be done before more people complain

Jacques

>
>>> What do you think?
>>>
>>> Jacques
>>>
>>>
>>
>>
>