OFBiz Core Dependency on Plugins

[Ratnesh Upadhyay-2]

Devs,

While reviewing email services, I noticed that we are still having
references of plugins component (ecommerce) in core components.

Here is the quick references : (order/data/DemoProduct.xml)
<ProductStoreEmailSetting productStoreId="9000"
emailType="PRDS_ODR_CONFIRM"
bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice"
xslfoAttachScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf"
subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
[hidden email]" fromAddress="[hidden email]"/>

There are some more occurrences (in controller, screens, menus), I'll log a
Jira ticket and share all the details there to resolve all such
dependencies.
I'm pretty sure that it's not intentional as the community did big effort
to resolve dependencies while creating plugins but still Its good to get
confirmation from the community.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

[Rishi Solanki]

I don't see any reason to keep these referneces in core components.

+1 for fixing the references.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: [phone]
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, Sep 9, 2017 at 8:40 PM, Ratnesh Upadhyay <[hidden email]
> wrote:

> Devs,
>
> While reviewing email services, I noticed that we are still having
> references of plugins component (ecommerce) in core components.
>
> Here is the quick references : (order/data/DemoProduct.xml)
> <ProductStoreEmailSetting productStoreId="9000"
> emailType="PRDS_ODR_CONFIRM"
> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#
> OrderConfirmNotice"
> xslfoAttachScreenLocation="component://ecommerce/widget/
> EmailOrderScreens.xml#OrderConfirmNoticePdf"
> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
> [hidden email]" fromAddress="[hidden email]"/>
>
> There are some more occurrences (in controller, screens, menus), I'll log a
> Jira ticket and share all the details there to resolve all such
> dependencies.
> I'm pretty sure that it's not intentional as the community did big effort
> to resolve dependencies while creating plugins but still Its good to get
> confirmation from the community.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>

[Michael Brohl-3]

Hi Ratnesh,

thanks for bringing this up again.

I'm pretty sure that we have discussed this before and there may already
exist a Jira for it.

I think it should be relatively easy to move the email screens from
ecommerce to the order component.

Thanks and regards,

Michael


Am 09.09.17 um 17:10 schrieb Ratnesh Upadhyay:

> Devs,
>
> While reviewing email services, I noticed that we are still having
> references of plugins component (ecommerce) in core components.
>
> Here is the quick references : (order/data/DemoProduct.xml)
> <ProductStoreEmailSetting productStoreId="9000"
> emailType="PRDS_ODR_CONFIRM"
> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice"
> xslfoAttachScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf"
> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
> [hidden email]" fromAddress="[hidden email]"/>
>
> There are some more occurrences (in controller, screens, menus), I'll log a
> Jira ticket and share all the details there to resolve all such
> dependencies.
> I'm pretty sure that it's not intentional as the community did big effort
> to resolve dependencies while creating plugins but still Its good to get
> confirmation from the community.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>

[taher]

Not sure but maybe below would help. If you follow the links you will find
our discussion regarding default email templates.

https://issues.apache.org/jira/browse/OFBIZ-9322

On Sep 9, 2017 10:08 PM, "Michael Brohl" <[hidden email]> wrote:

Hi Ratnesh,

thanks for bringing this up again.

I'm pretty sure that we have discussed this before and there may already
exist a Jira for it.

I think it should be relatively easy to move the email screens from
ecommerce to the order component.

Thanks and regards,

Michael


Am 09.09.17 um 17:10 schrieb Ratnesh Upadhyay:

Devs,

>
> While reviewing email services, I noticed that we are still having
> references of plugins component (ecommerce) in core components.
>
> Here is the quick references : (order/data/DemoProduct.xml)
> <ProductStoreEmailSetting productStoreId="9000"
> emailType="PRDS_ODR_CONFIRM"
> bodyScreenLocation="component://ecommerce/widget/EmailOrderS
> creens.xml#OrderConfirmNotice"
> xslfoAttachScreenLocation="component://ecommerce/widget/Emai
> lOrderScreens.xml#OrderConfirmNoticePdf"
> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
> [hidden email]" fromAddress="[hidden email]"/>
>
> There are some more occurrences (in controller, screens, menus), I'll log a
> Jira ticket and share all the details there to resolve all such
> dependencies.
> I'm pretty sure that it's not intentional as the community did big effort
> to resolve dependencies while creating plugins but still Its good to get
> confirmation from the community.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>
>

[Michael Brohl-3]

These are related:

https://issues.apache.org/jira/browse/OFBIZ-7460

https://issues.apache.org/jira/browse/OFBIZ-9419

There must be more, I think, but cannot find it with a brief search.


Am 09.09.17 um 21:08 schrieb Michael Brohl:

> Hi Ratnesh,
>
> thanks for bringing this up again.
>
> I'm pretty sure that we have discussed this before and there may
> already exist a Jira for it.
>
> I think it should be relatively easy to move the email screens from
> ecommerce to the order component.
>
> Thanks and regards,
>
> Michael
>
>
> Am 09.09.17 um 17:10 schrieb Ratnesh Upadhyay:
>> Devs,
>>
>> While reviewing email services, I noticed that we are still having
>> references of plugins component (ecommerce) in core components.
>>
>> Here is the quick references : (order/data/DemoProduct.xml)
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_ODR_CONFIRM"
>> bodyScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNotice"
>>
>> xslfoAttachScreenLocation="component://ecommerce/widget/EmailOrderScreens.xml#OrderConfirmNoticePdf"
>>
>> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
>> [hidden email]" fromAddress="[hidden email]"/>
>>
>> There are some more occurrences (in controller, screens, menus), I'll
>> log a
>> Jira ticket and share all the details there to resolve all such
>> dependencies.
>> I'm pretty sure that it's not intentional as the community did big
>> effort
>> to resolve dependencies while creating plugins but still Its good to get
>> confirmation from the community.
>>
>> Thanks!!
>>
>> Regards,
>> Ratnesh Upadhyay
>> HotWax Systems | www.hotwaxsystems.com
>>
>
>

[Michael Brohl-3]

Yeah right, that was the missing Jira.

Thanks Taher!

Am 09.09.17 um 21:12 schrieb Taher Alkhateeb:

> Not sure but maybe below would help. If you follow the links you will find
> our discussion regarding default email templates.
>
> https://issues.apache.org/jira/browse/OFBIZ-9322
>
> On Sep 9, 2017 10:08 PM, "Michael Brohl" <[hidden email]> wrote:
>
> Hi Ratnesh,
>
> thanks for bringing this up again.
>
> I'm pretty sure that we have discussed this before and there may already
> exist a Jira for it.
>
> I think it should be relatively easy to move the email screens from
> ecommerce to the order component.
>
> Thanks and regards,
>
> Michael
>
>
> Am 09.09.17 um 17:10 schrieb Ratnesh Upadhyay:
>
> Devs,
>> While reviewing email services, I noticed that we are still having
>> references of plugins component (ecommerce) in core components.
>>
>> Here is the quick references : (order/data/DemoProduct.xml)
>> <ProductStoreEmailSetting productStoreId="9000"
>> emailType="PRDS_ODR_CONFIRM"
>> bodyScreenLocation="component://ecommerce/widget/EmailOrderS
>> creens.xml#OrderConfirmNotice"
>> xslfoAttachScreenLocation="component://ecommerce/widget/Emai
>> lOrderScreens.xml#OrderConfirmNoticePdf"
>> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
>> [hidden email]" fromAddress="[hidden email]"/>
>>
>> There are some more occurrences (in controller, screens, menus), I'll log a
>> Jira ticket and share all the details there to resolve all such
>> dependencies.
>> I'm pretty sure that it's not intentional as the community did big effort
>> to resolve dependencies while creating plugins but still Its good to get
>> confirmation from the community.
>>
>> Thanks!!
>>
>> Regards,
>> Ratnesh Upadhyay
>> HotWax Systems | www.hotwaxsystems.com
>>
>>

[Ratnesh Upadhyay-2]

Thanks, Rishi, Michael and Taher for the inputs.
I'll review the shared Jira tickets and update them as needed.

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Sun, Sep 10, 2017 at 12:45 AM, Michael Brohl <[hidden email]>
wrote:

> Yeah right, that was the missing Jira.
>
> Thanks Taher!
>
> Am 09.09.17 um 21:12 schrieb Taher Alkhateeb:
>
> Not sure but maybe below would help. If you follow the links you will find
>> our discussion regarding default email templates.
>>
>> https://issues.apache.org/jira/browse/OFBIZ-9322
>>
>> On Sep 9, 2017 10:08 PM, "Michael Brohl" <[hidden email]>
>> wrote:
>>
>> Hi Ratnesh,
>>
>> thanks for bringing this up again.
>>
>> I'm pretty sure that we have discussed this before and there may already
>> exist a Jira for it.
>>
>> I think it should be relatively easy to move the email screens from
>> ecommerce to the order component.
>>
>> Thanks and regards,
>>
>> Michael
>>
>>
>> Am 09.09.17 um 17:10 schrieb Ratnesh Upadhyay:
>>
>> Devs,
>>
>>> While reviewing email services, I noticed that we are still having
>>> references of plugins component (ecommerce) in core components.
>>>
>>> Here is the quick references : (order/data/DemoProduct.xml)
>>> <ProductStoreEmailSetting productStoreId="9000"
>>> emailType="PRDS_ODR_CONFIRM"
>>> bodyScreenLocation="component://ecommerce/widget/EmailOrderS
>>> creens.xml#OrderConfirmNotice"
>>> xslfoAttachScreenLocation="component://ecommerce/widget/Emai
>>> lOrderScreens.xml#OrderConfirmNoticePdf"
>>> subject="OFBiz Demo - Order Confirmation #${orderId}" bccAddress="
>>> [hidden email]" fromAddress="[hidden email]"/>
>>>
>>> There are some more occurrences (in controller, screens, menus), I'll
>>> log a
>>> Jira ticket and share all the details there to resolve all such
>>> dependencies.
>>> I'm pretty sure that it's not intentional as the community did big effort
>>> to resolve dependencies while creating plugins but still Its good to get
>>> confirmation from the community.
>>>
>>> Thanks!!
>>>
>>> Regards,
>>> Ratnesh Upadhyay
>>> HotWax Systems | www.hotwaxsystems.com
>>>
>>>
>>>
>