[OFBiz] Dev - some JIRA issues I looked through today

[Si Chen-2]

Hi everyone.  I looked through some JIRA issues today and assigned them
to myself to track.  This is my impression:

OFBIZ-369 - not needed.  Duplicated by work on the marketing package
components.
OFBIZ-371 - should be applied.  Fixes a bug.
OFBIZ-376 - not needed.  Recreates a feature which we removed a while
ago.  (See also David's comments.)
OFBIZ-382 - interesting.  Maybe a good idea, but the implementation is a
bit "nonstandard."  If done as a service might be good a idea?
OFBIZ-393 - I will test it out to make sure it does not break any
functionality.

Unless there is other feedback, I will close OFBIZ-369 and OFBIZ-376.  
Of course, that doesn't mean that someone couldn't use them as part of
their deployment, merely that it doesn't fit with the way the core
features are implemented.

If OFBIZ-393 works I will commit it.

If there is a re-factored version of OFBIZ-376 I will test it out and
commit it as well.

Please someone else commit OFBIZ-371 and fix the bug.

Thanks,

Si
 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Jacopo Cappellato]

Hi Si,

ok, I've committed OFBIZ-371.

Jacopo

Si Chen wrote:

> Hi everyone.  I looked through some JIRA issues today and assigned them
> to myself to track.  This is my impression:
>
> OFBIZ-369 - not needed.  Duplicated by work on the marketing package
> components.
> OFBIZ-371 - should be applied.  Fixes a bug.
> OFBIZ-376 - not needed.  Recreates a feature which we removed a while
> ago.  (See also David's comments.)
> OFBIZ-382 - interesting.  Maybe a good idea, but the implementation is a
> bit "nonstandard."  If done as a service might be good a idea?
> OFBIZ-393 - I will test it out to make sure it does not break any
> functionality.
>
> Unless there is other feedback, I will close OFBIZ-369 and OFBIZ-376.  
> Of course, that doesn't mean that someone couldn't use them as part of
> their deployment, merely that it doesn't fit with the way the core
> features are implemented.
>
> If OFBIZ-393 works I will commit it.
>
> If there is a re-factored version of OFBIZ-376 I will test it out and
> commit it as well.
>
> Please someone else commit OFBIZ-371 and fix the bug.
>
> Thanks,
>
> Si
>
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
>
>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[olivier.heintz Neogia.org]

Si Chen a écrit :

> Hi everyone.  I looked through some JIRA issues today and assigned
> them to myself to track.  This is my impression:
>
> OFBIZ-376 - not needed.  Recreates a feature which we removed a while
> ago.  (See also David's comments.)

...

> If OFBIZ-393 works I will commit it.
>
> If there is a re-factored version of OFBIZ-376 I will test it out and
> commit it as well.

which sort of re-factore do you think about?

Olivier
 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[Si Chen-2]

Olivier,

Sorry, I mis-typed.  It is OFBIZ-382 that I meant, and I'll drop a
comment on it.

Personally, I *really* appreciate your contributions.  Unfortunately it
seems a couple of the features don't fit with the way the applications
are designed right now.  But in the future, before implementing a
feature, maybe let's discuss it on the dev list?  I still think the
biggest risk in writing software is not Java vs. NET, but mis-specified
requirements.  Maybe discussions about features will help all of us.

Have a great weekend,

Si

olivier.heintz Neogia.org wrote:

> Si Chen a écrit :
>
>> Hi everyone.  I looked through some JIRA issues today and assigned
>> them to myself to track.  This is my impression:
>>
>> OFBIZ-376 - not needed.  Recreates a feature which we removed a while
>> ago.  (See also David's comments.)
>
>
> ...
>
>> If OFBIZ-393 works I will commit it.
>>
>> If there is a re-factored version of OFBIZ-376 I will test it out and
>> commit it as well.
>
>
> which sort of re-factore do you think about?
>
> Olivier
>
> _______________________________________________
> Dev mailing list
> [hidden email]
> http://lists.ofbiz.org/mailman/listinfo/dev
>

 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev

[olivier.heintz Neogia.org]

Si Chen a écrit :

> Olivier,
>
> Sorry, I mis-typed.  It is OFBIZ-382 that I meant, and I'll drop a
> comment on it.
>
> Personally, I *really* appreciate your contributions.  Unfortunately
> it seems a couple of the features don't fit with the way the
> applications are designed right now.  But in the future, before
> implementing a feature, maybe let's discuss it on the dev list?  I
> still think the biggest risk in writing software is not Java vs. NET,
> but mis-specified requirements.  Maybe discussions about features will
> help all of us.
>
> Have a great weekend,
>
> Si
>

Si,

I completly agree with you, (it's why, most of the time, we work with
UML modelisation, before realization  ;-)
 
but in this case it was a customer requirement which can be resolved by
the sale tax calculation if we have it for purchase !!!

So, no problem it will be a specific for our customer.

Olivier

 
 
_______________________________________________
Dev mailing list
[hidden email]
http://lists.ofbiz.org/mailman/listinfo/dev