OFBiz and Camel integration updated
Locked
OFBiz and Camel integration updated
 
|
hi all,
a quick heads up. I've been getting requests to fix the ofbiz-camel integration demo and finally did it. It works with the latest version of OFBiz and Camel Also added a nice diagram demonstrating how the integration works. https://github.com/bibryam/ofbiz-camel Cheers, -- Bilgin Ibryam ASF Member | Architect at Red Hat http://ofbizian.com | @bibryam Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) Camel Design Patterns https://leanpub.com/camel-design-patterns |
Re: OFBiz and Camel integration updated
Administrator
|
Looks quite good, thanks Bilgin !
"Licensed under The MIT License." why not ASL2 :) ? Jacques Le 21/03/2018 à 11:06, Bilgin Ibryam a écrit : > hi all, > > a quick heads up. I've been getting requests to fix the ofbiz-camel > integration demo and finally did it. > It works with the latest version of OFBiz and Camel > Also added a nice diagram demonstrating how the integration works. > > https://github.com/bibryam/ofbiz-camel > > Cheers, > |
Re: OFBiz and Camel integration updated
|
|
In reply to this post by Bilgin Ibryam-2
Wow, thanks so much Bilgin for your contribution! :-)
- Best Regards, Swapnil M Mane On Wed, Mar 21, 2018 at 3:36 PM, Bilgin Ibryam <[hidden email]> wrote: > hi all, > > a quick heads up. I've been getting requests to fix the ofbiz-camel > integration demo and finally did it. > It works with the latest version of OFBiz and Camel > Also added a nice diagram demonstrating how the integration works. > > https://github.com/bibryam/ofbiz-camel > > Cheers, > > -- > Bilgin Ibryam > ASF Member | Architect at Red Hat > http://ofbizian.com | @bibryam > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > Camel Design Patterns https://leanpub.com/camel-design-patterns > |
Re: OFBiz and Camel integration updated
|
|
In reply to this post by Jacques Le Roux
On Wed, Mar 21, 2018 at 10:39 AM, Jacques Le Roux
<[hidden email]> wrote: > Looks quite good, thanks Bilgin ! > > "Licensed under The MIT License." why not ASL2 :) ? no specific reasons, but more copy paste from other projects of mine. btw what is the difference and does it matter really? I'm curious? B. > > Jacques > > > > Le 21/03/2018 à 11:06, Bilgin Ibryam a écrit : >> >> hi all, >> >> a quick heads up. I've been getting requests to fix the ofbiz-camel >> integration demo and finally did it. >> It works with the latest version of OFBiz and Camel >> Also added a nice diagram demonstrating how the integration works. >> >> https://github.com/bibryam/ofbiz-camel >> >> Cheers, >> > -- Bilgin Ibryam ASF Member | Architect at Red Hat http://ofbizian.com | @bibryam Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) Camel Design Patterns https://leanpub.com/camel-design-patterns |
Re: OFBiz and Camel integration updated
|
Administrator
|
Le 21/03/2018 à 14:53, Bilgin Ibryam a écrit :
> On Wed, Mar 21, 2018 at 10:39 AM, Jacques Le Roux > <[hidden email]> wrote: >> Looks quite good, thanks Bilgin ! >> >> "Licensed under The MIT License." why not ASL2 :) ? > no specific reasons, but more copy paste from other projects of mine. > btw what is the difference and does it matter really? I'm curious? > B. MIT is more permissive, it fits if you don't care to protect your work at all and is easier for "users" (developers who use the code) to work with But actually there are not much differences: https://www.quora.com/Whats-the-difference-between-Apache-v2-0-and-MIT-license-What-are-the-major-consequences-of-using-Apache-software-over-MIT I asked because you are an ASF member, so thought that you would prefer ASL2. But of course that's up to you, and depends on cases. Seems to fit here. Jacques > >> Jacques >> >> >> >> Le 21/03/2018 à 11:06, Bilgin Ibryam a écrit : >>> hi all, >>> >>> a quick heads up. I've been getting requests to fix the ofbiz-camel >>> integration demo and finally did it. >>> It works with the latest version of OFBiz and Camel >>> Also added a nice diagram demonstrating how the integration works. >>> >>> https://github.com/bibryam/ofbiz-camel >>> >>> Cheers, >>> > > |
|
In reply to this post by Bilgin Ibryam-2
Super awesome Bilgin,
Maybe we should consider moving this work to plugins given how useful this feature could be? The license is compatible and the work joins two great apache projects. On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: > hi all, > > a quick heads up. I've been getting requests to fix the ofbiz-camel > integration demo and finally did it. > It works with the latest version of OFBiz and Camel > Also added a nice diagram demonstrating how the integration works. > > https://github.com/bibryam/ofbiz-camel > > Cheers, > > -- > Bilgin Ibryam > ASF Member | Architect at Red Hat > http://ofbizian.com | @bibryam > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > Camel Design Patterns https://leanpub.com/camel-design-patterns > |
Re: OFBiz and Camel integration updated
|
|
+1
Regards, Michael > Am 21.03.2018 um 17:16 schrieb Taher Alkhateeb <[hidden email]>: > > Super awesome Bilgin, > > Maybe we should consider moving this work to plugins given how useful this > feature could be? The license is compatible and the work joins two great > apache projects. > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: >> >> hi all, >> >> a quick heads up. I've been getting requests to fix the ofbiz-camel >> integration demo and finally did it. >> It works with the latest version of OFBiz and Camel >> Also added a nice diagram demonstrating how the integration works. >> >> https://github.com/bibryam/ofbiz-camel >> >> Cheers, >> >> -- >> Bilgin Ibryam >> ASF Member | Architect at Red Hat >> http://ofbizian.com | @bibryam >> >> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >> Camel Design Patterns https://leanpub.com/camel-design-patterns >> |
|
Banned User
|
This post was updated on .
In reply to this post by Bilgin Ibryam-2
CONTENTS DELETED
The author has deleted this message.
|
Re: OFBiz and Camel integration updated
|
|
if you mean in Camel, here it is:
http://camel.apache.org/components.html the list is growing with an average of 5-10 new endpoints every release (quarterly). Cheers, On Wed, Mar 21, 2018 at 11:09 PM, <[hidden email]> wrote: > > Is there a list of the end points? > -------- Original Message -------- > Subject: OFBiz and Camel integration updated > From: Bilgin Ibryam <[hidden email]> > Date: Wed, March 21, 2018 3:06 am > To: [hidden email] > > hi all, > > a quick heads up. I've been getting requests to fix the ofbiz-camel > integration demo and finally did it. > It works with the latest version of OFBiz and Camel > Also added a nice diagram demonstrating how the integration works. > > https://github.com/bibryam/ofbiz-camel > > Cheers, > > -- > Bilgin Ibryam > ASF Member | Architect at Red Hat > http://ofbizian.com | @bibryam > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > Camel Design Patterns https://leanpub.com/camel-design-patterns -- Bilgin Ibryam ASF Member | Architect at Red Hat http://ofbizian.com | @bibryam Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) Camel Design Patterns https://leanpub.com/camel-design-patterns |
Re: OFBiz and Camel integration updated
|
|
In reply to this post by taher
On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb
<[hidden email]> wrote: > Super awesome Bilgin, > > Maybe we should consider moving this work to plugins given how useful this > feature could be? The license is compatible and the work joins two great > apache projects. Since there is considerable interest in this, it might be worth the effort. What is the processes for adding things into plugins? > > On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: > >> hi all, >> >> a quick heads up. I've been getting requests to fix the ofbiz-camel >> integration demo and finally did it. >> It works with the latest version of OFBiz and Camel >> Also added a nice diagram demonstrating how the integration works. >> >> https://github.com/bibryam/ofbiz-camel >> >> Cheers, >> >> -- >> Bilgin Ibryam >> ASF Member | Architect at Red Hat >> http://ofbizian.com | @bibryam >> >> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >> Camel Design Patterns https://leanpub.com/camel-design-patterns >> -- Bilgin Ibryam ASF Member | Architect at Red Hat http://ofbizian.com | @bibryam Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) Camel Design Patterns https://leanpub.com/camel-design-patterns |
|
|
1- create a JIRA
2- provide a patch or reference to your github repo and get some feedback 3- commit in $OFBIZ_HOME/plugins/ Given that you're the expert in this domain, I doubt you'll get any feedback on the design. However there are a few things which might need changing, for example: - Putting apache 2 license header in files - deleting the data directory given it is empty - moving the documentation to src/docs/asciidoc - removing some commented-out code I'd help you out if you'd need my help in anything BTW. On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> wrote: > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb > <[hidden email]> wrote: >> Super awesome Bilgin, >> >> Maybe we should consider moving this work to plugins given how useful this >> feature could be? The license is compatible and the work joins two great >> apache projects. > > Since there is considerable interest in this, it might be worth the > effort. What is the processes for adding things into plugins? > > >> >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: >> >>> hi all, >>> >>> a quick heads up. I've been getting requests to fix the ofbiz-camel >>> integration demo and finally did it. >>> It works with the latest version of OFBiz and Camel >>> Also added a nice diagram demonstrating how the integration works. >>> >>> https://github.com/bibryam/ofbiz-camel >>> >>> Cheers, >>> >>> -- >>> Bilgin Ibryam >>> ASF Member | Architect at Red Hat >>> http://ofbizian.com | @bibryam >>> >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >>> Camel Design Patterns https://leanpub.com/camel-design-patterns >>> > > > > -- > Bilgin Ibryam > ASF Member | Architect at Red Hat > http://ofbizian.com | @bibryam > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > Camel Design Patterns https://leanpub.com/camel-design-patterns |
Re: OFBiz and Camel integration updated
|
|
Fantastic Work Bilgin
> On 22-Mar-2018, at 4:00 PM, Taher Alkhateeb <[hidden email]> wrote: > > 1- create a JIRA > 2- provide a patch or reference to your github repo and get some feedback > 3- commit in $OFBIZ_HOME/plugins/ > > Given that you're the expert in this domain, I doubt you'll get any > feedback on the design. However there are a few things which might > need changing, for example: > - Putting apache 2 license header in files > - deleting the data directory given it is empty > - moving the documentation to src/docs/asciidoc > - removing some commented-out code > > I'd help you out if you'd need my help in anything BTW. > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> wrote: >> On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb >> <[hidden email]> wrote: >>> Super awesome Bilgin, >>> >>> Maybe we should consider moving this work to plugins given how useful this >>> feature could be? The license is compatible and the work joins two great >>> apache projects. >> >> Since there is considerable interest in this, it might be worth the >> effort. What is the processes for adding things into plugins? >> >> >>> >>> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: >>> >>>> hi all, >>>> >>>> a quick heads up. I've been getting requests to fix the ofbiz-camel >>>> integration demo and finally did it. >>>> It works with the latest version of OFBiz and Camel >>>> Also added a nice diagram demonstrating how the integration works. >>>> >>>> https://github.com/bibryam/ofbiz-camel >>>> >>>> Cheers, >>>> >>>> -- >>>> Bilgin Ibryam >>>> ASF Member | Architect at Red Hat >>>> http://ofbizian.com | @bibryam >>>> >>>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >>>> Camel Design Patterns https://leanpub.com/camel-design-patterns >>>> >> >> >> >> -- >> Bilgin Ibryam >> ASF Member | Architect at Red Hat >> http://ofbizian.com | @bibryam >> >> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >> Camel Design Patterns https://leanpub.com/camel-design-patterns |
Re: OFBiz and Camel integration updated
|
|
In reply to this post by taher
Dear Bilgin/Taher,
I tried to look into the plugins and Jira could not found anything related. Although some discussion is there but I see plugin is not added into OFBiz till now. Can you please share any reference if I missed something? I see the code in the Bilgin's repo and seems we can take it as ground and test then commit it. If Bilgin allows then extend ofbiz-camel component to next level if possible. And it too late to reply on this thread but I also feel that the plugin should be part of OFBiz repo. Please suggest if all agree then I can go ahead to create Jira, test, enhance and proceed. Best Regards, -- Rishi Solanki Sr Manager, Enterprise Software Development *HotWax Systems* *Enterprise open source experts* cell: +91-98932-87847 http://www.hotwaxsystems.com On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb <[hidden email]> wrote: > 1- create a JIRA > 2- provide a patch or reference to your github repo and get some feedback > 3- commit in $OFBIZ_HOME/plugins/ > > Given that you're the expert in this domain, I doubt you'll get any > feedback on the design. However there are a few things which might > need changing, for example: > - Putting apache 2 license header in files > - deleting the data directory given it is empty > - moving the documentation to src/docs/asciidoc > - removing some commented-out code > > I'd help you out if you'd need my help in anything BTW. > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> wrote: > > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb > > <[hidden email]> wrote: > >> Super awesome Bilgin, > >> > >> Maybe we should consider moving this work to plugins given how useful > this > >> feature could be? The license is compatible and the work joins two great > >> apache projects. > > > > Since there is considerable interest in this, it might be worth the > > effort. What is the processes for adding things into plugins? > > > > > >> > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: > >> > >>> hi all, > >>> > >>> a quick heads up. I've been getting requests to fix the ofbiz-camel > >>> integration demo and finally did it. > >>> It works with the latest version of OFBiz and Camel > >>> Also added a nice diagram demonstrating how the integration works. > >>> > >>> https://github.com/bibryam/ofbiz-camel > >>> > >>> Cheers, > >>> > >>> -- > >>> Bilgin Ibryam > >>> ASF Member | Architect at Red Hat > >>> http://ofbizian.com | @bibryam > >>> > >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > >>> Camel Design Patterns https://leanpub.com/camel-design-patterns > >>> > > > > > > > > -- > > Bilgin Ibryam > > ASF Member | Architect at Red Hat > > http://ofbizian.com | @bibryam > > > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > Camel Design Patterns https://leanpub.com/camel-design-patterns > |
|
|
Hopefully the code still works. If yes, I think it would be a good
plugin to add. Either way, I think this discussion should perhaps move to the development mailing list. On Mon, Jun 17, 2019 at 1:04 PM Rishi Solanki <[hidden email]> wrote: > > Dear Bilgin/Taher, > I tried to look into the plugins and Jira could not found anything related. > Although some discussion is there but I see plugin is not added into OFBiz > till now. Can you please share any reference if I missed something? > > I see the code in the Bilgin's repo and seems we can take it as ground and > test then commit it. If Bilgin allows then extend ofbiz-camel component to > next level if possible. And it too late to reply on this thread but I also > feel that the plugin should be part of OFBiz repo. > > Please suggest if all agree then I can go ahead to create Jira, test, > enhance and proceed. > > Best Regards, > -- > Rishi Solanki > Sr Manager, Enterprise Software Development > *HotWax Systems* > *Enterprise open source experts* > cell: +91-98932-87847 > http://www.hotwaxsystems.com > > On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb <[hidden email]> > wrote: > > > 1- create a JIRA > > 2- provide a patch or reference to your github repo and get some feedback > > 3- commit in $OFBIZ_HOME/plugins/ > > > > Given that you're the expert in this domain, I doubt you'll get any > > feedback on the design. However there are a few things which might > > need changing, for example: > > - Putting apache 2 license header in files > > - deleting the data directory given it is empty > > - moving the documentation to src/docs/asciidoc > > - removing some commented-out code > > > > I'd help you out if you'd need my help in anything BTW. > > > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> wrote: > > > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb > > > <[hidden email]> wrote: > > >> Super awesome Bilgin, > > >> > > >> Maybe we should consider moving this work to plugins given how useful > > this > > >> feature could be? The license is compatible and the work joins two great > > >> apache projects. > > > > > > Since there is considerable interest in this, it might be worth the > > > effort. What is the processes for adding things into plugins? > > > > > > > > >> > > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> wrote: > > >> > > >>> hi all, > > >>> > > >>> a quick heads up. I've been getting requests to fix the ofbiz-camel > > >>> integration demo and finally did it. > > >>> It works with the latest version of OFBiz and Camel > > >>> Also added a nice diagram demonstrating how the integration works. > > >>> > > >>> https://github.com/bibryam/ofbiz-camel > > >>> > > >>> Cheers, > > >>> > > >>> -- > > >>> Bilgin Ibryam > > >>> ASF Member | Architect at Red Hat > > >>> http://ofbizian.com | @bibryam > > >>> > > >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > >>> Camel Design Patterns https://leanpub.com/camel-design-patterns > > >>> > > > > > > > > > > > > -- > > > Bilgin Ibryam > > > ASF Member | Architect at Red Hat > > > http://ofbizian.com | @bibryam > > > > > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > > Camel Design Patterns https://leanpub.com/camel-design-patterns > > |
Re: OFBiz and Camel integration updated
|
|
Dear Taher,
Thanks for your reply, I will soon start discussion on dev list. I just go thru the code developed and basics of Apache Camel, seems it would be very helpful to interact OFBiz with outer world. Work is really appreciated, thanks to Bilgin for doing that. Best Regards, -- *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems <http://www.hotwaxsystems.com/> Linkedin: *Rishi Solanki* <https://www.linkedin.com/in/rishi-solanki-62271b7/> Direct: +91-9893287847 On Mon, Jun 17, 2019 at 6:09 PM Taher Alkhateeb <[hidden email]> wrote: > Hopefully the code still works. If yes, I think it would be a good > plugin to add. > > Either way, I think this discussion should perhaps move to the > development mailing list. > > On Mon, Jun 17, 2019 at 1:04 PM Rishi Solanki <[hidden email]> > wrote: > > > > Dear Bilgin/Taher, > > I tried to look into the plugins and Jira could not found anything > related. > > Although some discussion is there but I see plugin is not added into > OFBiz > > till now. Can you please share any reference if I missed something? > > > > I see the code in the Bilgin's repo and seems we can take it as ground > and > > test then commit it. If Bilgin allows then extend ofbiz-camel component > to > > next level if possible. And it too late to reply on this thread but I > also > > feel that the plugin should be part of OFBiz repo. > > > > Please suggest if all agree then I can go ahead to create Jira, test, > > enhance and proceed. > > > > Best Regards, > > -- > > Rishi Solanki > > Sr Manager, Enterprise Software Development > > *HotWax Systems* > > *Enterprise open source experts* > > cell: +91-98932-87847 > > http://www.hotwaxsystems.com > > > > On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb < > [hidden email]> > > wrote: > > > > > 1- create a JIRA > > > 2- provide a patch or reference to your github repo and get some > feedback > > > 3- commit in $OFBIZ_HOME/plugins/ > > > > > > Given that you're the expert in this domain, I doubt you'll get any > > > feedback on the design. However there are a few things which might > > > need changing, for example: > > > - Putting apache 2 license header in files > > > - deleting the data directory given it is empty > > > - moving the documentation to src/docs/asciidoc > > > - removing some commented-out code > > > > > > I'd help you out if you'd need my help in anything BTW. > > > > > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> > wrote: > > > > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb > > > > <[hidden email]> wrote: > > > >> Super awesome Bilgin, > > > >> > > > >> Maybe we should consider moving this work to plugins given how > useful > > > this > > > >> feature could be? The license is compatible and the work joins two > great > > > >> apache projects. > > > > > > > > Since there is considerable interest in this, it might be worth the > > > > effort. What is the processes for adding things into plugins? > > > > > > > > > > > >> > > > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> > wrote: > > > >> > > > >>> hi all, > > > >>> > > > >>> a quick heads up. I've been getting requests to fix the ofbiz-camel > > > >>> integration demo and finally did it. > > > >>> It works with the latest version of OFBiz and Camel > > > >>> Also added a nice diagram demonstrating how the integration works. > > > >>> > > > >>> https://github.com/bibryam/ofbiz-camel > > > >>> > > > >>> Cheers, > > > >>> > > > >>> -- > > > >>> Bilgin Ibryam > > > >>> ASF Member | Architect at Red Hat > > > >>> http://ofbizian.com | @bibryam > > > >>> > > > >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > > >>> Camel Design Patterns https://leanpub.com/camel-design-patterns > > > >>> > > > > > > > > > > > > > > > > -- > > > > Bilgin Ibryam > > > > ASF Member | Architect at Red Hat > > > > http://ofbizian.com | @bibryam > > > > > > > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > > > Camel Design Patterns https://leanpub.com/camel-design-patterns > > > > |
|
|
Hi Bilgin
I have created a pull request <https://github.com/bibryam/ofbiz-camel/pull/5> for *ofbiz-camel* component with the following additions and fixes. Please review and let me know what you think. Post review if you feel it is worth incorporating, we can add it as an ofbiz plugin. Here's the summary - 1. Auto discovery of RouteBuilders. Considering possibility of a developer wanting to create more than one route, I though of scanning available RouteBuilder instances in the classpath and then registering them with camel context. I think it should be no issue having one RouteBuilder configuring single route, instead of all the routes configured by a single RouteBuilder. 2. Developer can configure property to specify the package where all RouteBuilders are packaged and at container initialization, system would try to register all available RouteBuilders. 3. Additionally, I have also added a custom annotation (CamelRoute) that a class can be annotated with. I have not thought about it's implementation for now but this may be added in the future. Since, the same can be achieved by discovering RouteBuilders, this may not be needed. 4. As a future enhancement, I feel the need to introduce XML DSL to configure the routes. I am willing to share the design on this if you feel it would be worth a feature. Please let me know if you have any questions related to the pull request. Best, Girish On Wed, Jun 19, 2019 at 12:14 AM Rishi Solanki <[hidden email]> wrote: > Dear Taher, > Thanks for your reply, I will soon start discussion on dev list. I just go > thru the code developed and basics of Apache Camel, seems it would be very > helpful to interact OFBiz with outer world. Work is really appreciated, > thanks to Bilgin for doing that. > > Best Regards, > -- > *Rishi Solanki* | Sr Manager, Enterprise Software Development > HotWax Systems <http://www.hotwaxsystems.com/> > Linkedin: *Rishi Solanki* > <https://www.linkedin.com/in/rishi-solanki-62271b7/> > Direct: +91-9893287847 > > > On Mon, Jun 17, 2019 at 6:09 PM Taher Alkhateeb < > [hidden email]> > wrote: > > > Hopefully the code still works. If yes, I think it would be a good > > plugin to add. > > > > Either way, I think this discussion should perhaps move to the > > development mailing list. > > > > On Mon, Jun 17, 2019 at 1:04 PM Rishi Solanki <[hidden email]> > > wrote: > > > > > > Dear Bilgin/Taher, > > > I tried to look into the plugins and Jira could not found anything > > related. > > > Although some discussion is there but I see plugin is not added into > > OFBiz > > > till now. Can you please share any reference if I missed something? > > > > > > I see the code in the Bilgin's repo and seems we can take it as ground > > and > > > test then commit it. If Bilgin allows then extend ofbiz-camel component > > to > > > next level if possible. And it too late to reply on this thread but I > > also > > > feel that the plugin should be part of OFBiz repo. > > > > > > Please suggest if all agree then I can go ahead to create Jira, test, > > > enhance and proceed. > > > > > > Best Regards, > > > -- > > > Rishi Solanki > > > Sr Manager, Enterprise Software Development > > > *HotWax Systems* > > > *Enterprise open source experts* > > > cell: +91-98932-87847 > > > http://www.hotwaxsystems.com > > > > > > On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb < > > [hidden email]> > > > wrote: > > > > > > > 1- create a JIRA > > > > 2- provide a patch or reference to your github repo and get some > > feedback > > > > 3- commit in $OFBIZ_HOME/plugins/ > > > > > > > > Given that you're the expert in this domain, I doubt you'll get any > > > > feedback on the design. However there are a few things which might > > > > need changing, for example: > > > > - Putting apache 2 license header in files > > > > - deleting the data directory given it is empty > > > > - moving the documentation to src/docs/asciidoc > > > > - removing some commented-out code > > > > > > > > I'd help you out if you'd need my help in anything BTW. > > > > > > > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> > > wrote: > > > > > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb > > > > > <[hidden email]> wrote: > > > > >> Super awesome Bilgin, > > > > >> > > > > >> Maybe we should consider moving this work to plugins given how > > useful > > > > this > > > > >> feature could be? The license is compatible and the work joins two > > great > > > > >> apache projects. > > > > > > > > > > Since there is considerable interest in this, it might be worth the > > > > > effort. What is the processes for adding things into plugins? > > > > > > > > > > > > > > >> > > > > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> > > wrote: > > > > >> > > > > >>> hi all, > > > > >>> > > > > >>> a quick heads up. I've been getting requests to fix the > ofbiz-camel > > > > >>> integration demo and finally did it. > > > > >>> It works with the latest version of OFBiz and Camel > > > > >>> Also added a nice diagram demonstrating how the integration > works. > > > > >>> > > > > >>> https://github.com/bibryam/ofbiz-camel > > > > >>> > > > > >>> Cheers, > > > > >>> > > > > >>> -- > > > > >>> Bilgin Ibryam > > > > >>> ASF Member | Architect at Red Hat > > > > >>> http://ofbizian.com | @bibryam > > > > >>> > > > > >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > > > >>> Camel Design Patterns https://leanpub.com/camel-design-patterns > > > > >>> > > > > > > > > > > > > > > > > > > > > -- > > > > > Bilgin Ibryam > > > > > ASF Member | Architect at Red Hat > > > > > http://ofbizian.com | @bibryam > > > > > > > > > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) > > > > > Camel Design Patterns https://leanpub.com/camel-design-patterns > > > > > > > |
|
|
Thanks Bilgin for taking care of pull request. If everyone is okay with the
changes, I will go ahead and create a ticket for the same to add it as an ofbiz plugin. Let me know of any issues or concerns anyone may have. While writing a few test cases for the various camel components (and I am using CamelTestSupport), it turned out OFBiz test container does not pick them up because it is still based on inheritance (extending TestCase) and not on annotation (any class with @Test annotated methods). I will probably elaborate further in a separate thread, but I feel we need to add support for considering such classes as part of test suite as well. We are using JUnit 4 but it is hardly being used except for being available on the classpath. Using JUnit 4 classes will make sure both mechanisms will be supported. Best, Girish On Fri, Jul 19, 2019 at 10:12 AM Girish Vasmatkar < [hidden email]> wrote: > Hi Bilgin > > I have created a pull request > <https://github.com/bibryam/ofbiz-camel/pull/5> for *ofbiz-camel* component > with the following additions and fixes. Please review and let me know what > you think. Post review if you feel it is worth incorporating, we can add it > as an ofbiz plugin. > Here's the summary - > > 1. Auto discovery of RouteBuilders. Considering possibility of a developer > wanting to create more than one route, I though of scanning available > RouteBuilder instances in the classpath and then registering them with > camel context. I think it should be no issue having one RouteBuilder > configuring single route, instead of all the routes configured by a single > RouteBuilder. > 2. Developer can configure property to specify the package where all > RouteBuilders are packaged and at container initialization, system would > try to register all available RouteBuilders. > 3. Additionally, I have also added a custom annotation (CamelRoute) that a > class can be annotated with. I have not thought about it's implementation > for now but this may be added in the future. Since, the same can be > achieved by discovering RouteBuilders, this may not be needed. > 4. As a future enhancement, I feel the need to introduce XML DSL to > configure the routes. I am willing to share the design on this if you feel > it would be worth a feature. > > Please let me know if you have any questions related to the pull request. > > Best, > Girish > > > On Wed, Jun 19, 2019 at 12:14 AM Rishi Solanki <[hidden email]> > wrote: > >> Dear Taher, >> Thanks for your reply, I will soon start discussion on dev list. I just go >> thru the code developed and basics of Apache Camel, seems it would be very >> helpful to interact OFBiz with outer world. Work is really appreciated, >> thanks to Bilgin for doing that. >> >> Best Regards, >> -- >> *Rishi Solanki* | Sr Manager, Enterprise Software Development >> HotWax Systems <http://www.hotwaxsystems.com/> >> Linkedin: *Rishi Solanki* >> <https://www.linkedin.com/in/rishi-solanki-62271b7/> >> Direct: +91-9893287847 >> >> >> On Mon, Jun 17, 2019 at 6:09 PM Taher Alkhateeb < >> [hidden email]> >> wrote: >> >> > Hopefully the code still works. If yes, I think it would be a good >> > plugin to add. >> > >> > Either way, I think this discussion should perhaps move to the >> > development mailing list. >> > >> > On Mon, Jun 17, 2019 at 1:04 PM Rishi Solanki <[hidden email]> >> > wrote: >> > > >> > > Dear Bilgin/Taher, >> > > I tried to look into the plugins and Jira could not found anything >> > related. >> > > Although some discussion is there but I see plugin is not added into >> > OFBiz >> > > till now. Can you please share any reference if I missed something? >> > > >> > > I see the code in the Bilgin's repo and seems we can take it as ground >> > and >> > > test then commit it. If Bilgin allows then extend ofbiz-camel >> component >> > to >> > > next level if possible. And it too late to reply on this thread but I >> > also >> > > feel that the plugin should be part of OFBiz repo. >> > > >> > > Please suggest if all agree then I can go ahead to create Jira, test, >> > > enhance and proceed. >> > > >> > > Best Regards, >> > > -- >> > > Rishi Solanki >> > > Sr Manager, Enterprise Software Development >> > > *HotWax Systems* >> > > *Enterprise open source experts* >> > > cell: +91-98932-87847 >> > > http://www.hotwaxsystems.com >> > > >> > > On Thu, Mar 22, 2018 at 4:00 PM Taher Alkhateeb < >> > [hidden email]> >> > > wrote: >> > > >> > > > 1- create a JIRA >> > > > 2- provide a patch or reference to your github repo and get some >> > feedback >> > > > 3- commit in $OFBIZ_HOME/plugins/ >> > > > >> > > > Given that you're the expert in this domain, I doubt you'll get any >> > > > feedback on the design. However there are a few things which might >> > > > need changing, for example: >> > > > - Putting apache 2 license header in files >> > > > - deleting the data directory given it is empty >> > > > - moving the documentation to src/docs/asciidoc >> > > > - removing some commented-out code >> > > > >> > > > I'd help you out if you'd need my help in anything BTW. >> > > > >> > > > On Thu, Mar 22, 2018 at 12:59 PM, Bilgin Ibryam <[hidden email]> >> > wrote: >> > > > > On Wed, Mar 21, 2018 at 4:16 PM, Taher Alkhateeb >> > > > > <[hidden email]> wrote: >> > > > >> Super awesome Bilgin, >> > > > >> >> > > > >> Maybe we should consider moving this work to plugins given how >> > useful >> > > > this >> > > > >> feature could be? The license is compatible and the work joins >> two >> > great >> > > > >> apache projects. >> > > > > >> > > > > Since there is considerable interest in this, it might be worth >> the >> > > > > effort. What is the processes for adding things into plugins? >> > > > > >> > > > > >> > > > >> >> > > > >> On Wed, Mar 21, 2018, 1:06 PM Bilgin Ibryam <[hidden email]> >> > wrote: >> > > > >> >> > > > >>> hi all, >> > > > >>> >> > > > >>> a quick heads up. I've been getting requests to fix the >> ofbiz-camel >> > > > >>> integration demo and finally did it. >> > > > >>> It works with the latest version of OFBiz and Camel >> > > > >>> Also added a nice diagram demonstrating how the integration >> works. >> > > > >>> >> > > > >>> https://github.com/bibryam/ofbiz-camel >> > > > >>> >> > > > >>> Cheers, >> > > > >>> >> > > > >>> -- >> > > > >>> Bilgin Ibryam >> > > > >>> ASF Member | Architect at Red Hat >> > > > >>> http://ofbizian.com | @bibryam >> > > > >>> >> > > > >>> Kubernetes Patterns http://leanpub.com/k8spatterns (in >> progress) >> > > > >>> Camel Design Patterns https://leanpub.com/camel-design-patterns >> > > > >>> >> > > > > >> > > > > >> > > > > >> > > > > -- >> > > > > Bilgin Ibryam >> > > > > ASF Member | Architect at Red Hat >> > > > > http://ofbizian.com | @bibryam >> > > > > >> > > > > Kubernetes Patterns http://leanpub.com/k8spatterns (in progress) >> > > > > Camel Design Patterns https://leanpub.com/camel-design-patterns >> > > > >> > >> > |
Re: OFBiz and Camel integration updated
|
|
Hello,
Girish Vasmatkar <[hidden email]> writes: > Thanks Bilgin for taking care of pull request. If everyone is okay with the > changes, I will go ahead and create a ticket for the same to add it as an > ofbiz plugin. Let me know of any issues or concerns anyone may have. > > While writing a few test cases for the various camel components (and I am > using CamelTestSupport), it turned out OFBiz test container does not pick > them up because it is still based on inheritance (extending TestCase) and > not on annotation (any class with @Test annotated methods). I will probably > elaborate further in a separate thread, but I feel we need to add support > for considering such classes as part of test suite as well. We are using > JUnit 4 but it is hardly being used except for being available on the > classpath. Using JUnit 4 classes will make sure both mechanisms will be > supported. Supporting the JUnit4 runner API which make use of annotations would be nice if it helps improving the *sad* state of OFBiz integration tests in term of error reporting. For the record Junit4 annotations are already supported by OFBiz unit tests run by ‘./gradlew test’ which by the way should be preferred over integration tests in most cases because they run faster. As a side note, please avoid cross-posting to ‘devel’ and ‘user’ mailing lists. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 |
|
|
I've created OFBIZ-11147 <https://issues.apache.org/jira/browse/OFBIZ-11147> to
track camel integration. I will provide the plug in along with relevant details. Best, Girish On Sat, Aug 3, 2019 at 5:07 PM Mathieu Lirzin <[hidden email]> wrote: > Hello, > > Girish Vasmatkar <[hidden email]> writes: > > > Thanks Bilgin for taking care of pull request. If everyone is okay with > the > > changes, I will go ahead and create a ticket for the same to add it as an > > ofbiz plugin. Let me know of any issues or concerns anyone may have. > > > > While writing a few test cases for the various camel components (and I am > > using CamelTestSupport), it turned out OFBiz test container does not pick > > them up because it is still based on inheritance (extending TestCase) and > > not on annotation (any class with @Test annotated methods). I will > probably > > elaborate further in a separate thread, but I feel we need to add support > > for considering such classes as part of test suite as well. We are using > > JUnit 4 but it is hardly being used except for being available on the > > classpath. Using JUnit 4 classes will make sure both mechanisms will be > > supported. > > Supporting the JUnit4 runner API which make use of annotations would be > nice if it helps improving the *sad* state of OFBiz integration tests in > term of error reporting. > > For the record Junit4 annotations are already supported by OFBiz unit > tests run by ‘./gradlew test’ which by the way should be preferred over > integration tests in most cases because they run faster. > > As a side note, please avoid cross-posting to ‘devel’ and ‘user’ mailing > lists. > > Thanks. > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 > |
«
Return to OFBiz - User
|
1 view|%1 views
| Free forum by Nabble | Edit this page |