OFBiz › OFBiz - Dev

[PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Michael Brohl-3

[PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Hi everyone,

I think we should setup some kind of policy for the bugfixing in the
project.

While every committer is free to decide if he does a backport himself,
we should make sure that bugfixes go into the supported release branches
also.

I propose to define the following policies:

1. bugfixes should be backported by the committer who does the bugfix in
trunk if possible

2. if he does not, for an reason, backport the bugfix, he should either
open a new Jira for a task to backport or leave the original issue open
with a remark that a backport is needed.

(I tend to leave the issue open).

In no case should we close a Jira issue without doing 1. or 2.

What do you think?

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de

Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):

> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080188#comment-16080188 ]
>
> Jacques Le Roux commented on OFBIZ-9459:
> ----------------------------------------
>
> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473, OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a reason? Do you want me to do it? Thanks.
>
>> Wrong screen redirection after adding note on Lead profile screen
>> -----------------------------------------------------------------
>>
>> Key: OFBIZ-9459
>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>> Project: OFBiz
>> Issue Type: Bug
>> Components: marketing
>> Reporter: Jagpreet Kaur
>> Assignee: Arun Patidar
>> Fix For: Upcoming Release
>>
>> Attachments: Create Note.png, OFBIZ-9459.patch, Screenredirection.png
>>
>>
>> 1) Go to SFA component.
>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/FindLeads].
>> 3) Choose any partyId from All Lead list, you will be navigated to Lead profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId=LEAD&partyId=DemoLead]
>> 4) Click on "Create New" button in the Notes section.
>> 5) Add the Note content.
>> 6) Click on "Save Button".
>> View redirection should be profile but it shows the blank screen.
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)

smime.p7s (5K) Download Attachment

Deepak Dixit-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

+1 , I think instead of opening new issue, we can leave it open with
comment

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
wrote:

> Hi everyone,
>
> I think we should setup some kind of policy for the bugfixing in the
> project.
>
> While every committer is free to decide if he does a backport himself, we
> should make sure that bugfixes go into the supported release branches also.
>
> I propose to define the following policies:
>
> 1. bugfixes should be backported by the committer who does the bugfix in
> trunk if possible
>
> 2. if he does not, for an reason, backport the bugfix, he should either
> open a new Jira for a task to backport or leave the original issue open
> with a remark that a backport is needed.
>
> (I tend to leave the issue open).
>
> In no case should we close a Jira issue without doing 1. or 2.
>
> What do you think?
>
> Regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>
>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>> l&focusedCommentId=16080188#comment-16080188 ]
>>
>> Jacques Le Roux commented on OFBIZ-9459:
>> ----------------------------------------
>>
>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>> reason? Do you want me to do it? Thanks.
>>
>> Wrong screen redirection after adding note on Lead profile screen
>>> -----------------------------------------------------------------
>>>
>>> Key: OFBIZ-9459
>>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>> Project: OFBiz
>>> Issue Type: Bug
>>> Components: marketing
>>> Reporter: Jagpreet Kaur
>>> Assignee: Arun Patidar
>>> Fix For: Upcoming Release
>>>
>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>> Screenredirection.png
>>>
>>>
>>> 1) Go to SFA component.
>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>> apache.org:8443/sfa/control/FindLeads].
>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>> =LEAD&partyId=DemoLead]
>>> 4) Click on "Create New" button in the Notes section.
>>> 5) Add the Note content.
>>> 6) Click on "Save Button".
>>> View redirection should be profile but it shows the blank screen.
>>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.4.14#64029)
>>
>
>
>

Jacques Le Roux

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Administrator

+1 for leaving open with a comment

Jacques

Le 10/07/2017 à 14:19, Deepak Dixit a écrit :

> +1 , I think instead of opening new issue, we can leave it open with
> comment
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
> wrote:
>
>> Hi everyone,
>>
>> I think we should setup some kind of policy for the bugfixing in the
>> project.
>>
>> While every committer is free to decide if he does a backport himself, we
>> should make sure that bugfixes go into the supported release branches also.
>>
>> I propose to define the following policies:
>>
>> 1. bugfixes should be backported by the committer who does the bugfix in
>> trunk if possible
>>
>> 2. if he does not, for an reason, backport the bugfix, he should either
>> open a new Jira for a task to backport or leave the original issue open
>> with a remark that a backport is needed.
>>
>> (I tend to leave the issue open).
>>
>> In no case should we close a Jira issue without doing 1. or 2.
>>
>> What do you think?
>>
>> Regards,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>>
>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>
>>> Jacques Le Roux commented on OFBIZ-9459:
>>> ----------------------------------------
>>>
>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>> reason? Do you want me to do it? Thanks.
>>>
>>> Wrong screen redirection after adding note on Lead profile screen
>>>> -----------------------------------------------------------------
>>>>
>>>> Key: OFBIZ-9459
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>>> Project: OFBiz
>>>> Issue Type: Bug
>>>> Components: marketing
>>>> Reporter: Jagpreet Kaur
>>>> Assignee: Arun Patidar
>>>> Fix For: Upcoming Release
>>>>
>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>> Screenredirection.png
>>>>
>>>>
>>>> 1) Go to SFA component.
>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>> apache.org:8443/sfa/control/FindLeads].
>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>> =LEAD&partyId=DemoLead]
>>>> 4) Click on "Create New" button in the Notes section.
>>>> 5) Add the Note content.
>>>> 6) Click on "Save Button".
>>>> View redirection should be profile but it shows the blank screen.
>>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.4.14#64029)
>>>
>>
>>

Michael Brohl-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Additional idea: we can also flag the issue with a label
"backport-needed" to easily find open issues which need a backport.

Am 10.07.17 um 14:55 schrieb Jacques Le Roux:

> +1 for leaving open with a comment
>
> Jacques
>
>
> Le 10/07/2017 à 14:19, Deepak Dixit a écrit :
>> +1 , I think instead of opening new issue, we can leave it open with
>> comment
>>
>>
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> www.hotwaxsystems.com
>> www.hotwax.co
>>
>> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl
>> <[hidden email]>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> I think we should setup some kind of policy for the bugfixing in the
>>> project.
>>>
>>> While every committer is free to decide if he does a backport
>>> himself, we
>>> should make sure that bugfixes go into the supported release
>>> branches also.
>>>
>>> I propose to define the following policies:
>>>
>>> 1. bugfixes should be backported by the committer who does the
>>> bugfix in
>>> trunk if possible
>>>
>>> 2. if he does not, for an reason, backport the bugfix, he should either
>>> open a new Jira for a task to backport or leave the original issue open
>>> with a remark that a backport is needed.
>>>
>>> (I tend to leave the issue open).
>>>
>>> In no case should we close a Jira issue without doing 1. or 2.
>>>
>>> What do you think?
>>>
>>> Regards,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>>
>>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>>
>>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>>
>>>> Jacques Le Roux commented on OFBIZ-9459:
>>>> ----------------------------------------
>>>>
>>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>>> reason? Do you want me to do it? Thanks.
>>>>
>>>> Wrong screen redirection after adding note on Lead profile screen
>>>>> -----------------------------------------------------------------
>>>>>
>>>>> Key: OFBIZ-9459
>>>>> URL:
>>>>> https://issues.apache.org/jira/browse/OFBIZ-9459
>>>>> Project: OFBiz
>>>>> Issue Type: Bug
>>>>> Components: marketing
>>>>> Reporter: Jagpreet Kaur
>>>>> Assignee: Arun Patidar
>>>>> Fix For: Upcoming Release
>>>>>
>>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>>> Screenredirection.png
>>>>>
>>>>>
>>>>> 1) Go to SFA component.
>>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>>> apache.org:8443/sfa/control/FindLeads].
>>>>> 3) Choose any partyId from All Lead list, you will be navigated to
>>>>> Lead
>>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>>> =LEAD&partyId=DemoLead]
>>>>> 4) Click on "Create New" button in the Notes section.
>>>>> 5) Add the Note content.
>>>>> 6) Click on "Save Button".
>>>>> View redirection should be profile but it shows the blank screen.
>>>>>
>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.4.14#64029)
>>>>
>>>
>>>
>

smime.p7s (5K) Download Attachment

Jacques Le Roux

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Administrator

If we agree (I guess we do) then we should update the committer page

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities

Thanks

Jacques

Le 10/07/2017 à 15:05, Michael Brohl a écrit :

> Additional idea: we can also flag the issue with a label "backport-needed" to easily find open issues which need a backport.
>
>
> Am 10.07.17 um 14:55 schrieb Jacques Le Roux:
>> +1 for leaving open with a comment
>>
>> Jacques
>>
>>
>> Le 10/07/2017 à 14:19, Deepak Dixit a écrit :
>>> +1 , I think instead of opening new issue, we can leave it open with
>>> comment
>>>
>>>
>>>
>>> Thanks & Regards
>>> --
>>> Deepak Dixit
>>> www.hotwaxsystems.com
>>> www.hotwax.co
>>>
>>> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
>>> wrote:
>>>
>>>> Hi everyone,
>>>>
>>>> I think we should setup some kind of policy for the bugfixing in the
>>>> project.
>>>>
>>>> While every committer is free to decide if he does a backport himself, we
>>>> should make sure that bugfixes go into the supported release branches also.
>>>>
>>>> I propose to define the following policies:
>>>>
>>>> 1. bugfixes should be backported by the committer who does the bugfix in
>>>> trunk if possible
>>>>
>>>> 2. if he does not, for an reason, backport the bugfix, he should either
>>>> open a new Jira for a task to backport or leave the original issue open
>>>> with a remark that a backport is needed.
>>>>
>>>> (I tend to leave the issue open).
>>>>
>>>> In no case should we close a Jira issue without doing 1. or 2.
>>>>
>>>> What do you think?
>>>>
>>>> Regards,
>>>>
>>>> Michael Brohl
>>>> ecomify GmbH
>>>> www.ecomify.de
>>>>
>>>>
>>>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>>>
>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>>>
>>>>> Jacques Le Roux commented on OFBIZ-9459:
>>>>> ----------------------------------------
>>>>>
>>>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>>>> reason? Do you want me to do it? Thanks.
>>>>>
>>>>> Wrong screen redirection after adding note on Lead profile screen
>>>>>> -----------------------------------------------------------------
>>>>>>
>>>>>> Key: OFBIZ-9459
>>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>>>>> Project: OFBiz
>>>>>> Issue Type: Bug
>>>>>> Components: marketing
>>>>>> Reporter: Jagpreet Kaur
>>>>>> Assignee: Arun Patidar
>>>>>> Fix For: Upcoming Release
>>>>>>
>>>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>>>> Screenredirection.png
>>>>>>
>>>>>>
>>>>>> 1) Go to SFA component.
>>>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>>>> apache.org:8443/sfa/control/FindLeads].
>>>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>>>> =LEAD&partyId=DemoLead]
>>>>>> 4) Click on "Create New" button in the Notes section.
>>>>>> 5) Add the Note content.
>>>>>> 6) Click on "Save Button".
>>>>>> View redirection should be profile but it shows the blank screen.
>>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian JIRA
>>>>> (v6.4.14#64029)
>>>>>
>>>>
>>>>
>>
>
>

Michael Brohl-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Hi Jacques,

I'll wait a few days if there are any objections and take care of it then.

Michael

Am 10.07.17 um 16:27 schrieb Jacques Le Roux:

> If we agree (I guess we do) then we should update the committer page
>
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities
>
>
> Thanks
>
> Jacques
>
>
> Le 10/07/2017 à 15:05, Michael Brohl a écrit :
>> Additional idea: we can also flag the issue with a label
>> "backport-needed" to easily find open issues which need a backport.
>>
>>
>> Am 10.07.17 um 14:55 schrieb Jacques Le Roux:
>>> +1 for leaving open with a comment
>>>
>>> Jacques
>>>
>>>
>>> Le 10/07/2017 à 14:19, Deepak Dixit a écrit :
>>>> +1 , I think instead of opening new issue, we can leave it open with
>>>> comment
>>>>
>>>>
>>>>
>>>> Thanks & Regards
>>>> --
>>>> Deepak Dixit
>>>> www.hotwaxsystems.com
>>>> www.hotwax.co
>>>>
>>>> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl
>>>> <[hidden email]>
>>>> wrote:
>>>>
>>>>> Hi everyone,
>>>>>
>>>>> I think we should setup some kind of policy for the bugfixing in the
>>>>> project.
>>>>>
>>>>> While every committer is free to decide if he does a backport
>>>>> himself, we
>>>>> should make sure that bugfixes go into the supported release
>>>>> branches also.
>>>>>
>>>>> I propose to define the following policies:
>>>>>
>>>>> 1. bugfixes should be backported by the committer who does the
>>>>> bugfix in
>>>>> trunk if possible
>>>>>
>>>>> 2. if he does not, for an reason, backport the bugfix, he should
>>>>> either
>>>>> open a new Jira for a task to backport or leave the original issue
>>>>> open
>>>>> with a remark that a backport is needed.
>>>>>
>>>>> (I tend to leave the issue open).
>>>>>
>>>>> In no case should we close a Jira issue without doing 1. or 2.
>>>>>
>>>>> What do you think?
>>>>>
>>>>> Regards,
>>>>>
>>>>> Michael Brohl
>>>>> ecomify GmbH
>>>>> www.ecomify.de
>>>>>
>>>>>
>>>>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>>>>
>>>>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>>>>
>>>>>> Jacques Le Roux commented on OFBIZ-9459:
>>>>>> ----------------------------------------
>>>>>>
>>>>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>>>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is
>>>>>> there a
>>>>>> reason? Do you want me to do it? Thanks.
>>>>>>
>>>>>> Wrong screen redirection after adding note on Lead profile screen
>>>>>>> -----------------------------------------------------------------
>>>>>>>
>>>>>>> Key: OFBIZ-9459
>>>>>>> URL:
>>>>>>> https://issues.apache.org/jira/browse/OFBIZ-9459
>>>>>>> Project: OFBiz
>>>>>>> Issue Type: Bug
>>>>>>> Components: marketing
>>>>>>> Reporter: Jagpreet Kaur
>>>>>>> Assignee: Arun Patidar
>>>>>>> Fix For: Upcoming Release
>>>>>>>
>>>>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>>>>> Screenredirection.png
>>>>>>>
>>>>>>>
>>>>>>> 1) Go to SFA component.
>>>>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>>>>> apache.org:8443/sfa/control/FindLeads].
>>>>>>> 3) Choose any partyId from All Lead list, you will be navigated
>>>>>>> to Lead
>>>>>>> profile.
>>>>>>> [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>>>>> =LEAD&partyId=DemoLead]
>>>>>>> 4) Click on "Create New" button in the Notes section.
>>>>>>> 5) Add the Note content.
>>>>>>> 6) Click on "Save Button".
>>>>>>> View redirection should be profile but it shows the blank screen.
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> This message was sent by Atlassian JIRA
>>>>>> (v6.4.14#64029)
>>>>>>
>>>>>
>>>>>
>>>
>>
>>
>

smime.p7s (5K) Download Attachment

Devanshu Vyas-2

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

In reply to this post by Michael Brohl-3

+1 and the committer should leave the ticket open with the comment 'Need to
backport the issue to the previous versions....'

Thanks & Regards,
Devanshu Vyas.

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
wrote:

Pranay Pandey-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

In reply to this post by Michael Brohl-3

+1

I think committer of the fix in trunk should take the ownership of
backporting. If you are not able to do it now, keep it open. Tagging the
ticket is a good idea. Bulk backporting should be avoided as it's error
prone.

Best regards,
Pranay Pandey
www.hotwaxsystems.com
www.hotwax.co

On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
wrote:

Gil Portenseigne

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

+1

Got the same Opinion

Regards

Gil

On 11/07/2017 08:38, Pranay Pandey wrote:

> +1
>
> I think committer of the fix in trunk should take the ownership of
> backporting. If you are not able to do it now, keep it open. Tagging the
> ticket is a good idea. Bulk backporting should be avoided as it's error
> prone.
>
> Best regards,
> Pranay Pandey
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
> wrote:
>
>> Hi everyone,
>>
>> I think we should setup some kind of policy for the bugfixing in the
>> project.
>>
>> While every committer is free to decide if he does a backport himself, we
>> should make sure that bugfixes go into the supported release branches also.
>>
>> I propose to define the following policies:
>>
>> 1. bugfixes should be backported by the committer who does the bugfix in
>> trunk if possible
>>
>> 2. if he does not, for an reason, backport the bugfix, he should either
>> open a new Jira for a task to backport or leave the original issue open
>> with a remark that a backport is needed.
>>
>> (I tend to leave the issue open).
>>
>> In no case should we close a Jira issue without doing 1. or 2.
>>
>> What do you think?
>>
>> Regards,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>>
>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>
>>> Jacques Le Roux commented on OFBIZ-9459:
>>> ----------------------------------------
>>>
>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>> reason? Do you want me to do it? Thanks.
>>>
>>> Wrong screen redirection after adding note on Lead profile screen
>>>> -----------------------------------------------------------------
>>>>
>>>> Key: OFBIZ-9459
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>>> Project: OFBiz
>>>> Issue Type: Bug
>>>> Components: marketing
>>>> Reporter: Jagpreet Kaur
>>>> Assignee: Arun Patidar
>>>> Fix For: Upcoming Release
>>>>
>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>> Screenredirection.png
>>>>
>>>>
>>>> 1) Go to SFA component.
>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>> apache.org:8443/sfa/control/FindLeads].
>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>> =LEAD&partyId=DemoLead]
>>>> 4) Click on "Create New" button in the Notes section.
>>>> 5) Add the Note content.
>>>> 6) Click on "Save Button".
>>>> View redirection should be profile but it shows the blank screen.
>>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.4.14#64029)
>>>
>>
>>

Arun Patidar-2

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

+1 for both, leave ticket open and tag it with label "backport-needed" .

--
Thanks & Regards
---
Arun Patidar
Manager, Enterprise Software Development

HotWax Systems Pvt Ltd.www.hotwaxsystems.com

On Tue, Jul 11, 2017 at 12:57 PM, gil portenseigne <
[hidden email]> wrote:

> +1
>
> Got the same Opinion
>
> Regards
>
> Gil
>
>
>
> On 11/07/2017 08:38, Pranay Pandey wrote:
>
>> +1
>>
>> I think committer of the fix in trunk should take the ownership of
>> backporting. If you are not able to do it now, keep it open. Tagging the
>> ticket is a good idea. Bulk backporting should be avoided as it's error
>> prone.
>>
>> Best regards,
>> Pranay Pandey
>> www.hotwaxsystems.com
>> www.hotwax.co
>>
>> On Mon, Jul 10, 2017 at 5:32 PM, Michael Brohl <[hidden email]>
>> wrote:
>>
>> Hi everyone,
>>>
>>> I think we should setup some kind of policy for the bugfixing in the
>>> project.
>>>
>>> While every committer is free to decide if he does a backport himself, we
>>> should make sure that bugfixes go into the supported release branches
>>> also.
>>>
>>> I propose to define the following policies:
>>>
>>> 1. bugfixes should be backported by the committer who does the bugfix in
>>> trunk if possible
>>>
>>> 2. if he does not, for an reason, backport the bugfix, he should either
>>> open a new Jira for a task to backport or leave the original issue open
>>> with a remark that a backport is needed.
>>>
>>> (I tend to leave the issue open).
>>>
>>> In no case should we close a Jira issue without doing 1. or 2.
>>>
>>> What do you think?
>>>
>>> Regards,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>>
>>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>>
>>>> Jacques Le Roux commented on OFBIZ-9459:
>>>> ----------------------------------------
>>>>
>>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>>> reason? Do you want me to do it? Thanks.
>>>>
>>>> Wrong screen redirection after adding note on Lead profile screen
>>>>
>>>>> -----------------------------------------------------------------
>>>>>
>>>>> Key: OFBIZ-9459
>>>>> URL: https://issues.apache.org/jira
>>>>> /browse/OFBIZ-9459
>>>>> Project: OFBiz
>>>>> Issue Type: Bug
>>>>> Components: marketing
>>>>> Reporter: Jagpreet Kaur
>>>>> Assignee: Arun Patidar
>>>>> Fix For: Upcoming Release
>>>>>
>>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>>> Screenredirection.png
>>>>>
>>>>>
>>>>> 1) Go to SFA component.
>>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz
>>>>> <http://he.org:8443/sfa/control/FindLeads%7Chttps://demo-trunk-ofbiz>.
>>>>> apache.org:8443/sfa/control/FindLeads].
>>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>>> =LEAD&partyId=DemoLead]
>>>>> 4) Click on "Create New" button in the Notes section.
>>>>> 5) Add the Note content.
>>>>> 6) Click on "Save Button".
>>>>> View redirection should be profile but it shows the blank screen.
>>>>>
>>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.4.14#64029)
>>>>
>>>>
>>>
>>>
>

Michael Brohl-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

I did a quick check using [1] and reopened all issues which need a
backport and labelled them.

It seems that everyone who answered agrees with the proposed process and
the label idea so I will change the wiki to reflect this.

Thanks,

Michael Brohl
ecomify GmbH
www.ecomify.de

[1]
https://issues.apache.org/jira/browse/OFBIZ-9481?filter=12315200&jql=project%20%3D%20OFBIZ%20AND%20issuetype%20%3D%20Bug%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20%3D%20%22Upcoming%20Release%22

Am 11.07.17 um 10:49 schrieb Arun Patidar:
> +1 for both, leave ticket open and tag it with label "backport-needed" .
>

smime.p7s (5K) Download Attachment

Arun Patidar-2

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Thanks Michael,

--
Thanks & Regards
---
Arun Patidar
Manager, Enterprise Software Development

HotWax Systems Pvt Ltd.www.hotwaxsystems.com

On Tue, Jul 11, 2017 at 4:31 PM, Michael Brohl <[hidden email]>
wrote:

> I did a quick check using [1] and reopened all issues which need a
> backport and labelled them.
>
> It seems that everyone who answered agrees with the proposed process and
> the label idea so I will change the wiki to reflect this.
>
> Thanks,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
> [1] https://issues.apache.org/jira/browse/OFBIZ-9481?filter=1231
> 5200&jql=project%20%3D%20OFBIZ%20AND%20issuetype%20%3D%
> 20Bug%20AND%20status%20%3D%20Closed%20AND%20fixVersion%20%
> 3D%20%22Upcoming%20Release%22
>
>
>
> Am 11.07.17 um 10:49 schrieb Arun Patidar:
>
> +1 for both, leave ticket open and tag it with label "backport-needed" .
>>
>>
>
>

Jacopo Cappellato-5

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

In reply to this post by Michael Brohl-3

+1 to the agreed upon output of this conversation (thank you Michael).
One little problem we will have to face is that, with the new workflow, a
bug that has been fixed in one branch and left open (waiting for a
backport) will not appear in the release notes of the branch.

Jacopo

On Mon, Jul 10, 2017 at 2:02 PM, Michael Brohl <[hidden email]>
wrote:

Michael Brohl-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Hi Jacopo,

I hope that we will apply rule 1. in most cases so maybe it's not
getting too much of a problem.

Maybe we should also have a process to check the "backport-needed"
issues some time before a planned release to avoid this?

Michael

Am 12.07.17 um 16:16 schrieb Jacopo Cappellato:

> +1 to the agreed upon output of this conversation (thank you Michael).
> One little problem we will have to face is that, with the new workflow, a
> bug that has been fixed in one branch and left open (waiting for a
> backport) will not appear in the release notes of the branch.
>
> Jacopo
>
> On Mon, Jul 10, 2017 at 2:02 PM, Michael Brohl <[hidden email]>
> wrote:
>
>> Hi everyone,
>>
>> I think we should setup some kind of policy for the bugfixing in the
>> project.
>>
>> While every committer is free to decide if he does a backport himself, we
>> should make sure that bugfixes go into the supported release branches also.
>>
>> I propose to define the following policies:
>>
>> 1. bugfixes should be backported by the committer who does the bugfix in
>> trunk if possible
>>
>> 2. if he does not, for an reason, backport the bugfix, he should either
>> open a new Jira for a task to backport or leave the original issue open
>> with a remark that a backport is needed.
>>
>> (I tend to leave the issue open).
>>
>> In no case should we close a Jira issue without doing 1. or 2.
>>
>> What do you think?
>>
>> Regards,
>>
>> Michael Brohl
>> ecomify GmbH
>> www.ecomify.de
>>
>>
>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>
>>> Jacques Le Roux commented on OFBIZ-9459:
>>> ----------------------------------------
>>>
>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>> reason? Do you want me to do it? Thanks.
>>>
>>> Wrong screen redirection after adding note on Lead profile screen
>>>> -----------------------------------------------------------------
>>>>
>>>> Key: OFBIZ-9459
>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-9459
>>>> Project: OFBiz
>>>> Issue Type: Bug
>>>> Components: marketing
>>>> Reporter: Jagpreet Kaur
>>>> Assignee: Arun Patidar
>>>> Fix For: Upcoming Release
>>>>
>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>> Screenredirection.png
>>>>
>>>>
>>>> 1) Go to SFA component.
>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz.
>>>> apache.org:8443/sfa/control/FindLeads].
>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>> =LEAD&partyId=DemoLead]
>>>> 4) Click on "Create New" button in the Notes section.
>>>> 5) Add the Note content.
>>>> 6) Click on "Save Button".
>>>> View redirection should be profile but it shows the blank screen.
>>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.4.14#64029)
>>>
>>
>>

smime.p7s (5K) Download Attachment

Jacopo Cappellato-5

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Yes, we will see how it goes and I like the idea of checking the the
"backport-needed" issues during the release preparation phase.

Jacopo

On Wed, Jul 12, 2017 at 5:07 PM, Michael Brohl <[hidden email]>
wrote:

> Hi Jacopo,
>
> I hope that we will apply rule 1. in most cases so maybe it's not getting
> too much of a problem.
>
> Maybe we should also have a process to check the "backport-needed" issues
> some time before a planned release to avoid this?
>
> Michael
>
>
> Am 12.07.17 um 16:16 schrieb Jacopo Cappellato:
>
>> +1 to the agreed upon output of this conversation (thank you Michael).
>> One little problem we will have to face is that, with the new workflow, a
>> bug that has been fixed in one branch and left open (waiting for a
>> backport) will not appear in the release notes of the branch.
>>
>> Jacopo
>>
>> On Mon, Jul 10, 2017 at 2:02 PM, Michael Brohl <[hidden email]>
>> wrote:
>>
>> Hi everyone,
>>>
>>> I think we should setup some kind of policy for the bugfixing in the
>>> project.
>>>
>>> While every committer is free to decide if he does a backport himself, we
>>> should make sure that bugfixes go into the supported release branches
>>> also.
>>>
>>> I propose to define the following policies:
>>>
>>> 1. bugfixes should be backported by the committer who does the bugfix in
>>> trunk if possible
>>>
>>> 2. if he does not, for an reason, backport the bugfix, he should either
>>> open a new Jira for a task to backport or leave the original issue open
>>> with a remark that a backport is needed.
>>>
>>> (I tend to leave the issue open).
>>>
>>> In no case should we close a Jira issue without doing 1. or 2.
>>>
>>> What do you think?
>>>
>>> Regards,
>>>
>>> Michael Brohl
>>> ecomify GmbH
>>> www.ecomify.de
>>>
>>>
>>> Am 10.07.17 um 13:26 schrieb Jacques Le Roux (JIRA):
>>>
>>> [ https://issues.apache.org/jira/browse/OFBIZ-9459?page=com.
>>>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>>>> l&focusedCommentId=16080188#comment-16080188 ]
>>>>
>>>> Jacques Le Roux commented on OFBIZ-9459:
>>>> ----------------------------------------
>>>>
>>>> Hi Arun, I noticed that, like few other issues (at least OFBIZ-9473,
>>>> OFBIZ-9316, OFBIZ-9317) that you did not backport this bug. Is there a
>>>> reason? Do you want me to do it? Thanks.
>>>>
>>>> Wrong screen redirection after adding note on Lead profile screen
>>>>
>>>>> -----------------------------------------------------------------
>>>>>
>>>>> Key: OFBIZ-9459
>>>>> URL: https://issues.apache.org/jira
>>>>> /browse/OFBIZ-9459
>>>>> Project: OFBiz
>>>>> Issue Type: Bug
>>>>> Components: marketing
>>>>> Reporter: Jagpreet Kaur
>>>>> Assignee: Arun Patidar
>>>>> Fix For: Upcoming Release
>>>>>
>>>>> Attachments: Create Note.png, OFBIZ-9459.patch,
>>>>> Screenredirection.png
>>>>>
>>>>>
>>>>> 1) Go to SFA component.
>>>>> 2) Click on Leads tab [https://demo-trunk-ofbiz.apac
>>>>> he.org:8443/sfa/control/FindLeads|https://demo-trunk-ofbiz
>>>>> <http://he.org:8443/sfa/control/FindLeads%7Chttps://demo-trunk-ofbiz>.
>>>>> apache.org:8443/sfa/control/FindLeads].
>>>>> 3) Choose any partyId from All Lead list, you will be navigated to Lead
>>>>> profile. [https://demo-trunk-ofbiz.apache.org:8443/sfa/control/viewpr
>>>>> ofile?roleTypeId=LEAD&partyId=DemoLead|https://demo-trunk-
>>>>> ofbiz.apache.org:8443/sfa/control/viewprofile?roleTypeId
>>>>> =LEAD&partyId=DemoLead]
>>>>> 4) Click on "Create New" button in the Notes section.
>>>>> 5) Add the Note content.
>>>>> 6) Click on "Save Button".
>>>>> View redirection should be profile but it shows the blank screen.
>>>>>
>>>>>
>>>> --
>>>> This message was sent by Atlassian JIRA
>>>> (v6.4.14#64029)
>>>>
>>>>
>>>
>>>
>
>

Michael Brohl-3

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Dear developers,

thanks for your suggestions and support for the backporting proposal!

I have documented the proposed process in the Wiki [1] and also added a
section [2] to the release management guide.

Cheers,

Michael Brohl
ecomify GmbH
www.ecomify.de

[1]
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Howshouldcommittershandlebackporting?

[2]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Thingstocheckbeforearelease

Am 12.07.17 um 18:07 schrieb Jacopo Cappellato:

> 1. bugfixes should be backported by the committer who does the bugfix in
> trunk if possible
>
> 2. if he does not, for an reason, backport the bugfix, he should either
> open a new Jira for a task to backport or leave the original issue open
> with a remark that a backport is needed.
>
> (I tend to leave the issue open).
>
> In no case should we close a Jira issue without doing 1. or 2.

smime.p7s (5K) Download Attachment

Jacques Le Roux

Re: [PROPOSAL] Backporting bugs Re: [jira] [Commented] (OFBIZ-9459) Wrong screen redirection after adding note on Lead profile screen

Administrator

Thanks Michael

Jacques

Le 12/07/2017 à 22:05, Michael Brohl a écrit :

> Dear developers,
>
> thanks for your suggestions and support for the backporting proposal!
>
> I have documented the proposed process in the Wiki [1] and also added a section [2] to the release management guide.
>
> Cheers,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
>
>
> [1]
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Howshouldcommittershandlebackporting?
>
> [2] https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Thingstocheckbeforearelease
>
>
> Am 12.07.17 um 18:07 schrieb Jacopo Cappellato:
>> 1. bugfixes should be backported by the committer who does the bugfix in
>> trunk if possible
>>
>> 2. if he does not, for an reason, backport the bugfix, he should either
>> open a new Jira for a task to backport or leave the original issue open
>> with a remark that a backport is needed.
>>
>> (I tend to leave the issue open).
>>
>> In no case should we close a Jira issue without doing 1. or 2.
>
>