PersonTraining services error (at least updatePersonTraining for sure)

[Jacques Le Roux]

Hi Hans,

In revision 802308 createPersonTraining, updatePersonTraining and deletePersonTraining services have been removed
http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
Is this intended ? Because there are still some calls to it, see https://issues.apache.org/jira/browse/OFBIZ-2919

Thanks

Jacques

[Ashish Vijaywargiya]

Interesting. :-)

--
Ashish

On Mon, Sep 21, 2009 at 12:54 AM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Hans,
>
> In revision 802308 createPersonTraining, updatePersonTraining and
> deletePersonTraining services have been removed
>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
> Is this intended ? Because there are still some calls to it, see
> https://issues.apache.org/jira/browse/OFBIZ-2919
>
> Thanks
>
> Jacques
>
>

[hans_bakker]

Asish,

can you please explain what this remark adds to the discussion?

> Interesting. :-)

Regards,
Hans

On Mon, 2009-09-21 at 12:07 +0530, Ashish Vijaywargiya wrote:

> Interesting. :-)
>
> --
> Ashish
>
> On Mon, Sep 21, 2009 at 12:54 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
> > Hi Hans,
> >
> > In revision 802308 createPersonTraining, updatePersonTraining and
> > deletePersonTraining services have been removed
> >
> > http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
> > Is this intended ? Because there are still some calls to it, see
> > https://issues.apache.org/jira/browse/OFBIZ-2919
> >
> > Thanks
> >
> > Jacques
> >
> >

--
Antwebsystems.com: Quality OFBiz services for competitive rates

[Ashish Vijaywargiya-5]

It means I am also interested to know the reason of this change as Jacques is expecting the same from you.
Thanks and we look forward to seeing your updated comment on this change Hans!

PS: Can you spell my name correct? Is it something wrong in your keyboard?

--
Ashish

Hans Bakker wrote:

Asish,

can you please explain what this remark adds to the discussion?

  

Interesting. :-)
    

Regards,
Hans

On Mon, 2009-09-21 at 12:07 +0530, Ashish Vijaywargiya wrote:
  

Interesting. :-)

--
Ashish

On Mon, Sep 21, 2009 at 12:54 AM, Jacques Le Roux <
[hidden email]> wrote:

    

Hi Hans,

In revision 802308 createPersonTraining, updatePersonTraining and
deletePersonTraining services have been removed

http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
Is this intended ? Because there are still some calls to it, see
https://issues.apache.org/jira/browse/OFBIZ-2919

Thanks

Jacques


      

[hans_bakker]

Hi Jacques,

In the issue there was a question about it. No i did not check if all
references were updated. I did judge however that the contribution was
valuable enough to be included.

Regards,
Hans

On Sun, 2009-09-20 at 21:24 +0200, Jacques Le Roux wrote:

> Hi Hans,
>
> In revision 802308 createPersonTraining, updatePersonTraining and deletePersonTraining services have been removed
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
> Is this intended ? Because there are still some calls to it, see https://issues.apache.org/jira/browse/OFBIZ-2919
>
> Thanks
>
> Jacques
>

--
Antwebsystems.com: Quality OFBiz services for competitive rates

[Jacques Le Roux]

Hi Hans,

So I understand that we should remove any mention of createPersonTraining, updatePersonTraining or deletePersonTraining in trunk
right (actually there is nothing for deletePersonTraining) ?

Jacques

From: "Hans Bakker" <[hidden email]>

> Hi Jacques,
>
> In the issue there was a question about it. No i did not check if all
> references were updated. I did judge however that the contribution was
> valuable enough to be included.
>
> Regards,
> Hans
>
> On Sun, 2009-09-20 at 21:24 +0200, Jacques Le Roux wrote:
>> Hi Hans,
>>
>> In revision 802308 createPersonTraining, updatePersonTraining and deletePersonTraining services have been removed
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
>> Is this intended ? Because there are still some calls to it, see https://issues.apache.org/jira/browse/OFBIZ-2919
>>
>> Thanks
>>
>> Jacques
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive rates
>

[Jacques Le Roux]

Yes, I thouhgt  about that straight afterward sending the message (actually it's often the case with me, it seems that I always
think afterward, but I'm sure I'm not the only one in this case :) , done at https://issues.apache.org/jira/browse/OFBIZ-2531
I suppose you did not commit the 2d patch ?

I also removed all calls to createPersonTraining and updatePersonTraining  at r817443

Jacques

From: "Hans Bakker" <[hidden email]>

> Yes sure, you can can remove these because they are replaced by using
> them on he calendar...
>
> Perhaps send a message to the original contributor?
>
> Regards,
> Hans
>
> On Mon, 2009-09-21 at 22:01 +0200, Jacques Le Roux wrote:
>> Hi Hans,
>>
>> So I understand that we should remove any mention of createPersonTraining, updatePersonTraining or deletePersonTraining in trunk
>> right (actually there is nothing for deletePersonTraining) ?
>>
>> Jacques
>>
>> From: "Hans Bakker" <[hidden email]>
>> > Hi Jacques,
>> >
>> > In the issue there was a question about it. No i did not check if all
>> > references were updated. I did judge however that the contribution was
>> > valuable enough to be included.
>> >
>> > Regards,
>> > Hans
>> >
>> > On Sun, 2009-09-20 at 21:24 +0200, Jacques Le Roux wrote:
>> >> Hi Hans,
>> >>
>> >> In revision 802308 createPersonTraining, updatePersonTraining and deletePersonTraining services have been removed
>> >> http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/servicedef/services.xml?r1=802308&r2=802307&pathrev=802308
>> >> Is this intended ? Because there are still some calls to it, see https://issues.apache.org/jira/browse/OFBIZ-2919
>> >>
>> >> Thanks
>> >>
>> >> Jacques
>> >>
>> > --
>> > Antwebsystems.com: Quality OFBiz services for competitive rates
>> >
>>
>>
> --
> Antwebsystems.com: Quality OFBiz services for competitive rates
>