Potential OFBiz Localization Bugs

[Adrian Crum]

In the trunk rev 658045 I committed some localization work. My intention
was to fix all of the quirky localization issues that keep popping up.

I took the shotgun approach and localized all numeric and date-time
conversions - believing that the majority of those conversions should be
localized. The exceptions could be handled on a case-by-case basis.

That commit solved a number of localization issues, but (as was pointed
out on the user ml today) it introduced a bug in order number and
invoice number generation. IDs were being localized. IDs are one of the
exceptions to localization. I fixed that issue in rev 672343.

If anyone can think of any other exceptions, please let me know and I
will take care of it.

-Adrian

[Jacques Le Roux]

Thanks for the detailled explanation, Adrian

Jacques

From: "Adrian Crum" <[hidden email]>

> In the trunk rev 658045 I committed some localization work. My intention
> was to fix all of the quirky localization issues that keep popping up.
>
> I took the shotgun approach and localized all numeric and date-time
> conversions - believing that the majority of those conversions should be
> localized. The exceptions could be handled on a case-by-case basis.
>
> That commit solved a number of localization issues, but (as was pointed
> out on the user ml today) it introduced a bug in order number and
> invoice number generation. IDs were being localized. IDs are one of the
> exceptions to localization. I fixed that issue in rev 672343.
>
> If anyone can think of any other exceptions, please let me know and I
> will take care of it.
>
> -Adrian
>

[Scott Gray]

Phone numbers?  I haven't checked if there's a problem, it's just the first
thing that came to mind.

Regards
Scott

2008/6/28 Adrian Crum <[hidden email]>:

> In the trunk rev 658045 I committed some localization work. My intention
> was to fix all of the quirky localization issues that keep popping up.
>
> I took the shotgun approach and localized all numeric and date-time
> conversions - believing that the majority of those conversions should be
> localized. The exceptions could be handled on a case-by-case basis.
>
> That commit solved a number of localization issues, but (as was pointed out
> on the user ml today) it introduced a bug in order number and invoice number
> generation. IDs were being localized. IDs are one of the exceptions to
> localization. I fixed that issue in rev 672343.
>
> If anyone can think of any other exceptions, please let me know and I will
> take care of it.
>
> -Adrian
>
>

[Scott Gray]

Oh hey, if you're looking at the localization stuff, I just noticed this
isn't working:
review.getRelatedOne("StatusItem").get("description", locale)
Here:
https://demo.hotwaxmedia.com/catalog/control/pendingReviews

I haven't looked into why but the key does exist in CommonEntityLabels.xml

Regards
Scott

2008/6/28 Scott Gray <[hidden email]>:

> Phone numbers?  I haven't checked if there's a problem, it's just the first
> thing that came to mind.
>
> Regards
> Scott
>
> 2008/6/28 Adrian Crum <[hidden email]>:
>
> In the trunk rev 658045 I committed some localization work. My intention
>> was to fix all of the quirky localization issues that keep popping up.
>>
>> I took the shotgun approach and localized all numeric and date-time
>> conversions - believing that the majority of those conversions should be
>> localized. The exceptions could be handled on a case-by-case basis.
>>
>> That commit solved a number of localization issues, but (as was pointed
>> out on the user ml today) it introduced a bug in order number and invoice
>> number generation. IDs were being localized. IDs are one of the exceptions
>> to localization. I fixed that issue in rev 672343.
>>
>> If anyone can think of any other exceptions, please let me know and I will
>> take care of it.
>>
>> -Adrian
>>
>>
>

[Jacques Le Roux]

Hi Scott,

I did not see any issue at https://demo.hotwaxmedia.com/catalog/control/pendingReviews (I tried in English and French)
Moreover it seems that there are no entries for "StatusItem" but a lot for "StatusItem.description.*"
In brief, I guess it needs more informations

Jacques

From: "Scott Gray" <[hidden email]>

> Oh hey, if you're looking at the localization stuff, I just noticed this
> isn't working:
> review.getRelatedOne("StatusItem").get("description", locale)
> Here:
> https://demo.hotwaxmedia.com/catalog/control/pendingReviews
>
> I haven't looked into why but the key does exist in CommonEntityLabels.xml
>
> Regards
> Scott
>
> 2008/6/28 Scott Gray <[hidden email]>:
>
>> Phone numbers?  I haven't checked if there's a problem, it's just the first
>> thing that came to mind.
>>
>> Regards
>> Scott
>>
>> 2008/6/28 Adrian Crum <[hidden email]>:
>>
>> In the trunk rev 658045 I committed some localization work. My intention
>>> was to fix all of the quirky localization issues that keep popping up.
>>>
>>> I took the shotgun approach and localized all numeric and date-time
>>> conversions - believing that the majority of those conversions should be
>>> localized. The exceptions could be handled on a case-by-case basis.
>>>
>>> That commit solved a number of localization issues, but (as was pointed
>>> out on the user ml today) it introduced a bug in order number and invoice
>>> number generation. IDs were being localized. IDs are one of the exceptions
>>> to localization. I fixed that issue in rev 672343.
>>>
>>> If anyone can think of any other exceptions, please let me know and I will
>>> take care of it.
>>>
>>> -Adrian
>>>
>>>
>>
>

[Adrian Crum-2]

Scott,

The bug would appear while converting a numeric or timestamp data type to a String. I believe phone numbers are Strings.

-Adrian


--- On Fri, 6/27/08, Scott Gray <[hidden email]> wrote:

> From: Scott Gray <[hidden email]>
> Subject: Re: Potential OFBiz Localization Bugs
> To: [hidden email]
> Date: Friday, June 27, 2008, 2:02 PM
> Phone numbers?  I haven't checked if there's a
> problem, it's just the first
> thing that came to mind.
>
> Regards
> Scott
>
> 2008/6/28 Adrian Crum <[hidden email]>:
>
> > In the trunk rev 658045 I committed some localization
> work. My intention
> > was to fix all of the quirky localization issues that
> keep popping up.
> >
> > I took the shotgun approach and localized all numeric
> and date-time
> > conversions - believing that the majority of those
> conversions should be
> > localized. The exceptions could be handled on a
> case-by-case basis.
> >
> > That commit solved a number of localization issues,
> but (as was pointed out
> > on the user ml today) it introduced a bug in order
> number and invoice number
> > generation. IDs were being localized. IDs are one of
> the exceptions to
> > localization. I fixed that issue in rev 672343.
> >
> > If anyone can think of any other exceptions, please
> let me know and I will
> > take care of it.
> >
> > -Adrian
> >
> >