Potential bug.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Potential bug.

Dimitri Valax
Hello,

I'am a new french ofbiz user.

After having  checked out, I'am having a  "Null pointer acces"  error

        String skipPermissionCheck = null;

        if (UtilValidate.isEmpty(skipPermissionCheck)
            || (!skipPermissionCheck.equalsIgnoreCase("true") && !skipPermissionCheck.equalsIgnoreCase("granted"))) {

I don't know if you are aware of that?

Dimitri Valax
Consultant
[hidden email]<mailto:[hidden email]>

Mobile : +33 (0)6 63 23 95 13

Valtech
5 avenue Marcel Dassault - Batiment A
31500 Toulouse
Tél. : +33 (0)5 62 47 64 00
Fax : +33 (0)5 62 47 64 10
www.valtech.fr<http://www.valtech.fr/>

Reply | Threaded
Open this post in threaded view
|

Re: Potential bug.

Erwan de FERRIERES
Le 23/02/2011 16:16, Dimitri Valax a écrit :

> Hello,
>
> I'am a new french ofbiz user.
>
> After having  checked out, I'am having a  "Null pointer acces"  error
>
>          String skipPermissionCheck = null;
>
>          if (UtilValidate.isEmpty(skipPermissionCheck)
>              || (!skipPermissionCheck.equalsIgnoreCase("true")&&  !skipPermissionCheck.equalsIgnoreCase("granted"))) {
>
> I don't know if you are aware of that?
>
> Dimitri Valax
> Consultant
> [hidden email]<mailto:[hidden email]>
>
> Mobile : +33 (0)6 63 23 95 13
>
> Valtech
> 5 avenue Marcel Dassault - Batiment A
> 31500 Toulouse
> Tél. : +33 (0)5 62 47 64 00
> Fax : +33 (0)5 62 47 64 10
> www.valtech.fr<http://www.valtech.fr/>
>
>
Hi,

what are you trying to  achieve ?
Please explain a bit more, so it will be easier to help you.

Be aware there is also a user mailing list
https://cwiki.apache.org/OFBADMIN/mailing-lists.html

Cheers,

--
Erwan de FERRIERES
www.nereide.biz
Reply | Threaded
Open this post in threaded view
|

Re: Potential bug.

Chirag Manocha-3
In reply to this post by Dimitri Valax
this is not OFBiz specific error. this is Core Java error.
you are trying to call a instance method on null object.

Your skipPermissionCheck is null.

and you are calling method equalsIgnoreCase on the object.

Thanks and Regards
--
Chirag Manocha
Emforium Software Pvt. Ltd. | ALL-IN Software
+91-98735-47457 | +91-98263-19099
Please don't print this Email unless you really need to - this will preserve trees on planet earth.




From: "Dimitri Valax" <[hidden email]>
To: [hidden email]
Sent: Wednesday, February 23, 2011 8:46:36 PM
Subject: Potential bug.

Hello,

I'am a new french ofbiz user.

After having checked out, I'am having a "Null pointer acces" error

String skipPermissionCheck = null;

if (UtilValidate.isEmpty(skipPermissionCheck)
|| (!skipPermissionCheck.equalsIgnoreCase("true") && !skipPermissionCheck.equalsIgnoreCase("granted"))) {

I don't know if you are aware of that?

Dimitri Valax
Consultant
[hidden email]<mailto:[hidden email]>

Mobile : +33 (0)6 63 23 95 13

Valtech
5 avenue Marcel Dassault - Batiment A
31500 Toulouse
Tél. : +33 (0)5 62 47 64 00
Fax : +33 (0)5 62 47 64 10
www.valtech.fr<http://www.valtech.fr/>


Reply | Threaded
Open this post in threaded view
|

Re: Potential bug.

Jacques Le Roux
Administrator
Sorry Chirag,

This is OFBiz OOTB in 3 places
It seems to me that it should be rather fixed using

if (UtilValidate.isEmpty(skipPermissionCheck) || (!"true".equalsIgnoreCase(skipPermissionCheck).&&
!"granted".equalsIgnoreCase(skipPermissionCheck)))) {

There is even one place where it does not make any sense.

I have opened https://issues.apache.org/jira/browse/OFBIZ-4198 and provided a patch. I have not enough time at the moment to test.
If someone could confirm it would be cool....

Thanks

Jacques

Chirag Manocha wrote:

> this is not OFBiz specific error. this is Core Java error.
> you are trying to call a instance method on null object.
>
> Your skipPermissionCheck is null.
>
> and you are calling method equalsIgnoreCase on the object.
>
> Thanks and Regards
>
> if (UtilValidate.isEmpty(skipPermissionCheck)
>>> (!skipPermissionCheck.equalsIgnoreCase("true") && !skipPermissionCheck.equalsIgnoreCase("granted"))) {
>
> I don't know if you are aware of that?
>
> Dimitri Valax
> Consultant
> [hidden email]<mailto:[hidden email]>
>
> Mobile : +33 (0)6 63 23 95 13
>
> Valtech
> 5 avenue Marcel Dassault - Batiment A
> 31500 Toulouse
> Tél. : +33 (0)5 62 47 64 00
> Fax : +33 (0)5 62 47 64 10
> www.valtech.fr<http://www.valtech.fr/>