Product weight field confusion in Product entity

[Suraj Khurana]

Hello all,

Hope you are doing good.

There are three sets of dimensions in the Product entity.
(productHeight, shippingHeight), (productWidth,  shippingWidth), (productDepth,
shippingDepth) which all makes perfect sense to user.
But in case of another dimension i.e. weight, there is another set of
dimension fields weight and productWeight in Product entity.
When I dig into the framework code weight field is more used when we are
talking about actual product weight and productWeight field is not used
anywhere.
Also, there is no field such as shippingWeight.
Can someone please put some more light on this and explain the exact use of
productWeight field and what is the exact way to store shippingWeight of a
product on Product level.
Thanks in advance.

--
Best Regards,
Suraj Khurana
Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
innovative enterprise commerce solutions **powered by Apache OFBiz.*
<https://about.me/surajkhurana?promo=email_sig>

[Jacopo Cappellato-5]

There are indeed some data model inconsistencies in this area.
After reviewing the commit (817605) that introduced the field productWeight
I think that the following applies:
"weight" should be used to specify the "shipping weight" of the product
"productWeight" should be used to specify the actual weight of the product.

However since its introduction, productWeight was never used and "weight"
has been used both to specify the shipping weight and to specify the actual
weight.

How can we fix this situation? I see two options:
1) review all usages of "weight" and fix according to the definition above
2) rename "productWeight" into "shippingWeight" and fix the codebase to use
this field only when the shipping weight is required and use "weight" in
all the other cases.

Maybe #2 would be easier to implement and would have a limited impact on
existing instances.

Jacopo



On Tue, Dec 15, 2015 at 12:03 PM, Suraj Khurana <
[hidden email]> wrote:

> Hello all,
>
> Hope you are doing good.
>
> There are three sets of dimensions in the Product entity.
> (productHeight, shippingHeight), (productWidth,  shippingWidth),
> (productDepth,
> shippingDepth) which all makes perfect sense to user.
> But in case of another dimension i.e. weight, there is another set of
> dimension fields weight and productWeight in Product entity.
> When I dig into the framework code weight field is more used when we are
> talking about actual product weight and productWeight field is not used
> anywhere.
> Also, there is no field such as shippingWeight.
> Can someone please put some more light on this and explain the exact use of
> productWeight field and what is the exact way to store shippingWeight of a
> product on Product level.
> Thanks in advance.
>
> --
> Best Regards,
> Suraj Khurana
> Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
> innovative enterprise commerce solutions **powered by Apache OFBiz.*
> <https://about.me/surajkhurana?promo=email_sig>
>

[Pierre Smits]

Hi Suraj,

This can be regarded as an improvement of the code base. Feel free to
create the appropriate issue in JIRA, so that this can be dealt with from
there and tracked.

Best regards,



Pierre Smits

ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Tue, Dec 15, 2015 at 12:03 PM, Suraj Khurana <
[hidden email]> wrote:

> Hello all,
>
> Hope you are doing good.
>
> There are three sets of dimensions in the Product entity.
> (productHeight, shippingHeight), (productWidth,  shippingWidth),
> (productDepth,
> shippingDepth) which all makes perfect sense to user.
> But in case of another dimension i.e. weight, there is another set of
> dimension fields weight and productWeight in Product entity.
> When I dig into the framework code weight field is more used when we are
> talking about actual product weight and productWeight field is not used
> anywhere.
> Also, there is no field such as shippingWeight.
> Can someone please put some more light on this and explain the exact use of
> productWeight field and what is the exact way to store shippingWeight of a
> product on Product level.
> Thanks in advance.
>
> --
> Best Regards,
> Suraj Khurana
> Enterprise Software Engineer
> HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
> innovative enterprise commerce solutions **powered by Apache OFBiz.*
> <https://about.me/surajkhurana?promo=email_sig>
>

[Pierre Smits]

This is related:
http://demo-trunk-ofbiz.apache.org/facility/control/WeightPackageOnly

Pierre Smits

ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Tue, Dec 15, 2015 at 12:41 PM, Pierre Smits <[hidden email]>
wrote:

> Hi Suraj,
>
> This can be regarded as an improvement of the code base. Feel free to
> create the appropriate issue in JIRA, so that this can be dealt with from
> there and tracked.
>
> Best regards,
>
>
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Tue, Dec 15, 2015 at 12:03 PM, Suraj Khurana <
> [hidden email]> wrote:
>
>> Hello all,
>>
>> Hope you are doing good.
>>
>> There are three sets of dimensions in the Product entity.
>> (productHeight, shippingHeight), (productWidth,  shippingWidth),
>> (productDepth,
>> shippingDepth) which all makes perfect sense to user.
>> But in case of another dimension i.e. weight, there is another set of
>> dimension fields weight and productWeight in Product entity.
>> When I dig into the framework code weight field is more used when we are
>> talking about actual product weight and productWeight field is not used
>> anywhere.
>> Also, there is no field such as shippingWeight.
>> Can someone please put some more light on this and explain the exact use
>> of
>> productWeight field and what is the exact way to store shippingWeight of a
>> product on Product level.
>> Thanks in advance.
>>
>> --
>> Best Regards,
>> Suraj Khurana
>> Enterprise Software Engineer
>> HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
>> innovative enterprise commerce solutions **powered by Apache OFBiz.*
>> <https://about.me/surajkhurana?promo=email_sig>
>>
>
>

[Suraj Khurana]

Thanks Jacopo and Pierre for you inputs.

I have created a JIRA ticket here
<https://issues.apache.org/jira/browse/OFBIZ-6777> and soon will be
providing patch for the same.

--
Best Regards,
Suraj Khurana
Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
innovative enterprise commerce solutions **powered by Apache OFBiz.*
<https://about.me/surajkhurana?promo=email_sig>


On Tue, Dec 15, 2015 at 5:16 PM, Pierre Smits <[hidden email]>
wrote:

> This is related:
> http://demo-trunk-ofbiz.apache.org/facility/control/WeightPackageOnly
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Tue, Dec 15, 2015 at 12:41 PM, Pierre Smits <[hidden email]>
> wrote:
>
> > Hi Suraj,
> >
> > This can be regarded as an improvement of the code base. Feel free to
> > create the appropriate issue in JIRA, so that this can be dealt with from
> > there and tracked.
> >
> > Best regards,
> >
> >
> >
> > Pierre Smits
> >
> > ORRTIZ.COM <http://www.orrtiz.com>
> > OFBiz based solutions & services
> >
> > OFBiz Extensions Marketplace
> > http://oem.ofbizci.net/oci-2/
> >
> > On Tue, Dec 15, 2015 at 12:03 PM, Suraj Khurana <
> > [hidden email]> wrote:
> >
> >> Hello all,
> >>
> >> Hope you are doing good.
> >>
> >> There are three sets of dimensions in the Product entity.
> >> (productHeight, shippingHeight), (productWidth,  shippingWidth),
> >> (productDepth,
> >> shippingDepth) which all makes perfect sense to user.
> >> But in case of another dimension i.e. weight, there is another set of
> >> dimension fields weight and productWeight in Product entity.
> >> When I dig into the framework code weight field is more used when we are
> >> talking about actual product weight and productWeight field is not used
> >> anywhere.
> >> Also, there is no field such as shippingWeight.
> >> Can someone please put some more light on this and explain the exact use
> >> of
> >> productWeight field and what is the exact way to store shippingWeight
> of a
> >> product on Product level.
> >> Thanks in advance.
> >>
> >> --
> >> Best Regards,
> >> Suraj Khurana
> >> Enterprise Software Engineer
> >> HotWax Systems <http://www.hotwaxsystems.com/> - *The global leader in
> >> innovative enterprise commerce solutions **powered by Apache OFBiz.*
> >> <https://about.me/surajkhurana?promo=email_sig>
> >>
> >
> >
>