[Proposal] Reducing the clean* operations in gradle

[taher]

Hello Everyone, I'm not sure why we have so many fine-grained clean
tasks, but to reduce clutter, I suggest to have only the following
clean operations in build.gradle:

- cleanCatalina: To reset web server state to test stuff
- cleanData: To reset database state to test stuff
- cleanAll: To remove everything including above.

So I suggest deleting all other clean* operations and incorporating
them into cleanAll. This would result in less clutter when issuing
"./gradlew tasks".

Ideas?

[Nicolas Malin-2]

Hello Taher,

I haven't a strong opinion so your proposal seems to be good for slim
the code.

A noob question, can we move deleted tasks to the tools folder like ant
previously ?

Nicolas


On 29/01/2018 11:31, Taher Alkhateeb wrote:

> Hello Everyone, I'm not sure why we have so many fine-grained clean
> tasks, but to reduce clutter, I suggest to have only the following
> clean operations in build.gradle:
>
> - cleanCatalina: To reset web server state to test stuff
> - cleanData: To reset database state to test stuff
> - cleanAll: To remove everything including above.
>
> So I suggest deleting all other clean* operations and incorporating
> them into cleanAll. This would result in less clutter when issuing
> "./gradlew tasks".
>
> Ideas?
>

[Jacques Le Roux]

Hi Taher,

I'd like to keep at least cleanLogs apart.

It's sometimes useful to clean logs w/o changing anything else.

Maybe cleanFooterFiles could be considered also but no strong opinion

Jacques


Le 29/01/2018 à 13:27, Nicolas Malin a écrit :

> Hello Taher,
>
> I haven't a strong opinion so your proposal seems to be good for slim the code.
>
> A noob question, can we move deleted tasks to the tools folder like ant previously ?
>
> Nicolas
>
>
> On 29/01/2018 11:31, Taher Alkhateeb wrote:
>> Hello Everyone, I'm not sure why we have so many fine-grained clean
>> tasks, but to reduce clutter, I suggest to have only the following
>> clean operations in build.gradle:
>>
>> - cleanCatalina: To reset web server state to test stuff
>> - cleanData: To reset database state to test stuff
>> - cleanAll: To remove everything including above.
>>
>> So I suggest deleting all other clean* operations and incorporating
>> them into cleanAll. This would result in less clutter when issuing
>> "./gradlew tasks".
>>
>> Ideas?
>>
>
>

[taher]

Hi Jacques,

Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other
opinions folks? Does anyone care for the other clean tasks to be
isolated?

On Tue, Jan 30, 2018 at 4:27 PM, Jacques Le Roux
<[hidden email]> wrote:

> Hi Taher,
>
> I'd like to keep at least cleanLogs apart.
>
> It's sometimes useful to clean logs w/o changing anything else.
>
> Maybe cleanFooterFiles could be considered also but no strong opinion
>
> Jacques
>
>
>
> Le 29/01/2018 à 13:27, Nicolas Malin a écrit :
>>
>> Hello Taher,
>>
>> I haven't a strong opinion so your proposal seems to be good for slim the
>> code.
>>
>> A noob question, can we move deleted tasks to the tools folder like ant
>> previously ?
>>
>> Nicolas
>>
>>
>> On 29/01/2018 11:31, Taher Alkhateeb wrote:
>>>
>>> Hello Everyone, I'm not sure why we have so many fine-grained clean
>>> tasks, but to reduce clutter, I suggest to have only the following
>>> clean operations in build.gradle:
>>>
>>> - cleanCatalina: To reset web server state to test stuff
>>> - cleanData: To reset database state to test stuff
>>> - cleanAll: To remove everything including above.
>>>
>>> So I suggest deleting all other clean* operations and incorporating
>>> them into cleanAll. This would result in less clutter when issuing
>>> "./gradlew tasks".
>>>
>>> Ideas?
>>>
>>
>>
>

[Shi Jinghai-3]

Hi Taher,

Excellent work on gradle! I like your pluginLibsCompile very much.

Inspired by the pluginLibsCompile, is it possible to define a new clean plugin in build.gradle of a component to clean a log or index folder?

Kind Regards,

Shi Jinghai

-----邮件原件-----
发件人: Taher Alkhateeb [mailto:[hidden email]]
发送时间: 2018年1月31日 0:54
收件人: OFBIZ Development Mailing List
主题: Re: [Proposal] Reducing the clean* operations in gradle

Hi Jacques,

Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other opinions folks? Does anyone care for the other clean tasks to be isolated?

On Tue, Jan 30, 2018 at 4:27 PM, Jacques Le Roux <[hidden email]> wrote:

> Hi Taher,
>
> I'd like to keep at least cleanLogs apart.
>
> It's sometimes useful to clean logs w/o changing anything else.
>
> Maybe cleanFooterFiles could be considered also but no strong opinion
>
> Jacques
>
>
>
> Le 29/01/2018 à 13:27, Nicolas Malin a écrit :
>>
>> Hello Taher,
>>
>> I haven't a strong opinion so your proposal seems to be good for slim
>> the code.
>>
>> A noob question, can we move deleted tasks to the tools folder like
>> ant previously ?
>>
>> Nicolas
>>
>>
>> On 29/01/2018 11:31, Taher Alkhateeb wrote:
>>>
>>> Hello Everyone, I'm not sure why we have so many fine-grained clean
>>> tasks, but to reduce clutter, I suggest to have only the following
>>> clean operations in build.gradle:
>>>
>>> - cleanCatalina: To reset web server state to test stuff
>>> - cleanData: To reset database state to test stuff
>>> - cleanAll: To remove everything including above.
>>>
>>> So I suggest deleting all other clean* operations and incorporating
>>> them into cleanAll. This would result in less clutter when issuing
>>> "./gradlew tasks".
>>>
>>> Ideas?
>>>
>>
>>
>

[taher]

Hi Shi,

You're changing the subject here, please make sure of starting new threads
to keep focus. This topic is a bit complex and you can check this reference
https://docs.gradle.org/current/userguide/multi_project_builds.html

On Jan 31, 2018 5:22 AM, "Shi Jinghai" <[hidden email]> wrote:

> Hi Taher,
>
> Excellent work on gradle! I like your pluginLibsCompile very much.
>
> Inspired by the pluginLibsCompile, is it possible to define a new clean
> plugin in build.gradle of a component to clean a log or index folder?
>
> Kind Regards,
>
> Shi Jinghai
>
> -----邮件原件-----
> 发件人: Taher Alkhateeb [mailto:[hidden email]]
> 发送时间: 2018年1月31日 0:54
> 收件人: OFBIZ Development Mailing List
> 主题: Re: [Proposal] Reducing the clean* operations in gradle
>
> Hi Jacques,
>
> Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other opinions
> folks? Does anyone care for the other clean tasks to be isolated?
>
> On Tue, Jan 30, 2018 at 4:27 PM, Jacques Le Roux <
> [hidden email]> wrote:
> > Hi Taher,
> >
> > I'd like to keep at least cleanLogs apart.
> >
> > It's sometimes useful to clean logs w/o changing anything else.
> >
> > Maybe cleanFooterFiles could be considered also but no strong opinion
> >
> > Jacques
> >
> >
> >
> > Le 29/01/2018 à 13:27, Nicolas Malin a écrit :
> >>
> >> Hello Taher,
> >>
> >> I haven't a strong opinion so your proposal seems to be good for slim
> >> the code.
> >>
> >> A noob question, can we move deleted tasks to the tools folder like
> >> ant previously ?
> >>
> >> Nicolas
> >>
> >>
> >> On 29/01/2018 11:31, Taher Alkhateeb wrote:
> >>>
> >>> Hello Everyone, I'm not sure why we have so many fine-grained clean
> >>> tasks, but to reduce clutter, I suggest to have only the following
> >>> clean operations in build.gradle:
> >>>
> >>> - cleanCatalina: To reset web server state to test stuff
> >>> - cleanData: To reset database state to test stuff
> >>> - cleanAll: To remove everything including above.
> >>>
> >>> So I suggest deleting all other clean* operations and incorporating
> >>> them into cleanAll. This would result in less clutter when issuing
> >>> "./gradlew tasks".
> >>>
> >>> Ideas?
> >>>
> >>
> >>
> >
>

[Michael Brohl-3]

I don't see much benefit in removing those tasks, they provide some
flexibility.

If we want to reduce them though, I'm in favor of keeping cleanIndexes too.

Regards,

Michael


Am 30.01.18 um 17:54 schrieb Taher Alkhateeb:

> Hi Jacques,
>
> Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other
> opinions folks? Does anyone care for the other clean tasks to be
> isolated?
>
> On Tue, Jan 30, 2018 at 4:27 PM, Jacques Le Roux
> <[hidden email]> wrote:
>> Hi Taher,
>>
>> I'd like to keep at least cleanLogs apart.
>>
>> It's sometimes useful to clean logs w/o changing anything else.
>>
>> Maybe cleanFooterFiles could be considered also but no strong opinion
>>
>> Jacques
>>
>>
>>
>> Le 29/01/2018 à 13:27, Nicolas Malin a écrit :
>>> Hello Taher,
>>>
>>> I haven't a strong opinion so your proposal seems to be good for slim the
>>> code.
>>>
>>> A noob question, can we move deleted tasks to the tools folder like ant
>>> previously ?
>>>
>>> Nicolas
>>>
>>>
>>> On 29/01/2018 11:31, Taher Alkhateeb wrote:
>>>> Hello Everyone, I'm not sure why we have so many fine-grained clean
>>>> tasks, but to reduce clutter, I suggest to have only the following
>>>> clean operations in build.gradle:
>>>>
>>>> - cleanCatalina: To reset web server state to test stuff
>>>> - cleanData: To reset database state to test stuff
>>>> - cleanAll: To remove everything including above.
>>>>
>>>> So I suggest deleting all other clean* operations and incorporating
>>>> them into cleanAll. This would result in less clutter when issuing
>>>> "./gradlew tasks".
>>>>
>>>> Ideas?
>>>>
>>>

[taher]

It was just a suggestion to reduce clutter. I see multiple individuals
wanting to keep tasks so I guess I didn't realize that and I withdraw my
proposal. Thank you all.

On Jan 31, 2018 12:23 PM, "Michael Brohl" <[hidden email]> wrote:

I don't see much benefit in removing those tasks, they provide some
flexibility.

If we want to reduce them though, I'm in favor of keeping cleanIndexes too.

Regards,

Michael


Am 30.01.18 um 17:54 schrieb Taher Alkhateeb:

Hi Jacques,

>
> Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other
> opinions folks? Does anyone care for the other clean tasks to be
> isolated?
>
> On Tue, Jan 30, 2018 at 4:27 PM, Jacques Le Roux
> <[hidden email]> wrote:
>
>> Hi Taher,
>>
>> I'd like to keep at least cleanLogs apart.
>>
>> It's sometimes useful to clean logs w/o changing anything else.
>>
>> Maybe cleanFooterFiles could be considered also but no strong opinion
>>
>> Jacques
>>
>>
>>
>> Le 29/01/2018 à 13:27, Nicolas Malin a écrit :
>>
>>> Hello Taher,
>>>
>>> I haven't a strong opinion so your proposal seems to be good for slim the
>>> code.
>>>
>>> A noob question, can we move deleted tasks to the tools folder like ant
>>> previously ?
>>>
>>> Nicolas
>>>
>>>
>>> On 29/01/2018 11:31, Taher Alkhateeb wrote:
>>>
>>>> Hello Everyone, I'm not sure why we have so many fine-grained clean
>>>> tasks, but to reduce clutter, I suggest to have only the following
>>>> clean operations in build.gradle:
>>>>
>>>> - cleanCatalina: To reset web server state to test stuff
>>>> - cleanData: To reset database state to test stuff
>>>> - cleanAll: To remove everything including above.
>>>>
>>>> So I suggest deleting all other clean* operations and incorporating
>>>> them into cleanAll. This would result in less clutter when issuing
>>>> "./gradlew tasks".
>>>>
>>>> Ideas?
>>>>
>>>>
>>>