Proposal for change in entity "GoogleCoShippingMethod"

[Pranay Pandey-2]

Hello Devs,

I want propose a change in entity GoogleCoShippingMethod.
We should change field "shipmentMethodName" from type "id-ne" to "id-
long-ne".
The reason is the name of Shipping method can be longer and this will  
not be accommodated in the present one.

As these changes have done before few days so I think no one will be  
using this on production and this change should not harm anything.

Thoughts?


Thanks & Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com

[Mridul Pathak-2]

+1

--
Thanks,
Mridul Pathak

On 25-Sep-09, at 4:04 PM, Pranay Pandey wrote:

> Hello Devs,
>
> I want propose a change in entity GoogleCoShippingMethod.
> We should change field "shipmentMethodName" from type "id-ne" to "id-
> long-ne".
> The reason is the name of Shipping method can be longer and this  
> will not be accommodated in the present one.
>
> As these changes have done before few days so I think no one will be  
> using this on production and this change should not harm anything.
>
> Thoughts?
>
>
> Thanks & Regards
> --
> Pranay Pandey
> HotWax Media | www.hotwaxmedia.com
>

[Vivek Mishra-2]

+1. Yes I think this change won't harm anything and seems necessary
indeed to accommodate long shipping method name.

Thanks!
--
Vivek Mishra


Pranay Pandey wrote:

> Hello Devs,
>
> I want propose a change in entity GoogleCoShippingMethod.
> We should change field "shipmentMethodName" from type "id-ne" to
> "id-long-ne".
> The reason is the name of Shipping method can be longer and this will
> not be accommodated in the present one.
>
> As these changes have done before few days so I think no one will be
> using this on production and this change should not harm anything.
>
> Thoughts?
>
>
> Thanks & Regards
> --
> Pranay Pandey
> HotWax Media | www.hotwaxmedia.com
>

[Jacques Le Roux]

I can't see any problems, +1

Jacques

From: "Vivek Mishra" <[hidden email]>

> +1. Yes I think this change won't harm anything and seems necessary
> indeed to accommodate long shipping method name.
>
> Thanks!
> --
> Vivek Mishra
>
>
> Pranay Pandey wrote:
>> Hello Devs,
>>
>> I want propose a change in entity GoogleCoShippingMethod.
>> We should change field "shipmentMethodName" from type "id-ne" to
>> "id-long-ne".
>> The reason is the name of Shipping method can be longer and this will
>> not be accommodated in the present one.
>>
>> As these changes have done before few days so I think no one will be
>> using this on production and this change should not harm anything.
>>
>> Thoughts?
>>
>>
>> Thanks & Regards
>> --
>> Pranay Pandey
>> HotWax Media | www.hotwaxmedia.com
>>
>

[Ashish Vijaywargiya]

+1 from my side as well for this change.
I will do the needful if nobody has objection on it in a day or so.

Thanks Pranay for initiating this email!

--
Ashish

On Fri, Sep 25, 2009 at 6:54 PM, Jacques Le Roux <
[hidden email]> wrote:

> I can't see any problems, +1
>
> Jacques
>
> From: "Vivek Mishra" <[hidden email]>
>
>
>
>  +1. Yes I think this change won't harm anything and seems necessary indeed
>> to accommodate long shipping method name.
>>
>> Thanks!
>> --
>> Vivek Mishra
>>
>>
>> Pranay Pandey wrote:
>>
>>> Hello Devs,
>>>
>>> I want propose a change in entity GoogleCoShippingMethod.
>>> We should change field "shipmentMethodName" from type "id-ne" to
>>> "id-long-ne".
>>> The reason is the name of Shipping method can be longer and this will not
>>> be accommodated in the present one.
>>>
>>> As these changes have done before few days so I think no one will be
>>> using this on production and this change should not harm anything.
>>>
>>> Thoughts?
>>>
>>>
>>> Thanks & Regards
>>> --
>>> Pranay Pandey
>>> HotWax Media | www.hotwaxmedia.com
>>>
>>>
>>
>

[Ashish Vijaywargiya-5]

Thanks Pranay & others for voting in favor of this change - Done at r820993.

--
Regards
Ashish Vijaywargiya
HotWax Media Pvt. Ltd.
http://www.hotwaxmedia.com

Helping hand around the World ...
USA | Italy | New Zealand | India



Pranay Pandey wrote:

> Hello Devs,
>
> I want propose a change in entity GoogleCoShippingMethod.
> We should change field "shipmentMethodName" from type "id-ne" to
> "id-long-ne".
> The reason is the name of Shipping method can be longer and this will
> not be accommodated in the present one.
>
> As these changes have done before few days so I think no one will be
> using this on production and this change should not harm anything.
>
> Thoughts?
>
>
> Thanks & Regards
> --
> Pranay Pandey
> HotWax Media | www.hotwaxmedia.com
>