Purchase Order Cancel status

[Renuka Srishti-2]

Hello Devs,

This is reference to
http://markmail.org/message/wggbvdumrndpkxrj

In "applications/order/src/org/ofbiz/order/order/OrderServices.java", under
"checkItemStatus" service, there is one check for all item cancelled:

if (!"PURCHASE_ORDER".equals(orderTypeId)) {
    newStatus = "ORDER_CANCELLED";
}

I was trying to find out the reason behind it but did not get any.

When we cancel all the items of an order, Order should cancel at the header
level too. Then why we have added this special check for purchase order?

Becuase of this check, after canceling of all the items, purchase order do
not get canceled at the header level. Currently, we need to cancel the
purchase order manually.


Thanks
Renuka Srishti

[Deepak Dixit-3]

Hi Renuka,

I see no reason to keen this condition.  we can remove this.
As I know there is no business scenario around this. If all order item
cancelled than order should be cancel either its Sales or Purchase order.



Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <[hidden email]>
wrote:

> Hello Devs,
>
> This is reference to
> http://markmail.org/message/wggbvdumrndpkxrj
>
> In "applications/order/src/org/ofbiz/order/order/OrderServices.java",
> under
> "checkItemStatus" service, there is one check for all item cancelled:
>
> if (!"PURCHASE_ORDER".equals(orderTypeId)) {
>     newStatus = "ORDER_CANCELLED";
> }
>
> I was trying to find out the reason behind it but did not get any.
>
> When we cancel all the items of an order, Order should cancel at the header
> level too. Then why we have added this special check for purchase order?
>
> Becuase of this check, after canceling of all the items, purchase order do
> not get canceled at the header level. Currently, we need to cancel the
> purchase order manually.
>
>
> Thanks
> Renuka Srishti
>

[Ratnesh Upadhyay-2]

Hi Renuka,

I would also prefer to remove this condition as it's not making sense to
keep order in created status when all the order items get canceled.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit <
[hidden email]> wrote:

> Hi Renuka,
>
> I see no reason to keen this condition.  we can remove this.
> As I know there is no business scenario around this. If all order item
> cancelled than order should be cancel either its Sales or Purchase order.
>
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <[hidden email]
> >
> wrote:
>
> > Hello Devs,
> >
> > This is reference to
> > http://markmail.org/message/wggbvdumrndpkxrj
> >
> > In "applications/order/src/org/ofbiz/order/order/OrderServices.java",
> > under
> > "checkItemStatus" service, there is one check for all item cancelled:
> >
> > if (!"PURCHASE_ORDER".equals(orderTypeId)) {
> >     newStatus = "ORDER_CANCELLED";
> > }
> >
> > I was trying to find out the reason behind it but did not get any.
> >
> > When we cancel all the items of an order, Order should cancel at the
> header
> > level too. Then why we have added this special check for purchase order?
> >
> > Becuase of this check, after canceling of all the items, purchase order
> do
> > not get canceled at the header level. Currently, we need to cancel the
> > purchase order manually.
> >
> >
> > Thanks
> > Renuka Srishti
> >
>

[Mohammad Kathawala-3]

Hi,

IMO, if all the items of the order need to be canceled then the user
should/would directly cancel the order rather than canceling all the items
individually. This will automatically cancel all the items and the order at
header level. Despite this, still, if the user cancels all the items
individually then IMO the order should not get canceled automatically at
header level because after the order is canceled you cannot add new items
to it and it might be possible that user wants to add new items to the
order after canceling all the existing items. The order should be canceled
manually in this case.

Thanks.

Regards*,*
*Mohammad Kathawala* | Technical Consultant / Team Lead
*HotWax Commerce* by *HotWax Systems*
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Cell phone: [phone]

HotWax Systems recently received 8 mentions in *The Gartner Digital
Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
research and advisory company. Learn more about our research here
<https://www.gartner.com/technology/media-products/newsletters/HotWax/1-2UVLP6M/index.html>
.

On Fri, Oct 6, 2017 at 7:14 PM, Ratnesh Upadhyay <[hidden email]
> wrote:

> Hi Renuka,
>
> I would also prefer to remove this condition as it's not making sense to
> keep order in created status when all the order items get canceled.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>
> On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit <
> [hidden email]> wrote:
>
> > Hi Renuka,
> >
> > I see no reason to keen this condition.  we can remove this.
> > As I know there is no business scenario around this. If all order item
> > cancelled than order should be cancel either its Sales or Purchase order.
> >
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > www.hotwaxsystems.com
> > www.hotwax.co
> >
> > On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <
> [hidden email]
> > >
> > wrote:
> >
> > > Hello Devs,
> > >
> > > This is reference to
> > > http://markmail.org/message/wggbvdumrndpkxrj
> > >
> > > In "applications/order/src/org/ofbiz/order/order/OrderServices.java",
> > > under
> > > "checkItemStatus" service, there is one check for all item cancelled:
> > >
> > > if (!"PURCHASE_ORDER".equals(orderTypeId)) {
> > >     newStatus = "ORDER_CANCELLED";
> > > }
> > >
> > > I was trying to find out the reason behind it but did not get any.
> > >
> > > When we cancel all the items of an order, Order should cancel at the
> > header
> > > level too. Then why we have added this special check for purchase
> order?
> > >
> > > Becuase of this check, after canceling of all the items, purchase order
> > do
> > > not get canceled at the header level. Currently, we need to cancel the
> > > purchase order manually.
> > >
> > >
> > > Thanks
> > > Renuka Srishti
> > >
> >
>

[Renuka Srishti-2]

Hii Mohammad,
I agree with your points. I think we should wait for other's reply too,
then we can conclude the implementation.

Thanks
Renuka Srishti

On Fri, Oct 6, 2017 at 7:34 PM, Mohammad Kathawala <
[hidden email]> wrote:

> Hi,
>
> IMO, if all the items of the order need to be canceled then the user
> should/would directly cancel the order rather than canceling all the items
> individually. This will automatically cancel all the items and the order at
> header level. Despite this, still, if the user cancels all the items
> individually then IMO the order should not get canceled automatically at
> header level because after the order is canceled you cannot add new items
> to it and it might be possible that user wants to add new items to the
> order after canceling all the existing items. The order should be canceled
> manually in this case.
>
> Thanks.
>
> Regards*,*
> *Mohammad Kathawala* | Technical Consultant / Team Lead
> *HotWax Commerce* by *HotWax Systems*
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore,
> M.P 452010
> Cell phone: [phone]
>
> HotWax Systems recently received 8 mentions in *The Gartner Digital
> Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> research and advisory company. Learn more about our research here
> <https://www.gartner.com/technology/media-products/
> newsletters/HotWax/1-2UVLP6M/index.html>
> .
>
> On Fri, Oct 6, 2017 at 7:14 PM, Ratnesh Upadhyay <
> [hidden email]
> > wrote:
>
> > Hi Renuka,
> >
> > I would also prefer to remove this condition as it's not making sense to
> > keep order in created status when all the order items get canceled.
> >
> > Thanks!!
> >
> > Regards,
> > Ratnesh Upadhyay
> > HotWax Systems | www.hotwaxsystems.com
> >
> > On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit <
> > [hidden email]> wrote:
> >
> > > Hi Renuka,
> > >
> > > I see no reason to keen this condition.  we can remove this.
> > > As I know there is no business scenario around this. If all order item
> > > cancelled than order should be cancel either its Sales or Purchase
> order.
> > >
> > >
> > >
> > > Thanks & Regards
> > > --
> > > Deepak Dixit
> > > www.hotwaxsystems.com
> > > www.hotwax.co
> > >
> > > On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <
> > [hidden email]
> > > >
> > > wrote:
> > >
> > > > Hello Devs,
> > > >
> > > > This is reference to
> > > > http://markmail.org/message/wggbvdumrndpkxrj
> > > >
> > > > In "applications/order/src/org/ofbiz/order/order/
> OrderServices.java",
> > > > under
> > > > "checkItemStatus" service, there is one check for all item cancelled:
> > > >
> > > > if (!"PURCHASE_ORDER".equals(orderTypeId)) {
> > > >     newStatus = "ORDER_CANCELLED";
> > > > }
> > > >
> > > > I was trying to find out the reason behind it but did not get any.
> > > >
> > > > When we cancel all the items of an order, Order should cancel at the
> > > header
> > > > level too. Then why we have added this special check for purchase
> > order?
> > > >
> > > > Becuase of this check, after canceling of all the items, purchase
> order
> > > do
> > > > not get canceled at the header level. Currently, we need to cancel
> the
> > > > purchase order manually.
> > > >
> > > >
> > > > Thanks
> > > > Renuka Srishti
> > > >
> > >
> >
>

[Arun Patidar-2]

IMO, we should keep SO and PO consistent in this workflow. Also, there is
less chance to add item after canceling all item.  To keep order status
sync with items, we should cancel the order if all items have been canceled.



--
Thanks & Regards
---
Arun Patidar
Manager, Enterprise Software Development

HotWax Systems Pvt Ltd.

www.hotwaxsystems.com


On Mon, Oct 9, 2017 at 2:36 PM, Renuka Srishti <[hidden email]>
wrote:

> Hii Mohammad,
> I agree with your points. I think we should wait for other's reply too,
> then we can conclude the implementation.
>
> Thanks
> Renuka Srishti
>
> On Fri, Oct 6, 2017 at 7:34 PM, Mohammad Kathawala <
> [hidden email]> wrote:
>
> > Hi,
> >
> > IMO, if all the items of the order need to be canceled then the user
> > should/would directly cancel the order rather than canceling all the
> items
> > individually. This will automatically cancel all the items and the order
> at
> > header level. Despite this, still, if the user cancels all the items
> > individually then IMO the order should not get canceled automatically at
> > header level because after the order is canceled you cannot add new items
> > to it and it might be possible that user wants to add new items to the
> > order after canceling all the existing items. The order should be
> canceled
> > manually in this case.
> >
> > Thanks.
> >
> > Regards*,*
> > *Mohammad Kathawala* | Technical Consultant / Team Lead
> > *HotWax Commerce* by *HotWax Systems*
> > Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> > Indore,
> > M.P 452010
> > Cell phone: [phone]
> >
> > HotWax Systems recently received 8 mentions in *The Gartner Digital
> > Commerce Vendor Guide, 2016 *by Gartner, Inc., the world's leading IT
> > research and advisory company. Learn more about our research here
> > <https://www.gartner.com/technology/media-products/
> > newsletters/HotWax/1-2UVLP6M/index.html>
> > .
> >
> > On Fri, Oct 6, 2017 at 7:14 PM, Ratnesh Upadhyay <
> > [hidden email]
> > > wrote:
> >
> > > Hi Renuka,
> > >
> > > I would also prefer to remove this condition as it's not making sense
> to
> > > keep order in created status when all the order items get canceled.
> > >
> > > Thanks!!
> > >
> > > Regards,
> > > Ratnesh Upadhyay
> > > HotWax Systems | www.hotwaxsystems.com
> > >
> > > On Fri, Oct 6, 2017 at 12:52 PM, Deepak Dixit <
> > > [hidden email]> wrote:
> > >
> > > > Hi Renuka,
> > > >
> > > > I see no reason to keen this condition.  we can remove this.
> > > > As I know there is no business scenario around this. If all order
> item
> > > > cancelled than order should be cancel either its Sales or Purchase
> > order.
> > > >
> > > >
> > > >
> > > > Thanks & Regards
> > > > --
> > > > Deepak Dixit
> > > > www.hotwaxsystems.com
> > > > www.hotwax.co
> > > >
> > > > On Thu, Oct 5, 2017 at 7:17 PM, Renuka Srishti <
> > > [hidden email]
> > > > >
> > > > wrote:
> > > >
> > > > > Hello Devs,
> > > > >
> > > > > This is reference to
> > > > > http://markmail.org/message/wggbvdumrndpkxrj
> > > > >
> > > > > In "applications/order/src/org/ofbiz/order/order/
> > OrderServices.java",
> > > > > under
> > > > > "checkItemStatus" service, there is one check for all item
> cancelled:
> > > > >
> > > > > if (!"PURCHASE_ORDER".equals(orderTypeId)) {
> > > > >     newStatus = "ORDER_CANCELLED";
> > > > > }
> > > > >
> > > > > I was trying to find out the reason behind it but did not get any.
> > > > >
> > > > > When we cancel all the items of an order, Order should cancel at
> the
> > > > header
> > > > > level too. Then why we have added this special check for purchase
> > > order?
> > > > >
> > > > > Becuase of this check, after canceling of all the items, purchase
> > order
> > > > do
> > > > > not get canceled at the header level. Currently, we need to cancel
> > the
> > > > > purchase order manually.
> > > > >
> > > > >
> > > > > Thanks
> > > > > Renuka Srishti
> > > > >
> > > >
> > >
> >
>

[Jacques Le Roux]

Hi Renuka,

It seems to have slipped in with http://svn.apache.org/viewvc?view=revision&revision=1026520

I see no reason to keep it

Jacques


Le 05/10/2017 à 15:47, Renuka Srishti a écrit :

> Hello Devs,
>
> This is reference to
> http://markmail.org/message/wggbvdumrndpkxrj
>
> In "applications/order/src/org/ofbiz/order/order/OrderServices.java", under
> "checkItemStatus" service, there is one check for all item cancelled:
>
> if (!"PURCHASE_ORDER".equals(orderTypeId)) {
>      newStatus = "ORDER_CANCELLED";
> }
>
> I was trying to find out the reason behind it but did not get any.
>
> When we cancel all the items of an order, Order should cancel at the header
> level too. Then why we have added this special check for purchase order?
>
> Becuase of this check, after canceling of all the items, purchase order do
> not get canceled at the header level. Currently, we need to cancel the
> purchase order manually.
>
>
> Thanks
> Renuka Srishti
>

[Suraj Khurana]

Thanks Renuka for bringing this into notice.

I also agree with Arun's point

--
Best Regards,
*Suraj Khurana* | Sr. Enterprise Software Engineer
*HotWax Commerce * by  *HotWax Systems*
Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010


On Mon, Oct 9, 2017 at 3:13 PM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Renuka,
>
> It seems to have slipped in with http://svn.apache.org/viewvc?v
> iew=revision&revision=1026520
>
> I see no reason to keep it
>
> Jacques
>
>
>
> Le 05/10/2017 à 15:47, Renuka Srishti a écrit :
>
>> Hello Devs,
>>
>> This is reference to
>> http://markmail.org/message/wggbvdumrndpkxrj
>>
>> In "applications/order/src/org/ofbiz/order/order/OrderServices.java",
>> under
>> "checkItemStatus" service, there is one check for all item cancelled:
>>
>> if (!"PURCHASE_ORDER".equals(orderTypeId)) {
>>      newStatus = "ORDER_CANCELLED";
>> }
>>
>> I was trying to find out the reason behind it but did not get any.
>>
>> When we cancel all the items of an order, Order should cancel at the
>> header
>> level too. Then why we have added this special check for purchase order?
>>
>> Becuase of this check, after canceling of all the items, purchase order do
>> not get canceled at the header level. Currently, we need to cancel the
>> purchase order manually.
>>
>>
>> Thanks
>> Renuka Srishti
>>
>>
>

[Renuka Srishti-2]

To make SO and PO flow consistent and to maintain order header status with
its item status. Removed the condition, patch attached in OFBIZ-9838
<https://issues.apache.org/jira/browse/OFBIZ-9838>

Thanks
Renuka Srishti

On Mon, Oct 9, 2017 at 3:20 PM, Suraj Khurana <
[hidden email]> wrote:

> Thanks Renuka for bringing this into notice.
>
> I also agree with Arun's point
>
> --
> Best Regards,
> *Suraj Khurana* | Sr. Enterprise Software Engineer
> *HotWax Commerce * by  *HotWax Systems*
> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
>
>
> On Mon, Oct 9, 2017 at 3:13 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
> > Hi Renuka,
> >
> > It seems to have slipped in with http://svn.apache.org/viewvc?v
> > iew=revision&revision=1026520
> >
> > I see no reason to keep it
> >
> > Jacques
> >
> >
> >
> > Le 05/10/2017 à 15:47, Renuka Srishti a écrit :
> >
> >> Hello Devs,
> >>
> >> This is reference to
> >> http://markmail.org/message/wggbvdumrndpkxrj
> >>
> >> In "applications/order/src/org/ofbiz/order/order/OrderServices.java",
> >> under
> >> "checkItemStatus" service, there is one check for all item cancelled:
> >>
> >> if (!"PURCHASE_ORDER".equals(orderTypeId)) {
> >>      newStatus = "ORDER_CANCELLED";
> >> }
> >>
> >> I was trying to find out the reason behind it but did not get any.
> >>
> >> When we cancel all the items of an order, Order should cancel at the
> >> header
> >> level too. Then why we have added this special check for purchase order?
> >>
> >> Becuase of this check, after canceling of all the items, purchase order
> do
> >> not get canceled at the header level. Currently, we need to cancel the
> >> purchase order manually.
> >>
> >>
> >> Thanks
> >> Renuka Srishti
> >>
> >>
> >
>

[Jacques Le Roux]

Le 09/10/2017 à 11:10, Arun Patidar a écrit :
> IMO, we should keep SO and PO consistent in this workflow. Also, there is
> less chance to add item after canceling all item.  To keep order status
> sync with items, we should cancel the order if all items have been canceled.
>
Agreed, better to create a new order than adding on an all cancelled order

Jacques