Just curious, but what do we want to get into the ml from github?
If infra needs to be involved for modifications, then we better have lost of action items ready. Mvg Pierre Op wo 20 mei 2020 19:13 schreef Pawan Verma <[hidden email]>: > Hey Jacques, Pierre > > Yes, I also feel it's useless and annoying. IMO If we can mute this > notification, it would be a great thing. > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Wed, May 20, 2020 at 9:39 PM Pierre Smits <[hidden email]> > wrote: > > > Not an issue. At least here, as I filter those out in my mail client. > > > > Met vriendelijke groet, > > > > Pierre Smits > > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > since > > 2008 (without privileges) > > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > > *Apache Directory <https://directory.apache.org>, PMC Member* > > Apache Incubator <https://incubator.apache.org>, committer > > Apache Steve <https://steve.apache.org>, committer > > > > > > On Wed, May 20, 2020 at 5:17 PM Jacques Le Roux < > > [hidden email]> wrote: > > > > > Hi All, > > > > > > Do we have to suffer the comment then removed all time? > > > > > > It uselessly clutters the email boxes, isn't? > > > > > > Thanks > > > > > > Jacques > > > > > > Le 20/05/2020 à 14:31, GitBox a écrit : > > > > sonarcloud[bot] removed a comment on pull request #117: > > > > URL: > > > > > > https://github.com/apache/ofbiz-framework/pull/117#issuecomment-630424349 > > > > > > > > > > > > Kudos, SonarCloud Quality Gate passed! > > > > > > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png > > ' > > > alt='Bug' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > ) > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > ' > > > alt='A' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > ) > > > [0 Bugs]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > > ) > > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png > > ' > > > alt='Vulnerability' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > ) > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > ' > > > alt='A' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > ) > > > [0 Vulnerabilities]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > ) > > > (and [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png > > ' > > > alt='Security Hotspot' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT > > ) > > > [0 Security Hotspots](https://sonarcloud.io/project/issue > > > > > > > > > > s?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT) > > > to review) > > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png > > ' > > > alt='Code Smell' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > ) > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > ' > > > alt='A' width='16' height='16' />]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > ) > > > [0 Code Smells]( > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > > ) > > > > > > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png > > ' > > > alt='No Coverage information' width='16' height='16' />]( > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117 > > ) > > > No Coverage information > > > > [<img src=' > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png > > ' > > > alt='0.0%' width='16' height='16' />]( > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list > > ) > > > [0.0% Duplication]( > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list > > > ) > > > > > > > > > > > > > > > > > > > > ---------------------------------------------------------------- > > > > This is an automated message from the Apache Git Service. > > > > To respond to the message, please log on to GitHub and use the > > > > URL above to go to the specific comment. > > > > > > > > For queries about this service, please contact Infrastructure at: > > > > [hidden email] > > > > > > > > > > > > > > > > > |
Hi Pierre,
For me, this one is good --> Kudos, SonarCloud Quality Gate passed! This one seems to be useless --> sonarcloud[bot] removed a comment on pull request -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Wed, May 20, 2020 at 11:02 PM Pierre Smits <[hidden email]> wrote: > Just curious, but what do we want to get into the ml from github? > > If infra needs to be involved for modifications, then we better have lost > of action items ready. > > Mvg > > Pierre > > Op wo 20 mei 2020 19:13 schreef Pawan Verma <[hidden email] > >: > > > Hey Jacques, Pierre > > > > Yes, I also feel it's useless and annoying. IMO If we can mute this > > notification, it would be a great thing. > > -- > > Thanks & Regards > > Pawan Verma > > Technical Consultant > > *HotWax Systems* > > *Enterprise open source experts* > > http://www.hotwaxsystems.com > > > > > > On Wed, May 20, 2020 at 9:39 PM Pierre Smits <[hidden email]> > > wrote: > > > > > Not an issue. At least here, as I filter those out in my mail client. > > > > > > Met vriendelijke groet, > > > > > > Pierre Smits > > > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > > since > > > 2008 (without privileges) > > > > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > > > *Apache Directory <https://directory.apache.org>, PMC Member* > > > Apache Incubator <https://incubator.apache.org>, committer > > > Apache Steve <https://steve.apache.org>, committer > > > > > > > > > On Wed, May 20, 2020 at 5:17 PM Jacques Le Roux < > > > [hidden email]> wrote: > > > > > > > Hi All, > > > > > > > > Do we have to suffer the comment then removed all time? > > > > > > > > It uselessly clutters the email boxes, isn't? > > > > > > > > Thanks > > > > > > > > Jacques > > > > > > > > Le 20/05/2020 à 14:31, GitBox a écrit : > > > > > sonarcloud[bot] removed a comment on pull request #117: > > > > > URL: > > > > > > > > > > https://github.com/apache/ofbiz-framework/pull/117#issuecomment-630424349 > > > > > > > > > > > > > > > Kudos, SonarCloud Quality Gate passed! > > > > > > > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png > > > ' > > > > alt='Bug' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > > ) > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > > ' > > > > alt='A' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > > ) > > > > [0 Bugs]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=BUG > > > > ) > > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png > > > ' > > > > alt='Vulnerability' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > > ) > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > > ' > > > > alt='A' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > > ) > > > > [0 Vulnerabilities]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=VULNERABILITY > > > ) > > > > (and [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png > > > ' > > > > alt='Security Hotspot' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT > > > ) > > > > [0 Security Hotspots](https://sonarcloud.io/project/issue > > > > > > > > > > > > > > > s?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=SECURITY_HOTSPOT) > > > > to review) > > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png > > > ' > > > > alt='Code Smell' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > > ) > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png > > > ' > > > > alt='A' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > > ) > > > > [0 Code Smells]( > > > > > > > > > > https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=117&resolved=false&types=CODE_SMELL > > > > ) > > > > > > > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png > > > ' > > > > alt='No Coverage information' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117 > > > ) > > > > No Coverage information > > > > > [<img src=' > > > > > > > > > > https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png > > > ' > > > > alt='0.0%' width='16' height='16' />]( > > > > > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list > > > ) > > > > [0.0% Duplication]( > > > > > > > > > > https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=117&metric=new_duplicated_lines_density&view=list > > > > ) > > > > > > > > > > > > > > > > > > > > > > > > > ---------------------------------------------------------------- > > > > > This is an automated message from the Apache Git Service. > > > > > To respond to the message, please log on to GitHub and use the > > > > > URL above to go to the specific comment. > > > > > > > > > > For queries about this service, please contact Infrastructure at: > > > > > [hidden email] > > > > > > > > > > > > > > > > > > > > > > > > |
Administrator
|
For me both are useless, I have never seen a SonarCloud Quality Gate not passing and this information is visible on the PR before pushing it
BTW is a PR pushable if the SonarCloud tests don't pass? I could filter them, but by experience I tend to privilege cutting at root. Because maintainer email filters is not my cup of tea. Jacques Le 20/05/2020 à 19:54, Pawan Verma a écrit : > Hi Pierre, > > For me, this one is good --> Kudos, SonarCloud Quality Gate passed! > > This one seems to be useless --> sonarcloud[bot] removed a comment on pull > request |
It happened to me a few times that a PR didn't pass the quality gates of
SonarCloud. And it helped me to correct the situation on a next push RE: BTW is a PR pushable if the SonarCloud tests don't pass? SonarCloud tests are done AFTER the PR is created. Then it checks on every commit coming in from where the PR was originated. Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux < [hidden email]> wrote: > For me both are useless, I have never seen a SonarCloud Quality Gate not > passing and this information is visible on the PR before pushing it > > BTW is a PR pushable if the SonarCloud tests don't pass? > > I could filter them, but by experience I tend to privilege cutting at > root. Because maintainer email filters is not my cup of tea. > > Jacques > > Le 20/05/2020 à 19:54, Pawan Verma a écrit : > > Hi Pierre, > > > > For me, this one is good --> Kudos, SonarCloud Quality Gate passed! > > > > This one seems to be useless --> sonarcloud[bot] removed a comment on > pull > > request > > |
Administrator
|
Actually we have also this information nicely coming to ofbiz-*@noreply.github.com
So we don't need the ugly couples (added then removed) at [hidden email] If nobody disagree I'll see if Infra can do something about that in a week... Jacques Le 20/05/2020 à 20:24, Pierre Smits a écrit : > It happened to me a few times that a PR didn't pass the quality gates of > SonarCloud. And it helped me to correct the situation on a next push > > RE: BTW is a PR pushable if the SonarCloud tests don't pass? > SonarCloud tests are done AFTER the PR is created. Then it checks on every > commit coming in from where the PR was originated. > > Met vriendelijke groet, > > Pierre Smits > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since > 2008 (without privileges) > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > *Apache Directory <https://directory.apache.org>, PMC Member* > Apache Incubator <https://incubator.apache.org>, committer > Apache Steve <https://steve.apache.org>, committer > > > On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux < > [hidden email]> wrote: > >> For me both are useless, I have never seen a SonarCloud Quality Gate not >> passing and this information is visible on the PR before pushing it >> >> BTW is a PR pushable if the SonarCloud tests don't pass? >> >> I could filter them, but by experience I tend to privilege cutting at >> root. Because maintainer email filters is not my cup of tea. >> >> Jacques >> >> Le 20/05/2020 à 19:54, Pawan Verma a écrit : >>> Hi Pierre, >>> >>> For me, this one is good --> Kudos, SonarCloud Quality Gate passed! >>> >>> This one seems to be useless --> sonarcloud[bot] removed a comment on >> pull >>> request >> |
Thanks Jacques, forellen staking care of thuis.
Op za 23 mei 2020 11:28 schreef Jacques Le Roux < [hidden email]>: > Actually we have also this information nicely coming to ofbiz-*@ > noreply.github.com > > So we don't need the ugly couples (added then removed) at > [hidden email] > > If nobody disagree I'll see if Infra can do something about that in a > week... > > Jacques > > Le 20/05/2020 à 20:24, Pierre Smits a écrit : > > It happened to me a few times that a PR didn't pass the quality gates of > > SonarCloud. And it helped me to correct the situation on a next push > > > > RE: BTW is a PR pushable if the SonarCloud tests don't pass? > > SonarCloud tests are done AFTER the PR is created. Then it checks on > every > > commit coming in from where the PR was originated. > > > > Met vriendelijke groet, > > > > Pierre Smits > > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> > since > > 2008 (without privileges) > > > > *Apache Trafodion <https://trafodion.apache.org>, Vice President* > > *Apache Directory <https://directory.apache.org>, PMC Member* > > Apache Incubator <https://incubator.apache.org>, committer > > Apache Steve <https://steve.apache.org>, committer > > > > > > On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux < > > [hidden email]> wrote: > > > >> For me both are useless, I have never seen a SonarCloud Quality Gate not > >> passing and this information is visible on the PR before pushing it > >> > >> BTW is a PR pushable if the SonarCloud tests don't pass? > >> > >> I could filter them, but by experience I tend to privilege cutting at > >> root. Because maintainer email filters is not my cup of tea. > >> > >> Jacques > >> > >> Le 20/05/2020 à 19:54, Pawan Verma a écrit : > >>> Hi Pierre, > >>> > >>> For me, this one is good --> Kudos, SonarCloud Quality Gate passed! > >>> > >>> This one seems to be useless --> sonarcloud[bot] removed a comment on > >> pull > >>> request > >> > |
Administrator
|
I created INFRA-20331 for that
Jacques Le 23/05/2020 à 11:34, Pierre Smits a écrit : > Thanks Jacques, forellen staking care of thuis. > > Op za 23 mei 2020 11:28 schreef Jacques Le Roux < > [hidden email]>: > >> Actually we have also this information nicely coming to ofbiz-*@ >> noreply.github.com >> >> So we don't need the ugly couples (added then removed) at >> [hidden email] >> >> If nobody disagree I'll see if Infra can do something about that in a >> week... >> >> Jacques >> >> Le 20/05/2020 à 20:24, Pierre Smits a écrit : >>> It happened to me a few times that a PR didn't pass the quality gates of >>> SonarCloud. And it helped me to correct the situation on a next push >>> >>> RE: BTW is a PR pushable if the SonarCloud tests don't pass? >>> SonarCloud tests are done AFTER the PR is created. Then it checks on >> every >>> commit coming in from where the PR was originated. >>> >>> Met vriendelijke groet, >>> >>> Pierre Smits >>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> >> since >>> 2008 (without privileges) >>> >>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >>> *Apache Directory <https://directory.apache.org>, PMC Member* >>> Apache Incubator <https://incubator.apache.org>, committer >>> Apache Steve <https://steve.apache.org>, committer >>> >>> >>> On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux < >>> [hidden email]> wrote: >>> >>>> For me both are useless, I have never seen a SonarCloud Quality Gate not >>>> passing and this information is visible on the PR before pushing it >>>> >>>> BTW is a PR pushable if the SonarCloud tests don't pass? >>>> >>>> I could filter them, but by experience I tend to privilege cutting at >>>> root. Because maintainer email filters is not my cup of tea. >>>> >>>> Jacques >>>> >>>> Le 20/05/2020 à 19:54, Pawan Verma a écrit : >>>>> Hi Pierre, >>>>> >>>>> For me, this one is good --> Kudos, SonarCloud Quality Gate passed! >>>>> >>>>> This one seems to be useless --> sonarcloud[bot] removed a comment on >>>> pull >>>>> request |
Administrator
|
I think this will never happen, let's see...
Le 27/05/2020 à 09:16, Jacques Le Roux a écrit : > I created INFRA-20331 for that > > Jacques > > Le 23/05/2020 à 11:34, Pierre Smits a écrit : >> Thanks Jacques, forellen staking care of thuis. >> >> Op za 23 mei 2020 11:28 schreef Jacques Le Roux < >> [hidden email]>: >> >>> Actually we have also this information nicely coming to ofbiz-*@ >>> noreply.github.com >>> >>> So we don't need the ugly couples (added then removed) at >>> [hidden email] >>> >>> If nobody disagree I'll see if Infra can do something about that in a >>> week... >>> >>> Jacques >>> >>> Le 20/05/2020 à 20:24, Pierre Smits a écrit : >>>> It happened to me a few times that a PR didn't pass the quality gates of >>>> SonarCloud. And it helped me to correct the situation on a next push >>>> >>>> RE: BTW is a PR pushable if the SonarCloud tests don't pass? >>>> SonarCloud tests are done AFTER the PR is created. Then it checks on >>> every >>>> commit coming in from where the PR was originated. >>>> >>>> Met vriendelijke groet, >>>> >>>> Pierre Smits >>>> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> >>> since >>>> 2008 (without privileges) >>>> >>>> *Apache Trafodion <https://trafodion.apache.org>, Vice President* >>>> *Apache Directory <https://directory.apache.org>, PMC Member* >>>> Apache Incubator <https://incubator.apache.org>, committer >>>> Apache Steve <https://steve.apache.org>, committer >>>> >>>> >>>> On Wed, May 20, 2020 at 8:15 PM Jacques Le Roux < >>>> [hidden email]> wrote: >>>> >>>>> For me both are useless, I have never seen a SonarCloud Quality Gate not >>>>> passing and this information is visible on the PR before pushing it >>>>> >>>>> BTW is a PR pushable if the SonarCloud tests don't pass? >>>>> >>>>> I could filter them, but by experience I tend to privilege cutting at >>>>> root. Because maintainer email filters is not my cup of tea. >>>>> >>>>> Jacques >>>>> >>>>> Le 20/05/2020 à 19:54, Pawan Verma a écrit : >>>>>> Hi Pierre, >>>>>> >>>>>> For me, this one is good --> Kudos, SonarCloud Quality Gate passed! >>>>>> >>>>>> This one seems to be useless --> sonarcloud[bot] removed a comment on >>>>> pull >>>>>> request > |
Free forum by Nabble | Edit this page |