Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 278

[Michael Brohl-3]

Hi James,

the commit contains more changes than mentioned in the  commit message.

It would be more transparent to separate those changes in separate
commits to make it more clear and easier for reviewers.

Thanks,

Michael Brohl

ecomify GmbH - www.ecomify.de


Am 21.01.21 um 14:22 schrieb [hidden email]:

> This is an automated email from the ASF dual-hosted git repository.
>
> jamesyong pushed a commit to branch trunk
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/trunk by this push:
>       new b679d36  Improved: Updated tasks.checkstyleMain.maxErrors to 278
> b679d36 is described below
>
> commit b679d36b492b23fc0a5797e9a637f5924aa0cba8
> Author: James Yong <[hidden email]>
> AuthorDate: Thu Jan 21 21:21:54 2021 +0800
>
>      Improved: Updated tasks.checkstyleMain.maxErrors to 278
> ---
>   build.gradle                                                            | 2 +-
>   framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java | 2 +-
>   .../base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java     | 2 +-
>   .../src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java   | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/build.gradle b/build.gradle
> index 139f526..56a1dc2 100644
> --- a/build.gradle
> +++ b/build.gradle
> @@ -296,7 +296,7 @@ checkstyle {
>       // the sum of errors found last time it was changed after using the
>       // ‘checkstyle’ tool present in the framework and in the official
>       // plugins.
> -    tasks.checkstyleMain.maxErrors = 279
> +    tasks.checkstyleMain.maxErrors = 278
>       // Currently there are a lot of errors so we need to temporarily
>       // hide them to avoid polluting the terminal output.
>       showViolations = false
> diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> index 4af9c74..15a6bc7 100644
> --- a/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> +++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> @@ -40,7 +40,7 @@ import org.apache.commons.codec.binary.Hex;
>    * Misc String Utility Functions
>    *
>    */
> -public class StringUtil {
> +public final class StringUtil {
>  
>       public static final StringUtil INSTANCE = new StringUtil();
>       private static final String MODULE = StringUtil.class.getName();
> diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> index d91187e..85db461 100644
> --- a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> +++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> @@ -1299,4 +1299,4 @@ public final class UtilValidate {
>           }
>           return isValid;
>       }
> -}
> \ No newline at end of file
> +}
> diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> index 6784926..3bf5632 100644
> --- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> +++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> @@ -79,7 +79,7 @@ import org.apache.ofbiz.widget.model.ThemeFactory;
>   /**
>    * RequestHandler - Request Processor Object
>    */
> -public class RequestHandler {
> +public final class RequestHandler {
>  
>       private static final String MODULE = RequestHandler.class.getName();
>       private final ViewFactory viewFactory;
>

[James Yong-2]

Hi Michael,

This commit is related to fixing checkstyle errors. Fixed 3 and updated
tasks.checkstyleMain.maxErrors from 279 to 278.

Regards,
James

On 2021/01/21 13:45:59, Michael Brohl <[hidden email]> wrote:

> Hi James,
>
> the commit contains more changes than mentioned in the  commit message.
>
> It would be more transparent to separate those changes in separate
> commits to make it more clear and easier for reviewers.
>
> Thanks,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 21.01.21 um 14:22 schrieb [hidden email]:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > jamesyong pushed a commit to branch trunk
> > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >
> >
> > The following commit(s) were added to refs/heads/trunk by this push:
> >       new b679d36  Improved: Updated tasks.checkstyleMain.maxErrors to 278
> > b679d36 is described below
> >
> > commit b679d36b492b23fc0a5797e9a637f5924aa0cba8
> > Author: James Yong <[hidden email]>
> > AuthorDate: Thu Jan 21 21:21:54 2021 +0800
> >
> >      Improved: Updated tasks.checkstyleMain.maxErrors to 278
> > ---
> >   build.gradle                                                            | 2 +-
> >   framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java | 2 +-
> >   .../base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java     | 2 +-
> >   .../src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java   | 2 +-
> >   4 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/build.gradle b/build.gradle
> > index 139f526..56a1dc2 100644
> > --- a/build.gradle
> > +++ b/build.gradle
> > @@ -296,7 +296,7 @@ checkstyle {
> >       // the sum of errors found last time it was changed after using the
> >       // ‘checkstyle’ tool present in the framework and in the official
> >       // plugins.
> > -    tasks.checkstyleMain.maxErrors = 279
> > +    tasks.checkstyleMain.maxErrors = 278
> >       // Currently there are a lot of errors so we need to temporarily
> >       // hide them to avoid polluting the terminal output.
> >       showViolations = false
> > diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> > index 4af9c74..15a6bc7 100644
> > --- a/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> > +++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/StringUtil.java
> > @@ -40,7 +40,7 @@ import org.apache.commons.codec.binary.Hex;
> >    * Misc String Utility Functions
> >    *
> >    */
> > -public class StringUtil {
> > +public final class StringUtil {
> >  
> >       public static final StringUtil INSTANCE = new StringUtil();
> >       private static final String MODULE = StringUtil.class.getName();
> > diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> > index d91187e..85db461 100644
> > --- a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> > +++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java
> > @@ -1299,4 +1299,4 @@ public final class UtilValidate {
> >           }
> >           return isValid;
> >       }
> > -}
> > \ No newline at end of file
> > +}
> > diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> > index 6784926..3bf5632 100644
> > --- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> > +++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
> > @@ -79,7 +79,7 @@ import org.apache.ofbiz.widget.model.ThemeFactory;
> >   /**
> >    * RequestHandler - Request Processor Object
> >    */
> > -public class RequestHandler {
> > +public final class RequestHandler {
> >  
> >       private static final String MODULE = RequestHandler.class.getName();
> >       private final ViewFactory viewFactory;
> >
>

[Michael Brohl-3]

Hi James,

I see. It was not clear from the commit message that you fixed
checkstyle errors and then reduced the count.

I could have recognized it, though.

Thanks,

Michael


Am 22.01.21 um 04:21 schrieb James Yong:
> -public class StringUtil {
> +public final class StringUtil {