Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
Locked
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
 
|
Hi Hans,
could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? I am asking you this because, even if I don't know much about this area of the data model, from what I understand: - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. Kind regards, Jacopo On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: > Author: hansbak > Date: Fri Jan 14 08:40:01 2011 > New Revision: 1058891 > > URL: http://svn.apache.org/viewvc?rev=1058891&view=rev > Log: > made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing > > Modified: > ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > > Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) > +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 > @@ -153,5 +153,17 @@ under the License. > > <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> > <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> > + > + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> > + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> > + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> > + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> > + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> > + > + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> > + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> > + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> > + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> > + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> > > </entity-engine-xml> > > Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) > +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 > @@ -164,15 +164,13 @@ under the License. > <entity entity-name="PerfReviewItem" > package-name="org.ofbiz.humanres.ability" > title="Performance Review Item Entity"> > - <field name="employeePartyId" type="id-ne"></field> > - <field name="employeeRoleTypeId" type="id"></field> > <field name="perfReviewId" type="id-ne"></field> > <field name="perfReviewItemSeqId" type="id-ne"></field> > <field name="perfRatingTypeId" type="id"></field> > <field name="perfReviewItemTypeId" type="id"></field> > + <field name="employeePartyId" type="id-ne"></field> > + <field name="employeeRoleTypeId" type="id"></field> > <field name="comments" type="comment"></field> > - <prim-key field="employeePartyId"/> > - <prim-key field="employeeRoleTypeId"/> > <prim-key field="perfReviewId"/> > <prim-key field="perfReviewItemSeqId"/> > <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> > > Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) > +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 > @@ -216,6 +216,7 @@ under the License. > </condition> > <widgets> > <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> > + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> > </widgets> > </section> > <decorator-section-include name="body"/> > > Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) > +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 > @@ -122,6 +122,11 @@ > </menu> > <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" > type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> > + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> > + <link target="EditPerfReview"> > + <parameter param-name="perfReviewId"/> > + </link> > + </menu-item> > <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> > <link target="EditPerfReviewItems"> > <parameter param-name="perfReviewId"/> > > Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) > +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 > @@ -62,7 +62,7 @@ > <entity-one entity-name="PerfReview" value-field="perfReview"/> > </actions> > <widgets> > - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> > + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> > <decorator-section name="body"> > <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> > <section> > > Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > ============================================================================== > --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) > +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 > @@ -101,7 +101,7 @@ under the License. > <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" > header-row-style="header-row" default-table-style="basic-table"> > <auto-fields-service service-name="createPerfReviewItem"/> > - <field name="perfReviewId"><hidden/></field> > + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> > <field name="perfReviewItemSeqId"><ignored/></field> > <field name="employeePartyId"><hidden/></field> > <field name="employeeRoleTypeId"><hidden/></field> > > |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
I changed this entity according the datamodel resource boook and what
the forms and services where expecting, please note the fields were not added or removed on the forms. Regards, Hans On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote: > Hi Hans, > > could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? > I am asking you this because, even if I don't know much about this area of the data model, from what I understand: > - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) > - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) > > I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. > > Kind regards, > > Jacopo > > On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: > > > Author: hansbak > > Date: Fri Jan 14 08:40:01 2011 > > New Revision: 1058891 > > > > URL: http://svn.apache.org/viewvc?rev=1058891&view=rev > > Log: > > made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing > > > > Modified: > > ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > > ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > > ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > > ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > > ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > > ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > > > > Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) > > +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 > > @@ -153,5 +153,17 @@ under the License. > > > > <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> > > <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> > > + > > + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> > > + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> > > + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> > > + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> > > + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> > > + > > + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> > > + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> > > + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> > > + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> > > + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> > > > > </entity-engine-xml> > > > > Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) > > +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 > > @@ -164,15 +164,13 @@ under the License. > > <entity entity-name="PerfReviewItem" > > package-name="org.ofbiz.humanres.ability" > > title="Performance Review Item Entity"> > > - <field name="employeePartyId" type="id-ne"></field> > > - <field name="employeeRoleTypeId" type="id"></field> > > <field name="perfReviewId" type="id-ne"></field> > > <field name="perfReviewItemSeqId" type="id-ne"></field> > > <field name="perfRatingTypeId" type="id"></field> > > <field name="perfReviewItemTypeId" type="id"></field> > > + <field name="employeePartyId" type="id-ne"></field> > > + <field name="employeeRoleTypeId" type="id"></field> > > <field name="comments" type="comment"></field> > > - <prim-key field="employeePartyId"/> > > - <prim-key field="employeeRoleTypeId"/> > > <prim-key field="perfReviewId"/> > > <prim-key field="perfReviewItemSeqId"/> > > <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> > > > > Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 > > @@ -216,6 +216,7 @@ under the License. > > </condition> > > <widgets> > > <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> > > + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> > > </widgets> > > </section> > > <decorator-section-include name="body"/> > > > > Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 > > @@ -122,6 +122,11 @@ > > </menu> > > <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" > > type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> > > + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> > > + <link target="EditPerfReview"> > > + <parameter param-name="perfReviewId"/> > > + </link> > > + </menu-item> > > <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> > > <link target="EditPerfReviewItems"> > > <parameter param-name="perfReviewId"/> > > > > Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 > > @@ -62,7 +62,7 @@ > > <entity-one entity-name="PerfReview" value-field="perfReview"/> > > </actions> > > <widgets> > > - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> > > + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> > > <decorator-section name="body"> > > <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> > > <section> > > > > Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 > > @@ -101,7 +101,7 @@ under the License. > > <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" > > header-row-style="header-row" default-table-style="basic-table"> > > <auto-fields-service service-name="createPerfReviewItem"/> > > - <field name="perfReviewId"><hidden/></field> > > + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> > > <field name="perfReviewItemSeqId"><ignored/></field> > > <field name="employeePartyId"><hidden/></field> > > <field name="employeeRoleTypeId"><hidden/></field> > > > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
In reply to this post by Jacopo Cappellato-4
Ok i did not see the unusual index of the PerfRreview too: which
includes the employeeId and role. This is also not according the dataresource book. I would even suggest to take the employeeparty and role out of this key too and follow the general pattern that the perfReview entity has a single key field perfReviewId. Thanks for commenting on this. Regards, Hans On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote: > Hi Hans, > > could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? > I am asking you this because, even if I don't know much about this area of the data model, from what I understand: > - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) > - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) > > I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. > > Kind regards, > > Jacopo > > On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: > > > Author: hansbak > > Date: Fri Jan 14 08:40:01 2011 > > New Revision: 1058891 > > > > URL: http://svn.apache.org/viewvc?rev=1058891&view=rev > > Log: > > made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing > > > > Modified: > > ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > > ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > > ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > > ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > > ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > > ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > > > > Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) > > +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 > > @@ -153,5 +153,17 @@ under the License. > > > > <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> > > <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> > > + > > + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> > > + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> > > + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> > > + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> > > + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> > > + > > + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> > > + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> > > + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> > > + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> > > + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> > > > > </entity-engine-xml> > > > > Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) > > +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 > > @@ -164,15 +164,13 @@ under the License. > > <entity entity-name="PerfReviewItem" > > package-name="org.ofbiz.humanres.ability" > > title="Performance Review Item Entity"> > > - <field name="employeePartyId" type="id-ne"></field> > > - <field name="employeeRoleTypeId" type="id"></field> > > <field name="perfReviewId" type="id-ne"></field> > > <field name="perfReviewItemSeqId" type="id-ne"></field> > > <field name="perfRatingTypeId" type="id"></field> > > <field name="perfReviewItemTypeId" type="id"></field> > > + <field name="employeePartyId" type="id-ne"></field> > > + <field name="employeeRoleTypeId" type="id"></field> > > <field name="comments" type="comment"></field> > > - <prim-key field="employeePartyId"/> > > - <prim-key field="employeeRoleTypeId"/> > > <prim-key field="perfReviewId"/> > > <prim-key field="perfReviewItemSeqId"/> > > <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> > > > > Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 > > @@ -216,6 +216,7 @@ under the License. > > </condition> > > <widgets> > > <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> > > + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> > > </widgets> > > </section> > > <decorator-section-include name="body"/> > > > > Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 > > @@ -122,6 +122,11 @@ > > </menu> > > <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" > > type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> > > + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> > > + <link target="EditPerfReview"> > > + <parameter param-name="perfReviewId"/> > > + </link> > > + </menu-item> > > <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> > > <link target="EditPerfReviewItems"> > > <parameter param-name="perfReviewId"/> > > > > Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 > > @@ -62,7 +62,7 @@ > > <entity-one entity-name="PerfReview" value-field="perfReview"/> > > </actions> > > <widgets> > > - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> > > + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> > > <decorator-section name="body"> > > <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> > > <section> > > > > Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > > ============================================================================== > > --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) > > +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 > > @@ -101,7 +101,7 @@ under the License. > > <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" > > header-row-style="header-row" default-table-style="basic-table"> > > <auto-fields-service service-name="createPerfReviewItem"/> > > - <field name="perfReviewId"><hidden/></field> > > + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> > > <field name="perfReviewItemSeqId"><ignored/></field> > > <field name="employeePartyId"><hidden/></field> > > <field name="employeeRoleTypeId"><hidden/></field> > > > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Hans,
I think that you are not interpreting correctly this part of the data model, please have a deeper look at it before going on with these modifications. Also, with reference to the Data Model Resource Book (even if we do not have to strictly follow what it is described there), I can't see your point because the book defines the entities exactly as they are in OFBiz: see the diagram at page 330 (and the fields and pk of the PerformanceReviewItem entity at page 480). Kind regards, Jacopo On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote: > Ok i did not see the unusual index of the PerfRreview too: which > includes the employeeId and role. This is also not according the > dataresource book. I would even suggest to take the employeeparty and > role out of this key too and follow the general pattern that the > perfReview entity has a single key field perfReviewId. > > Thanks for commenting on this. > > Regards, > Hans > > On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote: >> Hi Hans, >> >> could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? >> I am asking you this because, even if I don't know much about this area of the data model, from what I understand: >> - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) >> - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) >> >> I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. >> >> Kind regards, >> >> Jacopo >> >> On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: >> >>> Author: hansbak >>> Date: Fri Jan 14 08:40:01 2011 >>> New Revision: 1058891 >>> >>> URL: http://svn.apache.org/viewvc?rev=1058891&view=rev >>> Log: >>> made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing >>> >>> Modified: >>> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml >>> ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml >>> ofbiz/trunk/applications/humanres/widget/CommonScreens.xml >>> ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml >>> ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml >>> ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml >>> >>> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) >>> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 >>> @@ -153,5 +153,17 @@ under the License. >>> >>> <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> >>> <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> >>> + >>> + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> >>> + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> >>> + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> >>> + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> >>> + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> >>> + >>> + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> >>> + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> >>> + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> >>> + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> >>> + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> >>> >>> </entity-engine-xml> >>> >>> Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) >>> +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 >>> @@ -164,15 +164,13 @@ under the License. >>> <entity entity-name="PerfReviewItem" >>> package-name="org.ofbiz.humanres.ability" >>> title="Performance Review Item Entity"> >>> - <field name="employeePartyId" type="id-ne"></field> >>> - <field name="employeeRoleTypeId" type="id"></field> >>> <field name="perfReviewId" type="id-ne"></field> >>> <field name="perfReviewItemSeqId" type="id-ne"></field> >>> <field name="perfRatingTypeId" type="id"></field> >>> <field name="perfReviewItemTypeId" type="id"></field> >>> + <field name="employeePartyId" type="id-ne"></field> >>> + <field name="employeeRoleTypeId" type="id"></field> >>> <field name="comments" type="comment"></field> >>> - <prim-key field="employeePartyId"/> >>> - <prim-key field="employeeRoleTypeId"/> >>> <prim-key field="perfReviewId"/> >>> <prim-key field="perfReviewItemSeqId"/> >>> <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> >>> >>> Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) >>> +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 >>> @@ -216,6 +216,7 @@ under the License. >>> </condition> >>> <widgets> >>> <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> >>> + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> >>> </widgets> >>> </section> >>> <decorator-section-include name="body"/> >>> >>> Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) >>> +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 >>> @@ -122,6 +122,11 @@ >>> </menu> >>> <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" >>> type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> >>> + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> >>> + <link target="EditPerfReview"> >>> + <parameter param-name="perfReviewId"/> >>> + </link> >>> + </menu-item> >>> <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> >>> <link target="EditPerfReviewItems"> >>> <parameter param-name="perfReviewId"/> >>> >>> Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) >>> +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 >>> @@ -62,7 +62,7 @@ >>> <entity-one entity-name="PerfReview" value-field="perfReview"/> >>> </actions> >>> <widgets> >>> - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> >>> + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> >>> <decorator-section name="body"> >>> <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> >>> <section> >>> >>> Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>> ============================================================================== >>> --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) >>> +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 >>> @@ -101,7 +101,7 @@ under the License. >>> <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" >>> header-row-style="header-row" default-table-style="basic-table"> >>> <auto-fields-service service-name="createPerfReviewItem"/> >>> - <field name="perfReviewId"><hidden/></field> >>> + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> >>> <field name="perfReviewItemSeqId"><ignored/></field> >>> <field name="employeePartyId"><hidden/></field> >>> <field name="employeeRoleTypeId"><hidden/></field> >>> >>> >> > > -- > Ofbiz on twitter: http://twitter.com/apache_ofbiz > Myself on twitter: http://twitter.com/hansbak > Antwebsystems.com: Quality services for competitive rates. > |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Hi Jacopo,
I do not have the book here, but just checked the system and there the perfReviewId is already a unique value, why have employeePartyId and roleId also in he primary key? I suggest to change the PerfReviw entity also and take the employeePartyId and roleId also out of the primary key. My further suggestion would be to remove he employeePartyId and roleId fields from the PerfReviewItem entity because it is duplication of the header entity PerfReview. Aft this change this entity follows the same pattern as we have for many other entities in the system like Invoice, Order, Quote etc.... Because this Performance view function was completely unusable anyway i do not see any need for conversion programs. Regards, Hans On Fri, 2011-01-14 at 14:03 +0100, Jacopo Cappellato wrote: > Hans, > > I think that you are not interpreting correctly this part of the data model, please have a deeper look at it before going on with these modifications. > Also, with reference to the Data Model Resource Book (even if we do not have to strictly follow what it is described there), I can't see your point because the book defines the entities exactly as they are in OFBiz: see the diagram at page 330 (and the fields and pk of the PerformanceReviewItem entity at page 480). > > Kind regards, > > Jacopo > > On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote: > > > Ok i did not see the unusual index of the PerfRreview too: which > > includes the employeeId and role. This is also not according the > > dataresource book. I would even suggest to take the employeeparty and > > role out of this key too and follow the general pattern that the > > perfReview entity has a single key field perfReviewId. > > > > Thanks for commenting on this. > > > > Regards, > > Hans > > > > On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote: > >> Hi Hans, > >> > >> could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? > >> I am asking you this because, even if I don't know much about this area of the data model, from what I understand: > >> - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) > >> - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) > >> > >> I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. > >> > >> Kind regards, > >> > >> Jacopo > >> > >> On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: > >> > >>> Author: hansbak > >>> Date: Fri Jan 14 08:40:01 2011 > >>> New Revision: 1058891 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=1058891&view=rev > >>> Log: > >>> made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing > >>> > >>> Modified: > >>> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > >>> ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > >>> ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > >>> ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > >>> ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > >>> ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > >>> > >>> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 > >>> @@ -153,5 +153,17 @@ under the License. > >>> > >>> <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> > >>> <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> > >>> + > >>> + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> > >>> + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> > >>> + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> > >>> + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> > >>> + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> > >>> + > >>> + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> > >>> + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> > >>> + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> > >>> + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> > >>> + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> > >>> > >>> </entity-engine-xml> > >>> > >>> Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 > >>> @@ -164,15 +164,13 @@ under the License. > >>> <entity entity-name="PerfReviewItem" > >>> package-name="org.ofbiz.humanres.ability" > >>> title="Performance Review Item Entity"> > >>> - <field name="employeePartyId" type="id-ne"></field> > >>> - <field name="employeeRoleTypeId" type="id"></field> > >>> <field name="perfReviewId" type="id-ne"></field> > >>> <field name="perfReviewItemSeqId" type="id-ne"></field> > >>> <field name="perfRatingTypeId" type="id"></field> > >>> <field name="perfReviewItemTypeId" type="id"></field> > >>> + <field name="employeePartyId" type="id-ne"></field> > >>> + <field name="employeeRoleTypeId" type="id"></field> > >>> <field name="comments" type="comment"></field> > >>> - <prim-key field="employeePartyId"/> > >>> - <prim-key field="employeeRoleTypeId"/> > >>> <prim-key field="perfReviewId"/> > >>> <prim-key field="perfReviewItemSeqId"/> > >>> <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> > >>> > >>> Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 > >>> @@ -216,6 +216,7 @@ under the License. > >>> </condition> > >>> <widgets> > >>> <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> > >>> + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> > >>> </widgets> > >>> </section> > >>> <decorator-section-include name="body"/> > >>> > >>> Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 > >>> @@ -122,6 +122,11 @@ > >>> </menu> > >>> <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" > >>> type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> > >>> + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> > >>> + <link target="EditPerfReview"> > >>> + <parameter param-name="perfReviewId"/> > >>> + </link> > >>> + </menu-item> > >>> <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> > >>> <link target="EditPerfReviewItems"> > >>> <parameter param-name="perfReviewId"/> > >>> > >>> Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 > >>> @@ -62,7 +62,7 @@ > >>> <entity-one entity-name="PerfReview" value-field="perfReview"/> > >>> </actions> > >>> <widgets> > >>> - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> > >>> + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> > >>> <decorator-section name="body"> > >>> <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> > >>> <section> > >>> > >>> Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml > >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff > >>> ============================================================================== > >>> --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) > >>> +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 > >>> @@ -101,7 +101,7 @@ under the License. > >>> <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" > >>> header-row-style="header-row" default-table-style="basic-table"> > >>> <auto-fields-service service-name="createPerfReviewItem"/> > >>> - <field name="perfReviewId"><hidden/></field> > >>> + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> > >>> <field name="perfReviewItemSeqId"><ignored/></field> > >>> <field name="employeePartyId"><hidden/></field> > >>> <field name="employeeRoleTypeId"><hidden/></field> > >>> > >>> > >> > > > > -- > > Ofbiz on twitter: http://twitter.com/apache_ofbiz > > Myself on twitter: http://twitter.com/hansbak > > Antwebsystems.com: Quality services for competitive rates. > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Hi Hans,
On Jan 15, 2011, at 3:55 AM, Hans Bakker wrote: > Hi Jacopo, > > I do not have the book here, but just checked the system and there the > perfReviewId is already a unique value, why have employeePartyId and > roleId also in he primary key? > Because the performance review is done for a party id and the role id: you can think of the perfReviewId as a subindex of the employeePartyId/roleId pair. The fact that the createPerfReview service is setting the perfReviewId field using: <sequenced-id sequence-name="PerfReview" field="newEntity.perfReviewId"/> (causing it to be unique in the system) is not a good reason for assuming that it should be the primary key; if we don't like it we could for example modify the createPerfReview service to set the field using a subindex: employeePartyId, roleId, perfReviewId EMPLOYEE_01, PACKER, 00001 EMPLOYEE_01, PACKER, 00002 EMPLOYEE_01, PICKER, 00003 (or 00001) EMPLOYEE_02, PACKER, 00001 EMPLOYEE_02, PACKER, 00002 ... > I suggest to change the PerfReviw entity also and take the > employeePartyId and roleId also out of the primary key. > > My further suggestion would be to remove he employeePartyId and roleId > fields from the PerfReviewItem entity because it is duplication of the > header entity PerfReview. > > Aft this change this entity follows the same pattern as we have for many > other entities in the system like Invoice, Order, Quote etc.... > These are different examples of entities that have an associated *Role entity; there are many examples in OFBiz of entities that have a compound primary key similarly to PerfReview > Because this Performance view function was completely unusable anyway i > do not see any need for conversion programs. > here is what I propose: 1) we revert the commit (or part of it) in which you altered the pk of the PerfReviewItem entity; if possible and easy to do, we can fix the screens/services that were not working before your commit 2) in the meantime you will have time to read the book and and others, if interested, will comment as well When the discussion will settle down we will decide if we want to simplify the primary key and change this part of the data model that is currently following the Data Model Resource Book or not. Kind regards, Jacopo > Regards, > Hans > > > On Fri, 2011-01-14 at 14:03 +0100, Jacopo Cappellato wrote: >> Hans, >> >> I think that you are not interpreting correctly this part of the data model, please have a deeper look at it before going on with these modifications. >> Also, with reference to the Data Model Resource Book (even if we do not have to strictly follow what it is described there), I can't see your point because the book defines the entities exactly as they are in OFBiz: see the diagram at page 330 (and the fields and pk of the PerformanceReviewItem entity at page 480). >> >> Kind regards, >> >> Jacopo >> >> On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote: >> >>> Ok i did not see the unusual index of the PerfRreview too: which >>> includes the employeeId and role. This is also not according the >>> dataresource book. I would even suggest to take the employeeparty and >>> role out of this key too and follow the general pattern that the >>> perfReview entity has a single key field perfReviewId. >>> >>> Thanks for commenting on this. >>> >>> Regards, >>> Hans >>> >>> On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote: >>>> Hi Hans, >>>> >>>> could you please better explain what was the error and why you have decided to modify the PerfReviewItem entity? >>>> I am asking you this because, even if I don't know much about this area of the data model, from what I understand: >>>> - PerfReview is used to define an employee performance review; this is why we have a primary key composed by the employee party id, its role and an index (for the specific review) >>>> - PerfReviewItem is used to provide details about a specific review (defined above); this is why we had a primary key composed by the primary key of the PerfReview entity and an additional subindex (perfReviewItemSeqId) >>>> >>>> I don't doubt that the existing services were not working, but I am wondering if there was another way to fix them instead of altering the primary key of the PerfReviewItem entity. >>>> >>>> Kind regards, >>>> >>>> Jacopo >>>> >>>> On Jan 14, 2011, at 9:40 AM, [hidden email] wrote: >>>> >>>>> Author: hansbak >>>>> Date: Fri Jan 14 08:40:01 2011 >>>>> New Revision: 1058891 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=1058891&view=rev >>>>> Log: >>>>> made the employee review item work, corrected a completely wrong entity definition prefreviewitem, services now work again and added new type data. Added buttons to be able to select reveiw and item list NOTE: This change needs recreating of the PerfReviewItem index, the fields and format did not change, just the indexing >>>>> >>>>> Modified: >>>>> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml >>>>> ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml >>>>> ofbiz/trunk/applications/humanres/widget/CommonScreens.xml >>>>> ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml >>>>> ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml >>>>> ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -153,5 +153,17 @@ under the License. >>>>> >>>>> <EmplLeaveReasonType description="Medical" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Fever"/> >>>>> <EmplLeaveReasonType description="Casual" hasTable="N" parentTypeId="" emplLeaveReasonTypeId="Personal Work"/> >>>>> + >>>>> + <PerfReviewItemType perfRatingTypeId="TECH" hasTable="N" description="Technical skills"/> >>>>> + <PerfReviewItemType perfRatingTypeId="RESP" hasTable="N" description="Responsibility"/> >>>>> + <PerfReviewItemType perfRatingTypeId="ATT" hasTable="N" description="Attitude"/> >>>>> + <PerfReviewItemType perfRatingTypeId="COMM" hasTable="N" description="Communication skills"/> >>>>> + <PerfReviewItemType perfRatingTypeId="JOBSAT" hasTable="N" description="Job Satisfaction"/> >>>>> + >>>>> + <PerfRatingType perfRatingTypeId="1" hasTable="N" description="Fails to Meet Expectations"/> >>>>> + <PerfRatingType perfRatingTypeId="2" hasTable="N" description="Inconsistently Fulfills"/> >>>>> + <PerfRatingType perfRatingTypeId="3" hasTable="N" description="Fulfilled Expectations"/> >>>>> + <PerfRatingType perfRatingTypeId="4" hasTable="N" description="Frequently Exceeds"/> >>>>> + <PerfRatingType perfRatingTypeId="5" hasTable="N" description="Consistently Exceeds"/> >>>>> >>>>> </entity-engine-xml> >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -164,15 +164,13 @@ under the License. >>>>> <entity entity-name="PerfReviewItem" >>>>> package-name="org.ofbiz.humanres.ability" >>>>> title="Performance Review Item Entity"> >>>>> - <field name="employeePartyId" type="id-ne"></field> >>>>> - <field name="employeeRoleTypeId" type="id"></field> >>>>> <field name="perfReviewId" type="id-ne"></field> >>>>> <field name="perfReviewItemSeqId" type="id-ne"></field> >>>>> <field name="perfRatingTypeId" type="id"></field> >>>>> <field name="perfReviewItemTypeId" type="id"></field> >>>>> + <field name="employeePartyId" type="id-ne"></field> >>>>> + <field name="employeeRoleTypeId" type="id"></field> >>>>> <field name="comments" type="comment"></field> >>>>> - <prim-key field="employeePartyId"/> >>>>> - <prim-key field="employeeRoleTypeId"/> >>>>> <prim-key field="perfReviewId"/> >>>>> <prim-key field="perfReviewItemSeqId"/> >>>>> <relation type="one" fk-name="PERF_RVITM_PFRV" rel-entity-name="PerfReview"> >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/widget/CommonScreens.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/widget/CommonScreens.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -216,6 +216,7 @@ under the License. >>>>> </condition> >>>>> <widgets> >>>>> <include-menu name="PartyBar" location="component://humanres/widget/HumanresMenus.xml"/> >>>>> + <label style="h1" text="${uiLabelMap.HumanResPerfReview} ${uiLabelMap.CommonId} ${perfReviewId}"/> >>>>> </widgets> >>>>> </section> >>>>> <decorator-section-include name="body"/> >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -122,6 +122,11 @@ >>>>> </menu> >>>>> <menu name="PartyBar" default-menu-item-name="EditPerfReviewItems" default-selected-style="selected" >>>>> type="simple" menu-container-style="button-bar tab-bar" selected-menuitem-context-field-name="tabButtonItem"> >>>>> + <menu-item name="EditPerfReview" title="${uiLabelMap.HumanResPerfReview}"> >>>>> + <link target="EditPerfReview"> >>>>> + <parameter param-name="perfReviewId"/> >>>>> + </link> >>>>> + </menu-item> >>>>> <menu-item name="EditPerfReviewItems" title="${uiLabelMap.HumanResEditPerfReviewItems}"> >>>>> <link target="EditPerfReviewItems"> >>>>> <parameter param-name="perfReviewId"/> >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -62,7 +62,7 @@ >>>>> <entity-one entity-name="PerfReview" value-field="perfReview"/> >>>>> </actions> >>>>> <widgets> >>>>> - <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}"> >>>>> + <decorator-screen name="CommonPerfReviewDecorator" location="${parameters.mainDecoratorLocation}"> >>>>> <decorator-section name="body"> >>>>> <screenlet title="${uiLabelMap.CommonEdit} ${uiLabelMap.HumanResPerfReview}"> >>>>> <section> >>>>> >>>>> Modified: ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml?rev=1058891&r1=1058890&r2=1058891&view=diff >>>>> ============================================================================== >>>>> --- ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml (original) >>>>> +++ ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml Fri Jan 14 08:40:01 2011 >>>>> @@ -101,7 +101,7 @@ under the License. >>>>> <form name="AddPerfReviewItem" type="single" target="createPerfReviewItem" title="" >>>>> header-row-style="header-row" default-table-style="basic-table"> >>>>> <auto-fields-service service-name="createPerfReviewItem"/> >>>>> - <field name="perfReviewId"><hidden/></field> >>>>> + <field name="perfReviewId"><hidden value="${parameters.perfReviewId}"/></field> >>>>> <field name="perfReviewItemSeqId"><ignored/></field> >>>>> <field name="employeePartyId"><hidden/></field> >>>>> <field name="employeeRoleTypeId"><hidden/></field> >>>>> >>>>> >>>> >>> >>> -- >>> Ofbiz on twitter: http://twitter.com/apache_ofbiz >>> Myself on twitter: http://twitter.com/hansbak >>> Antwebsystems.com: Quality services for competitive rates. >>> >> > > -- > Ofbiz on twitter: http://twitter.com/apache_ofbiz > Myself on twitter: http://twitter.com/hansbak > Antwebsystems.com: Quality services for competitive rates. > |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
On Jan 15, 2011, at 6:45 AM, Jacopo Cappellato wrote:
> 1) we revert the commit (or part of it) in which you altered the pk of the PerfReviewItem entity; if possible and easy to do, we can fix the screens/services that were not working before your commit Hans, thanks for reverting that code; in rev. 1059340 I have committed some fixes to at least make the screens usable, please have a look at them when you have a chance. Kind regards, Jacopo |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Jacopo, what shall i say?
Having two additional fields in an already unique key, sorry i do not see the benefit, also because it is not following the general pattern used in invoice, quote and order etc. where the there is a header and items. You seem to have strong feelings keeping this, so be my guest. It makes the application unnecessary complicated. Usable? After adding a review one still has to go back to he find option, find the review again and then finally items can add be added. Regards, Hans On Sat, 2011-01-15 at 15:17 +0100, Jacopo Cappellato wrote: > On Jan 15, 2011, at 6:45 AM, Jacopo Cappellato wrote: > > > 1) we revert the commit (or part of it) in which you altered the pk of the PerfReviewItem entity; if possible and easy to do, we can fix the screens/services that were not working before your commit > > Hans, thanks for reverting that code; in rev. 1059340 I have committed some fixes to at least make the screens usable, please have a look at them when you have a chance. > > Kind regards, > > Jacopo > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote:
> After adding a review one still has to go back to he find option, find > the review again and then finally items can add be added. This is not what I can see in my local box, please have a second look. Jacopo |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Ah yes,
I can recreate the same after taking an update: it is caused by your today changes (rev. 1059556), I guess you will be able to fix it on your own. Jacopo On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: > On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: > >> After adding a review one still has to go back to he find option, find >> the review again and then finally items can add be added. > > This is not what I can see in my local box, please have a second look. > > Jacopo |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Sorry Jacopo,
many things either wrong or missing on this application....... redirecting to showing the tabs is only possible when the 'create' service returns the key of the entity (3 fields) and not only the perfReviewId..... Regards, Hans On Sun, 2011-01-16 at 17:19 +0100, Jacopo Cappellato wrote: > Ah yes, > > I can recreate the same after taking an update: it is caused by your today changes (rev. 1059556), I guess you will be able to fix it on your own. > > Jacopo > > On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: > > > On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: > > > >> After adding a review one still has to go back to he find option, find > >> the review again and then finally items can add be added. > > > > This is not what I can see in my local box, please have a second look. > > > > Jacopo > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Hans & Jacopo,
I agree with Hans - many things are wrong with that application. I am working on a project that will make much use of HR - so I can work on some of the problems. I expect to start working on it mid February or early March. -Adrian > Sorry Jacopo, > > many things either wrong or missing on this > application....... > redirecting to showing the tabs is only possible when the > 'create' > service returns the key of the entity (3 fields) and not > only the > perfReviewId..... > > Regards, > Hans > > On Sun, 2011-01-16 at 17:19 +0100, Jacopo Cappellato > wrote: > > Ah yes, > > > > I can recreate the same after taking an update: it is > caused by your today changes (rev. 1059556), I guess you > will be able to fix it on your own. > > > > Jacopo > > > > On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: > > > > > On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: > > > > > >> After adding a review one still has to go > back to he find option, find > > >> the review again and then finally items can > add be added. > > > > > > This is not what I can see in my local box, > please have a second look. > > > > > > Jacopo > > > > -- > Ofbiz on twitter: http://twitter.com/apache_ofbiz > Myself on twitter: http://twitter.com/hansbak > Antwebsystems.com: Quality services for competitive rates. > > |
Re: svn commit: r1058891 - in /ofbiz/trunk/applications/huma
|
|
Hi Adrian,
I am trying to use it for my own company but see chances for my customers too as long as it is working reasonably? looking forward to work together.... Regards Hans On Mon, 2011-01-17 at 04:05 -0800, Adrian Crum wrote: > Hans & Jacopo, > > I agree with Hans - many things are wrong with that application. I am working on a project that will make much use of HR - so I can work on some of the problems. I expect to start working on it mid February or early March. > > -Adrian > > > > Sorry Jacopo, > > > > many things either wrong or missing on this > > application....... > > redirecting to showing the tabs is only possible when the > > 'create' > > service returns the key of the entity (3 fields) and not > > only the > > perfReviewId..... > > > > Regards, > > Hans > > > > On Sun, 2011-01-16 at 17:19 +0100, Jacopo Cappellato > > wrote: > > > Ah yes, > > > > > > I can recreate the same after taking an update: it is > > caused by your today changes (rev. 1059556), I guess you > > will be able to fix it on your own. > > > > > > Jacopo > > > > > > On Jan 16, 2011, at 5:16 PM, Jacopo Cappellato wrote: > > > > > > > On Jan 16, 2011, at 10:37 AM, Hans Bakker wrote: > > > > > > > >> After adding a review one still has to go > > back to he find option, find > > > >> the review again and then finally items can > > add be added. > > > > > > > > This is not what I can see in my local box, > > please have a second look. > > > > > > > > Jacopo > > > > > > > -- > > Ofbiz on twitter: http://twitter.com/apache_ofbiz > > Myself on twitter: http://twitter.com/hansbak > > Antwebsystems.com: Quality services for competitive rates. > > > > > > > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |