Re: svn commit: r1167510 - /ofbiz/trunk/applications/commonext/ofbiz-component.xml

[Scott Gray-2]

Any opinions on whether that file should be considered seed data?  I have my doubts...

Regards
Scott

On 11/09/2011, at 1:09 AM, [hidden email] wrote:

> Author: jleroux
> Date: Sat Sep 10 13:09:51 2011
> New Revision: 1167510
>
> URL: http://svn.apache.org/viewvc?rev=1167510&view=rev
> Log:
> A patch from Marcelo Giubergia "ofbizsetup "INSERT CARRIER_SHIPMENT_METHOD" ERROR when new store is created" script" https://issues.apache.org/jira/browse/OFBIZ-4381
>
> I installed ofbiz from scratch according with recommended method
>
>> ant clean-all
>> ant run-install-extseed
>> ant create-admin-user-login
>> ./startofbiz.sh
>
> Then, when I create an store by https://localhost:8443/ofbizsetup/control/createProductStore
>
> Error: Error parsing entity xml file: org.ofbiz.entity.GenericEntityException: Error while inserting: [GenericEntity:CarrierShipmentMethod][createdStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][createdTxStamp,2011-08-29 11:16:32.951(java.sql.Timestamp)][lastUpdatedStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][lastUpdatedTxStamp,2011-08-29 11:16:32.951(java.sql.Timestamp)][partyId,sds(java.lang.String)][roleTypeId,CARRIER(java.lang.String)][sequenceNumber,4(java.lang.Long)][shipmentMethodTypeId,LOCAL_DELIVERY(java.lang.String)] (SQL Exception while executing the following:INSERT INTO public.CARRIER_SHIPMENT_METHOD (SHIPMENT_METHOD_TYPE_ID, PARTY_ID, ROLE_TYPE_ID, SEQUENCE_NUMBER, CARRIER_SERVICE_CODE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: inserción o actualización en la tabla «carrier_shipment_method» viola la llave foránea «carr_shmeth_type»<br/> Detail: La llave (shipment_method_
> type_id)=(LOCAL_DELIVERY) no está presente en la tabla «shipment_method_type».)) calling service parseEntityXmlFile in importTempDataFile
>
> Modified:
>    ofbiz/trunk/applications/commonext/ofbiz-component.xml
>
> Modified: ofbiz/trunk/applications/commonext/ofbiz-component.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/ofbiz-component.xml?rev=1167510&r1=1167509&r2=1167510&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/commonext/ofbiz-component.xml (original)
> +++ ofbiz/trunk/applications/commonext/ofbiz-component.xml Sat Sep 10 13:09:51 2011
> @@ -30,6 +30,7 @@ under the License.
>     <entity-resource type="data" reader-name="seed" loader="main" location="data/CommonExtHelpData.xml"/>
>     <entity-resource type="data" reader-name="seed" loader="main" location="data/SystemInfoPortletData.xml"/>
>     <entity-resource type="data" reader-name="seed" loader="main" location="data/SetupData.xml"/>
> +    <entity-resource type="data" reader-name="seed" loader="main" location="data/ShippingData.xml"/>
>     <entity-resource type="data" reader-name="seed" loader="main" location="data/OfbizSetupSecurityData.xml"/>
>
>     <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel.xml"/>
>
>

[Jacques Le Roux]

I had also a doubt, but has the process hangs if you don't put them I thought it was better to have them there

Jacques

Scott Gray wrote:

> Any opinions on whether that file should be considered seed data?  I have my doubts...
>
> Regards
> Scott
>
> On 11/09/2011, at 1:09 AM, [hidden email] wrote:
>
>> Author: jleroux
>> Date: Sat Sep 10 13:09:51 2011
>> New Revision: 1167510
>>
>> URL: http://svn.apache.org/viewvc?rev=1167510&view=rev
>> Log:
>> A patch from Marcelo Giubergia "ofbizsetup "INSERT CARRIER_SHIPMENT_METHOD" ERROR when new store is created" script"
>> https://issues.apache.org/jira/browse/OFBIZ-4381 
>>
>> I installed ofbiz from scratch according with recommended method
>>
>>> ant clean-all
>>> ant run-install-extseed
>>> ant create-admin-user-login
>>> ./startofbiz.sh
>>
>> Then, when I create an store by https://localhost:8443/ofbizsetup/control/createProductStore
>>
>> Error: Error parsing entity xml file: org.ofbiz.entity.GenericEntityException: Error while inserting:
>> [GenericEntity:CarrierShipmentMethod][createdStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][createdTxStamp,2011-08-29
>> 11:16:32.951(java.sql.Timestamp)][lastUpdatedStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][lastUpdatedTxStamp,2011-08-29
>> 11:16:32.951(java.sql.Timestamp)][partyId,sds(java.lang.String)][roleTypeId,CARRIER(java.lang.String)][sequenceNumber,4(java.lang.Long)][shipmentMethodTypeId,LOCAL_DELIVERY(java.lang.String)]
>> (SQL Exception while executing the following:INSERT INTO public.CARRIER_SHIPMENT_METHOD (SHIPMENT_METHOD_TYPE_ID, PARTY_ID,
>> ROLE_TYPE_ID, SEQUENCE_NUMBER, CARRIER_SERVICE_CODE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP)
>> VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: inserción o actualización en la tabla «carrier_shipment_method» viola la llave
>> foránea «carr_shmeth_type»<br/> Detail: La llave (shipment_method_ type_id)=(LOCAL_DELIVERY) no está presente en la tabla
>> «shipment_method_type».)) calling service parseEntityXmlFile in importTempDataFile      
>>
>> Modified:
>>    ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>
>> Modified: ofbiz/trunk/applications/commonext/ofbiz-component.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/ofbiz-component.xml?rev=1167510&r1=1167509&r2=1167510&view=diff
>> ============================================================================== ---
>> ofbiz/trunk/applications/commonext/ofbiz-component.xml (original) +++ ofbiz/trunk/applications/commonext/ofbiz-component.xml Sat
>> Sep 10 13:09:51 2011 @@ -30,6 +30,7 @@ under the License.
>>     <entity-resource type="data" reader-name="seed" loader="main" location="data/CommonExtHelpData.xml"/>
>>     <entity-resource type="data" reader-name="seed" loader="main" location="data/SystemInfoPortletData.xml"/>
>>     <entity-resource type="data" reader-name="seed" loader="main" location="data/SetupData.xml"/>
>> +    <entity-resource type="data" reader-name="seed" loader="main" location="data/ShippingData.xml"/>
>>     <entity-resource type="data" reader-name="seed" loader="main" location="data/OfbizSetupSecurityData.xml"/>
>>
>>     <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel.xml"/>

[Scott Gray-2]

That logic is what I have a problem with, that setup app is not a reason to add new seed data regardless of any errors it has.  Just because a solution makes a problem disappear doesn't make it the correct solution and not every issue can be solved with a quick fix.

Regards
Scott

On 12/09/2011, at 10:11 PM, Jacques Le Roux wrote:

> I had also a doubt, but has the process hangs if you don't put them I thought it was better to have them there
>
> Jacques
>
> Scott Gray wrote:
>> Any opinions on whether that file should be considered seed data?  I have my doubts...
>> Regards
>> Scott
>> On 11/09/2011, at 1:09 AM, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Sat Sep 10 13:09:51 2011
>>> New Revision: 1167510
>>> URL: http://svn.apache.org/viewvc?rev=1167510&view=rev
>>> Log:
>>> A patch from Marcelo Giubergia "ofbizsetup "INSERT CARRIER_SHIPMENT_METHOD" ERROR when new store is created" script"
>>> https://issues.apache.org/jira/browse/OFBIZ-4381 I installed ofbiz from scratch according with recommended method
>>>> ant clean-all
>>>> ant run-install-extseed
>>>> ant create-admin-user-login
>>>> ./startofbiz.sh
>>> Then, when I create an store by https://localhost:8443/ofbizsetup/control/createProductStore
>>> Error: Error parsing entity xml file: org.ofbiz.entity.GenericEntityException: Error while inserting:
>>> [GenericEntity:CarrierShipmentMethod][createdStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][createdTxStamp,2011-08-29
>>> 11:16:32.951(java.sql.Timestamp)][lastUpdatedStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][lastUpdatedTxStamp,2011-08-29
>>> 11:16:32.951(java.sql.Timestamp)][partyId,sds(java.lang.String)][roleTypeId,CARRIER(java.lang.String)][sequenceNumber,4(java.lang.Long)][shipmentMethodTypeId,LOCAL_DELIVERY(java.lang.String)]
>>> (SQL Exception while executing the following:INSERT INTO public.CARRIER_SHIPMENT_METHOD (SHIPMENT_METHOD_TYPE_ID, PARTY_ID,
>>> ROLE_TYPE_ID, SEQUENCE_NUMBER, CARRIER_SERVICE_CODE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP)
>>> VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: inserción o actualización en la tabla «carrier_shipment_method» viola la llave
>>> foránea «carr_shmeth_type»<br/> Detail: La llave (shipment_method_ type_id)=(LOCAL_DELIVERY) no está presente en la tabla
>>> «shipment_method_type».)) calling service parseEntityXmlFile in importTempDataFile       Modified:
>>>   ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>> Modified: ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/ofbiz-component.xml?rev=1167510&r1=1167509&r2=1167510&view=diff
>>> ============================================================================== ---
>>> ofbiz/trunk/applications/commonext/ofbiz-component.xml (original) +++ ofbiz/trunk/applications/commonext/ofbiz-component.xml Sat
>>> Sep 10 13:09:51 2011 @@ -30,6 +30,7 @@ under the License.
>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/CommonExtHelpData.xml"/>
>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/SystemInfoPortletData.xml"/>
>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/SetupData.xml"/>
>>> +    <entity-resource type="data" reader-name="seed" loader="main" location="data/ShippingData.xml"/>
>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/OfbizSetupSecurityData.xml"/>
>>>    <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel.xml"/>

[Jacques Le Roux]

I did it also because the file was there, so I thought it was a simple miss in the ofbiz-component.xml file
I don't see much harm in these data, but I agree they don't look like seed. What would you suggest, I guess a revert and a change in the setup code?

Jacques

Scott Gray wrote:

> That logic is what I have a problem with, that setup app is not a reason to add new seed data regardless of any errors it has.
> Just because a solution makes a problem disappear doesn't make it the correct solution and not every issue can be solved with a
> quick fix.  
>
> Regards
> Scott
>
> On 12/09/2011, at 10:11 PM, Jacques Le Roux wrote:
>
>> I had also a doubt, but has the process hangs if you don't put them I thought it was better to have them there
>>
>> Jacques
>>
>> Scott Gray wrote:
>>> Any opinions on whether that file should be considered seed data?  I have my doubts...
>>> Regards
>>> Scott
>>> On 11/09/2011, at 1:09 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat Sep 10 13:09:51 2011
>>>> New Revision: 1167510
>>>> URL: http://svn.apache.org/viewvc?rev=1167510&view=rev
>>>> Log:
>>>> A patch from Marcelo Giubergia "ofbizsetup "INSERT CARRIER_SHIPMENT_METHOD" ERROR when new store is created" script"
>>>> https://issues.apache.org/jira/browse/OFBIZ-4381 I installed ofbiz from scratch according with recommended method
>>>>> ant clean-all
>>>>> ant run-install-extseed
>>>>> ant create-admin-user-login
>>>>> ./startofbiz.sh
>>>> Then, when I create an store by https://localhost:8443/ofbizsetup/control/createProductStore
>>>> Error: Error parsing entity xml file: org.ofbiz.entity.GenericEntityException: Error while inserting:
>>>> [GenericEntity:CarrierShipmentMethod][createdStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][createdTxStamp,2011-08-29
>>>> 11:16:32.951(java.sql.Timestamp)][lastUpdatedStamp,2011-08-29 11:16:33.247(java.sql.Timestamp)][lastUpdatedTxStamp,2011-08-29
>>>> 11:16:32.951(java.sql.Timestamp)][partyId,sds(java.lang.String)][roleTypeId,CARRIER(java.lang.String)][sequenceNumber,4(java.lang.Long)][shipmentMethodTypeId,LOCAL_DELIVERY(java.lang.String)]
>>>> (SQL Exception while executing the following:INSERT INTO public.CARRIER_SHIPMENT_METHOD (SHIPMENT_METHOD_TYPE_ID, PARTY_ID,
>>>> ROLE_TYPE_ID, SEQUENCE_NUMBER, CARRIER_SERVICE_CODE, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP,
>>>> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) (ERROR: inserción o actualización en la tabla «carrier_shipment_method»
>>>> viola la llave foránea «carr_shmeth_type»<br/> Detail: La llave (shipment_method_ type_id)=(LOCAL_DELIVERY) no está presente
>>>> en la tabla «shipment_method_type».)) calling service parseEntityXmlFile in importTempDataFile       Modified:
>>>>   ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>>> Modified: ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/commonext/ofbiz-component.xml?rev=1167510&r1=1167509&r2=1167510&view=diff
>>>> ============================================================================== ---
>>>> ofbiz/trunk/applications/commonext/ofbiz-component.xml (original) +++ ofbiz/trunk/applications/commonext/ofbiz-component.xml
>>>> Sat Sep 10 13:09:51 2011 @@ -30,6 +30,7 @@ under the License.
>>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/CommonExtHelpData.xml"/>
>>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/SystemInfoPortletData.xml"/>
>>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/SetupData.xml"/>
>>>> +    <entity-resource type="data" reader-name="seed" loader="main" location="data/ShippingData.xml"/>
>>>>    <entity-resource type="data" reader-name="seed" loader="main" location="data/OfbizSetupSecurityData.xml"/>
>>>>    <entity-resource type="model" reader-name="main" loader="main" location="entitydef/entitymodel.xml"/>