Re: svn commit: r1188334 - /ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml

[Jacques Le Roux]

Hi Erwan,

I'm not sure it's the right solution, please see http://markmail.org/message/x2an3xfhshxbiwcv

Thanks

Jacques

> Author: erwan
> Date: Mon Oct 24 19:45:02 2011
> New Revision: 1188334
>
> URL: http://svn.apache.org/viewvc?rev=1188334&view=rev
> Log:
> A patch from Olivier Heintz - OFBIZ-4503 - wrong jquery.custom.min address in product/commonScreens.xml
>
> Modified:
>    ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>
> Modified: ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml?rev=1188334&r1=1188333&r2=1188334&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml (original)
> +++ ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml Mon Oct 24 19:45:02 2011
> @@ -43,7 +43,7 @@ under the License.
>                 <set field="applicationTitle" value="${uiLabelMap.ProductCatalogManagerApplication}" global="true"/>
>                 <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/external/jquery.cookie.js"
> global="true"/>
>                 <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/plugins/jsTree/jquery.jstree.js" global="true"/>
> -                <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.8.13.custom.min.js" global="true"/>
> +                <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.13.custom.min.js"
> global="true"/>
>             </actions>
>             <widgets>
>                 <include-screen name="ApplicationDecorator" location="component://commonext/widget/CommonScreens.xml"/>
>
>

[Jacques Le Roux]

Also related to this https://issues.apache.org/jira/browse/OFBIZ-4498

Jacques

From: "Jacques Le Roux" <[hidden email]>

> Hi Erwan,
>
> I'm not sure it's the right solution, please see http://markmail.org/message/x2an3xfhshxbiwcv
>
> Thanks
>
> Jacques
>
>> Author: erwan
>> Date: Mon Oct 24 19:45:02 2011
>> New Revision: 1188334
>>
>> URL: http://svn.apache.org/viewvc?rev=1188334&view=rev
>> Log:
>> A patch from Olivier Heintz - OFBIZ-4503 - wrong jquery.custom.min address in product/commonScreens.xml
>>
>> Modified:
>>    ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>>
>> Modified: ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml?rev=1188334&r1=1188333&r2=1188334&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml (original)
>> +++ ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml Mon Oct 24 19:45:02 2011
>> @@ -43,7 +43,7 @@ under the License.
>>                 <set field="applicationTitle" value="${uiLabelMap.ProductCatalogManagerApplication}" global="true"/>
>>                 <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/ui/development-bundle/external/jquery.cookie.js" global="true"/>
>>                 <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/plugins/jsTree/jquery.jstree.js"
>> global="true"/>
>> -                <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.8.13.custom.min.js" global="true"/>
>> +                <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.13.custom.min.js"
>> global="true"/>
>>             </actions>
>>             <widgets>
>>                 <include-screen name="ApplicationDecorator" location="component://commonext/widget/CommonScreens.xml"/>
>>
>>

[Olivier.heintz]

Le 25/10/2011 05:44, Jacques Le Roux a écrit :
> Hi Erwan,
>
> I'm not sure it's the right solution, please see
> http://markmail.org/message/x2an3xfhshxbiwcv
So maybe a temporary solution is to comment the line and add a clear
comment behind it.
I don't understand, why a know error should not be remove.

Olivier

>
> Thanks
>
> Jacques
>
>> Author: erwan
>> Date: Mon Oct 24 19:45:02 2011
>> New Revision: 1188334
>>
>> URL: http://svn.apache.org/viewvc?rev=1188334&view=rev
>> Log:
>> A patch from Olivier Heintz - OFBIZ-4503 - wrong jquery.custom.min
>> address in product/commonScreens.xml
>>
>> Modified:
>>    ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>>
>> Modified:
>> ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml?rev=1188334&r1=1188333&r2=1188334&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>> (original)
>> +++ ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>> Mon Oct 24 19:45:02 2011
>> @@ -43,7 +43,7 @@ under the License.
>> <set field="applicationTitle"
>> value="${uiLabelMap.ProductCatalogManagerApplication}" global="true"/>
>> <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/ui/development-bundle/external/jquery.cookie.js" global="true"/>
>>
>> <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/plugins/jsTree/jquery.jstree.js" global="true"/>
>> - <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/jquery-1.8.13.custom.min.js" global="true"/>
>> + <set field="layoutSettings.javaScripts[+0]"
>> value="/images/jquery/ui/js/jquery-ui-1.8.13.custom.min.js"
>> global="true"/>
>> </actions>
>> <widgets>
>> <include-screen name="ApplicationDecorator"
>> location="component://commonext/widget/CommonScreens.xml"/>
>>
>>
>

[Erwan de FERRIERES-2]

2011/10/26 Olivier Heintz <[hidden email]>:

> Le 25/10/2011 05:44, Jacques Le Roux a écrit :
>>
>> Hi Erwan,
>>
>> I'm not sure it's the right solution, please see
>> http://markmail.org/message/x2an3xfhshxbiwcv
>
> So maybe a temporary solution is to comment the line and add a clear comment
> behind it.
> I don't understand, why a know error should not be remove.
>
> Olivier

Jacques,

I must say I agree with Olivier. I don't understand what is the
problem with pointing to the right file. Is there anything I'm not
understanding ?

[Jacques Le Roux]

From: "Olivier Heintz" <[hidden email]>
> Le 25/10/2011 05:44, Jacques Le Roux a écrit :
>> Hi Erwan,
>>
>> I'm not sure it's the right solution, please see http://markmail.org/message/x2an3xfhshxbiwcv
> So maybe a temporary solution is to comment the line and add a clear comment behind it.
> I don't understand, why a know error should not be remove.

We could revert r1130415 but it seems a bit too much (seems to have some interesting feature there), I get no chances to look at it
yet...
You could help, Hans said he will not...

Jacques

> Olivier
>>
>> Thanks
>>
>> Jacques
>>
>>> Author: erwan
>>> Date: Mon Oct 24 19:45:02 2011
>>> New Revision: 1188334
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1188334&view=rev
>>> Log:
>>> A patch from Olivier Heintz - OFBIZ-4503 - wrong jquery.custom.min address in product/commonScreens.xml
>>>
>>> Modified:
>>>    ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>>>
>>> Modified: ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml?rev=1188334&r1=1188333&r2=1188334&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml (original)
>>> +++ ofbiz/trunk/applications/product/widget/catalog/CommonScreens.xml Mon Oct 24 19:45:02 2011
>>> @@ -43,7 +43,7 @@ under the License.
>>> <set field="applicationTitle" value="${uiLabelMap.ProductCatalogManagerApplication}" global="true"/>
>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/development-bundle/external/jquery.cookie.js"
>>> global="true"/>
>>> <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/plugins/jsTree/jquery.jstree.js" global="true"/>
>>> - <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/jquery-1.8.13.custom.min.js" global="true"/>
>>> + <set field="layoutSettings.javaScripts[+0]" value="/images/jquery/ui/js/jquery-ui-1.8.13.custom.min.js" global="true"/>
>>> </actions>
>>> <widgets>
>>> <include-screen name="ApplicationDecorator" location="component://commonext/widget/CommonScreens.xml"/>
>>>
>>>
>>
>

[Jacques Le Roux]

From: "Erwan de FERRIERES" <[hidden email]>

> 2011/10/26 Olivier Heintz <[hidden email]>:
>> Le 25/10/2011 05:44, Jacques Le Roux a écrit :
>>>
>>> Hi Erwan,
>>>
>>> I'm not sure it's the right solution, please see
>>> http://markmail.org/message/x2an3xfhshxbiwcv
>>
>> So maybe a temporary solution is to comment the line and add a clear comment
>> behind it.
>> I don't understand, why a know error should not be remove.

Because there more than that, see http://svn.apache.org/viewvc?view=revision&revision=1130415
I just had a glance

Jacques

>> Olivier
>
> Jacques,
>
> I must say I agree with Olivier. I don't understand what is the
> problem with pointing to the right file. Is there anything I'm not
> understanding ?
>