+1, it's use causes problems that aren't obvious to anyone except the person trying to fill in the captcha form. I think that problem outweighs the more obvious problem caused by the event no longer being present after an update.
Regards
Scott
On 13/05/2012, at 7:28 PM, Jacopo Cappellato wrote:
> Is it ok if we remove this class completely? this was only used by the two ofbiz screens that were using a captcha mechanism but they were broken and the class was actually completely unsafe for concurrent usage; the new implementation of captcha (already backported to 11.04 and 12.04) doesn't use it at all.
>
> Jacopo
>
> On May 11, 2012, at 10:23 AM,
[hidden email] wrote:
>
>> Author: lektran
>> Date: Fri May 11 08:23:10 2012
>> New Revision: 1337058
>>
>> URL:
http://svn.apache.org/viewvc?rev=1337058&view=rev>> Log:
>> Deprecated org.ofbiz.common.Captcha
>>
>> Modified:
>> ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java
>>
>> Modified: ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java
>> URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java?rev=1337058&r1=1337057&r2=1337058&view=diff>> ==============================================================================
>> --- ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java (original)
>> +++ ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java Fri May 11 08:23:10 2012
>> @@ -36,6 +36,10 @@ import javax.servlet.http.HttpServletRes
>>
>> import org.ofbiz.base.util.UtilDateTime;
>>
>> +/**
>> + * @deprecated since 2012-05, use org.ofbiz.common.CommonEvents.createCaptcha(request, response) instead
>> + */
>> +@Deprecated
>> public class Captcha {
>>
>> public static final String CAPTCHA_FILE_PATH = System.getProperty("ofbiz.home") + File.separator + "runtime" + File.separator + "tempfiles" + File.separator + "captcha" + File.separator;
>>
>>
>
Locked
