Re: svn commit: r1340414 - in /ofbiz/trunk: framework/base/lib/Tidy.jar framework/base/lib/ant-trax-1.8.0.jar framework/base/lib/ant/ant-nodeps-1.8.1.jar framework/base/lib/commons/commons-vfs-20070730.jar framework/base/lib/javacc/ lib/

[Adrian Crum-3]

I believe httpunit depends on Tidy.

-Adrian

On 5/19/2012 11:57 AM, [hidden email] wrote:

> Author: jleroux
> Date: Sat May 19 10:57:40 2012
> New Revision: 1340414
>
> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
> Log:
> Following https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
> Moves to Attic:
>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), seems to contains no needed stuff
>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was added by Marco, not sure why (no comment about need)
>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT task
>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>
> Removed:
>      ofbiz/trunk/framework/base/lib/Tidy.jar
>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>      ofbiz/trunk/framework/base/lib/javacc/
>      ofbiz/trunk/lib/
>

[Jacques Le Roux]

Possibly indeed, also buildbot report a failure, not sure it's because of the commit or the false reports it's used to do...

I don't see any references of httpunit in any files but .classpath and LICENSE, do you know where it's used (if it's still used)

Jacques

From: "Adrian Crum" <[hidden email]>

>I believe httpunit depends on Tidy.
>
> -Adrian
>
> On 5/19/2012 11:57 AM, [hidden email] wrote:
>> Author: jleroux
>> Date: Sat May 19 10:57:40 2012
>> New Revision: 1340414
>>
>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>> Log:
>> Following
>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>> Moves to Attic:
>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no
>> comment about need), seems to contains no needed stuff
>>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not
>> used OOTB, was added by Marco, not sure why (no comment about need)
>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about
>> need), contains XSLT task
>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>
>> Removed:
>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>      ofbiz/trunk/framework/base/lib/javacc/
>>      ofbiz/trunk/lib/
>>

[Adrian Crum-3]

I believe httpunit was used by Selenium.

-Adrian

On 5/19/2012 12:26 PM, Jacques Le Roux wrote:

> Possibly indeed, also buildbot report a failure, not sure it's because
> of the commit or the false reports it's used to do...
>
> I don't see any references of httpunit in any files but .classpath and
> LICENSE, do you know where it's used (if it's still used)
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> I believe httpunit depends on Tidy.
>>
>> -Adrian
>>
>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Sat May 19 10:57:40 2012
>>> New Revision: 1340414
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>> Log:
>>> Following
>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>> Moves to Attic:
>>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed
>>> IMO. It was added with ant 1.8 by Hans, not sure why (no comment
>>> about need), seems to contains no needed stuff
>>>      framework/base/lib/javacc can be removed IMO. The Java Compiler
>>> Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB,
>>> was added by Marco, not sure why (no comment about need)
>>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce
>>> pages before, no longer needed
>>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It
>>> was added with ant 1.8 by Hans, not sure why (no comment about
>>> need), contains XSLT task
>>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly
>>> added with Webslinger can be removed now
>>>
>>> Removed:
>>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>      ofbiz/trunk/framework/base/lib/javacc/
>>>      ofbiz/trunk/lib/
>>>

[Jacques Le Roux]

Yes, makes sense when you read http://httpunit.sourceforge.net/
You mean SeleniumXml ? Then we should also move httpunit  toAttic with SeleniumXml, right?

Jacques

From: "Adrian Crum" <[hidden email]>

>I believe httpunit was used by Selenium.
>
> -Adrian
>
> On 5/19/2012 12:26 PM, Jacques Le Roux wrote:
>> Possibly indeed, also buildbot report a failure, not sure it's because of the commit or the false reports it's used to do...
>>
>> I don't see any references of httpunit in any files but .classpath and LICENSE, do you know where it's used (if it's still used)
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> I believe httpunit depends on Tidy.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat May 19 10:57:40 2012
>>>> New Revision: 1340414
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>> Log:
>>>> Following
>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>> Moves to Attic:
>>>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no
>>>> comment about need), seems to contains no needed stuff
>>>>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not
>>>> used OOTB, was added by Marco, not sure why (no comment about need)
>>>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment
>>>> about need), contains XSLT task
>>>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>
>>>> Removed:
>>>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>      ofbiz/trunk/framework/base/lib/javacc/
>>>>      ofbiz/trunk/lib/
>>>>

[Adrian Crum-3]

The project will not compile after this change.

-Adrian

On 5/19/2012 11:57 AM, [hidden email] wrote:

> Author: jleroux
> Date: Sat May 19 10:57:40 2012
> New Revision: 1340414
>
> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
> Log:
> Following https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
> Moves to Attic:
>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), seems to contains no needed stuff
>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was added by Marco, not sure why (no comment about need)
>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT task
>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>
> Removed:
>      ofbiz/trunk/framework/base/lib/Tidy.jar
>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>      ofbiz/trunk/framework/base/lib/javacc/
>      ofbiz/trunk/lib/
>

[Adrian Crum-3]

Jacques,

I am going to repeat what Scott said the other day:

Before you commit, run ant clean-all load-demo run-tests.

This lack of care in the commit process needs to stop.

-Adrian

On 5/19/2012 1:41 PM, Adrian Crum wrote:

> The project will not compile after this change.
>
> -Adrian
>
> On 5/19/2012 11:57 AM, [hidden email] wrote:
>> Author: jleroux
>> Date: Sat May 19 10:57:40 2012
>> New Revision: 1340414
>>
>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>> Log:
>> Following
>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>> Moves to Attic:
>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed
>> IMO. It was added with ant 1.8 by Hans, not sure why (no comment
>> about need), seems to contains no needed stuff
>>      framework/base/lib/javacc can be removed IMO. The Java Compiler
>> Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB,
>> was added by Marco, not sure why (no comment about need)
>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce
>> pages before, no longer needed
>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was
>> added with ant 1.8 by Hans, not sure why (no comment about need),
>> contains XSLT task
>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly
>> added with Webslinger can be removed now
>>
>> Removed:
>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>      ofbiz/trunk/framework/base/lib/javacc/
>>      ofbiz/trunk/lib/
>>

[Adam Heath-2]

Do not remove javacc, it's used by framework/sql.


On 05/19/2012 06:36 AM, Adrian Crum wrote:

> I believe httpunit was used by Selenium.
>
> -Adrian
>
> On 5/19/2012 12:26 PM, Jacques Le Roux wrote:
>> Possibly indeed, also buildbot report a failure, not sure it's because
>> of the commit or the false reports it's used to do...
>>
>> I don't see any references of httpunit in any files but .classpath and
>> LICENSE, do you know where it's used (if it's still used)
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> I believe httpunit depends on Tidy.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat May 19 10:57:40 2012
>>>> New Revision: 1340414
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>> Log:
>>>> Following
>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>>
>>>> Moves to Attic:
>>>> framework/base/lib/ant/ant-nodeps-1.8.1.jar => can be removed IMO.
>>>> It was added with ant 1.8 by Hans, not sure why (no comment about
>>>> need), seems to contains no needed stuff
>>>> framework/base/lib/javacc can be removed IMO. The Java Compiler
>>>> Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB,
>>>> was added by Marco, not sure why (no comment about need)
>>>> framework/base/lib/Tidy.jar was used at bottom of eCommerce pages
>>>> before, no longer needed
>>>> framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was
>>>> added with ant 1.8 by Hans, not sure why (no comment about need),
>>>> contains XSLT task
>>>> framework/base/lib/commons/commons-vfs-20070730.jar certainly added
>>>> with Webslinger can be removed now
>>>>
>>>> Removed:
>>>> ofbiz/trunk/framework/base/lib/Tidy.jar
>>>> ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>> ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>> ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>> ofbiz/trunk/framework/base/lib/javacc/
>>>> ofbiz/trunk/lib/
>>>>

[Scott Gray-2]

+1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to respond most of the time unless it's obviously going to break something.

Before committing please just stop and ask yourself a few questions:
- Do I fully understand the problem I'm about to try and solve?
- Have a taken all practical steps to ensure this change won't break anything?
- Is this the best solution to the problem?

If the answer to any of the above is no then just stop, wait, think and discuss.

Thanks
Scott

On 20/05/2012, at 12:52 AM, Adrian Crum wrote:

> Jacques,
>
> I am going to repeat what Scott said the other day:
>
> Before you commit, run ant clean-all load-demo run-tests.
>
> This lack of care in the commit process needs to stop.
>
> -Adrian
>
> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>> The project will not compile after this change.
>>
>> -Adrian
>>
>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>> Author: jleroux
>>> Date: Sat May 19 10:57:40 2012
>>> New Revision: 1340414
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>> Log:
>>> Following https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>> Moves to Attic:
>>>     framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), seems to contains no needed stuff
>>>     framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was added by Marco, not sure why (no comment about need)
>>>     framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>     framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT task
>>>     framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>
>>> Removed:
>>>     ofbiz/trunk/framework/base/lib/Tidy.jar
>>>     ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>     ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>     ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>     ofbiz/trunk/framework/base/lib/javacc/
>>>     ofbiz/trunk/lib/
>>>

[Adam Heath-2]

And, this commit was done wrong in the first place.  If you remove a
library, remove it's entry from *all* locations, including NOTICE,
LICENSE, build.xml(s).  Do a grep on it's name.

In addition, each library removal should have been done as a *separate*
change, not all bundled like this.  Separate allows for debugging things
when something goes wrong in the future, and one has to revert back to
previous versions to figure it out(also known as git bisect).

On 05/19/2012 07:24 PM, Scott Gray wrote:

> +1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to respond most of the time unless it's obviously going to break something.
>
> Before committing please just stop and ask yourself a few questions:
> - Do I fully understand the problem I'm about to try and solve?
> - Have a taken all practical steps to ensure this change won't break anything?
> - Is this the best solution to the problem?
>
> If the answer to any of the above is no then just stop, wait, think and discuss.
>
> Thanks
> Scott
>
> On 20/05/2012, at 12:52 AM, Adrian Crum wrote:
>
>> Jacques,
>>
>> I am going to repeat what Scott said the other day:
>>
>> Before you commit, run ant clean-all load-demo run-tests.
>>
>> This lack of care in the commit process needs to stop.
>>
>> -Adrian
>>
>> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>>> The project will not compile after this change.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat May 19 10:57:40 2012
>>>> New Revision: 1340414
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>> Log:
>>>> Following https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>> Moves to Attic:
>>>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>   can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), seems to contains no needed stuff
>>>>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was added by Marco, not sure why (no comment about need)
>>>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT task
>>>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>
>>>> Removed:
>>>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>      ofbiz/trunk/framework/base/lib/javacc/
>>>>      ofbiz/trunk/lib/
>>>>
>

[Jacques Le Roux]

https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13274631&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13274631
https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249

Thanks for your help

Jacques

From: "Scott Gray" <[hidden email]>

> +1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about
> all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are
> OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all
> of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to
> respond most of the time unless it's obviously going to break something.
>
> Before committing please just stop and ask yourself a few questions:
> - Do I fully understand the problem I'm about to try and solve?
> - Have a taken all practical steps to ensure this change won't break anything?
> - Is this the best solution to the problem?
>
> If the answer to any of the above is no then just stop, wait, think and discuss.
>
> Thanks
> Scott
>
> On 20/05/2012, at 12:52 AM, Adrian Crum wrote:
>
>> Jacques,
>>
>> I am going to repeat what Scott said the other day:
>>
>> Before you commit, run ant clean-all load-demo run-tests.
>>
>> This lack of care in the commit process needs to stop.
>>
>> -Adrian
>>
>> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>>> The project will not compile after this change.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>> Author: jleroux
>>>> Date: Sat May 19 10:57:40 2012
>>>> New Revision: 1340414
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>> Log:
>>>> Following
>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>> Moves to Attic:
>>>>     framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no
>>>> comment about need), seems to contains no needed stuff
>>>>     framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not
>>>> used OOTB, was added by Marco, not sure why (no comment about need)
>>>>     framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>     framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about
>>>> need), contains XSLT task
>>>>     framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>
>>>> Removed:
>>>>     ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>     ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>     ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>     ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>     ofbiz/trunk/framework/base/lib/javacc/
>>>>     ofbiz/trunk/lib/
>>>>
>
>

[Jacques Le Roux]

From: "Adam Heath" <[hidden email]>
> And, this commit was done wrong in the first place.  If you remove a library, remove it's entry from *all* locations, including
> NOTICE, LICENSE, build.xml(s).  Do a grep on it's name.

Indeed

> In addition, each library removal should have been done as a *separate* change, not all bundled like this.  Separate allows for
> debugging things when something goes wrong in the future, and one has to revert back to previous versions to figure it out(also
> known as git bisect).

Right

Jacques

> On 05/19/2012 07:24 PM, Scott Gray wrote:
>> +1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about
>> all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are
>> OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all
>> of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to
>> respond most of the time unless it's obviously going to break something.
>>
>> Before committing please just stop and ask yourself a few questions:
>> - Do I fully understand the problem I'm about to try and solve?
>> - Have a taken all practical steps to ensure this change won't break anything?
>> - Is this the best solution to the problem?
>>
>> If the answer to any of the above is no then just stop, wait, think and discuss.
>>
>> Thanks
>> Scott
>>
>> On 20/05/2012, at 12:52 AM, Adrian Crum wrote:
>>
>>> Jacques,
>>>
>>> I am going to repeat what Scott said the other day:
>>>
>>> Before you commit, run ant clean-all load-demo run-tests.
>>>
>>> This lack of care in the commit process needs to stop.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>>>> The project will not compile after this change.
>>>>
>>>> -Adrian
>>>>
>>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>>> Author: jleroux
>>>>> Date: Sat May 19 10:57:40 2012
>>>>> New Revision: 1340414
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>>> Log:
>>>>> Following
>>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>>> Moves to Attic:
>>>>>      framework/base/lib/ant/ant-nodeps-1.8.1.jar =>   can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no
>>>>> comment about need), seems to contains no needed stuff
>>>>>      framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not
>>>>> used OOTB, was added by Marco, not sure why (no comment about need)
>>>>>      framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>>      framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment
>>>>> about need), contains XSLT task
>>>>>      framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>>
>>>>> Removed:
>>>>>      ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>>      ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>>      ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>>      ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>>      ofbiz/trunk/framework/base/lib/javacc/
>>>>>      ofbiz/trunk/lib/
>>>>>
>>
>

[Jacopo Cappellato-4]

A small clarification: in Jira I suggested to remove the empty folder framework/base/lib/javacc and not the javacc compile in $ofbiz_home/lib/build/javacc/

Jacopo


On May 20, 2012, at 10:22 AM, Jacques Le Roux wrote:

> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13274631&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13274631
> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>
> Thanks for your help
>
> Jacques
>
> From: "Scott Gray" <[hidden email]>
>> +1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to respond most of the time unless it's obviously going to break something.
>>
>> Before committing please just stop and ask yourself a few questions:
>> - Do I fully understand the problem I'm about to try and solve?
>> - Have a taken all practical steps to ensure this change won't break anything?
>> - Is this the best solution to the problem?
>>
>> If the answer to any of the above is no then just stop, wait, think and discuss.
>>
>> Thanks
>> Scott
>>
>> On 20/05/2012, at 12:52 AM, Adrian Crum wrote:
>>
>>> Jacques,
>>>
>>> I am going to repeat what Scott said the other day:
>>>
>>> Before you commit, run ant clean-all load-demo run-tests.
>>>
>>> This lack of care in the commit process needs to stop.
>>>
>>> -Adrian
>>>
>>> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>>>> The project will not compile after this change.
>>>>
>>>> -Adrian
>>>>
>>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>>> Author: jleroux
>>>>> Date: Sat May 19 10:57:40 2012
>>>>> New Revision: 1340414
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>>> Log:
>>>>> Following https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>>> Moves to Attic:
>>>>>    framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), seems to contains no needed stuff
>>>>>    framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not used OOTB, was added by Marco, not sure why (no comment about need)
>>>>>    framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>>    framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment about need), contains XSLT task
>>>>>    framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>>
>>>>> Removed:
>>>>>    ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>>    ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>>    ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>>    ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>>    ofbiz/trunk/framework/base/lib/javacc/
>>>>>    ofbiz/trunk/lib/
>>>>>
>>

[Jacques Le Roux]

Yes I was wrong removing ofbiz/trunk/lib/. I got sidetracked at this point and did not get a chance to react quickly, though I knew
there was a pb from buildbot.
My apologies guys for that. On the other hand, from the compile error it was obvious it was just a matter of reverting this specific
change, not rocket science, not a big worry.

But yes, as Adam suggested, removing lib by lib will be far easier to understand what's happening in  case of issue.

Jacques

From: "Jacopo Cappellato" <[hidden email]>

>A small clarification: in Jira I suggested to remove the empty folder framework/base/lib/javacc and not the javacc compile in
>$ofbiz_home/lib/build/javacc/
>
> Jacopo
>
>
> On May 20, 2012, at 10:22 AM, Jacques Le Roux wrote:
>
>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13274631&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13274631
>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>
>> Thanks for your help
>>
>> Jacques
>>
>> From: "Scott Gray" <[hidden email]>
>>> +1, I'm really sick and tired of this Jacques.  The lack of care shown in obvious places like this makes me very concerned about
>>> all of your commits in general, I really don't want to have to start closely reviewing every single one.  Given that you are
>>> OFBiz's most prolific committer by a large margin, you're taking time away from the other committers by forcing us to review all
>>> of your work and that's just not fair.  I regularly see basic problems with your commits but I just don't have the energy to
>>> respond most of the time unless it's obviously going to break something.
>>>
>>> Before committing please just stop and ask yourself a few questions:
>>> - Do I fully understand the problem I'm about to try and solve?
>>> - Have a taken all practical steps to ensure this change won't break anything?
>>> - Is this the best solution to the problem?
>>>
>>> If the answer to any of the above is no then just stop, wait, think and discuss.
>>>
>>> Thanks
>>> Scott
>>>
>>> On 20/05/2012, at 12:52 AM, Adrian Crum wrote:
>>>
>>>> Jacques,
>>>>
>>>> I am going to repeat what Scott said the other day:
>>>>
>>>> Before you commit, run ant clean-all load-demo run-tests.
>>>>
>>>> This lack of care in the commit process needs to stop.
>>>>
>>>> -Adrian
>>>>
>>>> On 5/19/2012 1:41 PM, Adrian Crum wrote:
>>>>> The project will not compile after this change.
>>>>>
>>>>> -Adrian
>>>>>
>>>>> On 5/19/2012 11:57 AM, [hidden email] wrote:
>>>>>> Author: jleroux
>>>>>> Date: Sat May 19 10:57:40 2012
>>>>>> New Revision: 1340414
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1340414&view=rev
>>>>>> Log:
>>>>>> Following
>>>>>> https://issues.apache.org/jira/browse/OFBIZ-4833?focusedCommentId=13275249&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13275249
>>>>>> Moves to Attic:
>>>>>>    framework/base/lib/ant/ant-nodeps-1.8.1.jar =>  can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no
>>>>>> comment about need), seems to contains no needed stuff
>>>>>>    framework/base/lib/javacc can be removed IMO. The Java Compiler Compiler tm (JavaCC tm) - The Java Parser Generator, not
>>>>>> used OOTB, was added by Marco, not sure why (no comment about need)
>>>>>>    framework/base/lib/Tidy.jar was used at bottom of eCommerce pages before, no longer needed
>>>>>>    framework/base/lib/ant-trax-1.8.0.jar can be removed IMO. It was added with ant 1.8 by Hans, not sure why (no comment
>>>>>> about need), contains XSLT task
>>>>>>    framework/base/lib/commons/commons-vfs-20070730.jar certainly added with Webslinger can be removed now
>>>>>>
>>>>>> Removed:
>>>>>>    ofbiz/trunk/framework/base/lib/Tidy.jar
>>>>>>    ofbiz/trunk/framework/base/lib/ant-trax-1.8.0.jar
>>>>>>    ofbiz/trunk/framework/base/lib/ant/ant-nodeps-1.8.1.jar
>>>>>>    ofbiz/trunk/framework/base/lib/commons/commons-vfs-20070730.jar
>>>>>>    ofbiz/trunk/framework/base/lib/javacc/
>>>>>>    ofbiz/trunk/lib/
>>>>>>
>>>
>
>