OFBiz › OFBiz - Dev

Re: svn commit: r1680155 - /ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 3 messages Options
Adrian Crum-3
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1680155 - /ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml

Adrian Crum-3
Please make the commit message more informative. What was changed/fixed?
Also, if there is a related Jira issue, then include a link to the issue.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 5/18/2015 8:15 PM, [hidden email] wrote:

> Author: ccarlow
> Date: Tue May 19 03:15:43 2015
> New Revision: 1680155
>
> URL: http://svn.apache.org/r1680155
> Log:
> JIRA OFBIZ-6387.patch
>
> Modified:
>      ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
>
> Modified: ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml?rev=1680155&r1=1680154&r2=1680155&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml (original)
> +++ ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml Tue May 19 03:15:43 2015
> @@ -58,8 +58,7 @@ under the License.
>           </field>
>           <field name="partyId"><hidden/></field>
>           <field name="applyingPartyId" title="${uiLabelMap.FormFieldTitle_applyingPartyId}"><lookup target-form-name="LookupPartyName"/></field>
> -        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}" use-when="&quot;${referredByPartyId}&quot;.equals(null)"><lookup target-form-name="LookupPartyName"/></field>
> -        <field name="referredByPartyId" use-when="referredByPartyId!=null"><lookup target-form-name="LookupPartyName"/></field>
> +        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}"><lookup target-form-name="LookupPartyName"/></field>
>           <field name="applicationDate" title="${uiLabelMap.FormFieldTitle_applicationDate}"><date-time/></field>
>           <field name="deleteLink" title="${uiLabelMap.CommonDelete}" widget-style="buttontext">
>               <hyperlink target="deleteEmploymentApp" description="${uiLabelMap.CommonDelete}" also-hidden="true">
>
>
Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1680155 - /ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml

Jacques Le Roux
Administrator
Hi Christian,

When you commit please don't put only a reference to a Jira in your comment. Sometimes we have no Internet access and then here a (possibly
simplified) copy of the Jira description would fit. In more complicated cases it's good to at least give an idea of what is done by the commit.

Jacques

Le 19/05/2015 05:15, [hidden email] a écrit :

> Author: ccarlow
> Date: Tue May 19 03:15:43 2015
> New Revision: 1680155
>
> URL: http://svn.apache.org/r1680155
> Log:
> JIRA OFBIZ-6387.patch
>
> Modified:
>      ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
>
> Modified: ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml?rev=1680155&r1=1680154&r2=1680155&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml (original)
> +++ ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml Tue May 19 03:15:43 2015
> @@ -58,8 +58,7 @@ under the License.
>           </field>
>           <field name="partyId"><hidden/></field>
>           <field name="applyingPartyId" title="${uiLabelMap.FormFieldTitle_applyingPartyId}"><lookup target-form-name="LookupPartyName"/></field>
> -        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}" use-when="&quot;${referredByPartyId}&quot;.equals(null)"><lookup target-form-name="LookupPartyName"/></field>
> -        <field name="referredByPartyId" use-when="referredByPartyId!=null"><lookup target-form-name="LookupPartyName"/></field>
> +        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}"><lookup target-form-name="LookupPartyName"/></field>
>           <field name="applicationDate" title="${uiLabelMap.FormFieldTitle_applicationDate}"><date-time/></field>
>           <field name="deleteLink" title="${uiLabelMap.CommonDelete}" widget-style="buttontext">
>               <hyperlink target="deleteEmploymentApp" description="${uiLabelMap.CommonDelete}" also-hidden="true">
>
>
>
Jacques Le Roux
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: svn commit: r1680155 - /ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml

Jacques Le Roux
Administrator
In reply to this post by Adrian Crum-3
Ha, we are on the same page Adrian, just sent the same kind of message, crossed on wire :)

Jacques

Le 19/05/2015 05:25, Adrian Crum a écrit :

> Please make the commit message more informative. What was changed/fixed? Also, if there is a related Jira issue, then include a link to the issue.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 5/18/2015 8:15 PM, [hidden email] wrote:
>> Author: ccarlow
>> Date: Tue May 19 03:15:43 2015
>> New Revision: 1680155
>>
>> URL: http://svn.apache.org/r1680155
>> Log:
>> JIRA OFBIZ-6387.patch
>>
>> Modified:
>> ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
>>
>> Modified: ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml?rev=1680155&r1=1680154&r2=1680155&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml (original)
>> +++ ofbiz/trunk/applications/humanres/widget/forms/EmploymentAppForms.xml Tue May 19 03:15:43 2015
>> @@ -58,8 +58,7 @@ under the License.
>>           </field>
>>           <field name="partyId"><hidden/></field>
>>           <field name="applyingPartyId" title="${uiLabelMap.FormFieldTitle_applyingPartyId}"><lookup target-form-name="LookupPartyName"/></field>
>> -        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}"
>> use-when="&quot;${referredByPartyId}&quot;.equals(null)"><lookup target-form-name="LookupPartyName"/></field>
>> -        <field name="referredByPartyId" use-when="referredByPartyId!=null"><lookup target-form-name="LookupPartyName"/></field>
>> +        <field name="referredByPartyId" title="${uiLabelMap.FormFieldTitle_referredByPartyId}"><lookup target-form-name="LookupPartyName"/></field>
>>           <field name="applicationDate" title="${uiLabelMap.FormFieldTitle_applicationDate}"><date-time/></field>
>>           <field name="deleteLink" title="${uiLabelMap.CommonDelete}" widget-style="buttontext">
>>               <hyperlink target="deleteEmploymentApp" description="${uiLabelMap.CommonDelete}" also-hidden="true">
>>
>>
>
Free forum by Nabble Edit this page