OFBiz › OFBiz - Dev

Re: svn commit: r1746460 - /ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Deepak Dixit-3

Re: svn commit: r1746460 - /ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl

Hi Amardeep,

I think Here instead of showing empty terms we can move condition before
fo:table-row,

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com

On Wed, Jun 1, 2016 at 7:02 PM, <[hidden email]> wrote:

> Author: pranayp
> Date: Wed Jun 1 13:32:24 2016
> New Revision: 1746460
>
> URL: http://svn.apache.org/viewvc?rev=1746460&view=rev
> Log:
> [OFBIZ-7146] Applied patch from the ticket to fix error in rendering Quote
> PDF which is not having terms associated to it.
>
> Thanks Amardeep Singh Jhajj for reporting the issue and providing patch.
>
> Modified:
>
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
>
> Modified:
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl?rev=1746460&r1=1746459&r2=1746460&view=diff
>
> ==============================================================================
> ---
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> (original)
> +++
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> Wed Jun 1 13:32:24 2016
> @@ -74,9 +74,9 @@ under the License.
>
> <fo:table-cell><fo:block>${(quote.validThruDate.toString())!}</fo:block></fo:table-cell>
> </fo:table-row>
> <fo:table-row>
> +
> <fo:table-cell><fo:block>${uiLabelMap.CommonQuoteTerms}:</fo:block></fo:table-cell>
> <#assign quoteLevelTerms =
> Static["org.ofbiz.entity.util.EntityUtil"].filterByAnd(quoteTerms,
> {"quoteItemSeqId": "_NA_"})!>
> <#if quoteLevelTerms?has_content &&
> quoteLevelTerms.size() gt 0>
> -
> <fo:table-cell><fo:block>${uiLabelMap.CommonQuoteTerms}:</fo:block></fo:table-cell>
> <fo:table-cell>
> <#list quoteLevelTerms as quoteLevelTerm>
> <fo:block>
>
>
>

Pranay Pandey-3

Re: svn commit: r1746460 - /ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl

Hi Deepak,

Thanks for your comment, surely this one could be the other way to fix the
issue. But Amardeep has tried to follow the structure which is being
followed by other fields on this pdf.

Amardeep, please feel free to add further details.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 3, 2016 at 11:54 AM, Deepak Dixit <
[hidden email]> wrote:

> Hi Amardeep,
>
> I think Here instead of showing empty terms we can move condition before
> fo:table-row,
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Wed, Jun 1, 2016 at 7:02 PM, <[hidden email]> wrote:
>
> > Author: pranayp
> > Date: Wed Jun 1 13:32:24 2016
> > New Revision: 1746460
> >
> > URL: http://svn.apache.org/viewvc?rev=1746460&view=rev
> > Log:
> > [OFBIZ-7146] Applied patch from the ticket to fix error in rendering
> Quote
> > PDF which is not having terms associated to it.
> >
> > Thanks Amardeep Singh Jhajj for reporting the issue and providing patch.
> >
> > Modified:
> >
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> >
> > Modified:
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl?rev=1746460&r1=1746459&r2=1746460&view=diff
> >
> >
> ==============================================================================
> > ---
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > (original)
> > +++
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > Wed Jun 1 13:32:24 2016
> > @@ -74,9 +74,9 @@ under the License.
> >
> >
> <fo:table-cell><fo:block>${(quote.validThruDate.toString())!}</fo:block></fo:table-cell>
> > </fo:table-row>
> > <fo:table-row>
> > +
> >
> <fo:table-cell><fo:block>${uiLabelMap.CommonQuoteTerms}:</fo:block></fo:table-cell>
> > <#assign quoteLevelTerms =
> > Static["org.ofbiz.entity.util.EntityUtil"].filterByAnd(quoteTerms,
> > {"quoteItemSeqId": "_NA_"})!>
> > <#if quoteLevelTerms?has_content &&
> > quoteLevelTerms.size() gt 0>
> > -
> >
> <fo:table-cell><fo:block>${uiLabelMap.CommonQuoteTerms}:</fo:block></fo:table-cell>
> > <fo:table-cell>
> > <#list quoteLevelTerms as quoteLevelTerm>
> > <fo:block>
> >
> >
> >
>

Amardeep Singh Jhajj-2

Re: svn commit: r1746460 - /ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl

In reply to this post by Deepak Dixit-3

Thanks Deepak for suggestions.

I thought the same as you mentioned. But after looking the rendering of
other fields like Description, Valid Through Date, I worked to show the
empty terms.

I am also agreed on showing the empty terms because it simply says not
terms added till now and user can add it in future.

Thanks
--
Amardeep Singh Jhajj
www.hotwaxsystems.com

On Fri, Jun 3, 2016 at 11:54 AM, Deepak Dixit <
[hidden email]> wrote: