Re: svn commit: r1785581 - /ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplat e.ftl

[Jacques Le Roux]

Hi Wei,

At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read that Jacopo removed this in purpose

<<moved freemarkerImports.properties from "widget" to "base" component, and
changed its content (and the content of the associated templates
AutoImportTemplate.ftl and *HtmlTemplate.ftl*) to remove the dependency from base
to widget&common; some resources of "widget" and "common" are still referenced
from AutoImportTemplate.ftl (that is in "base") but even if they are soft
dependencies: if they are missing the system will load properly without any
error or warning; before this change it was impossible to use, or unit test,
FreeMarkerWorker before the "widget" and "common" components were loaded by the
system, now it is possible>>

So are we sure it's a good thing to do? Did you cross issues? If yes, why not creating a Jira?

Thanks

Jacques

Le 06/03/2017 à 01:39, [hidden email] a écrit :

> Author: zhangwei
> Date: Mon Mar  6 00:39:53 2017
> New Revision: 1785581
>
> URL: http://svn.apache.org/viewvc?rev=1785581&view=rev
> Log:
> Lost <#include "component://widget/templates/HtmlFormMacroLibrary.ftl"/> in framework/common/template/HtmlTemplate.ftl
>
> Modified:
>      ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplate.ftl
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplate.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplate.ftl?rev=1785581&r1=1785580&r2=1785581&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplate.ftl (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/template/includes/HtmlTemplate.ftl Mon Mar  6 00:39:53 2017
> @@ -16,6 +16,7 @@ KIND, either express or implied.  See th
>   specific language governing permissions and limitations
>   under the License.
>   -->
> +<#include "component://widget/templates/HtmlFormMacroLibrary.ftl"/>
>  
>   <#macro lookupField className="" alert="" name="" value="" size="20" maxlength="20" id="" event="" action="" readonly="" autocomplete="" descriptionFieldName="" formName="" fieldFormName="" targetParameterIter="" imgSrc="" ajaxUrl="" ajaxEnabled="" presentation="layer" width="" height="" position="topleft" fadeBackground="true" clearText="" showDescription="" initiallyCollapsed="" tabindex="">
>     <#if (!ajaxEnabled?has_content)>
>
>
>

[Jacopo Cappellato-5]

On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
[hidden email]> wrote:

> Hi Wei,
>
> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
> that Jacopo removed this in purpose
>

Exactly, I was going to comment on this as well, thank you Jacques.

Wei, I think you should revert your commit and then we could spend some
time discussing about the best way to address the problem you are fixing.

Jacopo

[Jacopo Cappellato-5]

any news on this?

Jacopo

On Mon, Mar 6, 2017 at 9:20 AM, Jacopo Cappellato <
[hidden email]> wrote:

> On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Hi Wei,
>>
>> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
>> that Jacopo removed this in purpose
>>
>
> Exactly, I was going to comment on this as well, thank you Jacques.
>
> Wei, I think you should revert your commit and then we could spend some
> time discussing about the best way to address the problem you are fixing.
>
> Jacopo
>

[Jacques Le Roux]

Yes after 10 days w/o news this is worrisome, please Wei answer

Thanks

Jacques


Le 14/03/2017 à 10:00, Jacopo Cappellato a écrit :

> any news on this?
>
> Jacopo
>
> On Mon, Mar 6, 2017 at 9:20 AM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>>> Hi Wei,
>>>
>>> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
>>> that Jacopo removed this in purpose
>>>
>> Exactly, I was going to comment on this as well, thank you Jacques.
>>
>> Wei, I think you should revert your commit and then we could spend some
>> time discussing about the best way to address the problem you are fixing.
>>
>> Jacopo
>>

[Jacopo Cappellato-5]

Ok, since we are not getting any response from Wei, I think that we should
revert this commit in the meantime. Any objections?

Jacopo

On Thu, Mar 16, 2017 at 1:01 PM, Jacques Le Roux <
[hidden email]> wrote:

> Yes after 10 days w/o news this is worrisome, please Wei answer
>
> Thanks
>
> Jacques
>
>
>
> Le 14/03/2017 à 10:00, Jacopo Cappellato a écrit :
>
>> any news on this?
>>
>> Jacopo
>>
>> On Mon, Mar 6, 2017 at 9:20 AM, Jacopo Cappellato <
>> [hidden email]> wrote:
>>
>> On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
>>> [hidden email]> wrote:
>>>
>>> Hi Wei,
>>>>
>>>> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
>>>> that Jacopo removed this in purpose
>>>>
>>>> Exactly, I was going to comment on this as well, thank you Jacques.
>>>
>>> Wei, I think you should revert your commit and then we could spend some
>>> time discussing about the best way to address the problem you are fixing.
>>>
>>> Jacopo
>>>
>>>
>

[Michael Brohl-3]

+1

Am 21.03.17 um 07:22 schrieb Jacopo Cappellato:

> Ok, since we are not getting any response from Wei, I think that we should
> revert this commit in the meantime. Any objections?
>
> Jacopo
>
> On Thu, Mar 16, 2017 at 1:01 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Yes after 10 days w/o news this is worrisome, please Wei answer
>>
>> Thanks
>>
>> Jacques
>>
>>
>>
>> Le 14/03/2017 à 10:00, Jacopo Cappellato a écrit :
>>
>>> any news on this?
>>>
>>> Jacopo
>>>
>>> On Mon, Mar 6, 2017 at 9:20 AM, Jacopo Cappellato <
>>> [hidden email]> wrote:
>>>
>>> On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
>>>> [hidden email]> wrote:
>>>>
>>>> Hi Wei,
>>>>> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
>>>>> that Jacopo removed this in purpose
>>>>>
>>>>> Exactly, I was going to comment on this as well, thank you Jacques.
>>>> Wei, I think you should revert your commit and then we could spend some
>>>> time discussing about the best way to address the problem you are fixing.
>>>>
>>>> Jacopo
>>>>
>>>>

[Jacopo Cappellato-5]

Reverted in rev. 1791763

Jacopo

On Tue, Mar 21, 2017 at 10:13 PM, Michael Brohl <[hidden email]>
wrote:

> +1
>
> Am 21.03.17 um 07:22 schrieb Jacopo Cappellato:
>
> Ok, since we are not getting any response from Wei, I think that we should
>> revert this commit in the meantime. Any objections?
>>
>> Jacopo
>>
>> On Thu, Mar 16, 2017 at 1:01 PM, Jacques Le Roux <
>> [hidden email]> wrote:
>>
>> Yes after 10 days w/o news this is worrisome, please Wei answer
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 14/03/2017 à 10:00, Jacopo Cappellato a écrit :
>>>
>>> any news on this?
>>>>
>>>> Jacopo
>>>>
>>>> On Mon, Mar 6, 2017 at 9:20 AM, Jacopo Cappellato <
>>>> [hidden email]> wrote:
>>>>
>>>> On Mon, Mar 6, 2017 at 8:49 AM, Jacques Le Roux <
>>>>
>>>>> [hidden email]> wrote:
>>>>>
>>>>> Hi Wei,
>>>>>
>>>>>> At http://svn.apache.org/viewvc?view=revision&revision=1762227 I read
>>>>>> that Jacopo removed this in purpose
>>>>>>
>>>>>> Exactly, I was going to comment on this as well, thank you Jacques.
>>>>>>
>>>>> Wei, I think you should revert your commit and then we could spend some
>>>>> time discussing about the best way to address the problem you are
>>>>> fixing.
>>>>>
>>>>> Jacopo
>>>>>
>>>>>
>>>>>
>
>