Re: svn commit: r1821226 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java

[Michael Brohl-3]

Hi Jacques,

would you mind keeping our message template, it would help us to avoid a
lot of unordered entries when we prepare the blog details.

Thank you,

Michael


Am 16.01.18 um 11:25 schrieb [hidden email]:

> Author: jleroux
> Date: Tue Jan 16 10:25:41 2018
> New Revision: 1821226
>
> URL: http://svn.apache.org/viewvc?rev=1821226&view=rev
> Log:
> No functional change, as Deepak suggested on dev ML better to use "name" here
>
> Modified:
>      ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?rev=1821226&r1=1821225&r2=1821226&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java Tue Jan 16 10:25:41 2018
> @@ -206,7 +206,7 @@ public class ContextFilter implements Fi
>                       value = ExternalLoginKeysManager.createJwt(externalServerUserLoginId, dnsName, webAppName , timeToLive);
>                   }
>                   if (value != null) return value;
> -                return super.getHeader("Authorisation");
> +                return super.getHeader(name); // Here name is always "Authorisation"
>               }
>           };
>           // we're done checking; continue on
>
>

[Jacques Le Roux]

Michael,

I had a problem with Jira, so committed before and updated the commits comments after

Also I wrongly thought it was a non functional change initially

Jacques


Le 16/01/2018 à 12:04, Michael Brohl a écrit :

> Hi Jacques,
>
> would you mind keeping our message template, it would help us to avoid a lot of unordered entries when we prepare the blog details.
>
> Thank you,
>
> Michael
>
>
> Am 16.01.18 um 11:25 schrieb [hidden email]:
>> Author: jleroux
>> Date: Tue Jan 16 10:25:41 2018
>> New Revision: 1821226
>>
>> URL: http://svn.apache.org/viewvc?rev=1821226&view=rev
>> Log:
>> No functional change, as Deepak suggested on dev ML better to use "name" here
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java
>>
>> Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?rev=1821226&r1=1821225&r2=1821226&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java (original)
>> +++ ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java Tue Jan 16 10:25:41 2018
>> @@ -206,7 +206,7 @@ public class ContextFilter implements Fi
>>                       value = ExternalLoginKeysManager.createJwt(externalServerUserLoginId, dnsName, webAppName , timeToLive);
>>                   }
>>                   if (value != null) return value;
>> -                return super.getHeader("Authorisation");
>> +                return super.getHeader(name); // Here name is always "Authorisation"
>>               }
>>           };
>>           // we're done checking; continue on
>>
>>
>
>