Re: svn commit: r1828569 - /ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml

[taher]

Hi Jacques,

I think the commit message is a bit confusing. What you did is simply add a
missing jQuery plugin.

Also, why did you add it to ecommerce and not the common-theme?

On Sat, Apr 7, 2018, 12:06 AM <[hidden email]> wrote:

> Author: jleroux
> Date: Fri Apr  6 21:06:48 2018
> New Revision: 1828569
>
> URL: http://svn.apache.org/viewvc?rev=1828569&view=rev
> Log:
> Fixed: One Page Checkout page cannot move to Step 5 due to javascript
> errors
> (OFBIZ-10329)
>
> I was trying to give one page checkout a try..
> But seems like no matter which browser(used IE & Chrome) or version of
> ofbiz
> (used 17.12 and trunk demo) is used, one cannot go beyond  Step 4 :
> Billing.
> I.e. when you click on continue to step 5 we encounter some javascript
> exception
> which makes the checkout process hit the wall.
>
> For actual error messges etc. please refer to screenshot attached.
>
> Thanks: Sameer Gajanan Apte
>
> Modified:
>     ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml
>
> Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml?rev=1828569&r1=1828568&r2=1828569&view=diff
>
> ==============================================================================
> --- ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml (original)
> +++ ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml Fri Apr
> 6 21:06:48 2018
> @@ -48,6 +48,7 @@ under the License.
>
>                  <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-1.6.3.min.js"
> global="true"/>
>                  <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/ui/jquery-ui-1.12.1.min.js" global="true"/>
> +                <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/plugins/validate/additional-methods.min.js"
> global="true"/>
>                  <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/plugins/validate/jquery.validate.min.js"
> global="true"/>
>                  <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/plugins/browser-plugin/jquery.browser-0.1.0.min.js"
> global="true"/>
>                  <set field="layoutSettings.javaScripts[+0]"
> value="/common/js/jquery/jquery-migrate-3.0.0.min.js" global="true"/>
>
>
>

[Michael Brohl-3]

Hi Taher,

I think this is correct. The javascript library itself is in the common
theme, it is only referenced in the ecommerce plugin because it is
needed there to fix the bug.

Regarding the commit message, Jacques: it would be good if you could
take more time to write clear and brief commit messages. We have the
reference to the Jira so it is not necessary to write down the steps to
reproduce the problem again in the message.

I also would prefer if the commit messages are formulated in a neutral
way and free of personal insights or first person narrative.

In this case, the type of change, title, Jira reference and thanks part
would have been enough to get an impression of the change, all other
information can easily be retrieved from the Jira.

Thanks,

Michael


Am 07.04.18 um 08:22 schrieb Taher Alkhateeb:

> Hi Jacques,
>
> I think the commit message is a bit confusing. What you did is simply add a
> missing jQuery plugin.
>
> Also, why did you add it to ecommerce and not the common-theme?
>
> On Sat, Apr 7, 2018, 12:06 AM <[hidden email]> wrote:
>
>> Author: jleroux
>> Date: Fri Apr  6 21:06:48 2018
>> New Revision: 1828569
>>
>> URL: http://svn.apache.org/viewvc?rev=1828569&view=rev
>> Log:
>> Fixed: One Page Checkout page cannot move to Step 5 due to javascript
>> errors
>> (OFBIZ-10329)
>>
>> I was trying to give one page checkout a try..
>> But seems like no matter which browser(used IE & Chrome) or version of
>> ofbiz
>> (used 17.12 and trunk demo) is used, one cannot go beyond  Step 4 :
>> Billing.
>> I.e. when you click on continue to step 5 we encounter some javascript
>> exception
>> which makes the checkout process hit the wall.
>>
>> For actual error messges etc. please refer to screenshot attached.
>>
>> Thanks: Sameer Gajanan Apte
>>
>> Modified:
>>      ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml
>>
>> Modified: ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml?rev=1828569&r1=1828568&r2=1828569&view=diff
>>
>> ==============================================================================
>> --- ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml (original)
>> +++ ofbiz/ofbiz-plugins/trunk/ecommerce/widget/CommonScreens.xml Fri Apr
>> 6 21:06:48 2018
>> @@ -48,6 +48,7 @@ under the License.
>>
>>                   <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/plugins/datetimepicker/jquery-ui-timepicker-addon-1.6.3.min.js"
>> global="true"/>
>>                   <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/ui/jquery-ui-1.12.1.min.js" global="true"/>
>> +                <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/plugins/validate/additional-methods.min.js"
>> global="true"/>
>>                   <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/plugins/validate/jquery.validate.min.js"
>> global="true"/>
>>                   <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/plugins/browser-plugin/jquery.browser-0.1.0.min.js"
>> global="true"/>
>>                   <set field="layoutSettings.javaScripts[+0]"
>> value="/common/js/jquery/jquery-migrate-3.0.0.min.js" global="true"/>
>>
>>
>>