Re: svn commit: r1845086 [2/2] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/webapp/accounting/WEB-INF/ content/webapp/content/WEB-INF/ order/webapp/ordermgr/WEB-INF/ party/webapp/partymgr/WEB-INF/ product/webapp/catalog/WEB-INF/ product/webap...

[Gil Portenseigne]

Hello Suraj,

Is there a reason to keep empty path for service event ?

Regards

Gil

Le lundi 29 oct. 2018 à 08:14:55 (-0000), [hidden email] a écrit :

> Modified: ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml?rev=1845086&r1=1845085&r2=1845086&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml (original)
> +++ ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml Mon Oct 29 08:14:55 2018
> @@ -482,21 +482,21 @@ under the License.
>  
>      <request-map uri="createWorkEffortContent">
>          <security auth="true" https="true"/>
> -        <event invoke="createWorkEffortContent" path="" type="service"/>
> +        <event type="service" invoke="createWorkEffortContent" path=""/>
>          <response name="success" type="view" value="EditWorkEffortContents"/>
>          <response name="error" type="view" value="EditWorkEffortContents"/>
>      </request-map>
>  
>      <request-map uri="updateWorkEffortContent">
>          <security auth="true" https="true"/>
> -        <event invoke="updateWorkEffortContent" path="" type="service"/>
> +        <event type="service" invoke="updateWorkEffortContent" path=""/>
>          <response name="success" type="view" value="EditWorkEffortContents"/>
>          <response name="error" type="view" value="EditWorkEffortContents"/>
>      </request-map>
>  
>      <request-map uri="deleteWorkEffortContent">
>          <security auth="true" https="true"/>
> -        <event invoke="deleteWorkEffortContent" path="" type="service"/>
> +        <event type="service" invoke="deleteWorkEffortContent" path=""/>
>          <response name="success" type="view" value="EditWorkEffortContents"/>
>          <response name="error" type="view" value="EditWorkEffortContents"/>
>      </request-map>
> @@ -509,21 +509,21 @@ under the License.
>  
>      <request-map uri="createWorkEffortGoodStandard">
>          <security auth="true" https="true"/>
> -        <event invoke="createWorkEffortGoodStandard" path="" type="service"/>
> +        <event type="service" invoke="createWorkEffortGoodStandard" path=""/>
>          <response name="success" type="view" value="EditWorkEffortGoodStandards"/>
>          <response name="error" type="view" value="EditWorkEffortGoodStandards"/>
>      </request-map>
>  
>      <request-map uri="updateWorkEffortGoodStandard">
>          <security auth="true" https="true"/>
> -        <event invoke="updateWorkEffortGoodStandard" path="" type="service"/>
> +        <event type="service" invoke="updateWorkEffortGoodStandard" path=""/>
>          <response name="success" type="view" value="EditWorkEffortGoodStandards"/>
>          <response name="error" type="view" value="EditWorkEffortGoodStandards"/>
>      </request-map>
>  
>      <request-map uri="removeWorkEffortGoodStandard">
>          <security auth="true" https="true"/>
> -        <event invoke="removeWorkEffortGoodStandard" path="" type="service"/>
> +        <event type="service" invoke="removeWorkEffortGoodStandard" path=""/>
>          <response name="success" type="view" value="EditWorkEffortGoodStandards"/>
>          <response name="error" type="view" value="EditWorkEffortGoodStandards"/>
>      </request-map>
>
>

[Devanshu Vyas-2]

Hello Gil,

In this task, we didn't changed anything, just rearranged the tags in
correct format. It was a manual effort with Find/Replace. So maybe it was
left behind, and we can definitely remove that empty path in another
commit.

Thanks & Regards,
Devanshu Vyas.


On Mon, Oct 29, 2018 at 1:51 PM Gil Portenseigne <
[hidden email]> wrote:

>
> Hello Suraj,
>
> Is there a reason to keep empty path for service event ?
>
> Regards
>
> Gil
>
> Le lundi 29 oct. 2018 à 08:14:55 (-0000), [hidden email] a écrit :
> > Modified:
> ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml?rev=1845086&r1=1845085&r2=1845086&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml
> (original)
> > +++
> ofbiz/ofbiz-framework/trunk/applications/workeffort/webapp/workeffort/WEB-INF/controller.xml
> Mon Oct 29 08:14:55 2018
> > @@ -482,21 +482,21 @@ under the License.
> >
> >      <request-map uri="createWorkEffortContent">
> >          <security auth="true" https="true"/>
> > -        <event invoke="createWorkEffortContent" path="" type="service"/>
> > +        <event type="service" invoke="createWorkEffortContent" path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortContents"/>
> >          <response name="error" type="view"
> value="EditWorkEffortContents"/>
> >      </request-map>
> >
> >      <request-map uri="updateWorkEffortContent">
> >          <security auth="true" https="true"/>
> > -        <event invoke="updateWorkEffortContent" path="" type="service"/>
> > +        <event type="service" invoke="updateWorkEffortContent" path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortContents"/>
> >          <response name="error" type="view"
> value="EditWorkEffortContents"/>
> >      </request-map>
> >
> >      <request-map uri="deleteWorkEffortContent">
> >          <security auth="true" https="true"/>
> > -        <event invoke="deleteWorkEffortContent" path="" type="service"/>
> > +        <event type="service" invoke="deleteWorkEffortContent" path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortContents"/>
> >          <response name="error" type="view"
> value="EditWorkEffortContents"/>
> >      </request-map>
> > @@ -509,21 +509,21 @@ under the License.
> >
> >      <request-map uri="createWorkEffortGoodStandard">
> >          <security auth="true" https="true"/>
> > -        <event invoke="createWorkEffortGoodStandard" path=""
> type="service"/>
> > +        <event type="service" invoke="createWorkEffortGoodStandard"
> path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortGoodStandards"/>
> >          <response name="error" type="view"
> value="EditWorkEffortGoodStandards"/>
> >      </request-map>
> >
> >      <request-map uri="updateWorkEffortGoodStandard">
> >          <security auth="true" https="true"/>
> > -        <event invoke="updateWorkEffortGoodStandard" path=""
> type="service"/>
> > +        <event type="service" invoke="updateWorkEffortGoodStandard"
> path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortGoodStandards"/>
> >          <response name="error" type="view"
> value="EditWorkEffortGoodStandards"/>
> >      </request-map>
> >
> >      <request-map uri="removeWorkEffortGoodStandard">
> >          <security auth="true" https="true"/>
> > -        <event invoke="removeWorkEffortGoodStandard" path=""
> type="service"/>
> > +        <event type="service" invoke="removeWorkEffortGoodStandard"
> path=""/>
> >          <response name="success" type="view"
> value="EditWorkEffortGoodStandards"/>
> >          <response name="error" type="view"
> value="EditWorkEffortGoodStandards"/>
> >      </request-map>
> >
> >
>