Re: svn commit: r1845824 - /ofbiz/site/dtds/ofbiz-component.xsd

[Michael Brohl-3]

Hi Jacques,

isn't this an unreleased change in 17.12?

I think we should keep the version corresponding to the released 16.12
at least until 17.12 ist released.

Much better would it be to keep consistent sets of dtds for each release
but this would be another discussion...

Best regards,

Michael


Am 05.11.18 um 18:13 schrieb [hidden email]:

> Author: jleroux
> Date: Mon Nov  5 17:13:53 2018
> New Revision: 1845824
>
> URL: http://svn.apache.org/viewvc?rev=1845824&view=rev
> Log:
> Updates dtds on site
>
> Modified:
>      ofbiz/site/dtds/ofbiz-component.xsd
>
> Modified: ofbiz/site/dtds/ofbiz-component.xsd
> URL: http://svn.apache.org/viewvc/ofbiz/site/dtds/ofbiz-component.xsd?rev=1845824&r1=1845823&r2=1845824&view=diff
> ==============================================================================
> --- ofbiz/site/dtds/ofbiz-component.xsd (original)
> +++ ofbiz/site/dtds/ofbiz-component.xsd Mon Nov  5 17:13:53 2018
> @@ -258,7 +258,7 @@ under the License.
>                   </xs:restriction>
>               </xs:simpleType>
>           </xs:attribute>
> -        <xs:attribute name="keep-autologin-cookie" default="false">
> +        <xs:attribute name="use-autologin-cookie" default="false">
>               <xs:simpleType>
>                   <xs:annotation>
>                       <xs:documentation>
>
>

[Jacques Le Roux]

Yes you are right  Michael.

Bu it's hard to handle that this way.  Do we want to revert? There will be several other cases to handle. And we are not at pair at the moment, there
are other commits I did...

BTW, we already add this discussion several times, at least

https://markmail.org/message/qqxzfsq4jn4nd7dc

https://markmail.org/message/gi772634n2ewbujb

As I wrote in my answer (2nd link above, better to refer now to [1]) you can always refer to the xsds packaged in the release using catalog.

But indeed it would be really good to have on the site different sets of dtds for each release and rightly refer to them.

Would you mind create a Jira for that?

[1] https://s.apache.org/HYXJ (I guess the same exists in other IDEs)

Thanks

Jacques

Le 05/11/2018 à 21:02, Michael Brohl a écrit :

> Hi Jacques,
>
> isn't this an unreleased change in 17.12?
>
> I think we should keep the version corresponding to the released 16.12 at least until 17.12 ist released.
>
> Much better would it be to keep consistent sets of dtds for each release but this would be another discussion...
>
> Best regards,
>
> Michael
>
>
> Am 05.11.18 um 18:13 schrieb [hidden email]:
>> Author: jleroux
>> Date: Mon Nov  5 17:13:53 2018
>> New Revision: 1845824
>>
>> URL: http://svn.apache.org/viewvc?rev=1845824&view=rev
>> Log:
>> Updates dtds on site
>>
>> Modified:
>>      ofbiz/site/dtds/ofbiz-component.xsd
>>
>> Modified: ofbiz/site/dtds/ofbiz-component.xsd
>> URL: http://svn.apache.org/viewvc/ofbiz/site/dtds/ofbiz-component.xsd?rev=1845824&r1=1845823&r2=1845824&view=diff
>> ==============================================================================
>> --- ofbiz/site/dtds/ofbiz-component.xsd (original)
>> +++ ofbiz/site/dtds/ofbiz-component.xsd Mon Nov  5 17:13:53 2018
>> @@ -258,7 +258,7 @@ under the License.
>>                   </xs:restriction>
>>               </xs:simpleType>
>>           </xs:attribute>
>> -        <xs:attribute name="keep-autologin-cookie" default="false">
>> +        <xs:attribute name="use-autologin-cookie" default="false">
>>               <xs:simpleType>
>>                   <xs:annotation>
>>                       <xs:documentation>
>>
>>
>
>

[Jacques Le Roux]

I was reviewing https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=7045159

I let a comment there with a link to
https://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo#FAQ-Tips-Tricks-Cookbook-HowTo-localeXSD

I remember we had this discussion w/ David and others long ago and I believe it's the pragmatic way to do it, at least for now.

I see no efforts in having DTDs by releases for years and I surmise it will never happen due to lack of human resources and especially interest.

If someone disagree please create an umbrella Jira and subtasks when needed.

Jacques


Le 06/11/2018 à 10:18, Jacques Le Roux a écrit :

> Yes you are right  Michael.
>
> Bu it's hard to handle that this way.  Do we want to revert? There will be several other cases to handle. And we are not at pair at the moment,
> there are other commits I did...
>
> BTW, we already add this discussion several times, at least
>
> https://markmail.org/message/qqxzfsq4jn4nd7dc
>
> https://markmail.org/message/gi772634n2ewbujb
>
> As I wrote in my answer (2nd link above, better to refer now to [1]) you can always refer to the xsds packaged in the release using catalog.
>
> But indeed it would be really good to have on the site different sets of dtds for each release and rightly refer to them.
>
> Would you mind create a Jira for that?
>
> [1] https://s.apache.org/HYXJ (I guess the same exists in other IDEs)
>
> Thanks
>
> Jacques
>
> Le 05/11/2018 à 21:02, Michael Brohl a écrit :
>> Hi Jacques,
>>
>> isn't this an unreleased change in 17.12?
>>
>> I think we should keep the version corresponding to the released 16.12 at least until 17.12 ist released.
>>
>> Much better would it be to keep consistent sets of dtds for each release but this would be another discussion...
>>
>> Best regards,
>>
>> Michael
>>
>>
>> Am 05.11.18 um 18:13 schrieb [hidden email]:
>>> Author: jleroux
>>> Date: Mon Nov  5 17:13:53 2018
>>> New Revision: 1845824
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1845824&view=rev
>>> Log:
>>> Updates dtds on site
>>>
>>> Modified:
>>>      ofbiz/site/dtds/ofbiz-component.xsd
>>>
>>> Modified: ofbiz/site/dtds/ofbiz-component.xsd
>>> URL: http://svn.apache.org/viewvc/ofbiz/site/dtds/ofbiz-component.xsd?rev=1845824&r1=1845823&r2=1845824&view=diff
>>> ==============================================================================
>>> --- ofbiz/site/dtds/ofbiz-component.xsd (original)
>>> +++ ofbiz/site/dtds/ofbiz-component.xsd Mon Nov  5 17:13:53 2018
>>> @@ -258,7 +258,7 @@ under the License.
>>>                   </xs:restriction>
>>>               </xs:simpleType>
>>>           </xs:attribute>
>>> -        <xs:attribute name="keep-autologin-cookie" default="false">
>>> +        <xs:attribute name="use-autologin-cookie" default="false">
>>>               <xs:simpleType>
>>>                   <xs:annotation>
>>>                       <xs:documentation>
>>>
>>>
>>
>>
>
>