Re: svn commit: r599516 - in /ofbiz/trunk/applications/product: entitydef/entitymodel.xml script/org/ofbiz/product/inventory/InventoryServices.xml

[Vikas Mayur-2]

Line number 222, InventoryServices.xml
<set field-name="oldUnitCost" from-field="lookedUpValue.unitCost"/>

This line is breaking the code.
It should be

<set field="oldUnitCost" from-field="lookedUpValue.unitCost"/>

Thank you,
-- Vikas

[Jacopo Cappellato]

Thanks Vikas,

this is fixed it in rev. 599826

Jacopo


Vikas Mayur wrote:

> Line number 222, InventoryServices.xml
> <set field-name="oldUnitCost" from-field="lookedUpValue.unitCost"/>
>
> This line is breaking the code.
> It should be
>
> <set field="oldUnitCost" from-field="lookedUpValue.unitCost"/>
>
> Thank you,
> -- Vikas
>

[Vikas Mayur-2]

Hi Jacopo,

Thanks for doing it fast.

There is still an error when we recieve Serialized Inventory. :(, that I
missed.

>> Error with comparison in if-compare between field [.parameters.unitCost]
with value [] and value [0.0] with operator [less] and type  [Double]: Left
value is null, cannot complete compare for the operator less calling service
updateInventoryItem in receiveInventoryProduct

I think we have to add a null check for unitCost at Line 218 of
InventoryServices.xml for updateInventoryProduct before
doing <if-compare field-name="parameters.unitCost" operator="less" value="
0.0" type="Double">.
It solves the problem.

Thanks again,
-- Vikas


On Nov 30, 2007 8:00 PM, Jacopo Cappellato <[hidden email]> wrote:

> Thanks Vikas,
>
> this is fixed it in rev. 599826
>
> Jacopo
>
>
> Vikas Mayur wrote:
> > Line number 222, InventoryServices.xml
> > <set field-name="oldUnitCost" from-field="lookedUpValue.unitCost"/>
> >
> > This line is breaking the code.
> > It should be
> >
> > <set field="oldUnitCost" from-field="lookedUpValue.unitCost"/>
> >
> > Thank you,
> > -- Vikas
> >
>
>

--
Vikas Mayur

[Jacopo Cappellato]

Vikas,

you are right again! it should be fixed by rev. 599866

Thanks

Jacopo


Vikas Mayur wrote:

> Hi Jacopo,
>
> Thanks for doing it fast.
>
> There is still an error when we recieve Serialized Inventory. :(, that I
> missed.
>
>>> Error with comparison in if-compare between field [.parameters.unitCost]
> with value [] and value [0.0] with operator [less] and type  [Double]: Left
> value is null, cannot complete compare for the operator less calling service
> updateInventoryItem in receiveInventoryProduct
>
> I think we have to add a null check for unitCost at Line 218 of
> InventoryServices.xml for updateInventoryProduct before
> doing <if-compare field-name="parameters.unitCost" operator="less" value="
> 0.0" type="Double">.
> It solves the problem.
>
> Thanks again,
> -- Vikas
>
>
> On Nov 30, 2007 8:00 PM, Jacopo Cappellato <[hidden email]> wrote:
>
>> Thanks Vikas,
>>
>> this is fixed it in rev. 599826
>>
>> Jacopo
>>
>>
>> Vikas Mayur wrote:
>>> Line number 222, InventoryServices.xml
>>> <set field-name="oldUnitCost" from-field="lookedUpValue.unitCost"/>
>>>
>>> This line is breaking the code.
>>> It should be
>>>
>>> <set field="oldUnitCost" from-field="lookedUpValue.unitCost"/>
>>>
>>> Thank you,
>>> -- Vikas
>>>
>>
>
>