[jira] Created: (OFBIZ-1437) Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity

[Nicolas Malin (Jira)]

Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
--------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1437
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
            Reporter: Jacopo Cappellato


Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
As usual, a product is associated to the category thru the ProductCategoryMember entity.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reassigned OFBIZ-1437:
-----------------------------------

    Assignee: Anil K Patel

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-1437:
---------------------------------------

    Attachment: getProductOrgGlAccountService.patch

Jacopo & Anil,

Here is the patch for this issue.

--
Ashish Vijaywargiya

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel closed OFBIZ-1437.
-------------------------------

    Resolution: Fixed

Ashish, thanks for patch, its in rev# 599175

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546573 ]

Jacopo Cappellato commented on OFBIZ-1437:
------------------------------------------

Anil, Ashish,

I was thinking to a slightly different approach: instead of looking the ProductCategoryGlAccount  by productCategoryId, we should verify if the parameters.productId is a member of the category that has the entry in ProductCategoryGlAccount.
So:

1) select the records in ProductCategoryGlAccount  that match the parameters.organizationPartyId and parameters.glAccountTypeId
2) iterate thru the list and for each category, verify if the product is a member of the category (ProductCategoryMember, also considering from/thru dates)
3) if we find a match then stop and return the ProductCategoryGlAccount.glAccountId

In this way the calling service will not have to bother to pass a categoryId together with the product.
What do you think?

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil K Patel reopened OFBIZ-1437:
---------------------------------


Make changes according to Jacopo's comments.

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-1437:
---------------------------------

    Attachment: getProductOrgGlAccountService.patch

Hi Jacopo, Anil
    Here is the patch for modifications according to new comments

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccountService.patch, getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mridul Pathak updated OFBIZ-1437:
---------------------------------

    Attachment: getProductOrgGlAccount_new_approach.patch

Jacopo and Anil,
Here is the patch for modifications according to the given comments with a new approach which is as follows.
1) Find out the ProductCategoryMember list for parameters.productId (Considering from/thru dates)
2) For each productCategoryId in the list find ProductCategoryGlAccount using fields parameters.organizationPartyId and parameters.glAccountTypreId.
3) If we find a match then stop and return the ProductCategoryGlAccount.glAccountId

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccount_new_approach.patch, getProductOrgGlAccountService.patch, getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12547144 ]

mridul.pathak edited comment on OFBIZ-1437 at 11/30/07 6:10 AM:
----------------------------------------------------------------

Jacopo and Anil,
Here is the patch for modifications according to the given comments with a new approach which is as follows.
1) Find out the ProductCategoryMember list for parameters.productId (Considering from/thru dates)
2) For each productCategoryId in the list find ProductCategoryGlAccount using fields parameters.organizationPartyId and parameters.glAccountTypreId.
3) If we find a match then stop and return the ProductCategoryGlAccount.glAccountId

Please use the patch which seems more suitable to you.

      was (Author: mridul.pathak):
    Jacopo and Anil,
Here is the patch for modifications according to the given comments with a new approach which is as follows.
1) Find out the ProductCategoryMember list for parameters.productId (Considering from/thru dates)
2) For each productCategoryId in the list find ProductCategoryGlAccount using fields parameters.organizationPartyId and parameters.glAccountTypreId.
3) If we find a match then stop and return the ProductCategoryGlAccount.glAccountId
 

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Anil K Patel
>         Attachments: getProductOrgGlAccount_new_approach.patch, getProductOrgGlAccountService.patch, getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1437:
----------------------------------------

    Assignee: Jacopo Cappellato  (was: Anil K Patel)

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>         Attachments: getProductOrgGlAccount_new_approach.patch, getProductOrgGlAccountService.patch, getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1437.
------------------------------------

    Resolution: Fixed

Thanks Mridul! Your patch is in rev. 599830

> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity
> --------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1437
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1437
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>         Attachments: getProductOrgGlAccount_new_approach.patch, getProductOrgGlAccountService.patch, getProductOrgGlAccountService.patch
>
>
> Modify the getProductOrgGlAccount service to also consider the new ProductCategoryGlAccount entity: the information in this file will be considered if no specific mapping for the productId was found in the ProductGlAccount entity and before looking at the general GlAccountTypeDefault entity.
> As usual, a product is associated to the category thru the ProductCategoryMember entity.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.