Re:svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re:svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

mrisaliti@libero.it
Thanks Jacques,

you have already done it, so delete my previously mail.

Marco

> Author: jleroux
> Date: Mon Dec 17 12:31:47 2007
> New Revision: 604986
>
> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
> Log:
> I guess it's better to put this one too (and 3 typos)
>
> Modified:
>     ofbiz/trunk/applications/accounting/config/payment.properties
>
> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/config/payment.properties (original)
> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon Dec 17 12:31:47 2007
> @@ -242,16 +242,16 @@
>  payment.paypal.business=[hidden email]
>
>  # PayPal Notify URL
> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>
>  # PayPal Return URL
> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>
>  # PayPal Return On Cancel URL
> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>
>  # Image To Use On PayPal
> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>
>  # Thank-You / Confirm Order Template (rendered via Freemarker)
>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

Jacopo Cappellato
Maybe I'm missing something but: shouldn't we comment (#) these entries?

Jacopo

[hidden email] wrote:

> Thanks Jacques,
>
> you have already done it, so delete my previously mail.
>
> Marco
>
>> Author: jleroux
>> Date: Mon Dec 17 12:31:47 2007
>> New Revision: 604986
>>
>> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
>> Log:
>> I guess it's better to put this one too (and 3 typos)
>>
>> Modified:
>>     ofbiz/trunk/applications/accounting/config/payment.properties
>>
>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/applications/accounting/config/payment.properties (original)
>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon Dec 17 12:31:47 2007
>> @@ -242,16 +242,16 @@
>>  payment.paypal.business=[hidden email]
>>  
>>  # PayPal Notify URL
>> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
>> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>  
>>  # PayPal Return URL
>> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
>> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>  
>>  # PayPal Return On Cancel URL
>> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
>> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>  
>>  # Image To Use On PayPal
>> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
>> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>  
>>  # Thank-You / Confirm Order Template (rendered via Freemarker)
>>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>
>>
>>
>


Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

mrisaliti@libero.it
In reply to this post by mrisaliti@libero.it
If there is a broken link simply PayPal cannot notify their requests to OFBiz.
So we can leave like it is and when someone want to test it has to insert a valid link or comment it.

Thanks
Marco


> Maybe I'm missing something but: shouldn't we comment (#) these entries?
>
> Jacopo
>
> [hidden email] wrote:
> > Thanks Jacques,
> >
> > you have already done it, so delete my previously mail.
> >
> > Marco
> >
> >> Author: jleroux
> >> Date: Mon Dec 17 12:31:47 2007
> >> New Revision: 604986
> >>
> >> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
> >> Log:
> >> I guess it's better to put this one too (and 3 typos)
> >>
> >> Modified:
> >>     ofbiz/trunk/applications/accounting/config/payment.properties
> >>
> >> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
> >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff
> >> ==============================================================================
> >> --- ofbiz/trunk/applications/accounting/config/payment.properties (original)
> >> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon Dec 17 12:31:47 2007
> >> @@ -242,16 +242,16 @@
> >>  payment.paypal.business=[hidden email]
> >>
> >>  # PayPal Notify URL
> >> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
> >> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
> >>
> >>  # PayPal Return URL
> >> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
> >> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
> >>
> >>  # PayPal Return On Cancel URL
> >> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
> >> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
> >>
> >>  # Image To Use On PayPal
> >> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
> >> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
> >>
> >>  # Thank-You / Confirm Order Template (rendered via Freemarker)
> >>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
> >>
> >>
> >>
> >
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

BJ Freeman
In reply to this post by Jacopo Cappellato
I agree
plus
configname=
so we can check if it is null.
see my other email\Re: svn commit: r604632
dated 12/16/2007 7:42 AM

Jacopo Cappellato sent the following on 12/18/2007 1:08 AM:

> Maybe I'm missing something but: shouldn't we comment (#) these entries?
>
> Jacopo
>
> [hidden email] wrote:
>> Thanks Jacques,
>>
>> you have already done it, so delete my previously mail.
>>
>> Marco
>>
>>> Author: jleroux
>>> Date: Mon Dec 17 12:31:47 2007
>>> New Revision: 604986
>>>
>>> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
>>> Log:
>>> I guess it's better to put this one too (and 3 typos)
>>>
>>> Modified:
>>>     ofbiz/trunk/applications/accounting/config/payment.properties
>>>
>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>> (original)
>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon
>>> Dec 17 12:31:47 2007
>>> @@ -242,16 +242,16 @@
>>>  payment.paypal.business=[hidden email]
>>>  
>>>  # PayPal Notify URL
>>> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
>>>
>>> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>
>>>  
>>>  # PayPal Return URL
>>> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
>>>
>>> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>
>>>  
>>>  # PayPal Return On Cancel URL
>>> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
>>>
>>> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>
>>>  
>>>  # Image To Use On PayPal
>>> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
>>> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>>  
>>>  # Thank-You / Confirm Order Template (rendered via Freemarker)
>>>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>
>>>
>>>
>>
>
>
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

Jacques Le Roux
Administrator
I will look at "configname=" tomorrow...

Jacques

> I agree
> plus
> configname=
> so we can check if it is null.
> see my other email\Re: svn commit: r604632
> dated 12/16/2007 7:42 AM
>
> Jacopo Cappellato sent the following on 12/18/2007 1:08 AM:
> > Maybe I'm missing something but: shouldn't we comment (#) these entries?
> >
> > Jacopo
> >
> > [hidden email] wrote:
> >> Thanks Jacques,
> >>
> >> you have already done it, so delete my previously mail.
> >>
> >> Marco
> >>
> >>> Author: jleroux
> >>> Date: Mon Dec 17 12:31:47 2007
> >>> New Revision: 604986
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
> >>> Log:
> >>> I guess it's better to put this one too (and 3 typos)
> >>>
> >>> Modified:
> >>>     ofbiz/trunk/applications/accounting/config/payment.properties
> >>>
> >>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
> >>> URL:
> >>>
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff

> >>>
> >>> ==============================================================================
> >>>
> >>> --- ofbiz/trunk/applications/accounting/config/payment.properties
> >>> (original)
> >>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon
> >>> Dec 17 12:31:47 2007
> >>> @@ -242,16 +242,16 @@
> >>>  payment.paypal.business=[hidden email]
> >>>
> >>>  # PayPal Notify URL
> >>> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
> >>>
> >>> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
> >>>
> >>>
> >>>  # PayPal Return URL
> >>> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
> >>>
> >>> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
> >>>
> >>>
> >>>  # PayPal Return On Cancel URL
> >>> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
> >>>
> >>> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
> >>>
> >>>
> >>>  # Image To Use On PayPal
> >>> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
> >>> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
> >>>
> >>>  # Thank-You / Confirm Order Template (rendered via Freemarker)
> >>>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
> >>>
> >>>
> >>>
> >>
> >
> >
> >
> >
> >
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

Jacques Le Roux
Administrator
BJ,

I can't see what you mean by "configname="

Jacques

De : "Jacques Le Roux" <[hidden email]>

> I will look at "configname=" tomorrow...
>
> Jacques
>
> > I agree
> > plus
> > configname=
> > so we can check if it is null.
> > see my other email\Re: svn commit: r604632
> > dated 12/16/2007 7:42 AM
> >
> > Jacopo Cappellato sent the following on 12/18/2007 1:08 AM:
> > > Maybe I'm missing something but: shouldn't we comment (#) these entries?
> > >
> > > Jacopo
> > >
> > > [hidden email] wrote:
> > >> Thanks Jacques,
> > >>
> > >> you have already done it, so delete my previously mail.
> > >>
> > >> Marco
> > >>
> > >>> Author: jleroux
> > >>> Date: Mon Dec 17 12:31:47 2007
> > >>> New Revision: 604986
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
> > >>> Log:
> > >>> I guess it's better to put this one too (and 3 typos)
> > >>>
> > >>> Modified:
> > >>>     ofbiz/trunk/applications/accounting/config/payment.properties
> > >>>
> > >>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
> > >>> URL:
> > >>>
>
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff

> > >>>
> > >>> ==============================================================================
> > >>>
> > >>> --- ofbiz/trunk/applications/accounting/config/payment.properties
> > >>> (original)
> > >>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon
> > >>> Dec 17 12:31:47 2007
> > >>> @@ -242,16 +242,16 @@
> > >>>  payment.paypal.business=[hidden email]
> > >>>
> > >>>  # PayPal Notify URL
> > >>> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
> > >>>
> > >>> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
> > >>>
> > >>>
> > >>>  # PayPal Return URL
> > >>> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
> > >>>
> > >>> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
> > >>>
> > >>>
> > >>>  # PayPal Return On Cancel URL
> > >>> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
> > >>>
> > >>> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
> > >>>
> > >>>
> > >>>  # Image To Use On PayPal
> > >>> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
> > >>> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
> > >>>
> > >>>  # Thank-You / Confirm Order Template (rendered via Freemarker)
> > >>>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
> > >>>
> > >>>
> > >>>
> > >>
> > >
> > >
> > >
> > >
> > >
> >
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r604986 - /ofbiz/trunk/applications/accounting/config/payment.properties

BJ Freeman
My apologies. bad choice of words
configname=
should be
propertyname=

the code submitted with the orginal patch, looks for nulll from the
property .
so
in the property file
payment.paypal.notify=
returns a null.
so put a comment in the property file that has the suggested
line
#payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify

that way it is documented right above the empty
Propertyname
and will be caught by the added code to look for a null for those
properties.

Jacques Le Roux sent the following on 12/19/2007 7:20 AM:

> BJ,
>
> I can't see what you mean by "configname="
>
> Jacques
>
> De : "Jacques Le Roux" <[hidden email]>
>> I will look at "configname=" tomorrow...
>>
>> Jacques
>>
>>> I agree
>>> plus
>>> configname=
>>> so we can check if it is null.
>>> see my other email\Re: svn commit: r604632
>>> dated 12/16/2007 7:42 AM
>>>
>>> Jacopo Cappellato sent the following on 12/18/2007 1:08 AM:
>>>> Maybe I'm missing something but: shouldn't we comment (#) these entries?
>>>>
>>>> Jacopo
>>>>
>>>> [hidden email] wrote:
>>>>> Thanks Jacques,
>>>>>
>>>>> you have already done it, so delete my previously mail.
>>>>>
>>>>> Marco
>>>>>
>>>>>> Author: jleroux
>>>>>> Date: Mon Dec 17 12:31:47 2007
>>>>>> New Revision: 604986
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=604986&view=rev
>>>>>> Log:
>>>>>> I guess it's better to put this one too (and 3 typos)
>>>>>>
>>>>>> Modified:
>>>>>>     ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>>
>>>>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>> URL:
>>>>>>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=604986&r1=604985&r2=604986&view=diff
>>>>>> ==============================================================================
>>>>>>
>>>>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>> (original)
>>>>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Mon
>>>>>> Dec 17 12:31:47 2007
>>>>>> @@ -242,16 +242,16 @@
>>>>>>  payment.paypal.business=[hidden email]
>>>>>>
>>>>>>  # PayPal Notify URL
>>>>>> -payment.paypal.notify=http://[yourServerName)/ecommerce/control/payPalNotify
>>>>>>
>>>>>> +payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>>>
>>>>>>
>>>>>>  # PayPal Return URL
>>>>>> -payment.paypal.return=http://[yourServerName)/ecommerce/control/orderhistory
>>>>>>
>>>>>> +payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>>>
>>>>>>
>>>>>>  # PayPal Return On Cancel URL
>>>>>> -payment.paypal.cancelReturn=http://[yourServerName)/ecommerce/control/payPalCancel/main
>>>>>>
>>>>>> +payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>>>
>>>>>>
>>>>>>  # Image To Use On PayPal
>>>>>> -payment.paypal.image=http://demo.hotwaxmedia.com/images/ofbiz_logo.jpg
>>>>>> +payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>>>>>
>>>>>>  # Thank-You / Confirm Order Template (rendered via Freemarker)
>>>>>>  payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>>
>>>>
>
>
>
>