Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
Locked
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
 
|
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
|
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
|
|
From a data modeling perspective this doesn't constrain having a single default rate type... perhaps it would be better to add a defaultRateTypeId field to the Person entity (would say Party, but I don't know if we'll need to bill for an entire organization... maybe so though... so maybe better on Party). -David On Jan 7, 2008, at 11:48 PM, Hans Bakker wrote: > Hi David, > > it is not the point that another ratetype will help we already have > that. When employees however fill in their timesheet we have employees > that are charged full rate because they are fully trained, and have > employees who are in training and should be charged half. We indeed > have > a rate for full and for half. > > On the timesheet it would be very helpful that depending on the > employee > a default rateType is already filled in. That is where this default > rate > indicator is coming in. They can then still adjust it for overtime > etc.. > > I am already using this in the weekly timesheet of the project > manager. > > Regards, Hans > > > On Mon, 2008-01-07 at 23:02 -0700, David E Jones wrote: >> Based on the requirement described in the commit log it sounds like >> using another RateType for that would be the way to go. >> >> Could you describe why this is needed instead of using another >> RateType (along with PartyRate)? >> >> -David >> >> >> On Jan 7, 2008, at 10:47 PM, [hidden email] wrote: >> >>> Author: hansbak >>> Date: Mon Jan 7 21:47:02 2008 >>> New Revision: 609878 >>> >>> URL: http://svn.apache.org/viewvc?rev=609878&view=rev >>> Log: >>> add a indicator field to the partyRate table to indicate what is the >>> default rate of a party, this is required for employees who are in >>> training and for which a reduced rate is invoiced to the customer >>> >>> Modified: >>> ofbiz/trunk/applications/party/webapp/partymgr/party/ >>> PartyForms.xml >>> ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>> >>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/ >>> PartyForms.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml?rev=609878&r1=609877&r2=609878&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/party/webapp/partymgr/party/ >>> PartyForms.xml (original) >>> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/ >>> PartyForms.xml Mon Jan 7 21:47:02 2008 >>> @@ -264,6 +264,12 @@ >>> </entity-options> >>> </drop-down> >>> </field> >>> + <field name="defaultRate"> >>> + <drop-down no-current-selected-key="N"> >>> + <option key="N"/> >>> + <option key="Y"/> >>> + </drop-down> >>> + </field> >>> <field name="submitButton" title="$ >>> {uiLabelMap.CommonCreate}"><submit button-type="button"/></field> >>> </form> >>> >>> >>> Modified: ofbiz/trunk/applications/workeffort/entitydef/ >>> entitymodel.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml?rev=609878&r1=609877&r2=609878&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ==================================================================== >>> --- ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>> (original) >>> +++ ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>> Mon Jan 7 21:47:02 2008 >>> @@ -46,6 +46,7 @@ >>> title="Party Rate Entity"> >>> <field name="partyId" type="id-ne"></field> >>> <field name="rateTypeId" type="id-ne"></field> >>> + <field name="defaultRate" type="indicator"></field> >>> <field name="fromDate" type="date-time"></field> >>> <field name="thruDate" type="date-time"></field> >>> <field name="rate" type="currency-amount"></field> >>> >>> >> >> > |
smime.p7s (3K)
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
|
|
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
|
|
Re: svn commit: r609878 - in /ofbiz/trunk/applications: party/webapp/partymgr/party/Pa
|
|
I personally like constraining things like this at a data model level whenever possible, but this is another valid approach, and the type of thing is supposed to be plenty with the ofbiz architecture as all updates should go through the low-level services... -David On Jan 8, 2008, at 7:19 AM, Hans Bakker wrote: > Ok David, i changed the services a bit to ensure there is only one > active record with the flag set at 'Y' > > Regards, > Hans > > > On Tue, 2008-01-08 at 00:11 -0700, David E Jones wrote: >> From a data modeling perspective this doesn't constrain having a >> single default rate type... perhaps it would be better to add a >> defaultRateTypeId field to the Person entity (would say Party, but I >> don't know if we'll need to bill for an entire organization... maybe >> so though... so maybe better on Party). >> >> -David >> >> >> On Jan 7, 2008, at 11:48 PM, Hans Bakker wrote: >> >>> Hi David, >>> >>> it is not the point that another ratetype will help we already have >>> that. When employees however fill in their timesheet we have >>> employees >>> that are charged full rate because they are fully trained, and have >>> employees who are in training and should be charged half. We indeed >>> have >>> a rate for full and for half. >>> >>> On the timesheet it would be very helpful that depending on the >>> employee >>> a default rateType is already filled in. That is where this default >>> rate >>> indicator is coming in. They can then still adjust it for overtime >>> etc.. >>> >>> I am already using this in the weekly timesheet of the project >>> manager. >>> >>> Regards, Hans >>> >>> >>> On Mon, 2008-01-07 at 23:02 -0700, David E Jones wrote: >>>> Based on the requirement described in the commit log it sounds like >>>> using another RateType for that would be the way to go. >>>> >>>> Could you describe why this is needed instead of using another >>>> RateType (along with PartyRate)? >>>> >>>> -David >>>> >>>> >>>> On Jan 7, 2008, at 10:47 PM, [hidden email] wrote: >>>> >>>>> Author: hansbak >>>>> Date: Mon Jan 7 21:47:02 2008 >>>>> New Revision: 609878 >>>>> >>>>> URL: http://svn.apache.org/viewvc?rev=609878&view=rev >>>>> Log: >>>>> add a indicator field to the partyRate table to indicate what is >>>>> the >>>>> default rate of a party, this is required for employees who are in >>>>> training and for which a reduced rate is invoiced to the customer >>>>> >>>>> Modified: >>>>> ofbiz/trunk/applications/party/webapp/partymgr/party/ >>>>> PartyForms.xml >>>>> ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>>>> >>>>> Modified: ofbiz/trunk/applications/party/webapp/partymgr/party/ >>>>> PartyForms.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/webapp/partymgr/party/PartyForms.xml?rev=609878&r1=609877&r2=609878&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/party/webapp/partymgr/party/ >>>>> PartyForms.xml (original) >>>>> +++ ofbiz/trunk/applications/party/webapp/partymgr/party/ >>>>> PartyForms.xml Mon Jan 7 21:47:02 2008 >>>>> @@ -264,6 +264,12 @@ >>>>> </entity-options> >>>>> </drop-down> >>>>> </field> >>>>> + <field name="defaultRate"> >>>>> + <drop-down no-current-selected-key="N"> >>>>> + <option key="N"/> >>>>> + <option key="Y"/> >>>>> + </drop-down> >>>>> + </field> >>>>> <field name="submitButton" title="$ >>>>> {uiLabelMap.CommonCreate}"><submit button-type="button"/></field> >>>>> </form> >>>>> >>>>> >>>>> Modified: ofbiz/trunk/applications/workeffort/entitydef/ >>>>> entitymodel.xml >>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml?rev=609878&r1=609877&r2=609878&view=diff >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> = >>>>> ================================================================== >>>>> --- ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>>>> (original) >>>>> +++ ofbiz/trunk/applications/workeffort/entitydef/entitymodel.xml >>>>> Mon Jan 7 21:47:02 2008 >>>>> @@ -46,6 +46,7 @@ >>>>> title="Party Rate Entity"> >>>>> <field name="partyId" type="id-ne"></field> >>>>> <field name="rateTypeId" type="id-ne"></field> >>>>> + <field name="defaultRate" type="indicator"></field> >>>>> <field name="fromDate" type="date-time"></field> >>>>> <field name="thruDate" type="date-time"></field> >>>>> <field name="rate" type="currency-amount"></field> >>>>> >>>>> >>>> >>>> >>> >> > |
| Free forum by Nabble | Edit this page |