Re: svn commit: r649287 - /ofbiz/trunk/framework/images/webapp/images/maincss.css

[Jacques Le Roux]

Thanks Adrian,

But are you sure you prefer to see the menus vertically so near from each other ? Anyway this are really cosmetic issues since now
it's OK in IE7 :o)

Jacques

From: <[hidden email]>

> Author: adrianc
> Date: Thu Apr 17 14:33:56 2008
> New Revision: 649287
>
> URL: http://svn.apache.org/viewvc?rev=649287&view=rev
> Log:
> Fixed tab-bar style change that was made in rev 647632 - tab-bar style is now back to the way it was. I confirmed it displays
> properly in Firefox and IE7.
>
> Modified:
>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>
> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Apr 17 14:33:56 2008
> @@ -1537,9 +1537,11 @@
> /* tab-bar decorator intended to be used at
> the top of the main content area */
> .tab-bar {
> -margin-left: 0em;
> -margin-top: 0em;
> +margin-left: -1em;
> +margin-top: -1em;
> padding: 0;
> +position:absolute;
> +z-index: 2;
> }
>
> .tab-bar ul li {
>
>

[Adrian Crum]

Jacques,

The original intent of the tab-bar style was to make it look like a row
of tabs along the top of the content area. The previous commit moved the
tabs away from the top of the content area.

-Adrian

Jacques Le Roux wrote:

> Thanks Adrian,
>
> But are you sure you prefer to see the menus vertically so near from
> each other ? Anyway this are really cosmetic issues since now it's OK in
> IE7 :o)
>
> Jacques
>
> From: <[hidden email]>
>> Author: adrianc
>> Date: Thu Apr 17 14:33:56 2008
>> New Revision: 649287
>>
>> URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>> Log:
>> Fixed tab-bar style change that was made in rev 647632 - tab-bar style
>> is now back to the way it was. I confirmed it displays
>> properly in Firefox and IE7.
>>
>> Modified:
>>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>>
>> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff 
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
>> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Apr 17
>> 14:33:56 2008
>> @@ -1537,9 +1537,11 @@
>> /* tab-bar decorator intended to be used at
>> the top of the main content area */
>> .tab-bar {
>> -margin-left: 0em;
>> -margin-top: 0em;
>> +margin-left: -1em;
>> +margin-top: -1em;
>> padding: 0;
>> +position:absolute;
>> +z-index: 2;
>> }
>>
>> .tab-bar ul li {
>>
>>
>
>

[Jacques Le Roux]

Adrian,

Yes I saw. I just wondered if a "blank line" betwen the 1st menu of the content area and the second (etc.) could not make it more
readeable but actually it's just a matter of taste and it seems that anybody but us are interested ;o)

Thanks

Jacques

From: "Adrian Crum" <[hidden email]>

> Jacques,
>
> The original intent of the tab-bar style was to make it look like a row of tabs along the top of the content area. The previous
> commit moved the tabs away from the top of the content area.
>
> -Adrian
>
> Jacques Le Roux wrote:
>> Thanks Adrian,
>>
>> But are you sure you prefer to see the menus vertically so near from each other ? Anyway this are really cosmetic issues since
>> now it's OK in IE7 :o)
>>
>> Jacques
>>
>> From: <[hidden email]>
>>> Author: adrianc
>>> Date: Thu Apr 17 14:33:56 2008
>>> New Revision: 649287
>>>
>>> URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>>> Log:
>>> Fixed tab-bar style change that was made in rev 647632 - tab-bar style is now back to the way it was. I confirmed it displays
>>> properly in Firefox and IE7.
>>>
>>> Modified:
>>>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>>>
>>> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
>>> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Apr 17 14:33:56 2008
>>> @@ -1537,9 +1537,11 @@
>>> /* tab-bar decorator intended to be used at
>>> the top of the main content area */
>>> .tab-bar {
>>> -margin-left: 0em;
>>> -margin-top: 0em;
>>> +margin-left: -1em;
>>> +margin-top: -1em;
>>> padding: 0;
>>> +position:absolute;
>>> +z-index: 2;
>>> }
>>>
>>> .tab-bar ul li {
>>>
>>>
>>
>>
>

[Jacques Le Roux]

> Adrian,
>
> Yes I saw. I just wondered if a "blank line" betwen the 1st menu of the content area and the second (etc.) could not make it more
> readeable but actually it's just a matter of taste and it seems that anybody but us are interested ;o)

Adrian,

BTW there is still this weird behaviour in IE 7 I mentionned in
https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438#action_12588438. I may fix it if you give me some clues ?

Thanks

Jacques

> Thanks
>
> Jacques
>
> From: "Adrian Crum" <[hidden email]>
>> Jacques,
>>
>> The original intent of the tab-bar style was to make it look like a row of tabs along the top of the content area. The previous
>> commit moved the tabs away from the top of the content area.
>>
>> -Adrian
>>
>> Jacques Le Roux wrote:
>>> Thanks Adrian,
>>>
>>> But are you sure you prefer to see the menus vertically so near from each other ? Anyway this are really cosmetic issues since
>>> now it's OK in IE7 :o)
>>>
>>> Jacques
>>>
>>> From: <[hidden email]>
>>>> Author: adrianc
>>>> Date: Thu Apr 17 14:33:56 2008
>>>> New Revision: 649287
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>>>> Log:
>>>> Fixed tab-bar style change that was made in rev 647632 - tab-bar style is now back to the way it was. I confirmed it displays
>>>> properly in Firefox and IE7.
>>>>
>>>> Modified:
>>>>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>>>>
>>>> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
>>>> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Apr 17 14:33:56 2008
>>>> @@ -1537,9 +1537,11 @@
>>>> /* tab-bar decorator intended to be used at
>>>> the top of the main content area */
>>>> .tab-bar {
>>>> -margin-left: 0em;
>>>> -margin-top: 0em;
>>>> +margin-left: -1em;
>>>> +margin-top: -1em;
>>>> padding: 0;
>>>> +position:absolute;
>>>> +z-index: 2;
>>>> }
>>>>
>>>> .tab-bar ul li {
>>>>
>>>>
>>>
>>>
>>
>

[Adrian Crum]

Jacques,

I'll take a look at it this weekend, and I want to work on some other
layout issues as well.

Some time ago I started working on refactoring the main style sheet, but
I never finished it because things got busy at work. Maybe I'll get it
finished this weekend.

Btw, I don't like how my change affects the lower button bar either, but
I don't have a solution right now. I can get the layout to work in one
browser or the other, but not both.

-Adrian

Jacques Le Roux wrote:

>> Adrian,
>>
>> Yes I saw. I just wondered if a "blank line" betwen the 1st menu of
>> the content area and the second (etc.) could not make it more
>> readeable but actually it's just a matter of taste and it seems that
>> anybody but us are interested ;o)
>
> Adrian,
>
> BTW there is still this weird behaviour in IE 7 I mentionned in
> https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438#action_12588438.
> I may fix it if you give me some clues ?
>
> Thanks
>
> Jacques
>
>> Thanks
>>
>> Jacques
>>
>> From: "Adrian Crum" <[hidden email]>
>>> Jacques,
>>>
>>> The original intent of the tab-bar style was to make it look like a
>>> row of tabs along the top of the content area. The previous
>>> commit moved the tabs away from the top of the content area.
>>>
>>> -Adrian
>>>
>>> Jacques Le Roux wrote:
>>>> Thanks Adrian,
>>>>
>>>> But are you sure you prefer to see the menus vertically so near from
>>>> each other ? Anyway this are really cosmetic issues since
>>>> now it's OK in IE7 :o)
>>>>
>>>> Jacques
>>>>
>>>> From: <[hidden email]>
>>>>> Author: adrianc
>>>>> Date: Thu Apr 17 14:33:56 2008
>>>>> New Revision: 649287
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>>>>> Log:
>>>>> Fixed tab-bar style change that was made in rev 647632 - tab-bar
>>>>> style is now back to the way it was. I confirmed it displays
>>>>> properly in Firefox and IE7.
>>>>>
>>>>> Modified:
>>>>>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>>>>>
>>>>> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff 
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
>>>>> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Apr
>>>>> 17 14:33:56 2008
>>>>> @@ -1537,9 +1537,11 @@
>>>>> /* tab-bar decorator intended to be used at
>>>>> the top of the main content area */
>>>>> .tab-bar {
>>>>> -margin-left: 0em;
>>>>> -margin-top: 0em;
>>>>> +margin-left: -1em;
>>>>> +margin-top: -1em;
>>>>> padding: 0;
>>>>> +position:absolute;
>>>>> +z-index: 2;
>>>>> }
>>>>>
>>>>> .tab-bar ul li {
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>
>

[Bruno Busco]

I have given a look to this layout issue.
It seems to me that it is also necessary some change in the ftl files
becouse even with the same browser (FF) the tab-bar is displayed differently
in different screens.

For example see those two:
https://localhost:8443/catalog/control/EditProduct?productId=10000
https://localhost:8443/facility/control/EditInventoryItem?productId=10000

It could be impossible (or may be very tricky) to fix it with a css only
change.

-Bruno


2008/4/18, Adrian Crum <[hidden email]>:

>
> Jacques,
>
> I'll take a look at it this weekend, and I want to work on some other
> layout issues as well.
>
> Some time ago I started working on refactoring the main style sheet, but I
> never finished it because things got busy at work. Maybe I'll get it
> finished this weekend.
>
> Btw, I don't like how my change affects the lower button bar either, but I
> don't have a solution right now. I can get the layout to work in one browser
> or the other, but not both.
>
> -Adrian
>
> Jacques Le Roux wrote:
>
> > Adrian,
> > >
> > > Yes I saw. I just wondered if a "blank line" betwen the 1st menu of
> > > the content area and the second (etc.) could not make it more
> > > readeable but actually it's just a matter of taste and it seems that
> > > anybody but us are interested ;o)
> > >
> >
> > Adrian,
> >
> > BTW there is still this weird behaviour in IE 7 I mentionned in
> >
> > https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438#action_12588438.
> > I may fix it if you give me some clues ?
> >
> > Thanks
> >
> > Jacques
> >
> >  Thanks
> > >
> > > Jacques
> > >
> > > From: "Adrian Crum" <[hidden email]>
> > >
> > > > Jacques,
> > > >
> > > > The original intent of the tab-bar style was to make it look like a
> > > > row of tabs along the top of the content area. The previous
> > > > commit moved the tabs away from the top of the content area.
> > > >
> > > > -Adrian
> > > >
> > > > Jacques Le Roux wrote:
> > > >
> > > > > Thanks Adrian,
> > > > >
> > > > > But are you sure you prefer to see the menus vertically so near
> > > > > from each other ? Anyway this are really cosmetic issues since
> > > > > now it's OK in IE7 :o)
> > > > >
> > > > > Jacques
> > > > >
> > > > > From: <[hidden email]>
> > > > >
> > > > > > Author: adrianc
> > > > > > Date: Thu Apr 17 14:33:56 2008
> > > > > > New Revision: 649287
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?rev=649287&view=rev
> > > > > > Log:
> > > > > > Fixed tab-bar style change that was made in rev 647632 - tab-bar
> > > > > > style is now back to the way it was. I confirmed it displays
> > > > > > properly in Firefox and IE7.
> > > > > >
> > > > > > Modified:
> > > > > >   ofbiz/trunk/framework/images/webapp/images/maincss.css
> > > > > >
> > > > > > Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
> > > > > > URL:
> > > > > >
> > > > > > http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
> > > > > > ==============================================================================
> > > > > >
> > > > > > --- ofbiz/trunk/framework/images/webapp/images/maincss.css
> > > > > > (original)
> > > > > > +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu
> > > > > > Apr 17 14:33:56 2008
> > > > > > @@ -1537,9 +1537,11 @@
> > > > > > /* tab-bar decorator intended to be used at
> > > > > > the top of the main content area */
> > > > > > .tab-bar {
> > > > > > -margin-left: 0em;
> > > > > > -margin-top: 0em;
> > > > > > +margin-left: -1em;
> > > > > > +margin-top: -1em;
> > > > > > padding: 0;
> > > > > > +position:absolute;
> > > > > > +z-index: 2;
> > > > > > }
> > > > > >
> > > > > > .tab-bar ul li {
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> >

[Jacques Le Roux]

Hi All,

I would like to revert Adrian's last changes as they are worse than those introduced by Krzysztof : they have side-effects as Bruno
pointed ou below.
Look also at
https://demo.hotwaxmedia.com/catalog/control/EditCategory?productCategoryId=PC-100 (Adrian's changes)
don't you prefer (for now)
https://lamouline.myvnc.com/catalog/control/EditCategory?productCategoryId=PC-100  (Krzysztof's changes)
I'm pretty sure Adrian will find a better solution (including Bruno's remarks below), maybe with some help from us... But in the
meantime I would like to revert.

BTW,  don't you feel that in certain cases (catalog sub-menu for instance) we should introduce drop-down menus ? There are to many
options there and we could group them by themes. The goal is obvious: readability.

What do you think ?

Jacques

From: "Bruno Busco" <[hidden email]>

>I have given a look to this layout issue.
> It seems to me that it is also necessary some change in the ftl files
> becouse even with the same browser (FF) the tab-bar is displayed differently
> in different screens.
>
> For example see those two:
> https://localhost:8443/catalog/control/EditProduct?productId=10000
> https://localhost:8443/facility/control/EditInventoryItem?productId=10000
>
> It could be impossible (or may be very tricky) to fix it with a css only
> change.
>
> -Bruno
>
>
> 2008/4/18, Adrian Crum <[hidden email]>:
>>
>> Jacques,
>>
>> I'll take a look at it this weekend, and I want to work on some other
>> layout issues as well.
>>
>> Some time ago I started working on refactoring the main style sheet, but I
>> never finished it because things got busy at work. Maybe I'll get it
>> finished this weekend.
>>
>> Btw, I don't like how my change affects the lower button bar either, but I
>> don't have a solution right now. I can get the layout to work in one browser
>> or the other, but not both.
>>
>> -Adrian
>>
>> Jacques Le Roux wrote:
>>
>> > Adrian,
>> > >
>> > > Yes I saw. I just wondered if a "blank line" betwen the 1st menu of
>> > > the content area and the second (etc.) could not make it more
>> > > readeable but actually it's just a matter of taste and it seems that
>> > > anybody but us are interested ;o)
>> > >
>> >
>> > Adrian,
>> >
>> > BTW there is still this weird behaviour in IE 7 I mentionned in
>> >
>> > https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438#action_12588438.
>> > I may fix it if you give me some clues ?
>> >
>> > Thanks
>> >
>> > Jacques
>> >
>> >  Thanks
>> > >
>> > > Jacques
>> > >
>> > > From: "Adrian Crum" <[hidden email]>
>> > >
>> > > > Jacques,
>> > > >
>> > > > The original intent of the tab-bar style was to make it look like a
>> > > > row of tabs along the top of the content area. The previous
>> > > > commit moved the tabs away from the top of the content area.
>> > > >
>> > > > -Adrian
>> > > >
>> > > > Jacques Le Roux wrote:
>> > > >
>> > > > > Thanks Adrian,
>> > > > >
>> > > > > But are you sure you prefer to see the menus vertically so near
>> > > > > from each other ? Anyway this are really cosmetic issues since
>> > > > > now it's OK in IE7 :o)
>> > > > >
>> > > > > Jacques
>> > > > >
>> > > > > From: <[hidden email]>
>> > > > >
>> > > > > > Author: adrianc
>> > > > > > Date: Thu Apr 17 14:33:56 2008
>> > > > > > New Revision: 649287
>> > > > > >
>> > > > > > URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>> > > > > > Log:
>> > > > > > Fixed tab-bar style change that was made in rev 647632 - tab-bar
>> > > > > > style is now back to the way it was. I confirmed it displays
>> > > > > > properly in Firefox and IE7.
>> > > > > >
>> > > > > > Modified:
>> > > > > >   ofbiz/trunk/framework/images/webapp/images/maincss.css
>> > > > > >
>> > > > > > Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
>> > > > > > URL:
>> > > > > >
>> > > > > > http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
>> > > > > > ==============================================================================
>> > > > > >
>> > > > > > --- ofbiz/trunk/framework/images/webapp/images/maincss.css
>> > > > > > (original)
>> > > > > > +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu
>> > > > > > Apr 17 14:33:56 2008
>> > > > > > @@ -1537,9 +1537,11 @@
>> > > > > > /* tab-bar decorator intended to be used at
>> > > > > > the top of the main content area */
>> > > > > > .tab-bar {
>> > > > > > -margin-left: 0em;
>> > > > > > -margin-top: 0em;
>> > > > > > +margin-left: -1em;
>> > > > > > +margin-top: -1em;
>> > > > > > padding: 0;
>> > > > > > +position:absolute;
>> > > > > > +z-index: 2;
>> > > > > > }
>> > > > > >
>> > > > > > .tab-bar ul li {
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>> >
>

[Jacopo Cappellato-3]

Yes, please revert.
The submenus are unusable in Safari because they are hidden by the  
previous ones.

Jacopo


On Apr 21, 2008, at 9:50 AM, Jacques Le Roux wrote:

> Hi All,
>
> I would like to revert Adrian's last changes as they are worse than  
> those introduced by Krzysztof : they have side-effects as Bruno  
> pointed ou below.
> Look also at
> https://demo.hotwaxmedia.com/catalog/control/EditCategory?productCategoryId=PC-100 
>  (Adrian's changes)
> don't you prefer (for now)
> https://lamouline.myvnc.com/catalog/control/EditCategory?productCategoryId=PC-100 
>   (Krzysztof's changes)
> I'm pretty sure Adrian will find a better solution (including  
> Bruno's remarks below), maybe with some help from us... But in the  
> meantime I would like to revert.
>
> BTW,  don't you feel that in certain cases (catalog sub-menu for  
> instance) we should introduce drop-down menus ? There are to many  
> options there and we could group them by themes. The goal is  
> obvious: readability.
>
> What do you think ?
>
> Jacques
>
> From: "Bruno Busco" <[hidden email]>
>> I have given a look to this layout issue.
>> It seems to me that it is also necessary some change in the ftl files
>> becouse even with the same browser (FF) the tab-bar is displayed  
>> differently
>> in different screens.
>>
>> For example see those two:
>> https://localhost:8443/catalog/control/EditProduct?productId=10000
>> https://localhost:8443/facility/control/EditInventoryItem?productId=10000
>>
>> It could be impossible (or may be very tricky) to fix it with a css  
>> only
>> change.
>>
>> -Bruno
>>
>>
>> 2008/4/18, Adrian Crum <[hidden email]>:
>>>
>>> Jacques,
>>>
>>> I'll take a look at it this weekend, and I want to work on some  
>>> other
>>> layout issues as well.
>>>
>>> Some time ago I started working on refactoring the main style  
>>> sheet, but I
>>> never finished it because things got busy at work. Maybe I'll get it
>>> finished this weekend.
>>>
>>> Btw, I don't like how my change affects the lower button bar  
>>> either, but I
>>> don't have a solution right now. I can get the layout to work in  
>>> one browser
>>> or the other, but not both.
>>>
>>> -Adrian
>>>
>>> Jacques Le Roux wrote:
>>>
>>> > Adrian,
>>> > >
>>> > > Yes I saw. I just wondered if a "blank line" betwen the 1st  
>>> menu of
>>> > > the content area and the second (etc.) could not make it more
>>> > > readeable but actually it's just a matter of taste and it  
>>> seems that
>>> > > anybody but us are interested ;o)
>>> > >
>>> >
>>> > Adrian,
>>> >
>>> > BTW there is still this weird behaviour in IE 7 I mentionned in
>>> >
>>> > https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438 
>>> #action_12588438.
>>> > I may fix it if you give me some clues ?
>>> >
>>> > Thanks
>>> >
>>> > Jacques
>>> >
>>> >  Thanks
>>> > >
>>> > > Jacques
>>> > >
>>> > > From: "Adrian Crum" <[hidden email]>
>>> > >
>>> > > > Jacques,
>>> > > >
>>> > > > The original intent of the tab-bar style was to make it look  
>>> like a
>>> > > > row of tabs along the top of the content area. The previous
>>> > > > commit moved the tabs away from the top of the content area.
>>> > > >
>>> > > > -Adrian
>>> > > >
>>> > > > Jacques Le Roux wrote:
>>> > > >
>>> > > > > Thanks Adrian,
>>> > > > >
>>> > > > > But are you sure you prefer to see the menus vertically so  
>>> near
>>> > > > > from each other ? Anyway this are really cosmetic issues  
>>> since
>>> > > > > now it's OK in IE7 :o)
>>> > > > >
>>> > > > > Jacques
>>> > > > >
>>> > > > > From: <[hidden email]>
>>> > > > >
>>> > > > > > Author: adrianc
>>> > > > > > Date: Thu Apr 17 14:33:56 2008
>>> > > > > > New Revision: 649287
>>> > > > > >
>>> > > > > > URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>>> > > > > > Log:
>>> > > > > > Fixed tab-bar style change that was made in rev 647632 -  
>>> tab-bar
>>> > > > > > style is now back to the way it was. I confirmed it  
>>> displays
>>> > > > > > properly in Firefox and IE7.
>>> > > > > >
>>> > > > > > Modified:
>>> > > > > >   ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> > > > > >
>>> > > > > > Modified: ofbiz/trunk/framework/images/webapp/images/
>>> maincss.css
>>> > > > > > URL:
>>> > > > > >
>>> > > > > > http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff
>>> > > > > >  
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> ====================================================================
>>> > > > > >
>>> > > > > > --- ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> > > > > > (original)
>>> > > > > > +++ ofbiz/trunk/framework/images/webapp/images/
>>> maincss.css Thu
>>> > > > > > Apr 17 14:33:56 2008
>>> > > > > > @@ -1537,9 +1537,11 @@
>>> > > > > > /* tab-bar decorator intended to be used at
>>> > > > > > the top of the main content area */
>>> > > > > > .tab-bar {
>>> > > > > > -margin-left: 0em;
>>> > > > > > -margin-top: 0em;
>>> > > > > > +margin-left: -1em;
>>> > > > > > +margin-top: -1em;
>>> > > > > > padding: 0;
>>> > > > > > +position:absolute;
>>> > > > > > +z-index: 2;
>>> > > > > > }
>>> > > > > >
>>> > > > > > .tab-bar ul li {
>>> > > > > >
>>> > > > > >
>>> > > > > >
>>> > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>> >
>

[Adrian Crum]

Jacques,

The revert is fine with me.

I spent a good part of the weekend trying to tackle this problem, and
Bruno is right - there is no way to correct it with CSS alone. I have
come up with a solution that will require re-working the screens that
use the tab-bar style. I will submit a Jira issue today or tomorrow that
will demonstrate my solution.

-Adrian

Jacques Le Roux wrote:

> Hi All,
>
> I would like to revert Adrian's last changes as they are worse than
> those introduced by Krzysztof : they have side-effects as Bruno pointed
> ou below.
> Look also at
> https://demo.hotwaxmedia.com/catalog/control/EditCategory?productCategoryId=PC-100 
> (Adrian's changes)
> don't you prefer (for now)
> https://lamouline.myvnc.com/catalog/control/EditCategory?productCategoryId=PC-100 
> (Krzysztof's changes)
> I'm pretty sure Adrian will find a better solution (including Bruno's
> remarks below), maybe with some help from us... But in the meantime I
> would like to revert.
>
> BTW,  don't you feel that in certain cases (catalog sub-menu for
> instance) we should introduce drop-down menus ? There are to many
> options there and we could group them by themes. The goal is obvious:
> readability.
>
> What do you think ?
>
> Jacques
>
> From: "Bruno Busco" <[hidden email]>
>> I have given a look to this layout issue.
>> It seems to me that it is also necessary some change in the ftl files
>> becouse even with the same browser (FF) the tab-bar is displayed
>> differently
>> in different screens.
>>
>> For example see those two:
>> https://localhost:8443/catalog/control/EditProduct?productId=10000
>> https://localhost:8443/facility/control/EditInventoryItem?productId=10000
>>
>> It could be impossible (or may be very tricky) to fix it with a css only
>> change.
>>
>> -Bruno
>>
>>
>> 2008/4/18, Adrian Crum <[hidden email]>:
>>>
>>> Jacques,
>>>
>>> I'll take a look at it this weekend, and I want to work on some other
>>> layout issues as well.
>>>
>>> Some time ago I started working on refactoring the main style sheet,
>>> but I
>>> never finished it because things got busy at work. Maybe I'll get it
>>> finished this weekend.
>>>
>>> Btw, I don't like how my change affects the lower button bar either,
>>> but I
>>> don't have a solution right now. I can get the layout to work in one
>>> browser
>>> or the other, but not both.
>>>
>>> -Adrian
>>>
>>> Jacques Le Roux wrote:
>>>
>>> > Adrian,
>>> > >
>>> > > Yes I saw. I just wondered if a "blank line" betwen the 1st menu of
>>> > > the content area and the second (etc.) could not make it more
>>> > > readeable but actually it's just a matter of taste and it seems that
>>> > > anybody but us are interested ;o)
>>> > >
>>> >
>>> > Adrian,
>>> >
>>> > BTW there is still this weird behaviour in IE 7 I mentionned in
>>> >
>>> >
>>> https://issues.apache.org/jira/browse/OFBIZ-1748?focusedCommentId=12588438#action_12588438.
>>>
>>> > I may fix it if you give me some clues ?
>>> >
>>> > Thanks
>>> >
>>> > Jacques
>>> >
>>> >  Thanks
>>> > >
>>> > > Jacques
>>> > >
>>> > > From: "Adrian Crum" <[hidden email]>
>>> > >
>>> > > > Jacques,
>>> > > >
>>> > > > The original intent of the tab-bar style was to make it look
>>> like a
>>> > > > row of tabs along the top of the content area. The previous
>>> > > > commit moved the tabs away from the top of the content area.
>>> > > >
>>> > > > -Adrian
>>> > > >
>>> > > > Jacques Le Roux wrote:
>>> > > >
>>> > > > > Thanks Adrian,
>>> > > > >
>>> > > > > But are you sure you prefer to see the menus vertically so near
>>> > > > > from each other ? Anyway this are really cosmetic issues since
>>> > > > > now it's OK in IE7 :o)
>>> > > > >
>>> > > > > Jacques
>>> > > > >
>>> > > > > From: <[hidden email]>
>>> > > > >
>>> > > > > > Author: adrianc
>>> > > > > > Date: Thu Apr 17 14:33:56 2008
>>> > > > > > New Revision: 649287
>>> > > > > >
>>> > > > > > URL: http://svn.apache.org/viewvc?rev=649287&view=rev
>>> > > > > > Log:
>>> > > > > > Fixed tab-bar style change that was made in rev 647632 -
>>> tab-bar
>>> > > > > > style is now back to the way it was. I confirmed it displays
>>> > > > > > properly in Firefox and IE7.
>>> > > > > >
>>> > > > > > Modified:
>>> > > > > >   ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> > > > > >
>>> > > > > > Modified:
>>> ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> > > > > > URL:
>>> > > > > >
>>> > > > > >
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=649287&r1=649286&r2=649287&view=diff 
>>>
>>> > > > > >
>>> ==============================================================================
>>>
>>> > > > > >
>>> > > > > > --- ofbiz/trunk/framework/images/webapp/images/maincss.css
>>> > > > > > (original)
>>> > > > > > +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu
>>> > > > > > Apr 17 14:33:56 2008
>>> > > > > > @@ -1537,9 +1537,11 @@
>>> > > > > > /* tab-bar decorator intended to be used at
>>> > > > > > the top of the main content area */
>>> > > > > > .tab-bar {
>>> > > > > > -margin-left: 0em;
>>> > > > > > -margin-top: 0em;
>>> > > > > > +margin-left: -1em;
>>> > > > > > +margin-top: -1em;
>>> > > > > > padding: 0;
>>> > > > > > +position:absolute;
>>> > > > > > +z-index: 2;
>>> > > > > > }
>>> > > > > >
>>> > > > > > .tab-bar ul li {
>>> > > > > >
>>> > > > > >
>>> > > > > >
>>> > > > >
>>> > > > >
>>> > > >
>>> > >
>>> >
>>> >
>>
>
>