[jira] Created: (OFBIZ-1744) The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.

[Nicolas Malin (Jira)]

The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-1744
                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
             Project: OFBiz
          Issue Type: Sub-task
          Components: accounting
            Reporter: Jacopo Cappellato
            Priority: Minor


The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
The screen is here:

https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587528#action_12587528 ]

Scott Gray commented on OFBIZ-1744:
-----------------------------------

Hi Jacopo

Do you mean the invoice item type drop downs? They're the only ones i can see.

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587540#action_12587540 ]

Jacopo Cappellato commented on OFBIZ-1744:
------------------------------------------

Hi Scott,

I mean the overrideGlAccountId fields (that I have changed to drop down in one of my last commits).

Jacopo

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil Soni updated OFBIZ-1744:
-----------------------------

    Attachment: Fix_for_EditInvoiceItem.patch

Hi Jacopo,

   Here I am attaching the  page of the work, if there is some improvements then let me know.

Anil Soni

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588519#action_12588519 ]

Sumit Pandit commented on OFBIZ-1744:
-------------------------------------

Hello Anil,
Nice job. Though the patch's path was wrong(C:/dev/ofbizapps/ofbiz/),  but don't worry about it . I will fix it and upload the correct patch.

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anil Soni updated OFBIZ-1744:
-----------------------------

    Attachment: Fix_for_EditInvoiceItem.patch

Oops ! I missed that. Thanks for pointing that out, I really appreciate your quick response.

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588608#action_12588608 ]

Jacopo Cappellato commented on OFBIZ-1744:
------------------------------------------

Hi Anil Soni,

thanks for your patch; however I think there are some problems in it.
The task can be implemented in the following way:
a) find the organizationPartyId for the invoice (for purchase invoices it is the party in the role "bill to customer"; for sales invoices it is the party in the role "bill from vendor")
b) show in the drop downs (there are two forms with this drop down in the screen) only the records from the OrganizationGlAccount for that organizationPartyId

I hope it is clearer.

Jacopo

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brajesh Patel updated OFBIZ-1744:
---------------------------------

    Attachment: Fix_for_EditInvoiceItem.patch

I have uploaded patch here for this issue.
Brajesh Patel

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brajesh Patel updated OFBIZ-1744:
---------------------------------

    Attachment: Fix_for_EditInvoiceItem.patch

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brajesh Patel updated OFBIZ-1744:
---------------------------------

    Attachment: Fix_for_EditInvoiceItem.patch

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato reassigned OFBIZ-1744:
----------------------------------------

    Assignee: Jacopo Cappellato

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-1744.
------------------------------------

    Resolution: Fixed

Thanks Brajesh, your patch is in rev. 650523

> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1744
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1744
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: accounting
>            Reporter: Jacopo Cappellato
>            Assignee: Jacopo Cappellato
>            Priority: Minor
>         Attachments: Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch, Fix_for_EditInvoiceItem.patch
>
>
> The list of accounts in the two drop downs in the edit Invoice Items screen should only show the accounts associated to the organization associated to the invoice.
> The screen is here:
> https://localhost:8443/accounting/control/listInvoiceItems?invoiceId=demo10001

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.