Re: svn commit: r659942 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r659942 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java

Adrian Crum
This change breaks the layout of the menus in other components.

If the "clear" CSS class is breaking the layout in a particular screen,
you can redefine it for the enclosing element:

<style type="text/css">
   .no-clear .clear {
     float: none;
   }
</style>

<div class="no-clear">
   <!-- menu widget code here -->
   ...
</div>

-Adrian

[hidden email] wrote:

> Author: hansbak
> Date: Sun May 25 02:13:52 2008
> New Revision: 659942
>
> URL: http://svn.apache.org/viewvc?rev=659942&view=rev
> Log:
> allow the menu usage also in a column: see the sfa component
>
> Modified:
>     ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
>
> Modified: ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java?rev=659942&r1=659941&r2=659942&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java (original)
> +++ ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java Sun May 25 02:13:52 2008
> @@ -259,7 +259,7 @@
>          //String menuContainerStyle = modelMenu.getMenuContainerStyle(context);
>          buffer.append(" </ul>");
>          appendWhitespace(buffer);
> -        buffer.append(" <br class=\"clear\" />");
> +        buffer.append(" <br/>");
>          appendWhitespace(buffer);
>          buffer.append("</div>");
>          appendWhitespace(buffer);
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r659942 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java

Adrian Crum
Oops, that should be

<style type="text/css">
   .no-clear .clear {
     clear: none;
   }
</style>

<div class="no-clear">
   <!-- menu widget code here -->
   ...
</div>


Adrian Crum wrote:

> This change breaks the layout of the menus in other components.
>
> If the "clear" CSS class is breaking the layout in a particular screen,
> you can redefine it for the enclosing element:
>
> <style type="text/css">
>   .no-clear .clear {
>     float: none;
>   }
> </style>
>
> <div class="no-clear">
>   <!-- menu widget code here -->
>   ...
> </div>
>
> -Adrian
>
> [hidden email] wrote:
>> Author: hansbak
>> Date: Sun May 25 02:13:52 2008
>> New Revision: 659942
>>
>> URL: http://svn.apache.org/viewvc?rev=659942&view=rev
>> Log:
>> allow the menu usage also in a column: see the sfa component
>>
>> Modified:
>>    
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
>>
>>
>> Modified:
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
>>
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java?rev=659942&r1=659941&r2=659942&view=diff 
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
>> (original)
>> +++
>> ofbiz/trunk/framework/widget/src/org/ofbiz/widget/html/HtmlMenuRenderer.java
>> Sun May 25 02:13:52 2008
>> @@ -259,7 +259,7 @@
>>          //String menuContainerStyle =
>> modelMenu.getMenuContainerStyle(context);
>>          buffer.append(" </ul>");
>>          appendWhitespace(buffer);
>> -        buffer.append(" <br class=\"clear\" />");
>> +        buffer.append(" <br/>");
>>          appendWhitespace(buffer);
>>          buffer.append("</div>");
>>          appendWhitespace(buffer);
>>
>>
>>
>