Re: svn commit: r682603 - /ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy

[Scott Gray]

Hi Ashish

Just my opinion (on what is a pretty minor issue) but I would prefer
to see a blank field rather than an inaccurate value.

Regards
Scott

2008/8/5  <[hidden email]>:

> Author: ashish
> Date: Mon Aug  4 23:51:22 2008
> New Revision: 682603
>
> URL: http://svn.apache.org/viewvc?rev=682603&view=rev
> Log:
> Now here comes the real change from my work.
>
> Modified:
>    ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy
>
> Modified: ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy?rev=682603&r1=682602&r2=682603&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy (original)
> +++ ofbiz/trunk/applications/order/webapp/ordermgr/WEB-INF/actions/reports/OpenOrderItemsReport.groovy Mon Aug  4 23:51:22 2008
> @@ -136,7 +136,7 @@
>                     listPrice : listPrice,
>                     discount : listPrice - retailPrice,
>                     calculatedMarkup : retailPrice - costPrice,
> -                    percentMarkup : ((retailPrice - costPrice)/costPrice)*100];
> +                    percentMarkup : ((retailPrice - costPrice)/costPrice?:1)*100];
>     orderItemList.add(orderItemMap);
>  }
>
>
>
>