Re: svn commit: r684780 - /ofbiz/trunk/applications/content/data/ContentTypeData.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r684780 - /ofbiz/trunk/applications/content/data/ContentTypeData.xml

Ashish Vijaywargiya
Oops this commit doesn't contain the full "comment".
Sorry by mistake I have clicked the Ok button before completing the whole
comment.

Here is the full comment :-

I think we should change the parentTypeId to some other value in case of
"Menu Container"
This was throwing error while doing ant run-install.

--
Ashish


On Mon, Aug 11, 2008 at 9:01 PM, <[hidden email]> wrote:

> Author: ashish
> Date: Mon Aug 11 08:31:34 2008
> New Revision: 684780
>
> URL: http://svn.apache.org/viewvc?rev=684780&view=rev
> Log:
> I think we should put something else in "Menu Container"
>
> Modified:
>    ofbiz/trunk/applications/content/data/ContentTypeData.xml
>
> Modified: ofbiz/trunk/applications/content/data/ContentTypeData.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/data/ContentTypeData.xml?rev=684780&r1=684779&r2=684780&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/applications/content/data/ContentTypeData.xml (original)
> +++ ofbiz/trunk/applications/content/data/ContentTypeData.xml Mon Aug 11
> 08:31:34 2008
> @@ -69,7 +69,7 @@
>     <ContentType contentTypeId="TEMPLATE" description="Template or Form"
> hasTable="N" parentTypeId=""/>
>     <ContentType contentTypeId="DECORATOR" description="Decorator"
> hasTable="N" parentTypeId="TEMPLATE"/>
>     <ContentType contentTypeId="ANNOTATION" description="Annotation"
> hasTable="N" parentTypeId=""/>
> -    <ContentType contentTypeId="MENU_CONTAINER" description="Menu
> Container" hasTable="N" parentTypeId="TREE_ROOT"/>
> +    <ContentType contentTypeId="MENU_CONTAINER" description="Menu
> Container" hasTable="N" parentTypeId=""/>
>     <!-- NOTE DEJ20080809 The following 3 ContentTypes may not be needed,
> and the current practice is to just use DOCUMENT instead -->
>     <ContentType contentTypeId="OUTLINE_NODE" description="Outline Node"
> hasTable="N" parentTypeId="DOCUMENT"/>
>     <ContentType contentTypeId="PAGE_NODE" description="Page Node"
> hasTable="N" parentTypeId="DOCUMENT"/>
>
>
>


--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r684780 - /ofbiz/trunk/applications/content/data/ContentTypeData.xml

David E Jones-2

Thanks Ashish, that fix is fine as the menu container thingy (is ever  
used...) doesn't need to be a child of the TREE_ROOT content type  
which is meant for something else (general knowledge management) even  
though a menu may be hierarchical (which is I think why Al set it to  
begin with). Sorry about leaving that in there....

-David


On Aug 11, 2008, at 9:31 AM, [hidden email] wrote:

> Author: ashish
> Date: Mon Aug 11 08:31:34 2008
> New Revision: 684780
>
> URL: http://svn.apache.org/viewvc?rev=684780&view=rev
> Log:
> I think we should put something else in "Menu Container"
>
> Modified:
>    ofbiz/trunk/applications/content/data/ContentTypeData.xml
>
> Modified: ofbiz/trunk/applications/content/data/ContentTypeData.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/data/ContentTypeData.xml?rev=684780&r1=684779&r2=684780&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/content/data/ContentTypeData.xml  
> (original)
> +++ ofbiz/trunk/applications/content/data/ContentTypeData.xml Mon  
> Aug 11 08:31:34 2008
> @@ -69,7 +69,7 @@
>     <ContentType contentTypeId="TEMPLATE" description="Template or  
> Form" hasTable="N" parentTypeId=""/>
>     <ContentType contentTypeId="DECORATOR" description="Decorator"  
> hasTable="N" parentTypeId="TEMPLATE"/>
>     <ContentType contentTypeId="ANNOTATION" description="Annotation"  
> hasTable="N" parentTypeId=""/>
> -    <ContentType contentTypeId="MENU_CONTAINER" description="Menu  
> Container" hasTable="N" parentTypeId="TREE_ROOT"/>
> +    <ContentType contentTypeId="MENU_CONTAINER" description="Menu  
> Container" hasTable="N" parentTypeId=""/>
>     <!-- NOTE DEJ20080809 The following 3 ContentTypes may not be  
> needed, and the current practice is to just use DOCUMENT instead -->
>     <ContentType contentTypeId="OUTLINE_NODE" description="Outline  
> Node" hasTable="N" parentTypeId="DOCUMENT"/>
>     <ContentType contentTypeId="PAGE_NODE" description="Page Node"  
> hasTable="N" parentTypeId="DOCUMENT"/>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r684780 - /ofbiz/trunk/applications/content/data/ContentTypeData.xml

Ashish Vijaywargiya
Your most welcome David :-)

On Mon, Aug 11, 2008 at 9:26 PM, David E Jones <
[hidden email]> wrote:

>
> Thanks Ashish, that fix is fine as the menu container thingy (is ever
> used...) doesn't need to be a child of the TREE_ROOT content type which is
> meant for something else (general knowledge management) even though a menu
> may be hierarchical (which is I think why Al set it to begin with). Sorry
> about leaving that in there....
>
> -David
>
>
>
> On Aug 11, 2008, at 9:31 AM, [hidden email] wrote:
>
>  Author: ashish
>> Date: Mon Aug 11 08:31:34 2008
>> New Revision: 684780
>>
>> URL: http://svn.apache.org/viewvc?rev=684780&view=rev
>> Log:
>> I think we should put something else in "Menu Container"
>>
>> Modified:
>>   ofbiz/trunk/applications/content/data/ContentTypeData.xml
>>
>> Modified: ofbiz/trunk/applications/content/data/ContentTypeData.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/data/ContentTypeData.xml?rev=684780&r1=684779&r2=684780&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/applications/content/data/ContentTypeData.xml (original)
>> +++ ofbiz/trunk/applications/content/data/ContentTypeData.xml Mon Aug 11
>> 08:31:34 2008
>> @@ -69,7 +69,7 @@
>>    <ContentType contentTypeId="TEMPLATE" description="Template or Form"
>> hasTable="N" parentTypeId=""/>
>>    <ContentType contentTypeId="DECORATOR" description="Decorator"
>> hasTable="N" parentTypeId="TEMPLATE"/>
>>    <ContentType contentTypeId="ANNOTATION" description="Annotation"
>> hasTable="N" parentTypeId=""/>
>> -    <ContentType contentTypeId="MENU_CONTAINER" description="Menu
>> Container" hasTable="N" parentTypeId="TREE_ROOT"/>
>> +    <ContentType contentTypeId="MENU_CONTAINER" description="Menu
>> Container" hasTable="N" parentTypeId=""/>
>>    <!-- NOTE DEJ20080809 The following 3 ContentTypes may not be needed,
>> and the current practice is to just use DOCUMENT instead -->
>>    <ContentType contentTypeId="OUTLINE_NODE" description="Outline Node"
>> hasTable="N" parentTypeId="DOCUMENT"/>
>>    <ContentType contentTypeId="PAGE_NODE" description="Page Node"
>> hasTable="N" parentTypeId="DOCUMENT"/>
>>
>>
>>
>


--
Ashish Vijaywargiya
Indore (M.P), India
http://en.wikipedia.org/wiki/Indore