Re: svn commit: r718299 - /ofbiz/trunk/framework/images/webapp/images/maincss.css

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r718299 - /ofbiz/trunk/framework/images/webapp/images/maincss.css

Bilgin Ibryam
Adrian,

I wasn´t aware of gray box while doing this change.
The reason for my change was that virtual products which require  
amount for some variants use the hidden style, and then use  
changeObjectVisibility function to become visible. And this function  
only change visibility but not the height, so the amount fields  
remains with 0 height and not visualized.


Is it ok to add a new class with height:0 and visibility:hidden to use  
in header.ftl (gray bar) ?

Bilgin

On Nov 17, 2008, at 7:56 PM, [hidden email] wrote:

> Author: adrianc
> Date: Mon Nov 17 09:56:44 2008
> New Revision: 718299
>
> URL: http://svn.apache.org/viewvc?rev=718299&view=rev
> Log:
> Reverted style change made in rev 712478. It caused a gray bar to  
> appear at the top of the screen.
>
> Modified:
>    ofbiz/trunk/framework/images/webapp/images/maincss.css
>
> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=718299&r1=718298&r2=718299&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original)
> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Mon Nov  
> 17 09:56:44 2008
> @@ -813,6 +813,7 @@
> }
>
> .hidden {
> +height: 0;
> visibility: hidden;
> }
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r718299 - /ofbiz/trunk/framework/images/webapp/images/maincss.css

Adrian Crum-2
It would be better to use a CSS descendant selector to reset the height. Changing the existing styles almost always breaks layout. So, do something like:

.variant-amount .hidden {
height: auto;
}

-Adrian


--- On Wed, 11/19/08, Bilgin Ibryam <[hidden email]> wrote:

> From: Bilgin Ibryam <[hidden email]>
> Subject: Re: svn commit: r718299 - /ofbiz/trunk/framework/images/webapp/images/maincss.css
> To: [hidden email]
> Date: Wednesday, November 19, 2008, 2:32 AM
> Adrian,
>
> I wasn´t aware of gray box while doing this change.
> The reason for my change was that virtual products which
> require amount for some variants use the hidden style, and
> then use changeObjectVisibility function to become visible.
> And this function only change visibility but not the height,
> so the amount fields remains with 0 height and not
> visualized.
>
>
> Is it ok to add a new class with height:0 and
> visibility:hidden to use in header.ftl (gray bar) ?
>
> Bilgin
>
> On Nov 17, 2008, at 7:56 PM, [hidden email] wrote:
>
> > Author: adrianc
> > Date: Mon Nov 17 09:56:44 2008
> > New Revision: 718299
> >
> > URL:
> http://svn.apache.org/viewvc?rev=718299&view=rev
> > Log:
> > Reverted style change made in rev 712478. It caused a
> gray bar to appear at the top of the screen.
> >
> > Modified:
> >  
> ofbiz/trunk/framework/images/webapp/images/maincss.css
> >
> > Modified:
> ofbiz/trunk/framework/images/webapp/images/maincss.css
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=718299&r1=718298&r2=718299&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/framework/images/webapp/images/maincss.css
> (original)
> > +++
> ofbiz/trunk/framework/images/webapp/images/maincss.css Mon
> Nov 17 09:56:44 2008
> > @@ -813,6 +813,7 @@
> > }
> >
> > .hidden {
> > +height: 0;
> > visibility: hidden;
> > }
> >
> >
> >