Re: svn commit: r720570 - in /ofbiz/trunk: applications/party/script/org/ofbiz/party/contact/PartyContactMechServices.xml applications/party/servicedef/services.xml framework/common/config/general.properties

[Adam Heath-2]

> --- ofbiz/trunk/framework/common/config/general.properties (original)
> +++ ofbiz/trunk/framework/common/config/general.properties Tue Nov 25 11:40:33 2008
> @@ -73,6 +73,9 @@
>  #--Fallback [true|false] determines whether you will allow a non secure connection if you are unable to get a secure one
>  #mail.smtp.socketFactory.fallback=false
>  
> +# -- how the address are matched with the CRM addresses
> +mail.address.caseInsensitive=Y
> +

No.  Do not change the current default to something that will break for
most installs.  Current deployments are case-senstive, and this change
will break them.  I'm going to revert this hunk.

[Adam Heath-2]

Adam Heath wrote:

>> --- ofbiz/trunk/framework/common/config/general.properties (original)
>> +++ ofbiz/trunk/framework/common/config/general.properties Tue Nov 25 11:40:33 2008
>> @@ -73,6 +73,9 @@
>>  #--Fallback [true|false] determines whether you will allow a non secure connection if you are unable to get a secure one
>>  #mail.smtp.socketFactory.fallback=false
>>  
>> +# -- how the address are matched with the CRM addresses
>> +mail.address.caseInsensitive=Y
>> +
>
> No.  Do not change the current default to something that will break for
> most installs.  Current deployments are case-senstive, and this change
> will break them.  I'm going to revert this hunk.

Actually, to be fair, this isn't the entire situation.  Domain names are
case *insenstive*.  The SMTP spec says that mail servers are free to
implement whatever kind of matching they want with the username.  So,
OFBiz should probably handle emails smarter, by converting the
primaryKey field's domain to lower case during a store, etc, with an ECA
or some such.