The reason why the rounded tabs was removed was because they do not
render correctly with IE7. The hover style doesn't work properly in IE7. -Adrian [hidden email] wrote: > Author: jleroux > Date: Thu Jan 15 07:02:49 2009 > New Revision: 734729 > > URL: http://svn.apache.org/viewvc?rev=734729&view=rev > Log: > A patch from Bruno Busco " Improved style for main navigation bar" '(https://issues.apache.org/jira/browse/OFBIZ-911) - OFBIZ-911 > Put rounded tabs back but on IE6 (anyway we don't care about IE6 anymore) > > > > Modified: > ofbiz/trunk/framework/images/webapp/images/maincss.css > > Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=734729&r1=734728&r2=734729&view=diff > ============================================================================== > --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original) > +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Jan 15 07:02:49 2009 > @@ -934,11 +934,20 @@ > > #main-navigation ul li { > float: left; > +background-image: url(/images/tabs/main_uns_left.gif); > +} > + > +#main-navigation ul li:hover { > +background-image: url(/images/tabs/main_sel_left.gif); > +} > + > +#main-navigation ul li.selected { > +background-image: url(/images/tabs/main_sel_left.gif); > } > > #main-navigation ul a { > -background-image: url(/images/tabs/main_uns_left.gif); > -background-position: top left; > +background-image: url(/images/tabs/main_uns_right.gif); > +background-position: top right; > background-repeat: no-repeat; > border-bottom: solid #989898 0.01em; > color: #000000; > @@ -955,8 +964,8 @@ > #main-navigation ul a:hover, > #main-navigation ul .selected a, > #main-navigation ui .selected a:hover { > -background-image: url(/images/tabs/main_sel_left.gif); > -background-position: top left; > +background-image: url(/images/tabs/main_sel_right.gif); > +background-position: top right; > background-repeat: no-repeat; > border-bottom: solid #D4D0C8 0.01em; > color: #000099; > > > |
Administrator
|
Yes, I agree there is a not completely fine look in IE7, but it's not too bad and I finally decided to commit these changes since
anybody answered Should we revert ? Jacques From: "Adrian Crum" <[hidden email]> > The reason why the rounded tabs was removed was because they do not render correctly with IE7. The hover style doesn't work > properly in IE7. > > -Adrian > > [hidden email] wrote: >> Author: jleroux >> Date: Thu Jan 15 07:02:49 2009 >> New Revision: 734729 >> >> URL: http://svn.apache.org/viewvc?rev=734729&view=rev >> Log: >> A patch from Bruno Busco " Improved style for main navigation bar" '(https://issues.apache.org/jira/browse/OFBIZ-911) - >> OFBIZ-911 >> Put rounded tabs back but on IE6 (anyway we don't care about IE6 anymore) >> >> >> >> Modified: >> ofbiz/trunk/framework/images/webapp/images/maincss.css >> >> Modified: ofbiz/trunk/framework/images/webapp/images/maincss.css >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/maincss.css?rev=734729&r1=734728&r2=734729&view=diff >> ============================================================================== >> --- ofbiz/trunk/framework/images/webapp/images/maincss.css (original) >> +++ ofbiz/trunk/framework/images/webapp/images/maincss.css Thu Jan 15 07:02:49 2009 >> @@ -934,11 +934,20 @@ >> #main-navigation ul li { >> float: left; >> +background-image: url(/images/tabs/main_uns_left.gif); >> +} >> + >> +#main-navigation ul li:hover { >> +background-image: url(/images/tabs/main_sel_left.gif); >> +} >> + >> +#main-navigation ul li.selected { >> +background-image: url(/images/tabs/main_sel_left.gif); >> } >> #main-navigation ul a { >> -background-image: url(/images/tabs/main_uns_left.gif); >> -background-position: top left; >> +background-image: url(/images/tabs/main_uns_right.gif); >> +background-position: top right; >> background-repeat: no-repeat; >> border-bottom: solid #989898 0.01em; >> color: #000000; >> @@ -955,8 +964,8 @@ >> #main-navigation ul a:hover, >> #main-navigation ul .selected a, >> #main-navigation ui .selected a:hover { >> -background-image: url(/images/tabs/main_sel_left.gif); >> -background-position: top left; >> +background-image: url(/images/tabs/main_sel_right.gif); >> +background-position: top right; >> background-repeat: no-repeat; >> border-bottom: solid #D4D0C8 0.01em; >> color: #000099; >> >> >> > |
Free forum by Nabble | Edit this page |