OFBiz › OFBiz - Dev

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

22 messages Options

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

I had a closer look
<service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)

I will do a serious Eclipse regexp S/R, when I will get a chance...

Jacques

From: <[hidden email]>

> Author: jleroux
> Date: Wed Mar 18 17:21:14 2009
> New Revision: 755658
>
> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
> Log:
> Following Ashish's commit at r755572:
> Followed best practice.
> Changed location="org/ofbiz/......... to location="component://party/script/org/ofbiz......
>
> Modified:
> ofbiz/trunk/applications/party/servicedef/services_view.xml
>
> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/party/servicedef/services_view.xml (original)
> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
> @@ -115,14 +115,14 @@
> </service>
>
> <service name="getPartiesByRelationship" engine="simple"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPartiesByRelationship">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getPartiesByRelationship">
> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
> <override name="partyIdFrom" optional="false"/>
> </service>
> <service name="getRelatedParties" engine="simple"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getRelatedParties">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getRelatedParties">
> <description>
> Get Parties Related to a Party
> - The relatedPartyIdList coming out will include the original partyIdFrom
> @@ -142,7 +142,7 @@
> </service>
>
> <service name="getParentOrganizations" engine="simple"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getParentOrganizations">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getParentOrganizations">
> <description>
> Gets Parent Organizations for an Organization Party.
> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
> @@ -157,7 +157,7 @@
> </service>
>
> <service name="getChildRoleTypes" engine="simple"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getChildRoleTypes">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getChildRoleTypes">
> <description>
> Get Child RoleTypes.
> The childRoleTypeIdList coming out will contain the original roleTypeId.
> @@ -168,7 +168,7 @@
>
> 
> <service name="getPostalAddressBoundary" engine="simple"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPostalAddressBoundary">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getPostalAddressBoundary">
> <description>Get all Postal Address Boundaries</description>
> <permission-service service-name="partyBasePermissionCheck" main-action="VIEW"/>
> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
> @@ -177,12 +177,12 @@
>
> 
> <service name="getCountryList" engine="simple" auth="false"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getCountryList">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getCountryList">
> <attribute name="countryList" mode="OUT" type="java.util.List"/>
> </service>
>
> <service name="getAssociatedStateList" engine="simple" auth="false"
> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getAssociatedStateList">
> + location="component://party/script/org/ofbiz/party/party/PartyServices.xml" invoke="getAssociatedStateList">
> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
> <attribute name="stateList" mode="OUT" type="java.util.List"/>
> </service>
>
>

David E Jones-3

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

This would be great to have done before the release. It would allow us
to get a LOT of stuff off the classpath, which can be a painful part
of deployment.

-David

On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:

> I had a closer look
> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
> says there are 1305 other cases... (I did not look into details,
> maybe this regexp is too loosely written)
>
> I will do a serious Eclipse regexp S/R, when I will get a chance...
>
> Jacques
>
> From: <[hidden email]>
>> Author: jleroux
>> Date: Wed Mar 18 17:21:14 2009
>> New Revision: 755658
>>
>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>> Log:
>> Following Ashish's commit at r755572:
>> Followed best practice.
>> Changed location="org/ofbiz/......... to location="component://
>> party/script/org/ofbiz......
>>
>> Modified:
>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>
>> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/party/servicedef/services_view.xml
>> (original)
>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed
>> Mar 18 17:21:14 2009
>> @@ -115,14 +115,14 @@
>> </service>
>>
>> <service name="getPartiesByRelationship" engine="simple"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getPartiesByRelationship">
>> + location="component://party/script/org/ofbiz/party/party/
>> PartyServices.xml" invoke="getPartiesByRelationship">
>> <description>Gets all parties related to partyIdFrom through
>> the PartyRelationship entity</description>
>> <auto-attributes mode="IN" include="all" optional="true"
>> entity-name="PartyRelationship"/>
>> <attribute name="parties" type="java.util.Collection"
>> mode="OUT" optional="true"/>
>> <override name="partyIdFrom" optional="false"/>
>> </service>
>> <service name="getRelatedParties" engine="simple"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getRelatedParties">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getRelatedParties">
>> <description>
>> Get Parties Related to a Party
>> - The relatedPartyIdList coming out will include the
>> original partyIdFrom
>> @@ -142,7 +142,7 @@
>> </service>
>>
>> <service name="getParentOrganizations" engine="simple"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getParentOrganizations">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getParentOrganizations">
>> <description>
>> Gets Parent Organizations for an Organization Party.
>> This uses the PartyRelationship table with
>> partyRelationshipTypeId="GROUP_ROLLUP".
>> @@ -157,7 +157,7 @@
>> </service>
>>
>> <service name="getChildRoleTypes" engine="simple"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getChildRoleTypes">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getChildRoleTypes">
>> <description>
>> Get Child RoleTypes.
>> The childRoleTypeIdList coming out will contain the
>> original roleTypeId.
>> @@ -168,7 +168,7 @@
>>
>> 
>> <service name="getPostalAddressBoundary" engine="simple"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getPostalAddressBoundary">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getPostalAddressBoundary">
>> <description>Get all Postal Address Boundaries</description>
>> <permission-service service-name="partyBasePermissionCheck"
>> main-action="VIEW"/>
>> <attribute name="contactMechId" type="String" mode="IN"
>> optional="false"/>
>> @@ -177,12 +177,12 @@
>>
>> 
>> <service name="getCountryList" engine="simple" auth="false"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getCountryList">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getCountryList">
>> <attribute name="countryList" mode="OUT"
>> type="java.util.List"/>
>> </service>
>>
>> <service name="getAssociatedStateList" engine="simple"
>> auth="false"
>> - location="org/ofbiz/party/party/PartyServices.xml"
>> invoke="getAssociatedStateList">
>> + location="component://party/script/org/ofbiz/party/
>> party/PartyServices.xml" invoke="getAssociatedStateList">
>> <attribute name="countryGeoId" mode="IN" type="String"
>> optional="false"/>
>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>> </service>
>>
>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

Done at revision: 755977

Jacques

From: "David E Jones" <[hidden email]>

>
> This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can be a
> painful part of deployment.
>
> -David
>
>
> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>
>> I had a closer look
>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>> says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)
>>
>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>
>> Jacques
>>
>> From: <[hidden email]>
>>> Author: jleroux
>>> Date: Wed Mar 18 17:21:14 2009
>>> New Revision: 755658
>>>
>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>> Log:
>>> Following Ashish's commit at r755572:
>>> Followed best practice.
>>> Changed location="org/ofbiz/......... to location="component:// party/script/org/ofbiz......
>>>
>>> Modified:
>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>
>>> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>> = = = = = = = = = =====================================================================
>>> --- ofbiz/trunk/applications/party/servicedef/services_view.xml (original)
>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
>>> @@ -115,14 +115,14 @@
>>> </service>
>>>
>>> <service name="getPartiesByRelationship" engine="simple"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPartiesByRelationship">
>>> + location="component://party/script/org/ofbiz/party/party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
>>> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
>>> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
>>> <override name="partyIdFrom" optional="false"/>
>>> </service>
>>> <service name="getRelatedParties" engine="simple"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getRelatedParties">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getRelatedParties">
>>> <description>
>>> Get Parties Related to a Party
>>> - The relatedPartyIdList coming out will include the original partyIdFrom
>>> @@ -142,7 +142,7 @@
>>> </service>
>>>
>>> <service name="getParentOrganizations" engine="simple"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getParentOrganizations">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>> <description>
>>> Gets Parent Organizations for an Organization Party.
>>> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
>>> @@ -157,7 +157,7 @@
>>> </service>
>>>
>>> <service name="getChildRoleTypes" engine="simple"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getChildRoleTypes">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>> <description>
>>> Get Child RoleTypes.
>>> The childRoleTypeIdList coming out will contain the original roleTypeId.
>>> @@ -168,7 +168,7 @@
>>>
>>> 
>>> <service name="getPostalAddressBoundary" engine="simple"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>> <description>Get all Postal Address Boundaries</description>
>>> <permission-service service-name="partyBasePermissionCheck" main-action="VIEW"/>
>>> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
>>> @@ -177,12 +177,12 @@
>>>
>>> 
>>> <service name="getCountryList" engine="simple" auth="false"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getCountryList">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getCountryList">
>>> <attribute name="countryList" mode="OUT" type="java.util.List"/>
>>> </service>
>>>
>>> <service name="getAssociatedStateList" engine="simple" auth="false"
>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getAssociatedStateList">
>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>> </service>
>>>
>>
>>
>

Ashish Vijaywargiya-5

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Thanks Jacques for your fast turn around on this.
I am impressed from it :-).

--
Ashish

Jacques Le Roux wrote:

> Done at revision: 755977
>
> Jacques
>
> From: "David E Jones" <[hidden email]>
>>
>> This would be great to have done before the release. It would allow
>> us to get a LOT of stuff off the classpath, which can be a painful
>> part of deployment.
>>
>> -David
>>
>>
>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>
>>> I had a closer look
>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>> says there are 1305 other cases... (I did not look into details,
>>> maybe this regexp is too loosely written)
>>>
>>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>>
>>> Jacques
>>>
>>> From: <[hidden email]>
>>>> Author: jleroux
>>>> Date: Wed Mar 18 17:21:14 2009
>>>> New Revision: 755658
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>> Log:
>>>> Following Ashish's commit at r755572:
>>>> Followed best practice.
>>>> Changed location="org/ofbiz/......... to location="component://
>>>> party/script/org/ofbiz......
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>
>>>> = = = = = = = = =
>>>> =====================================================================
>>>> --- ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>> Wed Mar 18 17:21:14 2009
>>>> @@ -115,14 +115,14 @@
>>>> </service>
>>>>
>>>> <service name="getPartiesByRelationship" engine="simple"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getPartiesByRelationship">
>>>> + location="component://party/script/org/ofbiz/party/party/
>>>> PartyServices.xml" invoke="getPartiesByRelationship">
>>>> <description>Gets all parties related to partyIdFrom
>>>> through the PartyRelationship entity</description>
>>>> <auto-attributes mode="IN" include="all" optional="true"
>>>> entity-name="PartyRelationship"/>
>>>> <attribute name="parties" type="java.util.Collection"
>>>> mode="OUT" optional="true"/>
>>>> <override name="partyIdFrom" optional="false"/>
>>>> </service>
>>>> <service name="getRelatedParties" engine="simple"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getRelatedParties">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getRelatedParties">
>>>> <description>
>>>> Get Parties Related to a Party
>>>> - The relatedPartyIdList coming out will include the
>>>> original partyIdFrom
>>>> @@ -142,7 +142,7 @@
>>>> </service>
>>>>
>>>> <service name="getParentOrganizations" engine="simple"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getParentOrganizations">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getParentOrganizations">
>>>> <description>
>>>> Gets Parent Organizations for an Organization Party.
>>>> This uses the PartyRelationship table with
>>>> partyRelationshipTypeId="GROUP_ROLLUP".
>>>> @@ -157,7 +157,7 @@
>>>> </service>
>>>>
>>>> <service name="getChildRoleTypes" engine="simple"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getChildRoleTypes">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getChildRoleTypes">
>>>> <description>
>>>> Get Child RoleTypes.
>>>> The childRoleTypeIdList coming out will contain the
>>>> original roleTypeId.
>>>> @@ -168,7 +168,7 @@
>>>>
>>>> 
>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getPostalAddressBoundary">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>>> <description>Get all Postal Address Boundaries</description>
>>>> <permission-service service-name="partyBasePermissionCheck"
>>>> main-action="VIEW"/>
>>>> <attribute name="contactMechId" type="String" mode="IN"
>>>> optional="false"/>
>>>> @@ -177,12 +177,12 @@
>>>>
>>>> 
>>>> <service name="getCountryList" engine="simple" auth="false"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getCountryList">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getCountryList">
>>>> <attribute name="countryList" mode="OUT"
>>>> type="java.util.List"/>
>>>> </service>
>>>>
>>>> <service name="getAssociatedStateList" engine="simple"
>>>> auth="false"
>>>> - location="org/ofbiz/party/party/PartyServices.xml"
>>>> invoke="getAssociatedStateList">
>>>> + location="component://party/script/org/ofbiz/party/
>>>> party/PartyServices.xml" invoke="getAssociatedStateList">
>>>> <attribute name="countryGeoId" mode="IN" type="String"
>>>> optional="false"/>
>>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>>> </service>
>>>>
>>>
>>>
>>
>
>

smime.p7s (4K) Download Attachment

Ashish Vijaywargiya-5

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

In reply to this post by Jacques Le Roux

Jacques,

Do we need to change the same thing in controller.xml ?
For ex :
<event type="simple"
path="org/ofbiz/ecommerce/customer/CustomerEvents.xml"
invoke="processCustomerSettings"/>

WDYT ?

--
Ashish

Jacques Le Roux wrote:

smime.p7s (4K) Download Attachment

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

Ashish,

Looks like a good idea, but I'm not sure FTTOMH
We would have to look at controller code...

Jacques

From: "Ashish Vijaywargiya" <[hidden email]>

> Jacques,
>
> Do we need to change the same thing in controller.xml ?
> For ex :
> <event type="simple" path="org/ofbiz/ecommerce/customer/CustomerEvents.xml" invoke="processCustomerSettings"/>
>
> WDYT ?
>
> --
> Ashish
>
>
> Jacques Le Roux wrote:
>> Done at revision: 755977
>>
>> Jacques
>>
>> From: "David E Jones" <[hidden email]>
>>>
>>> This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can be a
>>> painful part of deployment.
>>>
>>> -David
>>>
>>>
>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>
>>>> I had a closer look
>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>> says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)
>>>>
>>>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>>>
>>>> Jacques
>>>>
>>>> From: <[hidden email]>
>>>>> Author: jleroux
>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>> New Revision: 755658
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>> Log:
>>>>> Following Ashish's commit at r755572:
>>>>> Followed best practice.
>>>>> Changed location="org/ofbiz/......... to location="component:// party/script/org/ofbiz......
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>
>>>>> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>> = = = = = = = = = =====================================================================
>>>>> --- ofbiz/trunk/applications/party/servicedef/services_view.xml (original)
>>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
>>>>> @@ -115,14 +115,14 @@
>>>>> </service>
>>>>>
>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPartiesByRelationship">
>>>>> + location="component://party/script/org/ofbiz/party/party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
>>>>> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
>>>>> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
>>>>> <override name="partyIdFrom" optional="false"/>
>>>>> </service>
>>>>> <service name="getRelatedParties" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getRelatedParties">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>> <description>
>>>>> Get Parties Related to a Party
>>>>> - The relatedPartyIdList coming out will include the original partyIdFrom
>>>>> @@ -142,7 +142,7 @@
>>>>> </service>
>>>>>
>>>>> <service name="getParentOrganizations" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getParentOrganizations">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>>>> <description>
>>>>> Gets Parent Organizations for an Organization Party.
>>>>> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
>>>>> @@ -157,7 +157,7 @@
>>>>> </service>
>>>>>
>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>> <description>
>>>>> Get Child RoleTypes.
>>>>> The childRoleTypeIdList coming out will contain the original roleTypeId.
>>>>> @@ -168,7 +168,7 @@
>>>>>
>>>>> 
>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>> <description>Get all Postal Address Boundaries</description>
>>>>> <permission-service service-name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
>>>>> @@ -177,12 +177,12 @@
>>>>>
>>>>> 
>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getCountryList">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getCountryList">
>>>>> <attribute name="countryList" mode="OUT" type="java.util.List"/>
>>>>> </service>
>>>>>
>>>>> <service name="getAssociatedStateList" engine="simple" auth="false"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
>>>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>>>> </service>
>>>>>
>>>>
>>>>
>>>
>>
>>
>

David E Jones-3

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

It should be supported now, but yeah it would be a good idea to test
it before doing a mass change. And yes, a mass change there would be
great too.

Once those are done we could probably remove the ${component-dir}/
script directory from the classpath.

-David

On Mar 19, 2009, at 8:07 AM, Jacques Le Roux wrote:

> Ashish,
>
> Looks like a good idea, but I'm not sure FTTOMH
> We would have to look at controller code...
>
> Jacques
>
> From: "Ashish Vijaywargiya" <[hidden email]>
>> Jacques,
>>
>> Do we need to change the same thing in controller.xml ?
>> For ex :
>> <event type="simple" path="org/ofbiz/ecommerce/customer/
>> CustomerEvents.xml" invoke="processCustomerSettings"/>
>>
>> WDYT ?
>>
>> --
>> Ashish
>>
>>
>> Jacques Le Roux wrote:
>>> Done at revision: 755977
>>>
>>> Jacques
>>>
>>> From: "David E Jones" <[hidden email]>
>>>>
>>>> This would be great to have done before the release. It would
>>>> allow us to get a LOT of stuff off the classpath, which can be a
>>>> painful part of deployment.
>>>>
>>>> -David
>>>>
>>>>
>>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>>
>>>>> I had a closer look
>>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>>> says there are 1305 other cases... (I did not look into
>>>>> details, maybe this regexp is too loosely written)
>>>>>
>>>>> I will do a serious Eclipse regexp S/R, when I will get a
>>>>> chance...
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: <[hidden email]>
>>>>>> Author: jleroux
>>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>>> New Revision: 755658
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>>> Log:
>>>>>> Following Ashish's commit at r755572:
>>>>>> Followed best practice.
>>>>>> Changed location="org/ofbiz/......... to location="component://
>>>>>> party/script/org/ofbiz......
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>>
>>>>>> Modified: ofbiz/trunk/applications/party/servicedef/
>>>>>> services_view.xml
>>>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>>> = = = = = = = = =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =
>>>>>> =================================================================
>>>>>> --- ofbiz/trunk/applications/party/servicedef/
>>>>>> services_view.xml (original)
>>>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>> Wed Mar 18 17:21:14 2009
>>>>>> @@ -115,14 +115,14 @@
>>>>>> </service>
>>>>>>
>>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>> + location="component://party/script/org/ofbiz/party/
>>>>>> party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>> <description>Gets all parties related to partyIdFrom
>>>>>> through the PartyRelationship entity</description>
>>>>>> <auto-attributes mode="IN" include="all" optional="true"
>>>>>> entity-name="PartyRelationship"/>
>>>>>> <attribute name="parties" type="java.util.Collection"
>>>>>> mode="OUT" optional="true"/>
>>>>>> <override name="partyIdFrom" optional="false"/>
>>>>>> </service>
>>>>>> <service name="getRelatedParties" engine="simple"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getRelatedParties">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>>> <description>
>>>>>> Get Parties Related to a Party
>>>>>> - The relatedPartyIdList coming out will include the
>>>>>> original partyIdFrom
>>>>>> @@ -142,7 +142,7 @@
>>>>>> </service>
>>>>>>
>>>>>> <service name="getParentOrganizations" engine="simple"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getParentOrganizations">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>>>>> <description>
>>>>>> Gets Parent Organizations for an Organization Party.
>>>>>> This uses the PartyRelationship table with
>>>>>> partyRelationshipTypeId="GROUP_ROLLUP".
>>>>>> @@ -157,7 +157,7 @@
>>>>>> </service>
>>>>>>
>>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getChildRoleTypes">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>>> <description>
>>>>>> Get Child RoleTypes.
>>>>>> The childRoleTypeIdList coming out will contain the
>>>>>> original roleTypeId.
>>>>>> @@ -168,7 +168,7 @@
>>>>>>
>>>>>> 
>>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml"
>>>>>> invoke="getPostalAddressBoundary">
>>>>>> <description>Get all Postal Address Boundaries</
>>>>>> description>
>>>>>> <permission-service service-
>>>>>> name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>>> <attribute name="contactMechId" type="String" mode="IN"
>>>>>> optional="false"/>
>>>>>> @@ -177,12 +177,12 @@
>>>>>>
>>>>>> 
>>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getCountryList">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml" invoke="getCountryList">
>>>>>> <attribute name="countryList" mode="OUT"
>>>>>> type="java.util.List"/>
>>>>>> </service>
>>>>>>
>>>>>> <service name="getAssociatedStateList" engine="simple"
>>>>>> auth="false"
>>>>>> - location="org/ofbiz/party/party/
>>>>>> PartyServices.xml" invoke="getAssociatedStateList">
>>>>>> + location="component://party/script/org/ofbiz/
>>>>>> party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>>> <attribute name="countryGeoId" mode="IN" type="String"
>>>>>> optional="false"/>
>>>>>> <attribute name="stateList" mode="OUT"
>>>>>> type="java.util.List"/>
>>>>>> </service>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>
>

Adam Heath-2

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

David E Jones wrote:
>
> It should be supported now, but yeah it would be a good idea to test it
> before doing a mass change. And yes, a mass change there would be great
> too.
>
> Once those are done we could probably remove the ${component-dir}/script
> directory from the classpath.

Hmm, sorta-somewhat unrelated. This series of changes is about using
the pseudo-url-like resource loading in ofbiz. This is not
extensible, except by adding new code to base. Would using a
ServiceRegistry to find new protocol loaders on the classpath be
something people are interested in?

David E Jones-3

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

On Mar 19, 2009, at 3:06 PM, Adam Heath wrote:

> David E Jones wrote:
>>
>> It should be supported now, but yeah it would be a good idea to
>> test it
>> before doing a mass change. And yes, a mass change there would be
>> great
>> too.
>>
>> Once those are done we could probably remove the ${component-dir}/
>> script
>> directory from the classpath.
>
> Hmm, sorta-somewhat unrelated. This series of changes is about using
> the pseudo-url-like resource loading in ofbiz. This is not
> extensible, except by adding new code to base. Would using a
> ServiceRegistry to find new protocol loaders on the classpath be
> something people are interested in?

That sounds like a great solution to... ? Wait a minute... what's the
problem that is a solution to again? ;)

-David

Adrian Crum

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

In reply to this post by Adam Heath-2

It's not really a protocol - it is only used inside code.

Your idea is interesting, and would make coding simpler. So, would the
end result be that the resource loader would "know" what to do with
component:// resources?

-Adrian

Adam Heath wrote:

> David E Jones wrote:
>> It should be supported now, but yeah it would be a good idea to test it
>> before doing a mass change. And yes, a mass change there would be great
>> too.
>>
>> Once those are done we could probably remove the ${component-dir}/script
>> directory from the classpath.
>
> Hmm, sorta-somewhat unrelated. This series of changes is about using
> the pseudo-url-like resource loading in ofbiz. This is not
> extensible, except by adding new code to base. Would using a
> ServiceRegistry to find new protocol loaders on the classpath be
> something people are interested in?
>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

In reply to this post by Ashish Vijaywargiya-5

Thanks for compliments Ashish,

https://issues.apache.org/jira/browse/OFBIZ-2243 is another beast. But I think I have a good strategy for that one too now.
I will let it roll tomorrow, each day its pains and its pleasures :D

Jacques

From: "Ashish Vijaywargiya" <[hidden email]>

> Thanks Jacques for your fast turn around on this.
> I am impressed from it :-).
>
> --
> Ashish
>
> Jacques Le Roux wrote:
>> Done at revision: 755977
>>
>> Jacques
>>
>> From: "David E Jones" <[hidden email]>
>>>
>>> This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can be a
>>> painful part of deployment.
>>>
>>> -David
>>>
>>>
>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>
>>>> I had a closer look
>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>> says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)
>>>>
>>>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>>>
>>>> Jacques
>>>>
>>>> From: <[hidden email]>
>>>>> Author: jleroux
>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>> New Revision: 755658
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>> Log:
>>>>> Following Ashish's commit at r755572:
>>>>> Followed best practice.
>>>>> Changed location="org/ofbiz/......... to location="component:// party/script/org/ofbiz......
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>
>>>>> Modified: ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>> = = = = = = = = = =====================================================================
>>>>> --- ofbiz/trunk/applications/party/servicedef/services_view.xml (original)
>>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
>>>>> @@ -115,14 +115,14 @@
>>>>> </service>
>>>>>
>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPartiesByRelationship">
>>>>> + location="component://party/script/org/ofbiz/party/party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
>>>>> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
>>>>> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
>>>>> <override name="partyIdFrom" optional="false"/>
>>>>> </service>
>>>>> <service name="getRelatedParties" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getRelatedParties">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>> <description>
>>>>> Get Parties Related to a Party
>>>>> - The relatedPartyIdList coming out will include the original partyIdFrom
>>>>> @@ -142,7 +142,7 @@
>>>>> </service>
>>>>>
>>>>> <service name="getParentOrganizations" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getParentOrganizations">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>>>> <description>
>>>>> Gets Parent Organizations for an Organization Party.
>>>>> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
>>>>> @@ -157,7 +157,7 @@
>>>>> </service>
>>>>>
>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>> <description>
>>>>> Get Child RoleTypes.
>>>>> The childRoleTypeIdList coming out will contain the original roleTypeId.
>>>>> @@ -168,7 +168,7 @@
>>>>>
>>>>> 
>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>> <description>Get all Postal Address Boundaries</description>
>>>>> <permission-service service-name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
>>>>> @@ -177,12 +177,12 @@
>>>>>
>>>>> 
>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getCountryList">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getCountryList">
>>>>> <attribute name="countryList" mode="OUT" type="java.util.List"/>
>>>>> </service>
>>>>>
>>>>> <service name="getAssociatedStateList" engine="simple" auth="false"
>>>>> - location="org/ofbiz/party/party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>> + location="component://party/script/org/ofbiz/party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
>>>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>>>> </service>
>>>>>
>>>>
>>>>
>>>
>>
>>
>

Adam Heath-2

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

In reply to this post by Adrian Crum

Adrian Crum wrote:
> It's not really a protocol - it is only used inside code.
>
> Your idea is interesting, and would make coding simpler. So, would the
> end result be that the resource loader would "know" what to do with
> component:// resources?

No, I'm thinking along the lines of being able to use webslinger://.

We are wanting to do a framework-only release. As such, no
dependencies should exist *at all* in framework against *anything*
that resides outside of framework. This means that either framework
is completely static, and can never be extended by
applications/specialpurpose/hot-deploy, or some kind of lookup system
will need to be implemented to allow framework to be extended,
whenever another component is added.

These extension points can be used to add location 'protocol' helpers,
new containers, etc, which can then be referenced by various entity
fields, etc.

webslinger supports multiple event
implements(java/groovy/javascript/beanshell/python/ruby/php), multiple
template implementations(velocity/freemarker/php/text), all by
dropping in new jars, and the base code magically discovers them.

This is done by using javax.imagio.spi.ServiceRegistry(<= 1.5), or
java.util.ServiceLoader(>= 1.6), which looks at META-INF/services/$class.

>
> -Adrian
>
> Adam Heath wrote:
>> David E Jones wrote:
>>> It should be supported now, but yeah it would be a good idea to test it
>>> before doing a mass change. And yes, a mass change there would be great
>>> too.
>>>
>>> Once those are done we could probably remove the ${component-dir}/script
>>> directory from the classpath.
>>
>> Hmm, sorta-somewhat unrelated. This series of changes is about using
>> the pseudo-url-like resource loading in ofbiz. This is not
>> extensible, except by adding new code to base. Would using a
>> ServiceRegistry to find new protocol loaders on the classpath be
>> something people are interested in?
>>
>>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

In reply to this post by David E Jones-3

I tested it works well. Changes done at revision: 765798
Not removed the ${component-dir}/ script directory from the classpath yet..

Jacques

From: "David E Jones" <[hidden email]>

> It should be supported now, but yeah it would be a good idea to test it before doing a mass change. And yes, a mass change there
> would be great too.
>
> Once those are done we could probably remove the ${component-dir}/ script directory from the classpath.
>
> -David
>
>
> On Mar 19, 2009, at 8:07 AM, Jacques Le Roux wrote:
>
>> Ashish,
>>
>> Looks like a good idea, but I'm not sure FTTOMH
>> We would have to look at controller code...
>>
>> Jacques
>>
>> From: "Ashish Vijaywargiya" <[hidden email]>
>>> Jacques,
>>>
>>> Do we need to change the same thing in controller.xml ?
>>> For ex :
>>> <event type="simple" path="org/ofbiz/ecommerce/customer/ CustomerEvents.xml" invoke="processCustomerSettings"/>
>>>
>>> WDYT ?
>>>
>>> --
>>> Ashish
>>>
>>>
>>> Jacques Le Roux wrote:
>>>> Done at revision: 755977
>>>>
>>>> Jacques
>>>>
>>>> From: "David E Jones" <[hidden email]>
>>>>>
>>>>> This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can be
>>>>> a painful part of deployment.
>>>>>
>>>>> -David
>>>>>
>>>>>
>>>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>>>
>>>>>> I had a closer look
>>>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>>>> says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)
>>>>>>
>>>>>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: <[hidden email]>
>>>>>>> Author: jleroux
>>>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>>>> New Revision: 755658
>>>>>>>
>>>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>>>> Log:
>>>>>>> Following Ashish's commit at r755572:
>>>>>>> Followed best practice.
>>>>>>> Changed location="org/ofbiz/......... to location="component:// party/script/org/ofbiz......
>>>>>>>
>>>>>>> Modified:
>>>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>>>
>>>>>>> Modified: ofbiz/trunk/applications/party/servicedef/ services_view.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>>>> = = = = = = = = = = = = = =================================================================
>>>>>>> --- ofbiz/trunk/applications/party/servicedef/ services_view.xml (original)
>>>>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
>>>>>>> @@ -115,14 +115,14 @@
>>>>>>> </service>
>>>>>>>
>>>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>> + location="component://party/script/org/ofbiz/party/ party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
>>>>>>> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
>>>>>>> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
>>>>>>> <override name="partyIdFrom" optional="false"/>
>>>>>>> </service>
>>>>>>> <service name="getRelatedParties" engine="simple"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getRelatedParties">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>>>> <description>
>>>>>>> Get Parties Related to a Party
>>>>>>> - The relatedPartyIdList coming out will include the original partyIdFrom
>>>>>>> @@ -142,7 +142,7 @@
>>>>>>> </service>
>>>>>>>
>>>>>>> <service name="getParentOrganizations" engine="simple"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getParentOrganizations">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>>>>>> <description>
>>>>>>> Gets Parent Organizations for an Organization Party.
>>>>>>> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
>>>>>>> @@ -157,7 +157,7 @@
>>>>>>> </service>
>>>>>>>
>>>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>> <description>
>>>>>>> Get Child RoleTypes.
>>>>>>> The childRoleTypeIdList coming out will contain the original roleTypeId.
>>>>>>> @@ -168,7 +168,7 @@
>>>>>>>
>>>>>>> 
>>>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml"
>>>>>>> invoke="getPostalAddressBoundary">
>>>>>>> <description>Get all Postal Address Boundaries</ description>
>>>>>>> <permission-service service- name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>>>> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
>>>>>>> @@ -177,12 +177,12 @@
>>>>>>>
>>>>>>> 
>>>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getCountryList">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getCountryList">
>>>>>>> <attribute name="countryList" mode="OUT" type="java.util.List"/>
>>>>>>> </service>
>>>>>>>
>>>>>>> <service name="getAssociatedStateList" engine="simple" auth="false"
>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getAssociatedStateList">
>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>>>> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
>>>>>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>>>>>> </service>
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>
>>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

Ha! I forgot to say that some events of type "jsonsimple" were also changed.
I guess it's ok too, since it use the same ComponentLocationResolver.getBaseLocation()
But I did not test any hence the notice.

Jacques

From: "Jacques Le Roux" <[hidden email]>

>I tested it works well. Changes done at revision: 765798
> Not removed the ${component-dir}/ script directory from the classpath yet..
>
> Jacques
>
> From: "David E Jones" <[hidden email]>
>> It should be supported now, but yeah it would be a good idea to test it before doing a mass change. And yes, a mass change there
>> would be great too.
>>
>> Once those are done we could probably remove the ${component-dir}/ script directory from the classpath.
>>
>> -David
>>
>>
>> On Mar 19, 2009, at 8:07 AM, Jacques Le Roux wrote:
>>
>>> Ashish,
>>>
>>> Looks like a good idea, but I'm not sure FTTOMH
>>> We would have to look at controller code...
>>>
>>> Jacques
>>>
>>> From: "Ashish Vijaywargiya" <[hidden email]>
>>>> Jacques,
>>>>
>>>> Do we need to change the same thing in controller.xml ?
>>>> For ex :
>>>> <event type="simple" path="org/ofbiz/ecommerce/customer/ CustomerEvents.xml" invoke="processCustomerSettings"/>
>>>>
>>>> WDYT ?
>>>>
>>>> --
>>>> Ashish
>>>>
>>>>
>>>> Jacques Le Roux wrote:
>>>>> Done at revision: 755977
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "David E Jones" <[hidden email]>
>>>>>>
>>>>>> This would be great to have done before the release. It would allow us to get a LOT of stuff off the classpath, which can
>>>>>> be a painful part of deployment.
>>>>>>
>>>>>> -David
>>>>>>
>>>>>>
>>>>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>>>>
>>>>>>> I had a closer look
>>>>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>>>>> says there are 1305 other cases... (I did not look into details, maybe this regexp is too loosely written)
>>>>>>>
>>>>>>> I will do a serious Eclipse regexp S/R, when I will get a chance...
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>> From: <[hidden email]>
>>>>>>>> Author: jleroux
>>>>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>>>>> New Revision: 755658
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>>>>> Log:
>>>>>>>> Following Ashish's commit at r755572:
>>>>>>>> Followed best practice.
>>>>>>>> Changed location="org/ofbiz/......... to location="component:// party/script/org/ofbiz......
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>>>>
>>>>>>>> Modified: ofbiz/trunk/applications/party/servicedef/ services_view.xml
>>>>>>>> URL:
>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>>>>> = = = = = = = = = = = = = =================================================================
>>>>>>>> --- ofbiz/trunk/applications/party/servicedef/ services_view.xml (original)
>>>>>>>> +++ ofbiz/trunk/applications/party/servicedef/services_view.xml Wed Mar 18 17:21:14 2009
>>>>>>>> @@ -115,14 +115,14 @@
>>>>>>>> </service>
>>>>>>>>
>>>>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>>> + location="component://party/script/org/ofbiz/party/ party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>>> <description>Gets all parties related to partyIdFrom through the PartyRelationship entity</description>
>>>>>>>> <auto-attributes mode="IN" include="all" optional="true" entity-name="PartyRelationship"/>
>>>>>>>> <attribute name="parties" type="java.util.Collection" mode="OUT" optional="true"/>
>>>>>>>> <override name="partyIdFrom" optional="false"/>
>>>>>>>> </service>
>>>>>>>> <service name="getRelatedParties" engine="simple"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getRelatedParties">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>>>>> <description>
>>>>>>>> Get Parties Related to a Party
>>>>>>>> - The relatedPartyIdList coming out will include the original partyIdFrom
>>>>>>>> @@ -142,7 +142,7 @@
>>>>>>>> </service>
>>>>>>>>
>>>>>>>> <service name="getParentOrganizations" engine="simple"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getParentOrganizations">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getParentOrganizations">
>>>>>>>> <description>
>>>>>>>> Gets Parent Organizations for an Organization Party.
>>>>>>>> This uses the PartyRelationship table with partyRelationshipTypeId="GROUP_ROLLUP".
>>>>>>>> @@ -157,7 +157,7 @@
>>>>>>>> </service>
>>>>>>>>
>>>>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>>> <description>
>>>>>>>> Get Child RoleTypes.
>>>>>>>> The childRoleTypeIdList coming out will contain the original roleTypeId.
>>>>>>>> @@ -168,7 +168,7 @@
>>>>>>>>
>>>>>>>> 
>>>>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml"
>>>>>>>> invoke="getPostalAddressBoundary">
>>>>>>>> <description>Get all Postal Address Boundaries</ description>
>>>>>>>> <permission-service service- name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>>>>> <attribute name="contactMechId" type="String" mode="IN" optional="false"/>
>>>>>>>> @@ -177,12 +177,12 @@
>>>>>>>>
>>>>>>>> 
>>>>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getCountryList">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getCountryList">
>>>>>>>> <attribute name="countryList" mode="OUT" type="java.util.List"/>
>>>>>>>> </service>
>>>>>>>>
>>>>>>>> <service name="getAssociatedStateList" engine="simple" auth="false"
>>>>>>>> - location="org/ofbiz/party/party/ PartyServices.xml" invoke="getAssociatedStateList">
>>>>>>>> + location="component://party/script/org/ofbiz/ party/ party/PartyServices.xml" invoke="getAssociatedStateList">
>>>>>>>> <attribute name="countryGeoId" mode="IN" type="String" optional="false"/>
>>>>>>>> <attribute name="stateList" mode="OUT" type="java.util.List"/>
>>>>>>>> </service>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>>
>>
>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

In reply to this post by Jacques Le Roux

I tried to removed the ${component-dir}/script directory from the classpath but it does not work.
I tried with
<event type="simple" path="component://org/ofbiz/accounting/payment/PaymentMethodEvents.xml" invoke="updateCreditCard"/>
instead of
<event type="simple" path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
invoke="updateCreditCard"/>
ang got this message
Could not find SimpleMethod XML document in resource: component://org/ofbiz/accounting/payment/PaymentMethodEvents.xml; error was:
java.net.MalformedURLException: Could not get root location for component with name [org], error was:
org.ofbiz.base.component.ComponentException: No component found named : org (Could not get root location for component with name
[org], error was: org.ofbiz.base.component.ComponentException: No component found named : org)

I did not try further, nor looked at details in code. Did I do something wrong ?

Jacques

From: "Jacques Le Roux" <[hidden email]>

David E Jones-3

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Are you trying to use the classpath reference instead of the component
reference? If so, why?

To use a classpath reference make there is no "component://" on the
front, ie:

path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"

Still, using the component reference is generally better, and if not
supported somewhere please let me know...

-David

On Apr 20, 2009, at 11:02 AM, Jacques Le Roux wrote:

> I tried to removed the ${component-dir}/script directory from the
> classpath but it does not work.
> I tried with
> <event type="simple" path="component://org/ofbiz/accounting/payment/
> PaymentMethodEvents.xml" invoke="updateCreditCard"/>
> instead of
> <event type="simple" path="component://accounting/script/org/ofbiz/
> accounting/payment/PaymentMethodEvents.xml"
> invoke="updateCreditCard"/>
> ang got this message
> Could not find SimpleMethod XML document in resource: component://
> org/ofbiz/accounting/payment/PaymentMethodEvents.xml; error was:
> java.net.MalformedURLException: Could not get root location for
> component with name [org], error was:
> org.ofbiz.base.component.ComponentException: No component found
> named : org (Could not get root location for component with name
> [org], error was: org.ofbiz.base.component.ComponentException: No
> component found named : org)
>
> I did not try further, nor looked at details in code. Did I do
> something wrong ?
>
> Jacques
>
> From: "Jacques Le Roux" <[hidden email]>
>> I tested it works well. Changes done at revision: 765798
>> Not removed the ${component-dir}/ script directory from the
>> classpath yet..
>>
>> Jacques
>>
>> From: "David E Jones" <[hidden email]>
>>> It should be supported now, but yeah it would be a good idea to
>>> test it before doing a mass change. And yes, a mass change there
>>> would be great too.
>>>
>>> Once those are done we could probably remove the ${component-dir}/
>>> script directory from the classpath.
>>>
>>> -David
>>>
>>>
>>> On Mar 19, 2009, at 8:07 AM, Jacques Le Roux wrote:
>>>
>>>> Ashish,
>>>>
>>>> Looks like a good idea, but I'm not sure FTTOMH
>>>> We would have to look at controller code...
>>>>
>>>> Jacques
>>>>
>>>> From: "Ashish Vijaywargiya" <[hidden email]>
>>>>> Jacques,
>>>>>
>>>>> Do we need to change the same thing in controller.xml ?
>>>>> For ex :
>>>>> <event type="simple" path="org/ofbiz/ecommerce/customer/
>>>>> CustomerEvents.xml" invoke="processCustomerSettings"/>
>>>>>
>>>>> WDYT ?
>>>>>
>>>>> --
>>>>> Ashish
>>>>>
>>>>>
>>>>> Jacques Le Roux wrote:
>>>>>> Done at revision: 755977
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "David E Jones" <[hidden email]>
>>>>>>>
>>>>>>> This would be great to have done before the release. It would
>>>>>>> allow us to get a LOT of stuff off the classpath, which can
>>>>>>> be a painful part of deployment.
>>>>>>>
>>>>>>> -David
>>>>>>>
>>>>>>>
>>>>>>> On Mar 18, 2009, at 11:28 AM, Jacques Le Roux wrote:
>>>>>>>
>>>>>>>> I had a closer look
>>>>>>>> <service name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
>>>>>>>> says there are 1305 other cases... (I did not look into
>>>>>>>> details, maybe this regexp is too loosely written)
>>>>>>>>
>>>>>>>> I will do a serious Eclipse regexp S/R, when I will get a
>>>>>>>> chance...
>>>>>>>>
>>>>>>>> Jacques
>>>>>>>>
>>>>>>>> From: <[hidden email]>
>>>>>>>>> Author: jleroux
>>>>>>>>> Date: Wed Mar 18 17:21:14 2009
>>>>>>>>> New Revision: 755658
>>>>>>>>>
>>>>>>>>> URL: http://svn.apache.org/viewvc?rev=755658&view=rev
>>>>>>>>> Log:
>>>>>>>>> Following Ashish's commit at r755572:
>>>>>>>>> Followed best practice.
>>>>>>>>> Changed location="org/ofbiz/......... to
>>>>>>>>> location="component:// party/script/org/ofbiz......
>>>>>>>>>
>>>>>>>>> Modified:
>>>>>>>>> ofbiz/trunk/applications/party/servicedef/services_view.xml
>>>>>>>>>
>>>>>>>>> Modified: ofbiz/trunk/applications/party/servicedef/
>>>>>>>>> services_view.xml
>>>>>>>>> URL:
>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
>>>>>>>>> = = = = = = = = = = = = =
>>>>>>>>> =
>>>>>>>>> =
>>>>>>>>> =
>>>>>>>>> ==============================================================
>>>>>>>>> --- ofbiz/trunk/applications/party/servicedef/
>>>>>>>>> services_view.xml (original)
>>>>>>>>> +++ ofbiz/trunk/applications/party/servicedef/
>>>>>>>>> services_view.xml Wed Mar 18 17:21:14 2009
>>>>>>>>> @@ -115,14 +115,14 @@
>>>>>>>>> </service>
>>>>>>>>>
>>>>>>>>> <service name="getPartiesByRelationship" engine="simple"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>>>> + location="component://party/script/org/ofbiz/party/
>>>>>>>>> party/ PartyServices.xml" invoke="getPartiesByRelationship">
>>>>>>>>> <description>Gets all parties related to partyIdFrom
>>>>>>>>> through the PartyRelationship entity</description>
>>>>>>>>> <auto-attributes mode="IN" include="all"
>>>>>>>>> optional="true" entity-name="PartyRelationship"/>
>>>>>>>>> <attribute name="parties" type="java.util.Collection"
>>>>>>>>> mode="OUT" optional="true"/>
>>>>>>>>> <override name="partyIdFrom" optional="false"/>
>>>>>>>>> </service>
>>>>>>>>> <service name="getRelatedParties" engine="simple"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getRelatedParties">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml" invoke="getRelatedParties">
>>>>>>>>> <description>
>>>>>>>>> Get Parties Related to a Party
>>>>>>>>> - The relatedPartyIdList coming out will include
>>>>>>>>> the original partyIdFrom
>>>>>>>>> @@ -142,7 +142,7 @@
>>>>>>>>> </service>
>>>>>>>>>
>>>>>>>>> <service name="getParentOrganizations" engine="simple"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getParentOrganizations">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml"
>>>>>>>>> invoke="getParentOrganizations">
>>>>>>>>> <description>
>>>>>>>>> Gets Parent Organizations for an Organization Party.
>>>>>>>>> This uses the PartyRelationship table with
>>>>>>>>> partyRelationshipTypeId="GROUP_ROLLUP".
>>>>>>>>> @@ -157,7 +157,7 @@
>>>>>>>>> </service>
>>>>>>>>>
>>>>>>>>> <service name="getChildRoleTypes" engine="simple"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml" invoke="getChildRoleTypes">
>>>>>>>>> <description>
>>>>>>>>> Get Child RoleTypes.
>>>>>>>>> The childRoleTypeIdList coming out will contain
>>>>>>>>> the original roleTypeId.
>>>>>>>>> @@ -168,7 +168,7 @@
>>>>>>>>>
>>>>>>>>> 
>>>>>>>>> <service name="getPostalAddressBoundary" engine="simple"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getPostalAddressBoundary">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml"
>>>>>>>>> invoke="getPostalAddressBoundary">
>>>>>>>>> <description>Get all Postal Address Boundaries</
>>>>>>>>> description>
>>>>>>>>> <permission-service service-
>>>>>>>>> name="partyBasePermissionCheck" main-action="VIEW"/>
>>>>>>>>> <attribute name="contactMechId" type="String"
>>>>>>>>> mode="IN" optional="false"/>
>>>>>>>>> @@ -177,12 +177,12 @@
>>>>>>>>>
>>>>>>>>> 
>>>>>>>>> <service name="getCountryList" engine="simple" auth="false"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getCountryList">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml" invoke="getCountryList">
>>>>>>>>> <attribute name="countryList" mode="OUT"
>>>>>>>>> type="java.util.List"/>
>>>>>>>>> </service>
>>>>>>>>>
>>>>>>>>> <service name="getAssociatedStateList" engine="simple"
>>>>>>>>> auth="false"
>>>>>>>>> - location="org/ofbiz/party/party/
>>>>>>>>> PartyServices.xml" invoke="getAssociatedStateList">
>>>>>>>>> + location="component://party/script/org/ofbiz/
>>>>>>>>> party/ party/PartyServices.xml"
>>>>>>>>> invoke="getAssociatedStateList">
>>>>>>>>> <attribute name="countryGeoId" mode="IN"
>>>>>>>>> type="String" optional="false"/>
>>>>>>>>> <attribute name="stateList" mode="OUT"
>>>>>>>>> type="java.util.List"/>
>>>>>>>>> </service>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>
>>
>>
>
>

Adrian Crum-2

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

I think the answer Jacques is looking for is: Yes, you did something wrong.

The correct component:// URL is:

<event type="simple" path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml" invoke="updateCreditCard"/>

The correct classpath is:

<event type="simple" path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml" invoke="updateCreditCard"/>

From what I recall, the component:// version has a more efficient lookup algorithm - and as David mentioned, it is generally better to use.

-Adrian

--- On Mon, 4/20/09, David E Jones <[hidden email]> wrote:

> From: David E Jones <[hidden email]>
> Subject: Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml
> To: [hidden email]
> Date: Monday, April 20, 2009, 8:16 PM
> Are you trying to use the classpath reference instead of the
> component reference? If so, why?
>
> To use a classpath reference make there is no
> "component://" on the front, ie:
>
> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>
> Still, using the component reference is generally better,
> and if not supported somewhere please let me know...
>
> -David
>
>
> On Apr 20, 2009, at 11:02 AM, Jacques Le Roux wrote:
>
> > I tried to removed the ${component-dir}/script
> directory from the classpath but it does not work.
> > I tried with
> > <event type="simple"
> path="component://org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
> invoke="updateCreditCard"/>
> > instead of
> > <event type="simple"
> path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
> invoke="updateCreditCard"/>
> > ang got this message
> > Could not find SimpleMethod XML document in resource:
> component://org/ofbiz/accounting/payment/PaymentMethodEvents.xml;
> error was:
> > java.net.MalformedURLException: Could not get root
> location for component with name [org], error was:
> > org.ofbiz.base.component.ComponentException: No
> component found named : org (Could not get root location for
> component with name
> > [org], error was:
> org.ofbiz.base.component.ComponentException: No component
> found named : org)
> >
> > I did not try further, nor looked at details in code.
> Did I do something wrong ?
> >
> > Jacques
> >
> > From: "Jacques Le Roux"
> <[hidden email]>
> >> I tested it works well. Changes done at revision:
> 765798
> >> Not removed the ${component-dir}/ script
> directory from the classpath yet..
> >>
> >> Jacques
> >>
> >> From: "David E Jones"
> <[hidden email]>
> >>> It should be supported now, but yeah it would
> be a good idea to test it before doing a mass change. And
> yes, a mass change there
> >>> would be great too.
> >>>
> >>> Once those are done we could probably remove
> the ${component-dir}/ script directory from the classpath.
> >>>
> >>> -David
> >>>
> >>>
> >>> On Mar 19, 2009, at 8:07 AM, Jacques Le Roux
> wrote:
> >>>
> >>>> Ashish,
> >>>>
> >>>> Looks like a good idea, but I'm not
> sure FTTOMH
> >>>> We would have to look at controller
> code...
> >>>>
> >>>> Jacques
> >>>>
> >>>> From: "Ashish Vijaywargiya"
> <[hidden email]>
> >>>>> Jacques,
> >>>>>
> >>>>> Do we need to change the same thing in
> controller.xml ?
> >>>>> For ex :
> >>>>> <event type="simple"
> path="org/ofbiz/ecommerce/customer/
> CustomerEvents.xml"
> invoke="processCustomerSettings"/>
> >>>>>
> >>>>> WDYT ?
> >>>>>
> >>>>> --
> >>>>> Ashish
> >>>>>
> >>>>>
> >>>>> Jacques Le Roux wrote:
> >>>>>> Done at revision: 755977
> >>>>>>
> >>>>>> Jacques
> >>>>>>
> >>>>>> From: "David E Jones"
> <[hidden email]>
> >>>>>>>
> >>>>>>> This would be great to have
> done before the release. It would allow us to get a LOT of
> stuff off the classpath, which can
> >>>>>>> be a painful part of
> deployment.
> >>>>>>>
> >>>>>>> -David
> >>>>>>>
> >>>>>>>
> >>>>>>> On Mar 18, 2009, at 11:28 AM,
> Jacques Le Roux wrote:
> >>>>>>>
> >>>>>>>> I had a closer look
> >>>>>>>> <service
> name=(.*)engine="simple"(.*)\R(.*)location="org.ofbiz
> >>>>>>>> says there are 1305 other
> cases... (I did not look into details, maybe this regexp
> is too loosely written)
> >>>>>>>>
> >>>>>>>> I will do a serious
> Eclipse regexp S/R, when I will get a chance...
> >>>>>>>>
> >>>>>>>> Jacques
> >>>>>>>>
> >>>>>>>> From:
> <[hidden email]>
> >>>>>>>>> Author: jleroux
> >>>>>>>>> Date: Wed Mar 18
> 17:21:14 2009
> >>>>>>>>> New Revision: 755658
> >>>>>>>>>
> >>>>>>>>> URL:
> http://svn.apache.org/viewvc?rev=755658&view=rev
> >>>>>>>>> Log:
> >>>>>>>>> Following Ashish's
> commit at r755572:
> >>>>>>>>> Followed best
> practice.
> >>>>>>>>> Changed
> location="org/ofbiz/......... to
> location="component:// party/script/org/ofbiz......
> >>>>>>>>>
> >>>>>>>>> Modified:
> >>>>>>>>>
> ofbiz/trunk/applications/party/servicedef/services_view.xml
> >>>>>>>>>
> >>>>>>>>> Modified:
> ofbiz/trunk/applications/party/servicedef/ services_view.xml
> >>>>>>>>> URL:
> >>>>>>>>>
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/servicedef/services_view.xml?rev=755658&r1=755657&r2=755658&view=diff
> >>>>>>>>> = = = = = = = = = = =
> = =
> =================================================================
> >>>>>>>>> ---
> ofbiz/trunk/applications/party/servicedef/ services_view.xml
> (original)
> >>>>>>>>> +++
> ofbiz/trunk/applications/party/servicedef/services_view.xml
> Wed Mar 18 17:21:14 2009
> >>>>>>>>> @@ -115,14 +115,14 @@
> >>>>>>>>> </service>
> >>>>>>>>>
> >>>>>>>>> <service
> name="getPartiesByRelationship"
> engine="simple"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getPartiesByRelationship">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/party/
> party/ PartyServices.xml"
> invoke="getPartiesByRelationship">
> >>>>>>>>>
> <description>Gets all parties related to partyIdFrom
> through the PartyRelationship entity</description>
> >>>>>>>>>
> <auto-attributes mode="IN"
> include="all" optional="true"
> entity-name="PartyRelationship"/>
> >>>>>>>>> <attribute
> name="parties"
> type="java.util.Collection" mode="OUT"
> optional="true"/>
> >>>>>>>>> <override
> name="partyIdFrom" optional="false"/>
> >>>>>>>>> </service>
> >>>>>>>>> <service
> name="getRelatedParties" engine="simple"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getRelatedParties">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> invoke="getRelatedParties">
> >>>>>>>>>
> <description>
> >>>>>>>>> Get Parties
> Related to a Party
> >>>>>>>>> - The
> relatedPartyIdList coming out will include the original
> partyIdFrom
> >>>>>>>>> @@ -142,7 +142,7 @@
> >>>>>>>>> </service>
> >>>>>>>>>
> >>>>>>>>> <service
> name="getParentOrganizations"
> engine="simple"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getParentOrganizations">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> invoke="getParentOrganizations">
> >>>>>>>>>
> <description>
> >>>>>>>>> Gets Parent
> Organizations for an Organization Party.
> >>>>>>>>> This uses the
> PartyRelationship table with
> partyRelationshipTypeId="GROUP_ROLLUP".
> >>>>>>>>> @@ -157,7 +157,7 @@
> >>>>>>>>> </service>
> >>>>>>>>>
> >>>>>>>>> <service
> name="getChildRoleTypes" engine="simple"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getChildRoleTypes">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> invoke="getChildRoleTypes">
> >>>>>>>>>
> <description>
> >>>>>>>>> Get Child
> RoleTypes.
> >>>>>>>>> The
> childRoleTypeIdList coming out will contain the original
> roleTypeId.
> >>>>>>>>> @@ -168,7 +168,7 @@
> >>>>>>>>>
> >>>>>>>>> 
> >>>>>>>>> <service
> name="getPostalAddressBoundary"
> engine="simple"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getPostalAddressBoundary">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> >>>>>>>>>
> invoke="getPostalAddressBoundary">
> >>>>>>>>>
> <description>Get all Postal Address Boundaries</
> description>
> >>>>>>>>>
> <permission-service service-
> name="partyBasePermissionCheck"
> main-action="VIEW"/>
> >>>>>>>>> <attribute
> name="contactMechId" type="String"
> mode="IN" optional="false"/>
> >>>>>>>>> @@ -177,12 +177,12 @@
> >>>>>>>>>
> >>>>>>>>> 
> >>>>>>>>> <service
> name="getCountryList" engine="simple"
> auth="false"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getCountryList">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> invoke="getCountryList">
> >>>>>>>>> <attribute
> name="countryList" mode="OUT"
> type="java.util.List"/>
> >>>>>>>>> </service>
> >>>>>>>>>
> >>>>>>>>> <service
> name="getAssociatedStateList"
> engine="simple" auth="false"
> >>>>>>>>> -
> location="org/ofbiz/party/party/
> PartyServices.xml"
> invoke="getAssociatedStateList">
> >>>>>>>>> +
> location="component://party/script/org/ofbiz/ party/
> party/PartyServices.xml"
> invoke="getAssociatedStateList">
> >>>>>>>>> <attribute
> name="countryGeoId" mode="IN"
> type="String" optional="false"/>
> >>>>>>>>> <attribute
> name="stateList" mode="OUT"
> type="java.util.List"/>
> >>>>>>>>> </service>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>>
> >>>>
> >>>>
> >>>
> >>
> >>
> >
> >

Ashish Vijaywargiya

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

+1

--
Ashish

On Tue, Apr 21, 2009 at 9:01 AM, Adrian Crum <[hidden email]> wrote:

>
> I think the answer Jacques is looking for is: Yes, you did something wrong.
>
> The correct component:// URL is:
>
> <event type="simple"
> path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
> invoke="updateCreditCard"/>
>
> The correct classpath is:
>
> <event type="simple"
> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
> invoke="updateCreditCard"/>
>
> From what I recall, the component:// version has a more efficient lookup
> algorithm - and as David mentioned, it is generally better to use.
>
> -Adrian
>
>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

Thankd for your answers guys,

Yes I know that. I recently automatically refactored all links at r765798
http://markmail.org/message/xe6a7zdpwwewxnxy

Actually I was trying to follow David's suggestion from his answer to Ashish
http://markmail.org/message/to2jynvgthh6j756

I was not sure to clearly understand his suggestion though, and I think now my interpretation is totally wrong. Could you please
explain your idea David ?

Thanks

Jacques
PS: BTW I found some links I did not refactor even at r765808 where I already said
One more time caught by a file edited in Eclipse and not saved during S/R (related to r765798)
Fixed at r767060

From: "Ashish Vijaywargiya" <[hidden email]>

> +1
>
> --
> Ashish
>
> On Tue, Apr 21, 2009 at 9:01 AM, Adrian Crum <[hidden email]> wrote:
>
>>
>> I think the answer Jacques is looking for is: Yes, you did something wrong.
>>
>> The correct component:// URL is:
>>
>> <event type="simple"
>> path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>> invoke="updateCreditCard"/>
>>
>> The correct classpath is:
>>
>> <event type="simple"
>> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>> invoke="updateCreditCard"/>
>>
>> From what I recall, the component:// version has a more efficient lookup
>> algorithm - and as David mentioned, it is generally better to use.
>>
>> -Adrian
>>
>>
>>
>

Jacques Le Roux

Re: svn commit: r755658 - /ofbiz/trunk/applications/party/servicedef/services_view.xml

Administrator

Hi David,

Your suggestion was,

> Once those are done we could probably remove the ${component-dir}/ script directory from the classpath.

I'm not sure to understand what you mean by this. Or maybe, I tried and it does not work, in this case simply ignore this (last)
message (hope it's understandable)

Jacques

From: "Jacques Le Roux" <[hidden email]>

> Thankd for your answers guys,
>
> Yes I know that. I recently automatically refactored all links at r765798
> http://markmail.org/message/xe6a7zdpwwewxnxy
>
> Actually I was trying to follow David's suggestion from his answer to Ashish
> http://markmail.org/message/to2jynvgthh6j756
>
> I was not sure to clearly understand his suggestion though, and I think now my interpretation is totally wrong. Could you please
> explain your idea David ?
>
> Thanks
>
> Jacques
> PS: BTW I found some links I did not refactor even at r765808 where I already said
> One more time caught by a file edited in Eclipse and not saved during S/R (related to r765798)
> Fixed at r767060
>
> From: "Ashish Vijaywargiya" <[hidden email]>
>> +1
>>
>> --
>> Ashish
>>
>> On Tue, Apr 21, 2009 at 9:01 AM, Adrian Crum <[hidden email]> wrote:
>>
>>>
>>> I think the answer Jacques is looking for is: Yes, you did something wrong.
>>>
>>> The correct component:// URL is:
>>>
>>> <event type="simple"
>>> path="component://accounting/script/org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>>> invoke="updateCreditCard"/>
>>>
>>> The correct classpath is:
>>>
>>> <event type="simple"
>>> path="org/ofbiz/accounting/payment/PaymentMethodEvents.xml"
>>> invoke="updateCreditCard"/>
>>>
>>> From what I recall, the component:// version has a more efficient lookup
>>> algorithm - and as David mentioned, it is generally better to use.
>>>
>>> -Adrian
>>>
>>>
>>>
>>
>
>