If this was done to accommodate the UEL auto-vivify problem, it can be
reverted. -Adrian [hidden email] wrote: > Author: jonesde > Date: Tue Apr 14 20:50:23 2009 > New Revision: 764947 > > URL: http://svn.apache.org/viewvc?rev=764947&view=rev > Log: > Small change to have a prefix for all sequenced IDs by default > > Modified: > ofbiz/trunk/framework/entity/config/entityengine.xml > > Modified: ofbiz/trunk/framework/entity/config/entityengine.xml > URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/config/entityengine.xml?rev=764947&r1=764946&r2=764947&view=diff > ============================================================================== > --- ofbiz/trunk/framework/entity/config/entityengine.xml (original) > +++ ofbiz/trunk/framework/entity/config/entityengine.xml Tue Apr 14 20:50:23 2009 > @@ -49,21 +49,21 @@ > <!-- the connection factory class to use, one is needed for obtaining connections/pools for defined resources --> > <connection-factory class="org.ofbiz.entity.connection.DBCPConnectionFactory"/> > > - <delegator name="default" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main" distributed-cache-clear-enabled="false"> > + <delegator name="default" sequenced-id-prefix="OFB" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main" distributed-cache-clear-enabled="false"> > <group-map group-name="org.ofbiz" datasource-name="localderby"/> > <group-map group-name="org.ofbiz.olap" datasource-name="localderbyolap"/> > </delegator> > - <delegator name="default-no-eca" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main" entity-eca-enabled="false" distributed-cache-clear-enabled="false"> > + <delegator name="default-no-eca" sequenced-id-prefix="OFB" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main" entity-eca-enabled="false" distributed-cache-clear-enabled="false"> > <group-map group-name="org.ofbiz" datasource-name="localderby"/> > <group-map group-name="org.ofbiz.olap" datasource-name="localderbyolap"/> > </delegator> > > <!-- be sure that your default delegator (or the one you use) uses the same datasource for test. You must run "ant run-install" before running "ant run-tests" --> > - <delegator name="test" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main"> > + <delegator name="test" sequenced-id-prefix="OFB" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main"> > <group-map group-name="org.ofbiz" datasource-name="localderby"/> > <group-map group-name="org.ofbiz.olap" datasource-name="localderbyolap"/> > </delegator> > - <delegator name="other" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main"> > + <delegator name="other" sequenced-id-prefix="OFB" entity-model-reader="main" entity-group-reader="main" entity-eca-reader="main"> > <group-map group-name="org.ofbiz" datasource-name="localpostgres"/> > </delegator> > > > > |
This was indeed done to help with that, but I think I like it anyway. The overall effect is that it distinguishes the IDs from other sources, etc. On the other hand... maybe it's a little ugly? -David On Apr 14, 2009, at 5:42 PM, Adrian Crum wrote: > If this was done to accommodate the UEL auto-vivify problem, it can > be reverted. > > -Adrian > > [hidden email] wrote: >> Author: jonesde >> Date: Tue Apr 14 20:50:23 2009 >> New Revision: 764947 >> URL: http://svn.apache.org/viewvc?rev=764947&view=rev >> Log: >> Small change to have a prefix for all sequenced IDs by default >> Modified: >> ofbiz/trunk/framework/entity/config/entityengine.xml >> Modified: ofbiz/trunk/framework/entity/config/entityengine.xml >> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/config/entityengine.xml?rev=764947&r1=764946&r2=764947&view=diff >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- ofbiz/trunk/framework/entity/config/entityengine.xml (original) >> +++ ofbiz/trunk/framework/entity/config/entityengine.xml Tue Apr 14 >> 20:50:23 2009 >> @@ -49,21 +49,21 @@ >> <!-- the connection factory class to use, one is needed for >> obtaining connections/pools for defined resources --> >> <connection-factory >> class="org.ofbiz.entity.connection.DBCPConnectionFactory"/> >> - <delegator name="default" entity-model-reader="main" entity- >> group-reader="main" entity-eca-reader="main" distributed-cache- >> clear-enabled="false"> >> + <delegator name="default" sequenced-id-prefix="OFB" entity- >> model-reader="main" entity-group-reader="main" entity-eca- >> reader="main" distributed-cache-clear-enabled="false"> >> <group-map group-name="org.ofbiz" datasource- >> name="localderby"/> >> <group-map group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >> </delegator> >> - <delegator name="default-no-eca" entity-model-reader="main" >> entity-group-reader="main" entity-eca-reader="main" entity-eca- >> enabled="false" distributed-cache-clear-enabled="false"> >> + <delegator name="default-no-eca" sequenced-id-prefix="OFB" >> entity-model-reader="main" entity-group-reader="main" entity-eca- >> reader="main" entity-eca-enabled="false" distributed-cache-clear- >> enabled="false"> >> <group-map group-name="org.ofbiz" datasource- >> name="localderby"/> >> <group-map group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >> </delegator> >> <!-- be sure that your default delegator (or the one you use) >> uses the same datasource for test. You must run "ant run-install" >> before running "ant run-tests" --> >> - <delegator name="test" entity-model-reader="main" entity-group- >> reader="main" entity-eca-reader="main"> >> + <delegator name="test" sequenced-id-prefix="OFB" entity-model- >> reader="main" entity-group-reader="main" entity-eca-reader="main"> >> <group-map group-name="org.ofbiz" datasource- >> name="localderby"/> >> <group-map group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >> </delegator> >> - <delegator name="other" entity-model-reader="main" entity- >> group-reader="main" entity-eca-reader="main"> >> + <delegator name="other" sequenced-id-prefix="OFB" entity-model- >> reader="main" entity-group-reader="main" entity-eca-reader="main"> >> <group-map group-name="org.ofbiz" datasource- >> name="localpostgres"/> >> </delegator> >> |
Administrator
|
Do we really need that ? I think that adding a prefix when it comes from an external source is enough.
Jacques From: "David E Jones" <[hidden email]> > This was indeed done to help with that, but I think I like it anyway. > The overall effect is that it distinguishes the IDs from other > sources, etc. On the other hand... maybe it's a little ugly? > > -David > > > On Apr 14, 2009, at 5:42 PM, Adrian Crum wrote: > >> If this was done to accommodate the UEL auto-vivify problem, it can >> be reverted. >> >> -Adrian >> >> [hidden email] wrote: >>> Author: jonesde >>> Date: Tue Apr 14 20:50:23 2009 >>> New Revision: 764947 >>> URL: http://svn.apache.org/viewvc?rev=764947&view=rev >>> Log: >>> Small change to have a prefix for all sequenced IDs by default >>> Modified: >>> ofbiz/trunk/framework/entity/config/entityengine.xml >>> Modified: ofbiz/trunk/framework/entity/config/entityengine.xml >>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/config/entityengine.xml?rev=764947&r1=764946&r2=764947&view=diff >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> = >>> ===================================================================== >>> --- ofbiz/trunk/framework/entity/config/entityengine.xml (original) >>> +++ ofbiz/trunk/framework/entity/config/entityengine.xml Tue Apr 14 >>> 20:50:23 2009 >>> @@ -49,21 +49,21 @@ >>> <!-- the connection factory class to use, one is needed for >>> obtaining connections/pools for defined resources --> >>> <connection-factory >>> class="org.ofbiz.entity.connection.DBCPConnectionFactory"/> >>> - <delegator name="default" entity-model-reader="main" entity- >>> group-reader="main" entity-eca-reader="main" distributed-cache- >>> clear-enabled="false"> >>> + <delegator name="default" sequenced-id-prefix="OFB" entity- >>> model-reader="main" entity-group-reader="main" entity-eca- >>> reader="main" distributed-cache-clear-enabled="false"> >>> <group-map group-name="org.ofbiz" datasource- >>> name="localderby"/> >>> <group-map group-name="org.ofbiz.olap" datasource- >>> name="localderbyolap"/> >>> </delegator> >>> - <delegator name="default-no-eca" entity-model-reader="main" >>> entity-group-reader="main" entity-eca-reader="main" entity-eca- >>> enabled="false" distributed-cache-clear-enabled="false"> >>> + <delegator name="default-no-eca" sequenced-id-prefix="OFB" >>> entity-model-reader="main" entity-group-reader="main" entity-eca- >>> reader="main" entity-eca-enabled="false" distributed-cache-clear- >>> enabled="false"> >>> <group-map group-name="org.ofbiz" datasource- >>> name="localderby"/> >>> <group-map group-name="org.ofbiz.olap" datasource- >>> name="localderbyolap"/> >>> </delegator> >>> <!-- be sure that your default delegator (or the one you use) >>> uses the same datasource for test. You must run "ant run-install" >>> before running "ant run-tests" --> >>> - <delegator name="test" entity-model-reader="main" entity-group- >>> reader="main" entity-eca-reader="main"> >>> + <delegator name="test" sequenced-id-prefix="OFB" entity-model- >>> reader="main" entity-group-reader="main" entity-eca-reader="main"> >>> <group-map group-name="org.ofbiz" datasource- >>> name="localderby"/> >>> <group-map group-name="org.ofbiz.olap" datasource- >>> name="localderbyolap"/> >>> </delegator> >>> - <delegator name="other" entity-model-reader="main" entity- >>> group-reader="main" entity-eca-reader="main"> >>> + <delegator name="other" sequenced-id-prefix="OFB" entity-model- >>> reader="main" entity-group-reader="main" entity-eca-reader="main"> >>> <group-map group-name="org.ofbiz" datasource- >>> name="localpostgres"/> >>> </delegator> >>> > |
Please. Let's hold off on that. My conversation with David made me refer back to the UEL specification - and I'm pretty sure my recent commit does a better job of combining UEL syntax with the OFBiz extensions. I want the UEL integration to work with existing code as much as possible. Please revert it and let's see what happens. There is a good chance nothing goes wrong. -Adrian --- On Tue, 4/14/09, Jacques Le Roux <[hidden email]> wrote: > From: Jacques Le Roux <[hidden email]> > Subject: Re: svn commit: r764947 - /ofbiz/trunk/framework/entity/config/entityengine.xml > To: [hidden email] > Date: Tuesday, April 14, 2009, 11:52 PM > Do we really need that ? I think that adding a prefix when > it comes from an external source is enough. > > Jacques > > From: "David E Jones" > <[hidden email]> > > This was indeed done to help with that, but I think I > like it anyway. The overall effect is that it distinguishes > the IDs from other sources, etc. On the other hand... maybe > it's a little ugly? > > > > -David > > > > > > On Apr 14, 2009, at 5:42 PM, Adrian Crum wrote: > > > >> If this was done to accommodate the UEL > auto-vivify problem, it can be reverted. > >> > >> -Adrian > >> > >> [hidden email] wrote: > >>> Author: jonesde > >>> Date: Tue Apr 14 20:50:23 2009 > >>> New Revision: 764947 > >>> URL: > http://svn.apache.org/viewvc?rev=764947&view=rev > >>> Log: > >>> Small change to have a prefix for all > sequenced IDs by default > >>> Modified: > >>> > ofbiz/trunk/framework/entity/config/entityengine.xml > >>> Modified: > ofbiz/trunk/framework/entity/config/entityengine.xml > >>> URL: > http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/config/entityengine.xml?rev=764947&r1=764946&r2=764947&view=diff > >>> = = = = = = = = = > ===================================================================== > >>> --- > ofbiz/trunk/framework/entity/config/entityengine.xml > (original) > >>> +++ > ofbiz/trunk/framework/entity/config/entityengine.xml Tue Apr > 14 20:50:23 2009 > >>> @@ -49,21 +49,21 @@ > >>> <!-- the connection factory class to > use, one is needed for obtaining connections/pools for > defined resources --> > >>> <connection-factory > class="org.ofbiz.entity.connection.DBCPConnectionFactory"/> > >>> - <delegator name="default" > entity-model-reader="main" entity- > group-reader="main" > entity-eca-reader="main" distributed-cache- > clear-enabled="false"> > >>> + <delegator name="default" > sequenced-id-prefix="OFB" entity- > model-reader="main" > entity-group-reader="main" entity-eca- > reader="main" > distributed-cache-clear-enabled="false"> > >>> <group-map > group-name="org.ofbiz" datasource- > name="localderby"/> > >>> <group-map > group-name="org.ofbiz.olap" datasource- > name="localderbyolap"/> > >>> </delegator> > >>> - <delegator > name="default-no-eca" > entity-model-reader="main" > entity-group-reader="main" > entity-eca-reader="main" entity-eca- > enabled="false" > distributed-cache-clear-enabled="false"> > >>> + <delegator > name="default-no-eca" > sequenced-id-prefix="OFB" > entity-model-reader="main" > entity-group-reader="main" entity-eca- > reader="main" entity-eca-enabled="false" > distributed-cache-clear- enabled="false"> > >>> <group-map > group-name="org.ofbiz" datasource- > name="localderby"/> > >>> <group-map > group-name="org.ofbiz.olap" datasource- > name="localderbyolap"/> > >>> </delegator> > >>> <!-- be sure that your default > delegator (or the one you use) uses the same datasource for > test. You must run "ant run-install" before > running "ant run-tests" --> > >>> - <delegator name="test" > entity-model-reader="main" entity-group- > reader="main" > entity-eca-reader="main"> > >>> + <delegator name="test" > sequenced-id-prefix="OFB" entity-model- > reader="main" entity-group-reader="main" > entity-eca-reader="main"> > >>> <group-map > group-name="org.ofbiz" datasource- > name="localderby"/> > >>> <group-map > group-name="org.ofbiz.olap" datasource- > name="localderbyolap"/> > >>> </delegator> > >>> - <delegator name="other" > entity-model-reader="main" entity- > group-reader="main" > entity-eca-reader="main"> > >>> + <delegator name="other" > sequenced-id-prefix="OFB" entity-model- > reader="main" entity-group-reader="main" > entity-eca-reader="main"> > >>> <group-map > group-name="org.ofbiz" datasource- > name="localpostgres"/> > >>> </delegator> > >>> > > |
In reply to this post by Adrian Crum
Good enough, I'll pop that out now. -David On Apr 15, 2009, at 1:06 AM, Adrian Crum wrote: > > Please. Let's hold off on that. > > My conversation with David made me refer back to the UEL > specification - and I'm pretty sure my recent commit does a better > job of combining UEL syntax with the OFBiz extensions. > > I want the UEL integration to work with existing code as much as > possible. Please revert it and let's see what happens. There is a > good chance nothing goes wrong. > > -Adrian > > > --- On Tue, 4/14/09, Jacques Le Roux <[hidden email]> > wrote: > >> From: Jacques Le Roux <[hidden email]> >> Subject: Re: svn commit: r764947 - /ofbiz/trunk/framework/entity/ >> config/entityengine.xml >> To: [hidden email] >> Date: Tuesday, April 14, 2009, 11:52 PM >> Do we really need that ? I think that adding a prefix when >> it comes from an external source is enough. >> >> Jacques >> >> From: "David E Jones" >> <[hidden email]> >>> This was indeed done to help with that, but I think I >> like it anyway. The overall effect is that it distinguishes >> the IDs from other sources, etc. On the other hand... maybe >> it's a little ugly? >>> >>> -David >>> >>> >>> On Apr 14, 2009, at 5:42 PM, Adrian Crum wrote: >>> >>>> If this was done to accommodate the UEL >> auto-vivify problem, it can be reverted. >>>> >>>> -Adrian >>>> >>>> [hidden email] wrote: >>>>> Author: jonesde >>>>> Date: Tue Apr 14 20:50:23 2009 >>>>> New Revision: 764947 >>>>> URL: >> http://svn.apache.org/viewvc?rev=764947&view=rev >>>>> Log: >>>>> Small change to have a prefix for all >> sequenced IDs by default >>>>> Modified: >>>>> >> ofbiz/trunk/framework/entity/config/entityengine.xml >>>>> Modified: >> ofbiz/trunk/framework/entity/config/entityengine.xml >>>>> URL: >> http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/config/entityengine.xml?rev=764947&r1=764946&r2=764947&view=diff >>>>> = = = = = = = = = >> ===================================================================== >>>>> --- >> ofbiz/trunk/framework/entity/config/entityengine.xml >> (original) >>>>> +++ >> ofbiz/trunk/framework/entity/config/entityengine.xml Tue Apr >> 14 20:50:23 2009 >>>>> @@ -49,21 +49,21 @@ >>>>> <!-- the connection factory class to >> use, one is needed for obtaining connections/pools for >> defined resources --> >>>>> <connection-factory >> class="org.ofbiz.entity.connection.DBCPConnectionFactory"/> >>>>> - <delegator name="default" >> entity-model-reader="main" entity- >> group-reader="main" >> entity-eca-reader="main" distributed-cache- >> clear-enabled="false"> >>>>> + <delegator name="default" >> sequenced-id-prefix="OFB" entity- >> model-reader="main" >> entity-group-reader="main" entity-eca- >> reader="main" >> distributed-cache-clear-enabled="false"> >>>>> <group-map >> group-name="org.ofbiz" datasource- >> name="localderby"/> >>>>> <group-map >> group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >>>>> </delegator> >>>>> - <delegator >> name="default-no-eca" >> entity-model-reader="main" >> entity-group-reader="main" >> entity-eca-reader="main" entity-eca- >> enabled="false" >> distributed-cache-clear-enabled="false"> >>>>> + <delegator >> name="default-no-eca" >> sequenced-id-prefix="OFB" >> entity-model-reader="main" >> entity-group-reader="main" entity-eca- >> reader="main" entity-eca-enabled="false" >> distributed-cache-clear- enabled="false"> >>>>> <group-map >> group-name="org.ofbiz" datasource- >> name="localderby"/> >>>>> <group-map >> group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >>>>> </delegator> >>>>> <!-- be sure that your default >> delegator (or the one you use) uses the same datasource for >> test. You must run "ant run-install" before >> running "ant run-tests" --> >>>>> - <delegator name="test" >> entity-model-reader="main" entity-group- >> reader="main" >> entity-eca-reader="main"> >>>>> + <delegator name="test" >> sequenced-id-prefix="OFB" entity-model- >> reader="main" entity-group-reader="main" >> entity-eca-reader="main"> >>>>> <group-map >> group-name="org.ofbiz" datasource- >> name="localderby"/> >>>>> <group-map >> group-name="org.ofbiz.olap" datasource- >> name="localderbyolap"/> >>>>> </delegator> >>>>> - <delegator name="other" >> entity-model-reader="main" entity- >> group-reader="main" >> entity-eca-reader="main"> >>>>> + <delegator name="other" >> sequenced-id-prefix="OFB" entity-model- >> reader="main" entity-group-reader="main" >> entity-eca-reader="main"> >>>>> <group-map >> group-name="org.ofbiz" datasource- >> name="localpostgres"/> >>>>> </delegator> >>>>> >>> > > > |
In reply to this post by David E Jones-3
David E Jones wrote:
> > This was indeed done to help with that, but I think I like it anyway. > The overall effect is that it distinguishes the IDs from other sources, > etc. On the other hand... maybe it's a little ugly? It's actually quite nice when you deploy a website on a developer machine, a preview system, and a production machine. If the code is creating files that have to match up with an auto-generated id, and said files are *also* commited into revision control, having a per-machine prefix makes everything function a lot smoother. |
On Apr 15, 2009, at 1:32 PM, Adam Heath wrote: > David E Jones wrote: >> >> This was indeed done to help with that, but I think I like it anyway. >> The overall effect is that it distinguishes the IDs from other >> sources, >> etc. On the other hand... maybe it's a little ugly? > > It's actually quite nice when you deploy a website on a developer > machine, a preview system, and a production machine. If the code is > creating files that have to match up with an auto-generated id, and > said files are *also* commited into revision control, having a > per-machine prefix makes everything function a lot smoother. That's a good point. With that you could also easily identify staging data that accidently makes it into the production server and fairly easily eliminate it too. -David |
Administrator
|
Maybe we could use a parameter for that and not by default ?
Jacques From: "David E Jones" <[hidden email]> > On Apr 15, 2009, at 1:32 PM, Adam Heath wrote: > >> David E Jones wrote: >>> >>> This was indeed done to help with that, but I think I like it anyway. >>> The overall effect is that it distinguishes the IDs from other >>> sources, >>> etc. On the other hand... maybe it's a little ugly? >> >> It's actually quite nice when you deploy a website on a developer >> machine, a preview system, and a production machine. If the code is >> creating files that have to match up with an auto-generated id, and >> said files are *also* commited into revision control, having a >> per-machine prefix makes everything function a lot smoother. > > That's a good point. With that you could also easily identify staging > data that accidently makes it into the production server and fairly > easily eliminate it too. > > -David > |
That's basically what it is now. The option has been there for many years in fact. -David On Apr 15, 2009, at 2:09 PM, Jacques Le Roux wrote: > Maybe we could use a parameter for that and not by default ? > > Jacques > > From: "David E Jones" <[hidden email]> >> On Apr 15, 2009, at 1:32 PM, Adam Heath wrote: >>> David E Jones wrote: >>>> >>>> This was indeed done to help with that, but I think I like it >>>> anyway. >>>> The overall effect is that it distinguishes the IDs from other >>>> sources, >>>> etc. On the other hand... maybe it's a little ugly? >>> >>> It's actually quite nice when you deploy a website on a developer >>> machine, a preview system, and a production machine. If the code is >>> creating files that have to match up with an auto-generated id, and >>> said files are *also* commited into revision control, having a >>> per-machine prefix makes everything function a lot smoother. >> That's a good point. With that you could also easily identify >> staging data that accidently makes it into the production server >> and fairly easily eliminate it too. >> -David >> > |
Administrator
|
Yes I know that indeed
Jacques From: "David E Jones" <[hidden email]> > > That's basically what it is now. The option has been there for many > years in fact. > > -David > > > On Apr 15, 2009, at 2:09 PM, Jacques Le Roux wrote: > >> Maybe we could use a parameter for that and not by default ? >> >> Jacques >> >> From: "David E Jones" <[hidden email]> >>> On Apr 15, 2009, at 1:32 PM, Adam Heath wrote: >>>> David E Jones wrote: >>>>> >>>>> This was indeed done to help with that, but I think I like it >>>>> anyway. >>>>> The overall effect is that it distinguishes the IDs from other >>>>> sources, >>>>> etc. On the other hand... maybe it's a little ugly? >>>> >>>> It's actually quite nice when you deploy a website on a developer >>>> machine, a preview system, and a production machine. If the code is >>>> creating files that have to match up with an auto-generated id, and >>>> said files are *also* commited into revision control, having a >>>> per-machine prefix makes everything function a lot smoother. >>> That's a good point. With that you could also easily identify >>> staging data that accidently makes it into the production server >>> and fairly easily eliminate it too. >>> -David >>> >> > |
Free forum by Nabble | Edit this page |