Re: svn commit: r766520 - in /ofbiz/trunk/framework/common: config/CommonUiLabels.xml webcommon/includes/listVisualThemes.ftl

[Jacques Le Roux]

I think I remember a time when, when you changed the visual theme you were going directly back to the page you were on before. But
I'm maybe wrong.
Anyway, even if I'm wrong I think we should do that. This feature is used for changing language (locale actually) and is just great!

Jacques

From: <[hidden email]>

> Author: jonesde
> Date: Sun Apr 19 21:11:18 2009
> New Revision: 766520
>
> URL: http://svn.apache.org/viewvc?rev=766520&view=rev
> Log:
> Changed theme selection page label for link going back to main from Cancel to Done; as discussed a bit ago on the mailing list
> this is confusing
>
> Modified:
>    ofbiz/trunk/framework/common/config/CommonUiLabels.xml
>    ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
>
> Modified: ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?rev=766520&r1=766519&r2=766520&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/config/CommonUiLabels.xml (original)
> +++ ofbiz/trunk/framework/common/config/CommonUiLabels.xml Sun Apr 19 21:11:18 2009
> @@ -1854,6 +1854,18 @@
>         <value xml:lang="th">ระยะห่าง</value>
>         <value xml:lang="zh">距离</value>
>     </property>
> +    <property key="CommonDone">
> +        <value xml:lang="de">Erledigt</value>
> +        <value xml:lang="en">Done</value>
> +        <value xml:lang="es">Terminar</value>
> +        <value xml:lang="fr">Terminer</value>
> +        <value xml:lang="nl">Klaar</value>
> +        <value xml:lang="pt">Feito</value>
> +        <value xml:lang="ro">Executa</value>
> +        <value xml:lang="ru">Выполнить</value>
> +        <value xml:lang="zh">完成</value>
> +        <value xml:lang="zh_CN">完成</value>
> +    </property>
>     <property key="CommonDuplicate">
>         <value xml:lang="ar">مضاعفة</value>
>         <value xml:lang="de">Verdoppeln</value>
>
> Modified: ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl?rev=766520&r1=766519&r2=766520&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl (original)
> +++ ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl Sun Apr 19 21:11:18 2009
> @@ -27,7 +27,7 @@
>   <div class="screenlet-title-bar">
>     <ul>
>       <li class="h3">${uiLabelMap.CommonVisualThemes}</li>
> -      <li><a href="<@ofbizUrl>main</@ofbizUrl>">${uiLabelMap.CommonCancel}</a></li>
> +      <li><a href="<@ofbizUrl>main</@ofbizUrl>">${uiLabelMap.CommonDone}</a></li>
>     </ul>
>     <br class="clear"/>
>   </div>
>
>

[Tim Ruppert]

+1

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

----- "Jacques Le Roux" <[hidden email]> wrote:

> I think I remember a time when, when you changed the visual theme you
> were going directly back to the page you were on before. But
> I'm maybe wrong.
> Anyway, even if I'm wrong I think we should do that. This feature is
> used for changing language (locale actually) and is just great!
>
> Jacques
>
> From: <[hidden email]>
> > Author: jonesde
> > Date: Sun Apr 19 21:11:18 2009
> > New Revision: 766520
> >
> > URL: http://svn.apache.org/viewvc?rev=766520&view=rev
> > Log:
> > Changed theme selection page label for link going back to main from
> Cancel to Done; as discussed a bit ago on the mailing list
> > this is confusing
> >
> > Modified:
> >    ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> >  
> ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
> >
> > Modified: ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?rev=766520&r1=766519&r2=766520&view=diff
> >
> ==============================================================================
> > --- ofbiz/trunk/framework/common/config/CommonUiLabels.xml
> (original)
> > +++ ofbiz/trunk/framework/common/config/CommonUiLabels.xml Sun Apr
> 19 21:11:18 2009
> > @@ -1854,6 +1854,18 @@
> >         <value xml:lang="th">ระยะห่าง</value>
> >         <value xml:lang="zh">距离</value>
> >     </property>
> > +    <property key="CommonDone">
> > +        <value xml:lang="de">Erledigt</value>
> > +        <value xml:lang="en">Done</value>
> > +        <value xml:lang="es">Terminar</value>
> > +        <value xml:lang="fr">Terminer</value>
> > +        <value xml:lang="nl">Klaar</value>
> > +        <value xml:lang="pt">Feito</value>
> > +        <value xml:lang="ro">Executa</value>
> > +        <value xml:lang="ru">Выполнить</value>
> > +        <value xml:lang="zh">完成</value>
> > +        <value xml:lang="zh_CN">完成</value>
> > +    </property>
> >     <property key="CommonDuplicate">
> >         <value xml:lang="ar">مضاعفة</value>
> >         <value xml:lang="de">Verdoppeln</value>
> >
> > Modified:
> ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl?rev=766520&r1=766519&r2=766520&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
> (original)
> > +++
> ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl
> Sun Apr 19 21:11:18 2009
> > @@ -27,7 +27,7 @@
> >   <div class="screenlet-title-bar">
> >     <ul>
> >       <li class="h3">${uiLabelMap.CommonVisualThemes}</li>
> > -      <li><a
> href="<@ofbizUrl>main</@ofbizUrl>">${uiLabelMap.CommonCancel}</a></li>
> > +      <li><a
> href="<@ofbizUrl>main</@ofbizUrl>">${uiLabelMap.CommonDone}</a></li>
> >     </ul>
> >     <br class="clear"/>
> >   </div>
> >
> >

[Vikas Mayur-3]

+1.

See also this https://issues.apache.org/jira/browse/OFBIZ-2302

Vikas

On Apr 20, 2009, at 2:59 AM, Jacques Le Roux wrote:

> I think I remember a time when, when you changed the visual theme  
> you were going directly back to the page you were on before. But I'm  
> maybe wrong.
> Anyway, even if I'm wrong I think we should do that. This feature is  
> used for changing language (locale actually) and is just great!
>
> Jacques
>
> From: <[hidden email]>
>> Author: jonesde
>> Date: Sun Apr 19 21:11:18 2009
>> New Revision: 766520
>>
>> URL: http://svn.apache.org/viewvc?rev=766520&view=rev
>> Log:
>> Changed theme selection page label for link going back to main from  
>> Cancel to Done; as discussed a bit ago on the mailing list this is  
>> confusing
>>
>> Modified:
>>   ofbiz/trunk/framework/common/config/CommonUiLabels.xml
>>   ofbiz/trunk/framework/common/webcommon/includes/
>> listVisualThemes.ftl
>>
>> Modified: ofbiz/trunk/framework/common/config/CommonUiLabels.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/config/CommonUiLabels.xml?rev=766520&r1=766519&r2=766520&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/common/config/CommonUiLabels.xml (original)
>> +++ ofbiz/trunk/framework/common/config/CommonUiLabels.xml Sun Apr  
>> 19 21:11:18 2009
>> @@ -1854,6 +1854,18 @@
>>        <value xml:lang="th">ระยะห่าง</value>
>>        <value xml:lang="zh">距离</value>
>>    </property>
>> +    <property key="CommonDone">
>> +        <value xml:lang="de">Erledigt</value>
>> +        <value xml:lang="en">Done</value>
>> +        <value xml:lang="es">Terminar</value>
>> +        <value xml:lang="fr">Terminer</value>
>> +        <value xml:lang="nl">Klaar</value>
>> +        <value xml:lang="pt">Feito</value>
>> +        <value xml:lang="ro">Executa</value>
>> +        <value xml:lang="ru">Выполнить</value>
>> +        <value xml:lang="zh">完成</value>
>> +        <value xml:lang="zh_CN">完成</value>
>> +    </property>
>>    <property key="CommonDuplicate">
>>        <value xml:lang="ar">Ù
> ضاعفة</value>
>>        <value xml:lang="de">Verdoppeln</value>
>>
>> Modified: ofbiz/trunk/framework/common/webcommon/includes/
>> listVisualThemes.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/webcommon/includes/listVisualThemes.ftl?rev=766520&r1=766519&r2=766520&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/common/webcommon/includes/
>> listVisualThemes.ftl (original)
>> +++ ofbiz/trunk/framework/common/webcommon/includes/
>> listVisualThemes.ftl Sun Apr 19 21:11:18 2009
>> @@ -27,7 +27,7 @@
>>  <div class="screenlet-title-bar">
>>    <ul>
>>      <li class="h3">${uiLabelMap.CommonVisualThemes}</li>
>> -      <li><a href="<@ofbizUrl>main</@ofbizUrl>">$
>> {uiLabelMap.CommonCancel}</a></li>
>> +      <li><a href="<@ofbizUrl>main</@ofbizUrl>">$
>> {uiLabelMap.CommonDone}</a></li>
>>    </ul>
>>    <br class="clear"/>
>>  </div>
>>
>
>