Re: svn commit: r786450 - in /ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer: EditBillingAddress.groovy EditShippingAddress.groovy

[Adrian Crum]

Keep in mind that release commits should be bug fixes, not improvements.

-Adrian

[hidden email] wrote:

> Author: ashish
> Date: Fri Jun 19 10:56:57 2009
> New Revision: 786450
>
> URL: http://svn.apache.org/viewvc?rev=786450&view=rev
> Log:
> Applied fix from trunk revision: 786448.
> Applied patch from jira issue OFBIZ-2633 (Adding more attributes to context so that they can be used as well if required.)
> Thanks Rishi for the contribution.
>
> Modified:
>     ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>     ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>
> Modified: ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy (original)
> +++ ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy Fri Jun 19 10:56:57 2009
> @@ -28,6 +28,8 @@
>          postalAddress = contactMech.getRelatedOne("PostalAddress");
>          billToContactMechId = postalAddress.contactMechId;
>          context.billToContactMechId = billToContactMechId;
> +        context.billToName = postalAddress.toName;
> +        context.billToAttnName = postalAddress.attnName;
>          context.billToAddress1 = postalAddress.address1;
>          context.billToAddress2 = postalAddress.address2;
>          context.billToCity = postalAddress.city;
>
> Modified: ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
> ==============================================================================
> --- ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy (original)
> +++ ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy Fri Jun 19 10:56:57 2009
> @@ -31,6 +31,8 @@
>          postalAddress = contactMech.getRelatedOne("PostalAddress");
>          context.shipToContactMechId = postalAddress.contactMechId;
>  
> +        context.shipToName = postalAddress.toName;
> +        context.shipToAttnName = postalAddress.attnName;
>          context.shipToAddress1 = postalAddress.address1;
>          context.shipToAddress2 = postalAddress.address2;
>          context.shipToCity = postalAddress.city;
>
>
>

[Ashish Vijaywargiya]

Please take a look at my recent comment on OFBIZ-2633.
I am sure you will get your answer.

--
Ashish

On Fri, Jun 19, 2009 at 8:00 PM, Adrian Crum <[hidden email]> wrote:

> Keep in mind that release commits should be bug fixes, not improvements.
>
> -Adrian
>
>
> [hidden email] wrote:
>
>> Author: ashish
>> Date: Fri Jun 19 10:56:57 2009
>> New Revision: 786450
>>
>> URL: http://svn.apache.org/viewvc?rev=786450&view=rev
>> Log:
>> Applied fix from trunk revision: 786448.
>> Applied patch from jira issue OFBIZ-2633 (Adding more attributes to
>> context so that they can be used as well if required.)
>> Thanks Rishi for the contribution.
>>
>> Modified:
>>
>>  ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>>
>>  ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>>
>> Modified:
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>> (original)
>> +++
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>> Fri Jun 19 10:56:57 2009
>> @@ -28,6 +28,8 @@
>>         postalAddress = contactMech.getRelatedOne("PostalAddress");
>>         billToContactMechId = postalAddress.contactMechId;
>>         context.billToContactMechId = billToContactMechId;
>> +        context.billToName = postalAddress.toName;
>> +        context.billToAttnName = postalAddress.attnName;
>> context.billToAddress1 = postalAddress.address1;
>>         context.billToAddress2 = postalAddress.address2;
>>         context.billToCity = postalAddress.city;
>>
>> Modified:
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>> (original)
>> +++
>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>> Fri Jun 19 10:56:57 2009
>> @@ -31,6 +31,8 @@
>>         postalAddress = contactMech.getRelatedOne("PostalAddress");
>>         context.shipToContactMechId = postalAddress.contactMechId;
>>  +        context.shipToName = postalAddress.toName;
>> +        context.shipToAttnName = postalAddress.attnName;
>>         context.shipToAddress1 = postalAddress.address1;
>>         context.shipToAddress2 = postalAddress.address2;
>>         context.shipToCity = postalAddress.city;
>>
>>
>>
>>

[Adrian Crum]

Sorry, I replied too soon.

-Adrian

Ashish Vijaywargiya wrote:

> Please take a look at my recent comment on OFBIZ-2633.
> I am sure you will get your answer.
>
> --
> Ashish
>
> On Fri, Jun 19, 2009 at 8:00 PM, Adrian Crum <[hidden email]> wrote:
>
>> Keep in mind that release commits should be bug fixes, not improvements.
>>
>> -Adrian
>>
>>
>> [hidden email] wrote:
>>
>>> Author: ashish
>>> Date: Fri Jun 19 10:56:57 2009
>>> New Revision: 786450
>>>
>>> URL: http://svn.apache.org/viewvc?rev=786450&view=rev
>>> Log:
>>> Applied fix from trunk revision: 786448.
>>> Applied patch from jira issue OFBIZ-2633 (Adding more attributes to
>>> context so that they can be used as well if required.)
>>> Thanks Rishi for the contribution.
>>>
>>> Modified:
>>>
>>>  ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>>>
>>>  ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>>>
>>> Modified:
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>>> (original)
>>> +++
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditBillingAddress.groovy
>>> Fri Jun 19 10:56:57 2009
>>> @@ -28,6 +28,8 @@
>>>         postalAddress = contactMech.getRelatedOne("PostalAddress");
>>>         billToContactMechId = postalAddress.contactMechId;
>>>         context.billToContactMechId = billToContactMechId;
>>> +        context.billToName = postalAddress.toName;
>>> +        context.billToAttnName = postalAddress.attnName;
>>> context.billToAddress1 = postalAddress.address1;
>>>         context.billToAddress2 = postalAddress.address2;
>>>         context.billToCity = postalAddress.city;
>>>
>>> Modified:
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy?rev=786450&r1=786449&r2=786450&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>>> (original)
>>> +++
>>> ofbiz/branches/release09.04/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/customer/EditShippingAddress.groovy
>>> Fri Jun 19 10:56:57 2009
>>> @@ -31,6 +31,8 @@
>>>         postalAddress = contactMech.getRelatedOne("PostalAddress");
>>>         context.shipToContactMechId = postalAddress.contactMechId;
>>>  +        context.shipToName = postalAddress.toName;
>>> +        context.shipToAttnName = postalAddress.attnName;
>>>         context.shipToAddress1 = postalAddress.address1;
>>>         context.shipToAddress2 = postalAddress.address2;
>>>         context.shipToCity = postalAddress.city;
>>>
>>>
>>>
>>>
>