Re: svn commit: r815689 - in /ofbiz/branches/release09.04: ./ applications/content/webapp/content/survey/EditSurveyResponse.ftl

[Adam Heath-2]

[hidden email] wrote:

> Author: jleroux
> Date: Wed Sep 16 09:35:28 2009
> New Revision: 815689
>
> URL: http://svn.apache.org/viewvc?rev=815689&view=rev
> Log:
> "Applied fix from trunk for revision: 815687 "
> ------------------------------------------------------------------------
> r815687 | jleroux | 2009-09-16 11:28:30 +0200 (mer. 16 sept. 2009) | 1 ligne
>
> Fix a bug reported by James McGill on user ML
> ------------------------------------------------------------------------

And that bug was?

When writing changelogs, please include a description of the change.
Don't say "bug reported by so and so" or "bug reported in jira".
Actually describe the issue.

[Jacques Le Roux]

Right! I understand you don't have the time to follow each post on the user ML, there are more and more nowadays...

Here it is

content/control/EditSurveyResponse puts escaped HTML on the page instead of
the rendered survey.
applications/content/webapp/content/survey/EditSurveyResponse.ftl  has
${surveyString}    but
that apparently escapes the page.   ${surveyString?html} just adds another
level of escaping, and
I couldn't see how to "unescape" from here.
It looks to me like there really should be a call to surveyWrapper.render()
or something like that --
or is it the intended behavior to show the  HTML output instead of the
rendered survey?
--
James McGill
Able Engineering

Jacques

From: "Adam Heath" <[hidden email]>

> [hidden email] wrote:
>> Author: jleroux
>> Date: Wed Sep 16 09:35:28 2009
>> New Revision: 815689
>>
>> URL: http://svn.apache.org/viewvc?rev=815689&view=rev
>> Log:
>> "Applied fix from trunk for revision: 815687 "
>> ------------------------------------------------------------------------
>> r815687 | jleroux | 2009-09-16 11:28:30 +0200 (mer. 16 sept. 2009) | 1 ligne
>>
>> Fix a bug reported by James McGill on user ML
>> ------------------------------------------------------------------------
>
> And that bug was?
>
> When writing changelogs, please include a description of the change.
> Don't say "bug reported by so and so" or "bug reported in jira".
> Actually describe the issue.
>

[Adam Heath-2]

Jacques Le Roux wrote:
> Right! I understand you don't have the time to follow each post on the
> user ML, there are more and more nowadays...

It's not about following the mailling list, or following jira.

It's about having a deployment that contains an svn changelog, which
then contains references to other sources for changes, but you don't
have access to them.

[Jacques Le Roux]

I see! It's in there now

Jacques

From: "Adam Heath" <[hidden email]>

> Jacques Le Roux wrote:
>> Right! I understand you don't have the time to follow each post on the
>> user ML, there are more and more nowadays...
>
> It's not about following the mailling list, or following jira.
>
> It's about having a deployment that contains an svn changelog, which
> then contains references to other sources for changes, but you don't
> have access to them.
>