[jira] Created: (OFBIZ-2916) Add confirm action before do submit action
Locked
[jira] Created: (OFBIZ-2916) Add confirm action before do submit action
 
|
Add confirm action before do submit action
------------------------------------------ Key: OFBIZ-2916 URL: https://issues.apache.org/jira/browse/OFBIZ-2916 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: nicolas malin Fix For: SVN trunk In old thread on dev mailing I explain a process to confirm an action before submit for xml form. After a big latency, I create the patch. On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. I create two screenshot. Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-2916: --------------------------------- Attachment: delete-confirm.png add-confirm.png confirm.diff > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753001#action_12753001 ] Scott Gray commented on OFBIZ-2916: ----------------------------------- Hi Nicolas I haven't reviewed your patch but it sounds like a good idea, this feature already exists for the menu widget. If you have not done so yet please check the menu widget code and xsd to make sure you are following the same pattern, solely for sake of consistency. Thanks Scott > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-2916: --------------------------------- Attachment: confirm.diff forget CommonUiLabel in previous patch > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-2916: --------------------------------- Attachment: (was: confirm.diff) > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753007#action_12753007 ] nicolas malin commented on OFBIZ-2916: -------------------------------------- Hi scott, when I finalize my patch and add information on form widget xsd I show the recently code in menu widget xsd. After look in menu we need to up request-confirmation="yes" and confirmation-message="text" When I create this addon juste add confirm="text" and test if text is not empty to enable confirmation. What you prefer ? - I change confirm by confirmation-message and test just if empty to enable this action or - apply also request-confirmation on form and confirmation-message as menu I forget, Thanks Scott for your review :) Nicolas > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2916: ----------------------------------- Attachment: OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch BTW, here is a small patch for some labels changes > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753016#action_12753016 ] Jacques Le Roux commented on OFBIZ-2916: ---------------------------------------- Nicolas, I think it's a good way of doing it. But the problem here is inconsistency. So I would say, from a core commiter POV, else change menu to conform your way or vice-versa... My 2 cts > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753020#action_12753020 ] Scott Gray commented on OFBIZ-2916: ----------------------------------- I think the reasoning for the extra attribute was so that a default message could display if you chose not to specify one but I'm not 100% sure (even though I implemented it :-) ) > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753047#action_12753047 ] nicolas malin commented on OFBIZ-2916: -------------------------------------- Scott, Jacques, I propose to adapt the patch to follow this : 1. I change confirm by confirmation-message 2. I add request-confirmation 3. When test, if request-confirmation is true if confirmation-message not empty -> use it else use CommonConfirm if confirmation-message not empty -> use it With this system, If we want just confirmation we put request-confirmation="yes" and if we have specific message we use confirmation-message, with the goal to minimize writing attribute. If you are ok, I operate modification in few days. Nicolas > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753067#action_12753067 ] Jacques Le Roux commented on OFBIZ-2916: ---------------------------------------- Nicolas, It's ok for me as long as both work the same way (and yes having an optionnal message is obviously a +) > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-2916: --------------------------------- Attachment: NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch Scott, Jacques, I finalized my patch. I apply the same process with request-confirmation and confirmation-message to form and menu. I hope no forgot element but my tests are OK. Nicolas > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Closed: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2916. ---------------------------------- Resolution: Fixed Assignee: Scott Gray Thanks Nicolas, Your patch is in trunk at r815734. Works well on forms and menus > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Scott Gray > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Closed: (OFBIZ-2916) Add confirm action before do submit action
|
Thanks a lot Jacques for your review :)
Nicolas Jacques Le Roux (JIRA) a écrit : > [ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Jacques Le Roux closed OFBIZ-2916. > ---------------------------------- > > Resolution: Fixed > Assignee: Scott Gray > > Thanks Nicolas, > > Your patch is in trunk at r815734. > > Works well on forms and menus > > > >> Add confirm action before do submit action >> ------------------------------------------ >> >> Key: OFBIZ-2916 >> URL: https://issues.apache.org/jira/browse/OFBIZ-2916 >> Project: OFBiz >> Issue Type: Improvement >> Components: framework >> Affects Versions: SVN trunk >> Reporter: nicolas malin >> Assignee: Scott Gray >> Fix For: SVN trunk >> >> Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch >> >> >> In old thread on dev mailing I explain a process to confirm an action before submit for xml form. >> After a big latency, I create the patch. >> On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : >> <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> >> I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. >> I create two screenshot. >> Nicolas >> > > -- Nicolas MALIN Consultant Tél : 06.17.66.40.06 Site projet : http://www.neogia.org/ ------- Société LibrenBerry Tél : 02.48.02.56.12 Site : http://www.librenberry.net/ |
[jira] Assigned: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-2916: --------------------------------- Assignee: Jacques Le Roux (was: Scott Gray) No reason for this to be assigned to me > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756017#action_12756017 ] Jacques Le Roux commented on OFBIZ-2916: ---------------------------------------- Hi Scott, I tried :D You did most of the review > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756022#action_12756022 ] Scott Gray commented on OFBIZ-2916: ----------------------------------- That's a bit worrying considering the only review I performed was a real quick look at the commit notification. > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-2916) Add confirm action before do submit action
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756055#action_12756055 ] Jacques Le Roux commented on OFBIZ-2916: ---------------------------------------- Don't worry, It was just because you adviced about consistency with menu. I'd not have done it, since I did not know it existed... The remaining (reading and testing) was easy stuff : Nicolas did it right. I tested both (form + menu) without any issues. > Add confirm action before do submit action > ------------------------------------------ > > Key: OFBIZ-2916 > URL: https://issues.apache.org/jira/browse/OFBIZ-2916 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: nicolas malin > Assignee: Jacques Le Roux > Fix For: SVN trunk > > Attachments: add-confirm.png, confirm.diff, delete-confirm.png, NMA-OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch, OFBIZ-2916_Add_confirm_action_before_do_submit_action.patch > > > In old thread on dev mailing I explain a process to confirm an action before submit for xml form. > After a big latency, I create the patch. > On type submit and hyperlink, I added an attribute confirm that take a take to display in the confirm box. Exemple : > <field name="submitButton" title="${uiLabelMap.CommonAdd}"><submit button-type="button" confirm="${uiLabelMap.CommonConfirm}"/></field> > I added on example on example component : to test, after apply patch on rebuild, go to example component, add example and add example item. When you add a new exampleItem OFBiz ask to confirm and when you want delete it, he ask also confirmation before delete this element. > I create two screenshot. > Nicolas -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |