Re: svn commit: r827935 - in /ofbiz/trunk/specialpurpose/projectmgr: webapp/projectmgr/request/overViewRequestItems.ftl widget/CustRequestScreens.xml

[Scott Gray-2]

On 21/10/2009, at 10:22 PM, [hidden email] wrote:

> Author: hansbak
> Date: Wed Oct 21 09:22:16 2009
> New Revision: 827935
>
> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
> Log:
> add username to customeritem note list
>
> Modified:
>    ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl
>    ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>
> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
> request/overViewRequestItems.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl (original)
> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
> @@ -68,6 +68,9 @@
>                                 ${uiLabelMap.CommonNote}
>                             </td>
>                             <td>
> +                                ${uiLabelMap.PartyParty} $
> {uiLabelMap.PartyName}
> +                            </td>
> +                            <td>

This is bad for internationalization, you should make a new label  
instead of trying to combine existing labels.

Regards
Scott

[Tim Ruppert]

Hans - as I've said many times - thanks so much for continuing to add  
new functionality to the project and help to push things forward.  The  
remaining question I have is, why does everyone have to watch your  
commits so closely to ensure that crap does not continue to go back  
into the project?  I imagine that you must be just as tired as we are  
of hearing it - doesn't that make you want to change the tact?  I'm  
not trying to be an ass, it's just got to be frustrating for everyone  
involved and continues to make more work.

Cheers,
Ruppert

On Oct 21, 2009, at 3:59 AM, Scott Gray wrote:

> On 21/10/2009, at 10:22 PM, [hidden email] wrote:
>> Author: hansbak
>> Date: Wed Oct 21 09:22:16 2009
>> New Revision: 827935
>>
>> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
>> Log:
>> add username to customeritem note list
>>
>> Modified:
>>   ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl
>>   ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>>
>> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
>> request/overViewRequestItems.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl (original)
>> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
>> @@ -68,6 +68,9 @@
>>                                ${uiLabelMap.CommonNote}
>>                            </td>
>>                            <td>
>> +                                ${uiLabelMap.PartyParty} $
>> {uiLabelMap.PartyName}
>> +                            </td>
>> +                            <td>
>
>
> This is bad for internationalization, you should make a new label  
> instead of trying to combine existing labels.
>
> Regards
> Scott

[Anil Patel-3]

Some more mess carelessly stuffed into Ofbiz. Lets hope cheap  
providers would get careful so we can focus on enhancements.

Thanks and Regards
Anil Patel
HotWax Media Inc
http://www.hotwaxmedia.com
http://us.apachecon.com/c/acus2009/sponsors/sponsors

On Oct 21, 2009, at 5:59 AM, Scott Gray wrote:

> On 21/10/2009, at 10:22 PM, [hidden email] wrote:
>> Author: hansbak
>> Date: Wed Oct 21 09:22:16 2009
>> New Revision: 827935
>>
>> URL: http://svn.apache.org/viewvc?rev=827935&view=rev
>> Log:
>> add username to customeritem note list
>>
>> Modified:
>>   ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl
>>   ofbiz/trunk/specialpurpose/projectmgr/widget/CustRequestScreens.xml
>>
>> Modified: ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/
>> request/overViewRequestItems.ftl
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/overViewRequestItems.ftl?rev=827935&r1=827934&r2=827935&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl (original)
>> +++ ofbiz/trunk/specialpurpose/projectmgr/webapp/projectmgr/request/
>> overViewRequestItems.ftl Wed Oct 21 09:22:16 2009
>> @@ -68,6 +68,9 @@
>>                                ${uiLabelMap.CommonNote}
>>                            </td>
>>                            <td>
>> +                                ${uiLabelMap.PartyParty} $
>> {uiLabelMap.PartyName}
>> +                            </td>
>> +                            <td>
>
>
> This is bad for internationalization, you should make a new label  
> instead of trying to combine existing labels.
>
> Regards
> Scott