Re: svn commit: r884292 - /ofbiz/trunk/specialpurpose/shark/src/org/ofbiz/shark/repository/EntityRepositoryMgr.java

[Adam Heath-2]

[hidden email] wrote:
> Author: lektran
> Date: Wed Nov 25 22:03:53 2009
> New Revision: 884292
>
> URL: http://svn.apache.org/viewvc?rev=884292&view=rev
> Log:
> Fix invalid code that causing the docs-all target to fail

If this code isn't built during a normal ant compile run, then the
docs should also skip it.

[Scott Gray-2]

On 26/11/2009, at 11:22 AM, Adam Heath wrote:

> [hidden email] wrote:
>> Author: lektran
>> Date: Wed Nov 25 22:03:53 2009
>> New Revision: 884292
>>
>> URL: http://svn.apache.org/viewvc?rev=884292&view=rev
>> Log:
>> Fix invalid code that causing the docs-all target to fail
>
> If this code isn't built during a normal ant compile run, then the
> docs should also skip it.
>

Yeah I know, it was just a quick fix to get things running again.  
I'll take a look at it when I have time unless someone gets there first.

Regards
Scott

[Jacques Le Roux]

This came from my commit at r886549 <<Use UtilValidate.isNotEmpty methods instead of (obj != null) || (obj.length > 0) and (obj !=
null) || (obj.size > 0)>>
I have fixed it the right way.

Yes, it's surprising it passes ant run but not ant docs-all

So build-website and copy-apis targets are also used by scripts ? I thought only docs-all was needed ?

Jacques

From: "Scott Gray" <[hidden email]>

> On 26/11/2009, at 11:22 AM, Adam Heath wrote:
>
>> [hidden email] wrote:
>>> Author: lektran
>>> Date: Wed Nov 25 22:03:53 2009
>>> New Revision: 884292
>>>
>>> URL: http://svn.apache.org/viewvc?rev=884292&view=rev
>>> Log:
>>> Fix invalid code that causing the docs-all target to fail
>>
>> If this code isn't built during a normal ant compile run, then the
>> docs should also skip it.
>>
>
> Yeah I know, it was just a quick fix to get things running again.   I'll take a look at it when I have time unless someone gets
> there first.
>
> Regards
> Scott

[Adrian Crum]

Jacques Le Roux wrote:
> So build-website and copy-apis targets are also used by scripts ? I
> thought only docs-all was needed ?

I was just guessing, since the folders that weren't found by Contegix
are the same ones you commented out.

-Adrian

[Scott Gray-2]

On 26/11/2009, at 11:36 AM, Jacques Le Roux wrote:

> This came from my commit at r886549 <<Use UtilValidate.isNotEmpty  
> methods instead of (obj != null) || (obj.length > 0) and (obj !=  
> null) || (obj.size > 0)>>
> I have fixed it the right way.

I'm guessing this occurred because you were using a regex search and  
replace, they are useful but you have to be extremely careful if you  
want to avoid unintended changes.

>
> Yes, it's surprising it passes ant run but not ant docs-all

When I get time I'll see if we can get the docs-all target to actually  
fail the build if it runs into problems so that we get notified via  
buildbot

> So build-website and copy-apis targets are also used by scripts ? I  
> thought only docs-all was needed ?

Once again when I get time I'll look through the scripts at Contegix  
and see what targets are being used, let's leave everything as is for  
now.

>
> Jacques
>
> From: "Scott Gray" <[hidden email]>
>> On 26/11/2009, at 11:22 AM, Adam Heath wrote:
>>
>>> [hidden email] wrote:
>>>> Author: lektran
>>>> Date: Wed Nov 25 22:03:53 2009
>>>> New Revision: 884292
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=884292&view=rev
>>>> Log:
>>>> Fix invalid code that causing the docs-all target to fail
>>>
>>> If this code isn't built during a normal ant compile run, then the
>>> docs should also skip it.
>>>
>>
>> Yeah I know, it was just a quick fix to get things running again.    
>> I'll take a look at it when I have time unless someone gets there  
>> first.
>>
>> Regards
>> Scott
>
>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>
> On 26/11/2009, at 11:36 AM, Jacques Le Roux wrote:
>
>> This came from my commit at r886549 <<Use UtilValidate.isNotEmpty  methods instead of (obj != null) || (obj.length > 0) and (obj
>> !=  null) || (obj.size > 0)>>
>> I have fixed it the right way.
>
> I'm guessing this occurred because you were using a regex search and  replace, they are useful but you have to be extremely
> careful if you  want to avoid unintended changes.

I have been careful, but it's very powefull and I forgot shark+workflow could not be detected :/

>>
>> Yes, it's surprising it passes ant run but not ant docs-all

shark+workflow reason, lesson learned: when doing global search/replace changes beware of them, and even uncomment them in build.xml
to be sure. Even better IMO put them aside to avoid these kind of issues...

> When I get time I'll see if we can get the docs-all target to actually  fail the build if it runs into problems so that we get
> notified via  buildbot

Without shark+workflow there are any other reason I'm aware of. Finally should we not simply remove them from the docs-all target
(than putting them aside)

>> So build-website and copy-apis targets are also used by scripts ? I  thought only docs-all was needed ?
>
> Once again when I get time I'll look through the scripts at Contegix  and see what targets are being used, let's leave everything
> as is for  now.

Sure! Enough troubles for the week

Jacques

>>
>> Jacques
>>
>> From: "Scott Gray" <[hidden email]>
>>> On 26/11/2009, at 11:22 AM, Adam Heath wrote:
>>>
>>>> [hidden email] wrote:
>>>>> Author: lektran
>>>>> Date: Wed Nov 25 22:03:53 2009
>>>>> New Revision: 884292
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=884292&view=rev
>>>>> Log:
>>>>> Fix invalid code that causing the docs-all target to fail
>>>>
>>>> If this code isn't built during a normal ant compile run, then the
>>>> docs should also skip it.
>>>>
>>>
>>> Yeah I know, it was just a quick fix to get things running again.    I'll take a look at it when I have time unless someone gets
>>> there  first.
>>>
>>> Regards
>>> Scott
>>
>>
>
>