Re: svn commit: r893935 - /ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl

[Scott Gray-2]

On 26/12/2009, at 4:10 PM, [hidden email] wrote:

> Author: ashish
> Date: Sat Dec 26 03:10:26 2009
> New Revision: 893935
>
> URL: http://svn.apache.org/viewvc?rev=893935&view=rev
> Log:
> Conditional check. If "Internal Name" not found then check for  
> "Product Name" and if both the values are missing then show the  
> default message.
>
> Modified:
>    ofbiz/trunk/applications/product/webapp/catalog/find/
> miniproductlist.ftl
>
> Modified: ofbiz/trunk/applications/product/webapp/catalog/find/
> miniproductlist.ftl
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl?rev=893935&r1=893934&r2=893935&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/product/webapp/catalog/find/
> miniproductlist.ftl (original)
> +++ ofbiz/trunk/applications/product/webapp/catalog/find/
> miniproductlist.ftl Sat Dec 26 03:10:26 2009
> @@ -23,7 +23,11 @@
>         <#assign product =  
> productCategoryMember.getRelatedOneCache("Product")>
>           <div>
>             <a href='<@ofbizUrl>EditProduct?productId=$
> {product.productId}</@ofbizUrl>' class='buttontext'>
> -              ${product.internalName?default("$
> {uiLabelMap.CommonNo} ${uiLabelMap.ProductInternalName}")}
> +              <#if product.internalName?has_content>
> +                ${product.internalName}
> +              <#else>
> +                ${product.productName?default("$
> {uiLabelMap.CommonNo} ${uiLabelMap.ProductInternalName} / $
> {uiLabelMap.ProductProductName}")}

Hi Ashish

Please remember that you shouldn't join labels together but instead  
make a new label.

Thanks
Scott

> +              </#if>
>             </a>
>             <div>
>               <b>${product.productId}</b>
>
>

[Jacques Le Roux]

From: "Scott Gray" <[hidden email]>

> On 26/12/2009, at 4:10 PM, [hidden email] wrote:
>
>> Author: ashish
>> Date: Sat Dec 26 03:10:26 2009
>> New Revision: 893935
>>
>> URL: http://svn.apache.org/viewvc?rev=893935&view=rev
>> Log:
>> Conditional check. If "Internal Name" not found then check for  "Product Name" and if both the values are missing then show the
>> default message.
>>
>> Modified:
>>    ofbiz/trunk/applications/product/webapp/catalog/find/ miniproductlist.ftl
>>
>> Modified: ofbiz/trunk/applications/product/webapp/catalog/find/ miniproductlist.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl?rev=893935&r1=893934&r2=893935&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/applications/product/webapp/catalog/find/ miniproductlist.ftl (original)
>> +++ ofbiz/trunk/applications/product/webapp/catalog/find/ miniproductlist.ftl Sat Dec 26 03:10:26 2009
>> @@ -23,7 +23,11 @@
>>         <#assign product =  productCategoryMember.getRelatedOneCache("Product")>
>>           <div>
>>             <a href='<@ofbizUrl>EditProduct?productId=$ {product.productId}</@ofbizUrl>' class='buttontext'>
>> -              ${product.internalName?default("$ {uiLabelMap.CommonNo} ${uiLabelMap.ProductInternalName}")}
>> +              <#if product.internalName?has_content>
>> +                ${product.internalName}
>> +              <#else>
>> +                ${product.productName?default("$ {uiLabelMap.CommonNo} ${uiLabelMap.ProductInternalName} / $
>> {uiLabelMap.ProductProductName}")}
>
> Hi Ashish
>
> Please remember that you shouldn't join labels together but instead  make a new label.
> Thanks
> Scott

Thanks for the reminder Scott
Jacques

>
>> +              </#if>
>>             </a>
>>             <div>
>>               <b>${product.productId}</b>
>>
>>
>
>

[Ashish Vijaywargiya]

I will create the new label soon.
Thanks for your comment.

--
Ashish

On Mon, Dec 28, 2009 at 2:09 AM, Scott Gray <[hidden email]> wrote:

> On 26/12/2009, at 4:10 PM, [hidden email] wrote:
>
>> Author: ashish
>> Date: Sat Dec 26 03:10:26 2009
>> New Revision: 893935
>>
>> URL: http://svn.apache.org/viewvc?rev=893935&view=rev
>> Log:
>> Conditional check. If "Internal Name" not found then check for "Product
>> Name" and if both the values are missing then show the default message.
>>
>> Modified:
>>   ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl
>>
>> Modified:
>> ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl?rev=893935&r1=893934&r2=893935&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl
>> (original)
>> +++
>> ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl Sat
>> Dec 26 03:10:26 2009
>> @@ -23,7 +23,11 @@
>>        <#assign product =
>> productCategoryMember.getRelatedOneCache("Product")>
>>          <div>
>>            <a
>> href='<@ofbizUrl>EditProduct?productId=${product.productId}</@ofbizUrl>'
>> class='buttontext'>
>> -              ${product.internalName?default("${uiLabelMap.CommonNo}
>> ${uiLabelMap.ProductInternalName}")}
>> +              <#if product.internalName?has_content>
>> +                ${product.internalName}
>> +              <#else>
>> +                ${product.productName?default("${uiLabelMap.CommonNo}
>> ${uiLabelMap.ProductInternalName} / ${uiLabelMap.ProductProductName}")}
>
> Hi Ashish
>
> Please remember that you shouldn't join labels together but instead make a
> new label.
>
> Thanks
> Scott
>
>> +              </#if>
>>            </a>
>>            <div>
>>              <b>${product.productId}</b>
>>
>>
>
>

[Jacques Le Roux]

From: "Jacques Le Roux" <[hidden email]>
> From: "Scott Gray" <[hidden email]>
[Snip]>>
>> Please remember that you shouldn't join labels together but instead  make a new label.
>> Thanks
>> Scott
>
> Thanks for the reminder Scott
> Jacques

Not exactly related but I just replaced a bunch of hardcoded error messages by PartyUserNameInUse at r894318
We still have about 600 <fail-message in OFBiz. At least guys please don't add new ones but use <fail-property

Thanks

Jacques