Releasing Apache OFBiz 11.04.01

[Jacopo Cappellato-4]

Hi all,

according to our tentative release schedule:

http://ofbiz.apache.org/download.html

in May we should release Apache OFBiz 11.04.01.

Here are the tasks currently associated to this release:

https://issues.apache.org/jira/browse/OFBIZ/fixforversion/12320772

and specifically:

1) https://issues.apache.org/jira/browse/OFBIZ-4816

this is a reminder for me and I will take care of it

2) https://issues.apache.org/jira/browse/OFBIZ-4817

are there volunteers for this? The idea is to make sure that all files (source files and jars) adhere to the license requirements; and also make sure that the LICENSE And NOTICE files are up to date. The best way to start is to run Apache Rat and then work from there.

3) https://issues.apache.org/jira/browse/OFBIZ-4130

according to Hans' comments this can be probably addressed temporarily adding proper information to the documentation for tenant setup mentioning that Webtools application is not safe to be used in a multi tenant setup and that the SECURITYADMIN  permission should never be associated to a tenant user.

Apart from the above details: do we see any blockers or good reasons for postponing the release? I don't see any of them and if we complete #2 I will be ready to start wrapping a release package and starting the release vote.

Kind regards,

Jacopo

[Venkat Mangudi]

On Fri, May 18, 2012 at 6:15 PM, Jacopo Cappellato <
[hidden email]> wrote:

> 2) https://issues.apache.org/jira/browse/OFBIZ-4817
>
> are there volunteers for this? The idea is to make sure that all files
> (source files and jars) adhere to the license requirements; and also make
> sure that the LICENSE And NOTICE files are up to date. The best way to
> start is to run Apache Rat and then work from there.
>
>
Have not done this before, can try to do it.


--
Regards,
Venkat

[Jacques Le Roux]

You have a dynamic (updated at each builbot - our CI - build) RAT report at http://ci.apache.org/projects/ofbiz/rat-output.html

Be careful, this must be interpreted with a grain of salt...

Jacques

From: "Venkat Mangudi" <[hidden email]>

> On Fri, May 18, 2012 at 6:15 PM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> 2) https://issues.apache.org/jira/browse/OFBIZ-4817
>>
>> are there volunteers for this? The idea is to make sure that all files
>> (source files and jars) adhere to the license requirements; and also make
>> sure that the LICENSE And NOTICE files are up to date. The best way to
>> start is to run Apache Rat and then work from there.
>>
>>
> Have not done this before, can try to do it.
>
>
> --
> Regards,
> Venkat
>

[Jacopo Cappellato-4]

On May 18, 2012, at 5:23 PM, Jacques Le Roux wrote:

> You have a dynamic (updated at each builbot - our CI - build) RAT report at http://ci.apache.org/projects/ofbiz/rat-output.html

Cool, I didn't know about it

Jacopo

[Venkat Mangudi]

On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
[hidden email]> wrote:

> You have a dynamic (updated at each builbot - our CI - build) RAT report
> at http://ci.apache.org/projects/**ofbiz/rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>
> Be careful, this must be interpreted with a grain of salt...
>
>
Will get on it right away. Thank you...

--
Regards,
Venkat

[Jacques Le Roux]

BTW you don't have to worry about docbook. We already treated it seriously. A worry less...
On the other hand we need to put an ASL2 license in all Help_*.xml files where it's missing (my fault when committing Pierre's work)
All jQuery is of course also OK, etc.

Jacques

From: "Venkat Mangudi" <[hidden email]>

> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> You have a dynamic (updated at each builbot - our CI - build) RAT report
>> at http://ci.apache.org/projects/**ofbiz/rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>>
>> Be careful, this must be interpreted with a grain of salt...
>>
>>
> Will get on it right away. Thank you...
>
> --
> Regards,
> Venkat
>

[Pierre Smits]

Jacques,

I will amend immediately the help files for both EN and NL locales.

Regards,

Pierre

2012/5/18 Jacques Le Roux <[hidden email]>

> BTW you don't have to worry about docbook. We already treated it
> seriously. A worry less...
> On the other hand we need to put an ASL2 license in all Help_*.xml files
> where it's missing (my fault when committing Pierre's work)
> All jQuery is of course also OK, etc.
>
>
> Jacques
>
> From: "Venkat Mangudi" <[hidden email]>
>
>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>
>> [hidden email]> wrote:
>>
>>  You have a dynamic (updated at each builbot - our CI - build) RAT report
>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>>> >
>>>
>>> Be careful, this must be interpreted with a grain of salt...
>>>
>>>
>>>  Will get on it right away. Thank you...
>>
>> --
>> Regards,
>> Venkat
>>
>>

[Pierre Smits]

Jacques,

The amended help files (regarding licence statement in both locale EN and
NL, and improvements to content of locale in EN) including  the associcated
structure files are uploaded as a patch in
https://issues.apache.org/jira/browse/OFBIZ-4802.

Regards,

Pierre

2012/5/18 Pierre Smits <[hidden email]>

> Jacques,
>
> I will amend immediately the help files for both EN and NL locales.
>
> Regards,
>
> Pierre
>
>
> 2012/5/18 Jacques Le Roux <[hidden email]>
>
>> BTW you don't have to worry about docbook. We already treated it
>> seriously. A worry less...
>> On the other hand we need to put an ASL2 license in all Help_*.xml files
>> where it's missing (my fault when committing Pierre's work)
>> All jQuery is of course also OK, etc.
>>
>>
>> Jacques
>>
>> From: "Venkat Mangudi" <[hidden email]>
>>
>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>>
>>> [hidden email]> wrote:
>>>
>>>  You have a dynamic (updated at each builbot - our CI - build) RAT report
>>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>>>> >
>>>>
>>>> Be careful, this must be interpreted with a grain of salt...
>>>>
>>>>
>>>>  Will get on it right away. Thank you...
>>>
>>> --
>>> Regards,
>>> Venkat
>>>
>>>
>

[Venkat Mangudi]

There are about 1985 files without Apache License as per the RAT report.
Different types of file dtd, xsl, xml, groovy, java, js and some more.

I should check each file and verify/add Apache License to it, right? Who
did this last time? Maybe I can get a few pointers.

--Venkat

On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]>wrote:

> Jacques,
>
> The amended help files (regarding licence statement in both locale EN and
> NL, and improvements to content of locale in EN) including  the associcated
> structure files are uploaded as a patch in
> https://issues.apache.org/jira/browse/OFBIZ-4802.
>
> Regards,
>
> Pierre
>
> 2012/5/18 Pierre Smits <[hidden email]>
>
> > Jacques,
> >
> > I will amend immediately the help files for both EN and NL locales.
> >
> > Regards,
> >
> > Pierre
> >
> >
> > 2012/5/18 Jacques Le Roux <[hidden email]>
> >
> >> BTW you don't have to worry about docbook. We already treated it
> >> seriously. A worry less...
> >> On the other hand we need to put an ASL2 license in all Help_*.xml files
> >> where it's missing (my fault when committing Pierre's work)
> >> All jQuery is of course also OK, etc.
> >>
> >>
> >> Jacques
> >>
> >> From: "Venkat Mangudi" <[hidden email]>
> >>
> >>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
> >>>
> >>> [hidden email]> wrote:
> >>>
> >>>  You have a dynamic (updated at each builbot - our CI - build) RAT
> report
> >>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
> http://ci.apache.org/projects/**ofbiz/rat-output.html>
> >>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
> http://ci.apache.org/projects/ofbiz/rat-output.html>
> >>>> >
> >>>>
> >>>> Be careful, this must be interpreted with a grain of salt...
> >>>>
> >>>>
> >>>>  Will get on it right away. Thank you...
> >>>
> >>> --
> >>> Regards,
> >>> Venkat
> >>>
> >>>
> >
>

--
Regards,
Venkat

[Jacopo Cappellato-4]

For now please ignore the ones under docbook and jquery folders; I hope that the committer of jcr related code will fix the ones under jcr (veifying if it is ok to add the ASL license to them); you can ignore all the files under runtime; license headers needs to be added to the files of the webpos component.
These changes should be committed to trunk, 12.04 and 11.04

Jacopo


On May 22, 2012, at 12:16 PM, Venkat Mangudi wrote:

> There are about 1985 files without Apache License as per the RAT report.
> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>
> I should check each file and verify/add Apache License to it, right? Who
> did this last time? Maybe I can get a few pointers.
>
> --Venkat
>
> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]>wrote:
>
>> Jacques,
>>
>> The amended help files (regarding licence statement in both locale EN and
>> NL, and improvements to content of locale in EN) including  the associcated
>> structure files are uploaded as a patch in
>> https://issues.apache.org/jira/browse/OFBIZ-4802.
>>
>> Regards,
>>
>> Pierre
>>
>> 2012/5/18 Pierre Smits <[hidden email]>
>>
>>> Jacques,
>>>
>>> I will amend immediately the help files for both EN and NL locales.
>>>
>>> Regards,
>>>
>>> Pierre
>>>
>>>
>>> 2012/5/18 Jacques Le Roux <[hidden email]>
>>>
>>>> BTW you don't have to worry about docbook. We already treated it
>>>> seriously. A worry less...
>>>> On the other hand we need to put an ASL2 license in all Help_*.xml files
>>>> where it's missing (my fault when committing Pierre's work)
>>>> All jQuery is of course also OK, etc.
>>>>
>>>>
>>>> Jacques
>>>>
>>>> From: "Venkat Mangudi" <[hidden email]>
>>>>
>>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>>>>
>>>>> [hidden email]> wrote:
>>>>>
>>>>> You have a dynamic (updated at each builbot - our CI - build) RAT
>> report
>>>>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
>> http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>>>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
>> http://ci.apache.org/projects/ofbiz/rat-output.html>
>>>>>>>
>>>>>>
>>>>>> Be careful, this must be interpreted with a grain of salt...
>>>>>>
>>>>>>
>>>>>> Will get on it right away. Thank you...
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Venkat
>>>>>
>>>>>
>>>
>>
>
>
>
> --
> Regards,
> Venkat

[Jacopo Cappellato-4]

Oops, sorry of course my commentswere based on my review to the output of RAT based on trunk.

Jacopo

On May 22, 2012, at 12:27 PM, Jacopo Cappellato wrote:

> For now please ignore the ones under docbook and jquery folders; I hope that the committer of jcr related code will fix the ones under jcr (veifying if it is ok to add the ASL license to them); you can ignore all the files under runtime; license headers needs to be added to the files of the webpos component.
> These changes should be committed to trunk, 12.04 and 11.04
>
> Jacopo
>
>
> On May 22, 2012, at 12:16 PM, Venkat Mangudi wrote:
>
>> There are about 1985 files without Apache License as per the RAT report.
>> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>>
>> I should check each file and verify/add Apache License to it, right? Who
>> did this last time? Maybe I can get a few pointers.
>>
>> --Venkat
>>
>> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]>wrote:
>>
>>> Jacques,
>>>
>>> The amended help files (regarding licence statement in both locale EN and
>>> NL, and improvements to content of locale in EN) including  the associcated
>>> structure files are uploaded as a patch in
>>> https://issues.apache.org/jira/browse/OFBIZ-4802.
>>>
>>> Regards,
>>>
>>> Pierre
>>>
>>> 2012/5/18 Pierre Smits <[hidden email]>
>>>
>>>> Jacques,
>>>>
>>>> I will amend immediately the help files for both EN and NL locales.
>>>>
>>>> Regards,
>>>>
>>>> Pierre
>>>>
>>>>
>>>> 2012/5/18 Jacques Le Roux <[hidden email]>
>>>>
>>>>> BTW you don't have to worry about docbook. We already treated it
>>>>> seriously. A worry less...
>>>>> On the other hand we need to put an ASL2 license in all Help_*.xml files
>>>>> where it's missing (my fault when committing Pierre's work)
>>>>> All jQuery is of course also OK, etc.
>>>>>
>>>>>
>>>>> Jacques
>>>>>
>>>>> From: "Venkat Mangudi" <[hidden email]>
>>>>>
>>>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>>>>>
>>>>>> [hidden email]> wrote:
>>>>>>
>>>>>> You have a dynamic (updated at each builbot - our CI - build) RAT
>>> report
>>>>>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
>>> http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>>>>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
>>> http://ci.apache.org/projects/ofbiz/rat-output.html>
>>>>>>>>
>>>>>>>
>>>>>>> Be careful, this must be interpreted with a grain of salt...
>>>>>>>
>>>>>>>
>>>>>>> Will get on it right away. Thank you...
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Venkat
>>>>>>
>>>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Regards,
>> Venkat
>

[Venkat Mangudi]

I need a committer login to commit, right?

--Venkat

On Tue, May 22, 2012 at 3:57 PM, Jacopo Cappellato <
[hidden email]> wrote:

> For now please ignore the ones under docbook and jquery folders; I hope
> that the committer of jcr related code will fix the ones under jcr
> (veifying if it is ok to add the ASL license to them); you can ignore all
> the files under runtime; license headers needs to be added to the files of
> the webpos component.
> These changes should be committed to trunk, 12.04 and 11.04
>
> Jacopo
>
>
> On May 22, 2012, at 12:16 PM, Venkat Mangudi wrote:
>
> > There are about 1985 files without Apache License as per the RAT report.
> > Different types of file dtd, xsl, xml, groovy, java, js and some more.
> >
> > I should check each file and verify/add Apache License to it, right? Who
> > did this last time? Maybe I can get a few pointers.
> >
> > --Venkat
> >
> > On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]
> >wrote:
> >
> >> Jacques,
> >>
> >> The amended help files (regarding licence statement in both locale EN
> and
> >> NL, and improvements to content of locale in EN) including  the
> associcated
> >> structure files are uploaded as a patch in
> >> https://issues.apache.org/jira/browse/OFBIZ-4802.
> >>
> >> Regards,
> >>
> >> Pierre
> >>
> >> 2012/5/18 Pierre Smits <[hidden email]>
> >>
> >>> Jacques,
> >>>
> >>> I will amend immediately the help files for both EN and NL locales.
> >>>
> >>> Regards,
> >>>
> >>> Pierre
> >>>
> >>>
> >>> 2012/5/18 Jacques Le Roux <[hidden email]>
> >>>
> >>>> BTW you don't have to worry about docbook. We already treated it
> >>>> seriously. A worry less...
> >>>> On the other hand we need to put an ASL2 license in all Help_*.xml
> files
> >>>> where it's missing (my fault when committing Pierre's work)
> >>>> All jQuery is of course also OK, etc.
> >>>>
> >>>>
> >>>> Jacques
> >>>>
> >>>> From: "Venkat Mangudi" <[hidden email]>
> >>>>
> >>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
> >>>>>
> >>>>> [hidden email]> wrote:
> >>>>>
> >>>>> You have a dynamic (updated at each builbot - our CI - build) RAT
> >> report
> >>>>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
> >> http://ci.apache.org/projects/**ofbiz/rat-output.html>
> >>>>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
> >> http://ci.apache.org/projects/ofbiz/rat-output.html>
> >>>>>>>
> >>>>>>
> >>>>>> Be careful, this must be interpreted with a grain of salt...
> >>>>>>
> >>>>>>
> >>>>>> Will get on it right away. Thank you...
> >>>>>
> >>>>> --
> >>>>> Regards,
> >>>>> Venkat
> >>>>>
> >>>>>
> >>>
> >>
> >
> >
> >
> > --
> > Regards,
> > Venkat
>
>

--
Regards,
Venkat

[Jacopo Cappellato-4]

Please create a pacth and attach it to the Jira task and a committer will commit it.

Thanks,

Jacopo

On May 22, 2012, at 12:34 PM, Venkat Mangudi wrote:

> I need a committer login to commit, right?
>
> --Venkat
>
> On Tue, May 22, 2012 at 3:57 PM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> For now please ignore the ones under docbook and jquery folders; I hope
>> that the committer of jcr related code will fix the ones under jcr
>> (veifying if it is ok to add the ASL license to them); you can ignore all
>> the files under runtime; license headers needs to be added to the files of
>> the webpos component.
>> These changes should be committed to trunk, 12.04 and 11.04
>>
>> Jacopo
>>
>>
>> On May 22, 2012, at 12:16 PM, Venkat Mangudi wrote:
>>
>>> There are about 1985 files without Apache License as per the RAT report.
>>> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>>>
>>> I should check each file and verify/add Apache License to it, right? Who
>>> did this last time? Maybe I can get a few pointers.
>>>
>>> --Venkat
>>>
>>> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]
>>> wrote:
>>>
>>>> Jacques,
>>>>
>>>> The amended help files (regarding licence statement in both locale EN
>> and
>>>> NL, and improvements to content of locale in EN) including  the
>> associcated
>>>> structure files are uploaded as a patch in
>>>> https://issues.apache.org/jira/browse/OFBIZ-4802.
>>>>
>>>> Regards,
>>>>
>>>> Pierre
>>>>
>>>> 2012/5/18 Pierre Smits <[hidden email]>
>>>>
>>>>> Jacques,
>>>>>
>>>>> I will amend immediately the help files for both EN and NL locales.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Pierre
>>>>>
>>>>>
>>>>> 2012/5/18 Jacques Le Roux <[hidden email]>
>>>>>
>>>>>> BTW you don't have to worry about docbook. We already treated it
>>>>>> seriously. A worry less...
>>>>>> On the other hand we need to put an ASL2 license in all Help_*.xml
>> files
>>>>>> where it's missing (my fault when committing Pierre's work)
>>>>>> All jQuery is of course also OK, etc.
>>>>>>
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Venkat Mangudi" <[hidden email]>
>>>>>>
>>>>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>>>>>>
>>>>>>> [hidden email]> wrote:
>>>>>>>
>>>>>>> You have a dynamic (updated at each builbot - our CI - build) RAT
>>>> report
>>>>>>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
>>>> http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>>>>>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
>>>> http://ci.apache.org/projects/ofbiz/rat-output.html>
>>>>>>>>>
>>>>>>>>
>>>>>>>> Be careful, this must be interpreted with a grain of salt...
>>>>>>>>
>>>>>>>>
>>>>>>>> Will get on it right away. Thank you...
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Venkat
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Venkat
>>
>>
>
>
> --
> Regards,
> Venkat

[Jacques Le Roux]

Venkat,

It's great to offer your help. I'm afraid though that you will no be aware of some specificities (like the ones I underlined below:
all docbookc and jQuery files)
So the 1st thing is to distinguish patterns in order to exclude them. For instance,
all files under runtime should be neglicted
those under
 /home/buildslave2/slave2/ofbiz-trunk/build/framework/base/build/gen-src
are generated, etc.

On the other hand files like
JsLanguageFileMappingCreator.java
OnePageCheckoutOptions.groovy
should have a license header...

Also please be sure to work in the section which begins by

Files with Apache License headers will be marked AL
Binary files (which do not require AL headers) will be marked B
Compressed archives will be marked A
Notices, licenses etc will be marked N

HTH

Jacques

From: "Venkat Mangudi" <[hidden email]>

> There are about 1985 files without Apache License as per the RAT report.
> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>
> I should check each file and verify/add Apache License to it, right? Who
> did this last time? Maybe I can get a few pointers.
>
> --Venkat
>
> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]>wrote:
>
>> Jacques,
>>
>> The amended help files (regarding licence statement in both locale EN and
>> NL, and improvements to content of locale in EN) including  the associcated
>> structure files are uploaded as a patch in
>> https://issues.apache.org/jira/browse/OFBIZ-4802.
>>
>> Regards,
>>
>> Pierre
>>
>> 2012/5/18 Pierre Smits <[hidden email]>
>>
>> > Jacques,
>> >
>> > I will amend immediately the help files for both EN and NL locales.
>> >
>> > Regards,
>> >
>> > Pierre
>> >
>> >
>> > 2012/5/18 Jacques Le Roux <[hidden email]>
>> >
>> >> BTW you don't have to worry about docbook. We already treated it
>> >> seriously. A worry less...
>> >> On the other hand we need to put an ASL2 license in all Help_*.xml files
>> >> where it's missing (my fault when committing Pierre's work)
>> >> All jQuery is of course also OK, etc.
>> >>
>> >>
>> >> Jacques
>> >>
>> >> From: "Venkat Mangudi" <[hidden email]>
>> >>
>> >>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>> >>>
>> >>> [hidden email]> wrote:
>> >>>
>> >>>  You have a dynamic (updated at each builbot - our CI - build) RAT
>> report
>> >>>> at http://ci.apache.org/projects/****ofbiz/rat-output.html<
>> http://ci.apache.org/projects/**ofbiz/rat-output.html>
>> >>>> <http:/**/ci.apache.org/projects/ofbiz/**rat-output.html<
>> http://ci.apache.org/projects/ofbiz/rat-output.html>
>> >>>> >
>> >>>>
>> >>>> Be careful, this must be interpreted with a grain of salt...
>> >>>>
>> >>>>
>> >>>>  Will get on it right away. Thank you...
>> >>>
>> >>> --
>> >>> Regards,
>> >>> Venkat
>> >>>
>> >>>
>> >
>>
>
>
>
> --
> Regards,
> Venkat
>

[Venkat Mangudi]

Here is what I did.

Took the output from RAT after it had marked the license files
distinguishing the files that need license Vs the others. All files that
did not have a license (and were not a binary file were marked with
!?????). Outof this lot, I assumed svg files did not need the license
considering that they were graphics files. I also removed derby/db.lck
files as well as .class files.

From the remaining 1985, I just knocked off all files
under /home/buildslave2/slave2/ofbiz-trunk/build/framework/images/webapp/images/jquery,
all 597 of them.

1. I now have an assorted bunch of files under /home/buildslave2/slave2/**
ofbiz-trunk/build/framework/**base/build/ as well. Should I be ignoring
them?
2. I assume xml, xsl, dtd, java, groovy, ftl files should have
the Apache License and will create a patch for each of them.

As I come up with some other files that are not part of the above, I will
keep them for later and ask for help.

Does this sound like a plan?

--Venkat

On Tue, May 22, 2012 at 4:17 PM, Jacques Le Roux <
[hidden email]> wrote:

> Venkat,
>
> It's great to offer your help. I'm afraid though that you will no be aware
> of some specificities (like the ones I underlined below: all docbookc and
> jQuery files)
> So the 1st thing is to distinguish patterns in order to exclude them. For
> instance,
> all files under runtime should be neglicted
> those under
> /home/buildslave2/slave2/**ofbiz-trunk/build/framework/**
> base/build/gen-src
> are generated, etc.
>
> On the other hand files like
> JsLanguageFileMappingCreator.**java
> OnePageCheckoutOptions.groovy
> should have a license header...
>
> Also please be sure to work in the section which begins by
>
> Files with Apache License headers will be marked AL
> Binary files (which do not require AL headers) will be marked B
> Compressed archives will be marked A
> Notices, licenses etc will be marked N
>
> HTH
>
>
> Jacques
>
> From: "Venkat Mangudi" <[hidden email]>
>
>> There are about 1985 files without Apache License as per the RAT report.
>> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>>
>> I should check each file and verify/add Apache License to it, right? Who
>> did this last time? Maybe I can get a few pointers.
>>
>> --Venkat
>>
>> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]
>> >wrote:
>>
>>  Jacques,
>>>
>>> The amended help files (regarding licence statement in both locale EN and
>>> NL, and improvements to content of locale in EN) including  the
>>> associcated
>>> structure files are uploaded as a patch in
>>> https://issues.apache.org/**jira/browse/OFBIZ-4802<https://issues.apache.org/jira/browse/OFBIZ-4802>
>>> .
>>>
>>> Regards,
>>>
>>> Pierre
>>>
>>> 2012/5/18 Pierre Smits <[hidden email]>
>>>
>>> > Jacques,
>>> >
>>> > I will amend immediately the help files for both EN and NL locales.
>>> >
>>> > Regards,
>>> >
>>> > Pierre
>>> >
>>> >
>>> > 2012/5/18 Jacques Le Roux <[hidden email]>
>>> >
>>> >> BTW you don't have to worry about docbook. We already treated it
>>> >> seriously. A worry less...
>>> >> On the other hand we need to put an ASL2 license in all Help_*.xml
>>> files
>>> >> where it's missing (my fault when committing Pierre's work)
>>> >> All jQuery is of course also OK, etc.
>>> >>
>>> >>
>>> >> Jacques
>>> >>
>>> >> From: "Venkat Mangudi" <[hidden email]>
>>> >>
>>> >>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>> >>>
>>> >>> [hidden email]> wrote:
>>> >>>
>>> >>>  You have a dynamic (updated at each builbot - our CI - build) RAT
>>> report
>>> >>>> at http://ci.apache.org/projects/******ofbiz/rat-output.html<http://ci.apache.org/projects/****ofbiz/rat-output.html>
>>> <
>>> http://ci.apache.org/projects/****ofbiz/rat-output.html<http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>> >
>>> >>>> <http:/**/ci.apache.org/**projects/ofbiz/**rat-output.**html<http://ci.apache.org/projects/ofbiz/**rat-output.html>
>>> <
>>> http://ci.apache.org/projects/**ofbiz/rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>>> >
>>> >>>> >
>>> >>>>
>>> >>>> Be careful, this must be interpreted with a grain of salt...
>>> >>>>
>>> >>>>
>>> >>>>  Will get on it right away. Thank you...
>>> >>>
>>> >>> --
>>> >>> Regards,
>>> >>> Venkat
>>> >>>
>>> >>>
>>> >
>>>
>>>
>>
>>
>> --
>> Regards,
>> Venkat
>>
>>

--
Regards,
Venkat

[Jacopo Cappellato-4]

On May 22, 2012, at 1:07 PM, Venkat Mangudi wrote:

> Here is what I did.
>
> Took the output from RAT after it had marked the license files
> distinguishing the files that need license Vs the others. All files that
> did not have a license (and were not a binary file were marked with
> !?????). Outof this lot, I assumed svg files did not need the license
> considering that they were graphics files. I also removed derby/db.lck
> files as well as .class files.
>
> From the remaining 1985, I just knocked off all files
> under /home/buildslave2/slave2/ofbiz-trunk/build/framework/images/webapp/images/jquery,
> all 597 of them.
>
> 1. I now have an assorted bunch of files under /home/buildslave2/slave2/**
> ofbiz-trunk/build/framework/**base/build/ as well. Should I be ignoring
> them?

All the files under <component>/build/ folders are generated ones and should be ignored.
I would suggest to run RAT in your local box on a clean OFBiz in order to avoid these false positives.

Jacopo

> 2. I assume xml, xsl, dtd, java, groovy, ftl files should have
> the Apache License and will create a patch for each of them.
>
> As I come up with some other files that are not part of the above, I will
> keep them for later and ask for help.
>
> Does this sound like a plan?
>
> --Venkat
>
> On Tue, May 22, 2012 at 4:17 PM, Jacques Le Roux <
> [hidden email]> wrote:
>
>> Venkat,
>>
>> It's great to offer your help. I'm afraid though that you will no be aware
>> of some specificities (like the ones I underlined below: all docbookc and
>> jQuery files)
>> So the 1st thing is to distinguish patterns in order to exclude them. For
>> instance,
>> all files under runtime should be neglicted
>> those under
>> /home/buildslave2/slave2/**ofbiz-trunk/build/framework/**
>> base/build/gen-src
>> are generated, etc.
>>
>> On the other hand files like
>> JsLanguageFileMappingCreator.**java
>> OnePageCheckoutOptions.groovy
>> should have a license header...
>>
>> Also please be sure to work in the section which begins by
>>
>> Files with Apache License headers will be marked AL
>> Binary files (which do not require AL headers) will be marked B
>> Compressed archives will be marked A
>> Notices, licenses etc will be marked N
>>
>> HTH
>>
>>
>> Jacques
>>
>> From: "Venkat Mangudi" <[hidden email]>
>>
>>> There are about 1985 files without Apache License as per the RAT report.
>>> Different types of file dtd, xsl, xml, groovy, java, js and some more.
>>>
>>> I should check each file and verify/add Apache License to it, right? Who
>>> did this last time? Maybe I can get a few pointers.
>>>
>>> --Venkat
>>>
>>> On Sat, May 19, 2012 at 2:52 AM, Pierre Smits <[hidden email]
>>>> wrote:
>>>
>>> Jacques,
>>>>
>>>> The amended help files (regarding licence statement in both locale EN and
>>>> NL, and improvements to content of locale in EN) including  the
>>>> associcated
>>>> structure files are uploaded as a patch in
>>>> https://issues.apache.org/**jira/browse/OFBIZ-4802<https://issues.apache.org/jira/browse/OFBIZ-4802>
>>>> .
>>>>
>>>> Regards,
>>>>
>>>> Pierre
>>>>
>>>> 2012/5/18 Pierre Smits <[hidden email]>
>>>>
>>>>> Jacques,
>>>>>
>>>>> I will amend immediately the help files for both EN and NL locales.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Pierre
>>>>>
>>>>>
>>>>> 2012/5/18 Jacques Le Roux <[hidden email]>
>>>>>
>>>>>> BTW you don't have to worry about docbook. We already treated it
>>>>>> seriously. A worry less...
>>>>>> On the other hand we need to put an ASL2 license in all Help_*.xml
>>>> files
>>>>>> where it's missing (my fault when committing Pierre's work)
>>>>>> All jQuery is of course also OK, etc.
>>>>>>
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>> From: "Venkat Mangudi" <[hidden email]>
>>>>>>
>>>>>>> On Fri, May 18, 2012 at 8:53 PM, Jacques Le Roux <
>>>>>>>
>>>>>>> [hidden email]> wrote:
>>>>>>>
>>>>>>> You have a dynamic (updated at each builbot - our CI - build) RAT
>>>> report
>>>>>>>> at http://ci.apache.org/projects/******ofbiz/rat-output.html<http://ci.apache.org/projects/****ofbiz/rat-output.html>
>>>> <
>>>> http://ci.apache.org/projects/****ofbiz/rat-output.html<http://ci.apache.org/projects/**ofbiz/rat-output.html>
>>>>>
>>>>>>>> <http:/**/ci.apache.org/**projects/ofbiz/**rat-output.**html<http://ci.apache.org/projects/ofbiz/**rat-output.html>
>>>> <
>>>> http://ci.apache.org/projects/**ofbiz/rat-output.html<http://ci.apache.org/projects/ofbiz/rat-output.html>
>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> Be careful, this must be interpreted with a grain of salt...
>>>>>>>>
>>>>>>>>
>>>>>>>> Will get on it right away. Thank you...
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Venkat
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Regards,
>>> Venkat
>>>
>>>
>
>
> --
> Regards,
> Venkat

[Venkat Mangudi]

On Tue, May 22, 2012 at 5:51 PM, Jacopo Cappellato <
[hidden email]> wrote:

>
>
> All the files under <component>/build/ folders are generated ones and
> should be ignored.
> I would suggest to run RAT in your local box on a clean OFBiz in order to
> avoid these false positives.
>


Installed RAT and saxon9b. Where can I get the xsl stylesheet that was used
to build the rat-output file? The xml data is not as pretty as the output
file.

--
Regards,
Venkat

[hongs bill]

+1

--
I am hongs

[Venkat Mangudi]

Folks, some help would be please.

Regards,
Venkat

On Fri, May 25, 2012 at 7:03 PM, Venkat Mangudi <[hidden email]>wrote:

>
>
> On Tue, May 22, 2012 at 5:51 PM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>>
>>
>> All the files under <component>/build/ folders are generated ones and
>> should be ignored.
>> I would suggest to run RAT in your local box on a clean OFBiz in order to
>> avoid these false positives.
>>
>
>
> Installed RAT and saxon9b. Where can I get the xsl stylesheet that was
> used to build the rat-output file? The xml data is not as pretty as the
> output file.
>
> --
> Regards,
> Venkat
>

--
Regards,
Venkat

[Venkat Mangudi]

I meant to say this...

Folks, some help would be appreciated please. :-)

Regards,
Venkat

On Thu, Jun 14, 2012 at 1:34 PM, Venkat Mangudi <[hidden email]>wrote:

> Folks, some help would be please.
>
> Regards,
> Venkat
>
>
> On Fri, May 25, 2012 at 7:03 PM, Venkat Mangudi <[hidden email]>wrote:
>
>>
>>
>> On Tue, May 22, 2012 at 5:51 PM, Jacopo Cappellato <
>> [hidden email]> wrote:
>>
>>>
>>>
>>> All the files under <component>/build/ folders are generated ones and
>>> should be ignored.
>>> I would suggest to run RAT in your local box on a clean OFBiz in order
>>> to avoid these false positives.
>>>
>>
>>
>> Installed RAT and saxon9b. Where can I get the xsl stylesheet that was
>> used to build the rat-output file? The xml data is not as pretty as the
>> output file.
>>
>> --
>> Regards,
>> Venkat
>>
>
>
>
> --
> Regards,
> Venkat
>

--
Regards,
Venkat